Re: [PATCH v6 06/11] softmmu/memory: enable automatic deallocation of memory regions

2023-12-20 Thread Akihiko Odaki
On 2023/12/21 16:35, Xenia Ragiadakou wrote: On 21/12/23 07:45, Akihiko Odaki wrote: On 2023/12/19 16:53, Huang Rui wrote: From: Xenia Ragiadakou When the memory region has a different life-cycle from that of her parent, could be automatically released, once has been unparent and once all

Re: [PATCH v6 06/11] softmmu/memory: enable automatic deallocation of memory regions

2023-12-20 Thread Xenia Ragiadakou
On 21/12/23 07:45, Akihiko Odaki wrote: On 2023/12/19 16:53, Huang Rui wrote: From: Xenia Ragiadakou When the memory region has a different life-cycle from that of her parent, could be automatically released, once has been unparent and once all of her references have gone away, via the

Re: [PATCH v6 07/11] virtio-gpu: Handle resource blob commands

2023-12-20 Thread Xenia Ragiadakou
On 21/12/23 07:57, Akihiko Odaki wrote: On 2023/12/19 16:53, Huang Rui wrote: From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device

Re: [PATCH 3/6] fixup scsi: only access SCSIDevice->requests from one thread

2023-12-20 Thread Paolo Bonzini
On 12/21/23 02:49, Stefan Hajnoczi wrote: Signed-off-by: Stefan Hajnoczi --- hw/scsi/scsi-bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index df68a44b6a..5b08cbf60a 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c

Re: [PATCH] target/i386: Add new CPU model SierraForest

2023-12-20 Thread Xiaoyao Li
On 12/6/2023 9:19 PM, Tao Su wrote: SierraForest is Intel's first generation E-core based Xeon server processor, which will be released in the first half of 2024. SierraForest mainly adds the following new features based on GraniteRapids: - CMPCCXADD CPUID.(EAX=7,ECX=1):EAX[bit 7] - AVX-IFMA

Re: [PATCH v2 09/17] hw/loongarch: Fix fdt memory node wrong 'reg'

2023-12-20 Thread maobibo
On 2023/12/18 下午5:00, Song Gao wrote: The right fdt memory node like [1], not [2] [1] memory@0 { device_type = "memory"; reg = <0x00 0x00 0x00 0x1000>; }; [2] memory@0 { device_type = "memory";

Re: [PATCH 6/6] nbd/server: introduce NBDClient->lock to protect fields

2023-12-20 Thread Paolo Bonzini
On 12/21/23 02:49, Stefan Hajnoczi wrote: nbd_client_receive_next_request(client); + +qemu_mutex_unlock(>lock); + if (ret == -EIO) { goto disconnect; } I think I slightly prefer if disconnect is reached with lock taken, for consistency with the "done" label.

Re: [PATCH 4/6] nbd/server: avoid per-NBDRequest nbd_client_get/put()

2023-12-20 Thread Paolo Bonzini
On 12/21/23 02:49, Stefan Hajnoczi wrote: nbd_trip() processes a single NBD request from start to finish and holds an NBDClient reference throughout. NBDRequest does not outlive the scope of nbd_trip(). Therefore it is unnecessary to ref/unref NBDClient for each NBDRequest. Removing these

Re: [PATCH 5/6] nbd/server: only traverse NBDExport->clients from main loop thread

2023-12-20 Thread Paolo Bonzini
On 12/21/23 02:49, Stefan Hajnoczi wrote: The NBD clients list is currently accessed from both the export AioContext and the main loop thread. When the AioContext lock is removed there will be nothing protecting the clients list. Adding a lock around the clients list is tricky because NBDClient

Re: [PATCH v2 04/17] hw/loongarch: Add slave cpu boot_code

2023-12-20 Thread maobibo
On 2023/12/18 下午5:00, Song Gao wrote: Signed-off-by: Song Gao --- hw/loongarch/boot.c | 65 - 1 file changed, 64 insertions(+), 1 deletion(-) diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c index 4bfe24274a..076e795714 100644 ---

Re: [PATCH v2 03/17] hw/loongarch: Add init_cmdline

2023-12-20 Thread maobibo
On 2023/12/18 下午5:00, Song Gao wrote: Add init_cmline and set boot_info->a0, a1 Signed-off-by: Song Gao --- hw/loongarch/boot.c | 21 + include/hw/loongarch/virt.h | 2 ++ target/loongarch/cpu.h | 2 ++ 3 files changed, 25 insertions(+) diff --git

Re: [PATCH v7] ui/cocoa: Use NSWindow's ability to resize

2023-12-20 Thread Akihiko Odaki
On 2023/12/20 5:06, Marek Glogowski wrote: Hi For me, the problem does not occur if you use the maximum screen resolution available. For me it is 1680x1050 - everything works fine. When I change the screen preference to a smaller screen resolution than my maximum (1440x900,1024x768 ...) the

Re: [PATCH v2 02/17] hw/loongarch: Add load initrd

2023-12-20 Thread maobibo
On 2023/12/18 下午5:00, Song Gao wrote: we load initrd ramdisk after kernel_high address Signed-off-by: Song Gao --- hw/loongarch/boot.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c index

Re: [PATCH v2 01/17] hw/loongarch: Move boot fucntions to boot.c

2023-12-20 Thread maobibo
On 2023/12/18 下午5:00, Song Gao wrote: Move some boot functions to boot.c and struct loongarch_boot_info into struct LoongArchMachineState. Signed-off-by: Song Gao --- hw/loongarch/boot.c | 127 hw/loongarch/meson.build| 1 +

Re: [PATCH v6 01/11] linux-headers: Update to kernel headers to add venus capset

2023-12-20 Thread Akihiko Odaki
On 2023/12/19 23:14, Peter Maydell wrote: On Tue, 19 Dec 2023 at 13:49, Huang Rui wrote: On Tue, Dec 19, 2023 at 08:20:22PM +0800, Akihiko Odaki wrote: On 2023/12/19 16:53, Huang Rui wrote: Sync up kernel headers to update venus macro till they are merged into mainline. Thanks for sorting

Re: [PATCH v2 38/71] hw/loongarch: Constify VMState

2023-12-20 Thread gaosong
在 2023/12/21 上午11:16, Richard Henderson 写道: Signed-off-by: Richard Henderson --- hw/loongarch/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Song Gao Thanks. Song Gao diff --git a/hw/loongarch/acpi-build.c b/hw/loongarch/acpi-build.c index

Re: [PATCH v2 09/71] target/loongarch: Constify VMState in machine.c

2023-12-20 Thread gaosong
在 2023/12/21 上午11:15, Richard Henderson 写道: Signed-off-by: Richard Henderson --- target/loongarch/machine.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Song Gao Thanks. Song Gao diff --git a/target/loongarch/machine.c b/target/loongarch/machine.c

Re: [PATCH v4 0/4] Support RISC-V IOPMP

2023-12-20 Thread Ethan Chen via
On Mon, Dec 18, 2023 at 02:18:58PM +1000, Alistair Francis wrote: > On Wed, Nov 22, 2023 at 3:36 PM Ethan Chen via wrote: > > > > This series implements IOPMP specification v1.0.0-draft4 rapid-k model. > > The specification url: > >

Re: [PATCH v2] qdev: Report an error for machine without HotplugHandler

2023-12-20 Thread Akihiko Odaki
On 2023/12/21 1:46, Zhao Liu wrote: Hi Markus, On Wed, Dec 20, 2023 at 08:53:21AM +0100, Markus Armbruster wrote: Date: Wed, 20 Dec 2023 08:53:21 +0100 From: Markus Armbruster Subject: Re: [PATCH v2] qdev: Report an error for machine without HotplugHandler Akihiko Odaki writes: On

Re: [PATCH v2] qdev: Report an error for machine without HotplugHandler

2023-12-20 Thread Markus Armbruster
Zhao Liu writes: > Hi Markus, > > On Wed, Dec 20, 2023 at 08:53:21AM +0100, Markus Armbruster wrote: >> Date: Wed, 20 Dec 2023 08:53:21 +0100 >> From: Markus Armbruster >> Subject: Re: [PATCH v2] qdev: Report an error for machine without >> HotplugHandler >> >> Having hotpluggable = true when

Re: [PATCH v6 11/11] virtio-gpu: make blob scanout use dmabuf fd

2023-12-20 Thread Akihiko Odaki
On 2023/12/19 16:53, Huang Rui wrote: From: Robert Beckett This relies on a virglrenderer change to include the dmabuf fd when returning resource info. Signed-off-by: Robert Beckett Signed-off-by: Huang Rui --- Changes in v6: - Add scanout_blob function for virtio-gpu-virgl. - Update for

Re: [PATCH v3 09/70] physmem: Introduce ram_block_convert_range() for page conversion

2023-12-20 Thread Xiaoyao Li
On 12/8/2023 7:52 PM, David Hildenbrand wrote: On 08.12.23 08:59, Xiaoyao Li wrote: On 11/18/2023 5:03 AM, Isaku Yamahata wrote: On Wed, Nov 15, 2023 at 02:14:18AM -0500, Xiaoyao Li wrote: It's used for discarding opposite memory after memory conversion, for confidential guest. When page

Re: [PATCH v3 06/70] kvm: Introduce support for memory_attributes

2023-12-20 Thread Xiaoyao Li
On 12/12/2023 9:56 PM, Wang, Wei W wrote: On Wednesday, November 15, 2023 3:14 PM, Xiaoyao Li wrote: Introduce the helper functions to set the attributes of a range of memory to private or shared. This is necessary to notify KVM the private/shared attribute of each gpa range. KVM needs the

Re: [PATCH v6 08/11] virtio-gpu: Resource UUID

2023-12-20 Thread Akihiko Odaki
On 2023/12/19 16:53, Huang Rui wrote: From: Antonio Caggiano Enable resource UUID feature and implement command resource assign UUID. This is done by introducing a hash table to map resource IDs to their UUIDs. What about putting QemuUUID in struct virtio_gpu_simple_resource?

Re: [PATCH v6 07/11] virtio-gpu: Handle resource blob commands

2023-12-20 Thread Akihiko Odaki
On 2023/12/19 16:53, Huang Rui wrote: From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Caggiano

Re: [PATCH v6 06/11] softmmu/memory: enable automatic deallocation of memory regions

2023-12-20 Thread Akihiko Odaki
On 2023/12/19 16:53, Huang Rui wrote: From: Xenia Ragiadakou When the memory region has a different life-cycle from that of her parent, could be automatically released, once has been unparent and once all of her references have gone away, via the object's free callback. However, currently,

Re: [PATCH v6 05/11] virtio-gpu: Introduce virgl_gpu_resource structure

2023-12-20 Thread Akihiko Odaki
On 2023/12/19 22:27, Huang Rui wrote: On Tue, Dec 19, 2023 at 08:35:27PM +0800, Akihiko Odaki wrote: On 2023/12/19 16:53, Huang Rui wrote: Introduce a new virgl_gpu_resource data structure and helper functions for virgl. It's used to add new member which is specific for virgl in following

Re: [PATCH for 9.0 07/12] vdpa: set backend capabilities at vhost_vdpa_init

2023-12-20 Thread Jason Wang
On Wed, Dec 20, 2023 at 3:08 PM Eugenio Perez Martin wrote: > > On Wed, Dec 20, 2023 at 5:34 AM Jason Wang wrote: > > > > On Sat, Dec 16, 2023 at 1:28 AM Eugenio Pérez wrote: > > > > > > The backend does not reset them until the vdpa file descriptor is closed > > > so there is no harm in doing

RE: Questions regarding the still unpublished qemu series https://github.com/yiliu1765/qemu/tree/zhenzhong/wip/iommufd_nesting_rfcv1

2023-12-20 Thread Duan, Zhenzhong
Hi Joel, >-Original Message- >From: Joel Granados >Subject: Questions regarding the still unpublished qemu series >https://github.com/yiliu1765/qemu/tree/zhenzhong/wip/iommufd_nesting >_rfcv1 > >Hello Everyone > >While running

[PATCH v2 09/71] target/loongarch: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/loongarch/machine.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/target/loongarch/machine.c b/target/loongarch/machine.c index 1c4e01d076..c7029fb9b4 100644 --- a/target/loongarch/machine.c +++

[PATCH v2 45/71] hw/pci-bridge: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/pci-bridge/gen_pcie_root_port.c | 2 +- hw/pci-bridge/i82801b11.c | 2 +- hw/pci-bridge/ioh3420.c| 2 +- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge/pcie_pci_bridge.c| 2 +- hw/pci-bridge/xio3130_downstream.c | 2 +-

[PATCH v2 53/71] hw/sensor: Constify VMState

2023-12-20 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- hw/sensor/adm1266.c| 2 +- hw/sensor/adm1272.c| 2 +- hw/sensor/dps310.c | 2 +- hw/sensor/emc141x.c| 2 +- hw/sensor/lsm303dlhc_mag.c | 2 +-

[PATCH v2 57/71] hw/tpm: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/tpm/tpm_crb.c| 2 +- hw/tpm/tpm_spapr.c | 2 +- hw/tpm/tpm_tis_common.c | 2 +- hw/tpm/tpm_tis_i2c.c| 2 +- hw/tpm/tpm_tis_isa.c| 2 +- hw/tpm/tpm_tis_sysbus.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH v2 22/71] hw/adc: Constify VMState

2023-12-20 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- hw/adc/aspeed_adc.c| 2 +- hw/adc/max111x.c | 2 +- hw/adc/npcm7xx_adc.c | 2 +- hw/adc/stm32f2xx_adc.c | 2 +- hw/adc/zynq-xadc.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2 41/71] hw/net: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/net/allwinner-sun8i-emac.c | 2 +- hw/net/allwinner_emac.c| 4 ++-- hw/net/cadence_gem.c | 2 +- hw/net/can/can_kvaser_pci.c| 2 +- hw/net/can/can_mioe3680_pci.c | 2 +- hw/net/can/can_pcm3680_pci.c | 2 +-

[PATCH v2 54/71] hw/sparc: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/sparc/sun4m_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sparc/sun4m_iommu.c b/hw/sparc/sun4m_iommu.c index eb40f9377c..06703b1d96 100644 --- a/hw/sparc/sun4m_iommu.c +++ b/hw/sparc/sun4m_iommu.c @@ -331,7 +331,7 @@ static

Re: [PATCH v2 1/1] docs/system/riscv: document acpi parameter of virt machine

2023-12-20 Thread Sunil V L
On Wed, Dec 20, 2023 at 08:34:36PM +0100, Heinrich Schuchardt wrote: > Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI > table generation. Add it to the documentation. > > Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI") > Signed-off-by: Heinrich

[PATCH v2 71/71] docs: Constify VMstate in examples

2023-12-20 Thread Richard Henderson
Reviewed-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- docs/devel/clocks.rst| 2 +- docs/devel/migration.rst | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/devel/clocks.rst b/docs/devel/clocks.rst index

[PATCH v2 63/71] audio: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- audio/audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/audio.c b/audio/audio.c index 8d1e4ad922..a1097bb016 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1683,7 +1683,7 @@ static const VMStateDescription vmstate_audio = {

[PATCH v2 61/71] hw/watchdog: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/watchdog/allwinner-wdt.c | 2 +- hw/watchdog/cmsdk-apb-watchdog.c | 2 +- hw/watchdog/sbsa_gwdt.c | 2 +- hw/watchdog/spapr_watchdog.c | 2 +- hw/watchdog/wdt_aspeed.c | 2 +- hw/watchdog/wdt_diag288.c| 2 +-

[PATCH v2 56/71] hw/timer: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/timer/a9gtimer.c| 8 hw/timer/allwinner-a10-pit.c | 2 +- hw/timer/arm_mptimer.c | 4 ++-- hw/timer/arm_timer.c | 4 ++-- hw/timer/armv7m_systick.c | 2 +- hw/timer/aspeed_timer.c| 4 ++--

[PATCH v2 47/71] hw/ppc: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ppc/ppc.c| 2 +- hw/ppc/ppc4xx_pci.c | 6 +++--- hw/ppc/prep_systemio.c | 2 +- hw/ppc/rs6000_mc.c | 2 +- hw/ppc/spapr.c | 20 ++-- hw/ppc/spapr_caps.c | 2 +- hw/ppc/spapr_cpu_core.c | 12

[PATCH v2 66/71] migration: Constify VMState

2023-12-20 Thread Richard Henderson
Reviewed-by: Juan Quintela Signed-off-by: Richard Henderson --- migration/global_state.c | 2 +- migration/savevm.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/migration/global_state.c b/migration/global_state.c index 4e2a9d8ec0..8ee15dbb06 100644 ---

[PATCH v2 42/71] hw/nvram: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/nvram/ds1225y.c| 2 +- hw/nvram/eeprom93xx.c | 2 +- hw/nvram/fw_cfg.c | 8 hw/nvram/mac_nvram.c | 2 +- hw/nvram/npcm7xx_otp.c| 2 +- hw/nvram/nrf51_nvm.c | 2 +-

[PATCH v2 62/71] hw/misc/macio: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/misc/macio/cuda.c | 2 +- hw/misc/macio/gpio.c | 2 +- hw/misc/macio/mac_dbdma.c | 8 hw/misc/macio/macio.c | 4 ++-- hw/misc/macio/pmu.c | 6 +++--- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH v2 68/71] replay: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- replay/replay-snapshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/replay/replay-snapshot.c b/replay/replay-snapshot.c index 10a7cf7992..e5e39161e3 100644 --- a/replay/replay-snapshot.c +++ b/replay/replay-snapshot.c @@ -51,7 +51,7

[PATCH v2 58/71] hw/usb: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/usb/bus.c| 2 +- hw/usb/ccid-card-passthru.c | 2 +- hw/usb/dev-hid.c| 4 ++-- hw/usb/dev-hub.c| 8 hw/usb/dev-mtp.c| 2 +-

[PATCH v2 49/71] hw/rtc: Constify VMState

2023-12-20 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- hw/rtc/allwinner-rtc.c | 2 +- hw/rtc/aspeed_rtc.c | 2 +- hw/rtc/ds1338.c | 2 +- hw/rtc/exynos4210_rtc.c | 2 +- hw/rtc/goldfish_rtc.c| 2 +- hw/rtc/ls7a_rtc.c| 2 +- hw/rtc/m48t59.c

[PATCH v2 65/71] cpu-target: Constify VMState

2023-12-20 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- cpu-target.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cpu-target.c b/cpu-target.c index 508013e23d..430dc53566 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -87,7 +87,7 @@ static const

[PATCH v2 70/71] tests/unit/test-vmstate: Constify VMState

2023-12-20 Thread Richard Henderson
While const data in tests is not particularly important, this makes a grep test clear across the tree. Reviewed-by: Juan Quintela Signed-off-by: Richard Henderson --- tests/unit/test-vmstate.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff

[PATCH v2 60/71] hw/virtio: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/virtio/vdpa-dev.c | 2 +- hw/virtio/vhost-user-fs.c | 6 +++--- hw/virtio/vhost-vsock.c| 2 +- hw/virtio/virtio-balloon.c | 10 +- hw/virtio/virtio-crypto.c | 2 +- hw/virtio/virtio-iommu.c | 12 ++--

[PATCH v2 64/71] backends: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- backends/dbus-vmstate.c | 2 +- backends/tpm/tpm_emulator.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/dbus-vmstate.c b/backends/dbus-vmstate.c index a9d8cb0acd..be6c4d8e0a 100644 --- a/backends/dbus-vmstate.c +++

[PATCH v2 50/71] hw/s390x: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/s390x/ccw-device.c | 2 +- hw/s390x/css.c| 36 ++-- hw/s390x/event-facility.c | 8 hw/s390x/ipl.c| 8 hw/s390x/sclpquiesce.c| 2 +- hw/s390x/virtio-ccw.c | 4 ++-- 6

[PATCH v2 52/71] hw/sd: Constify VMState

2023-12-20 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- hw/sd/allwinner-sdhost.c | 2 +- hw/sd/aspeed_sdhci.c | 2 +- hw/sd/bcm2835_sdhost.c | 2 +- hw/sd/cadence_sdhci.c| 2 +- hw/sd/npcm7xx_sdhci.c| 2 +- hw/sd/pl181.c

[PATCH v2 46/71] hw/pci-host: Constify VMState

2023-12-20 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- hw/pci-host/astro.c | 4 ++-- hw/pci-host/bonito.c | 2 +- hw/pci-host/designware.c | 10 +- hw/pci-host/dino.c | 2 +- hw/pci-host/gpex.c | 2 +-

[PATCH v2 69/71] util/fifo8: Constify VMState

2023-12-20 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- util/fifo8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/fifo8.c b/util/fifo8.c index d4d1c135e0..de8fd0f1c5 100644 --- a/util/fifo8.c +++ b/util/fifo8.c @@ -109,7 +109,7 @@ const

[PATCH v2 44/71] hw/pci: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/hw/pci/shpc.h | 2 +- hw/pci/msix.c | 4 ++-- hw/pci/pci.c | 8 hw/pci/pci_host.c | 2 +- hw/pci/pcie_aer.c | 4 ++-- hw/pci/shpc.c | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH v2 67/71] system: Constify VMState

2023-12-20 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- system/cpu-timers.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/system/cpu-timers.c b/system/cpu-timers.c index 7452d97b67..bdf3a41dcb 100644 ---

[PATCH v2 55/71] hw/ssi: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ssi/aspeed_smc.c | 2 +- hw/ssi/ibex_spi_host.c| 2 +- hw/ssi/imx_spi.c | 2 +- hw/ssi/mss-spi.c | 2 +- hw/ssi/npcm7xx_fiu.c | 2 +- hw/ssi/npcm_pspi.c| 2 +- hw/ssi/pl022.c| 2 +- hw/ssi/ssi.c

[PATCH v2 15/71] target/riscv: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Acked-by: Alistair Francis Signed-off-by: Richard Henderson --- target/riscv/machine.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/target/riscv/machine.c b/target/riscv/machine.c index fdde243e04..72fe2374dc 100644 ---

[PATCH v2 43/71] hw/openrisc: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/openrisc/cputimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c index 10163b391b..835986c4db 100644 --- a/hw/openrisc/cputimer.c +++ b/hw/openrisc/cputimer.c @@ -145,7 +145,7 @@ static

[PATCH v2 33/71] hw/input: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/input/adb-kbd.c | 2 +- hw/input/adb-mouse.c | 2 +- hw/input/adb.c | 4 ++-- hw/input/ads7846.c | 2 +- hw/input/hid.c | 6 +++--- hw/input/lasips2.c | 4 ++-- hw/input/lm832x.c

[PATCH v2 59/71] hw/vfio: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/vfio/display.c | 2 +- hw/vfio/pci.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/vfio/display.c b/hw/vfio/display.c index 7a10fa8604..1aa440c663 100644 --- a/hw/vfio/display.c +++ b/hw/vfio/display.c @@ -560,7 +560,7

[PATCH v2 34/71] hw/intc: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/intc/allwinner-a10-pic.c| 2 +- hw/intc/apic_common.c | 6 +++--- hw/intc/arm_gic_common.c | 8 hw/intc/arm_gicv3_common.c | 16 hw/intc/arm_gicv3_its_common.c | 2 +- hw/intc/armv7m_nvic.c | 8

[PATCH v2 12/71] target/mips: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/sysemu/machine.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/target/mips/sysemu/machine.c b/target/mips/sysemu/machine.c

[PATCH v2 48/71] hw/riscv: Constify VMState

2023-12-20 Thread Richard Henderson
Acked-by: Alistair Francis Signed-off-by: Richard Henderson --- hw/riscv/virt-acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c index 7331248f59..d3bfaf502e 100644 --- a/hw/riscv/virt-acpi-build.c +++

[PATCH v2 51/71] hw/scsi: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/scsi/esp-pci.c | 2 +- hw/scsi/esp.c | 8 hw/scsi/lsi53c895a.c | 2 +- hw/scsi/megasas.c | 4 ++-- hw/scsi/mptsas.c | 2 +- hw/scsi/scsi-bus.c| 6 +++--- hw/scsi/scsi-disk.c | 2 +-

[PATCH v2 05/71] target/avr: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/avr/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/avr/machine.c b/target/avr/machine.c index 16f7a3e031..4402862fb9 100644 ---

[PATCH v2 27/71] hw/dma: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/dma/bcm2835_dma.c | 4 ++-- hw/dma/i82374.c | 2 +- hw/dma/i8257.c| 4 ++-- hw/dma/pl080.c| 4 ++-- hw/dma/pl330.c| 10 +- hw/dma/pxa2xx_dma.c | 4 ++-- hw/dma/rc4030.c | 2 +-

[PATCH v2 14/71] target/ppc: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/ppc/machine.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/ppc/machine.c b/target/ppc/machine.c index 68cbdffecd..203fe28e01 100644 --- a/target/ppc/machine.c +++ b/target/ppc/machine.c

[PATCH v2 37/71] hw/isa: Constify VMState

2023-12-20 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- hw/isa/apm.c | 2 +- hw/isa/i82378.c | 2 +- hw/isa/lpc_ich9.c | 8 hw/isa/pc87312.c | 2 +- hw/isa/piix.c | 8 hw/isa/vt82c686.c | 4 ++-- 6 files changed, 13 insertions(+), 13 deletions(-)

[PATCH v2 40/71] hw/misc: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/misc/a9scu.c| 2 +- hw/misc/allwinner-a10-ccm.c| 2 +- hw/misc/allwinner-a10-dramc.c | 2 +- hw/misc/allwinner-cpucfg.c | 2 +- hw/misc/allwinner-h3-ccu.c | 2 +- hw/misc/allwinner-h3-dramc.c | 2

[PATCH v2 04/71] target/alpha: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/alpha/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/alpha/machine.c b/target/alpha/machine.c index 2b7c8148ff..f09834f635 100644 --- a/target/alpha/machine.c +++ b/target/alpha/machine.c @@ -24,7 +24,7 @@

[PATCH v2 16/71] target/s390x: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/s390x/machine.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/s390x/machine.c b/target/s390x/machine.c index 37a076858c..a125ebcc2f 100644 --- a/target/s390x/machine.c +++

[PATCH v2 25/71] hw/char: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/char/bcm2835_aux.c | 2 +- hw/char/cadence_uart.c | 2 +- hw/char/cmsdk-apb-uart.c| 2 +- hw/char/digic-uart.c| 2 +- hw/char/escc.c | 4 ++-- hw/char/exynos4210_uart.c | 4 ++-- hw/char/goldfish_tty.c | 2

[PATCH v2 03/71] target/arm: Constify hvf/hvf.c

2023-12-20 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/hvf/hvf.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 757e13b0f9..203d88f80b 100644 ---

[PATCH v2 30/71] hw/i2c: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/i2c/allwinner-i2c.c | 2 +- hw/i2c/aspeed_i2c.c | 4 ++-- hw/i2c/core.c | 4 ++-- hw/i2c/exynos4210_i2c.c | 2 +- hw/i2c/imx_i2c.c| 2 +- hw/i2c/microbit_i2c.c | 2 +- hw/i2c/mpc_i2c.c| 2 +- hw/i2c/npcm7xx_smbus.c | 2 +-

[PATCH v2 38/71] hw/loongarch: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/loongarch/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/loongarch/acpi-build.c b/hw/loongarch/acpi-build.c index ae292fc543..730bc4a748 100644 --- a/hw/loongarch/acpi-build.c +++ b/hw/loongarch/acpi-build.c @@ -564,7

[PATCH v2 28/71] hw/gpio: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/gpio/aspeed_gpio.c | 4 ++-- hw/gpio/bcm2835_gpio.c | 2 +- hw/gpio/gpio_key.c | 2 +- hw/gpio/imx_gpio.c | 2 +- hw/gpio/max7310.c | 2 +- hw/gpio/mpc8xxx.c | 2 +- hw/gpio/npcm7xx_gpio.c | 2 +- hw/gpio/nrf51_gpio.c | 2 +-

[PATCH v2 32/71] hw/ide: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ide/ahci-allwinner.c | 2 +- hw/ide/ahci.c | 8 hw/ide/core.c | 16 hw/ide/ich.c| 2 +- hw/ide/isa.c| 2 +- hw/ide/macio.c | 2 +- hw/ide/microdrive.c | 2 +-

[PATCH v2 17/71] target/sparc: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Reviewed-by: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/machine.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/sparc/machine.c b/target/sparc/machine.c index 44dfc07014..2b5686c330 100644 --- a/target/sparc/machine.c +++

[PATCH v2 18/71] hw/arm: Constify VMState

2023-12-20 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- hw/arm/armsse.c | 2 +- hw/arm/armv7m.c | 2 +- hw/arm/highbank.c| 2 +- hw/arm/integratorcp.c| 6 +++--- hw/arm/musicpal.c| 14 +++---

[PATCH v2 39/71] hw/m68k: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/m68k/next-cube.c | 4 ++-- hw/m68k/q800-glue.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index fabd861941..baca38bf39 100644 --- a/hw/m68k/next-cube.c +++ b/hw/m68k/next-cube.c @@

[PATCH v2 26/71] hw/display: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/display/artist.c | 2 +- hw/display/bcm2835_fb.c | 2 +- hw/display/bochs-display.c| 2 +- hw/display/cg3.c | 2 +- hw/display/cirrus_vga.c | 4 ++-- hw/display/dpcd.c | 2 +-

[PATCH v2 35/71] hw/ipack: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ipack/ipack.c | 2 +- hw/ipack/tpci200.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ipack/ipack.c b/hw/ipack/ipack.c index ae20f36da6..c39dbb481f 100644 --- a/hw/ipack/ipack.c +++ b/hw/ipack/ipack.c @@ -93,7 +93,7 @@ const

[PATCH v2 19/71] hw/core: Constify VMState

2023-12-20 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- hw/core/clock-vmstate.c | 6 +++--- hw/core/or-irq.c| 6 +++--- hw/core/ptimer.c| 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v2 10/71] target/m68k: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/m68k/cpu.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index 11c7e0a790..43b1bde21c 100644 --- a/target/m68k/cpu.c +++ b/target/m68k/cpu.c @@ -381,7 +381,7 @@ static const

[PATCH v2 36/71] hw/ipmi: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ipmi/ipmi_bmc_extern.c | 2 +- hw/ipmi/ipmi_bmc_sim.c| 2 +- hw/ipmi/ipmi_bt.c | 2 +- hw/ipmi/ipmi_kcs.c| 2 +- hw/ipmi/isa_ipmi_bt.c | 2 +- hw/ipmi/isa_ipmi_kcs.c| 2 +- hw/ipmi/pci_ipmi_bt.c | 2 +-

[PATCH v2 31/71] hw/i386: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/i386/acpi-build.c | 2 +- hw/i386/intel_iommu.c | 2 +- hw/i386/kvm/clock.c| 6 +++--- hw/i386/kvm/xen_evtchn.c | 4 ++-- hw/i386/kvm/xen_gnttab.c | 2 +- hw/i386/kvm/xen_overlay.c | 2 +- hw/i386/kvm/xen_xenstore.c | 2 +-

[PATCH v2 20/71] hw/9pfs: Constify VMState

2023-12-20 Thread Richard Henderson
Acked-by: Greg Kurz Acked-by: Christian Schoenebeck Signed-off-by: Richard Henderson --- hw/9pfs/virtio-9p-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 5f522e68e9..efa41cfd73 100644 ---

[PATCH v2 29/71] hw/hyperv: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/hyperv/vmbus.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index c64eaa5a46..c86d1895ba 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -526,7 +526,7 @@ static const

[PATCH v2 23/71] hw/audio: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/audio/ac97.c| 4 ++-- hw/audio/asc.c | 4 ++-- hw/audio/cs4231.c | 2 +- hw/audio/cs4231a.c | 2 +- hw/audio/es1370.c | 4 ++-- hw/audio/gus.c | 2 +- hw/audio/hda-codec.c | 8

[PATCH v2 07/71] target/hppa: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/machine.c b/target/hppa/machine.c index 15cbc5e6d0..211bfcf640 100644 --- a/target/hppa/machine.c +++ b/target/hppa/machine.c @@ -201,7 +201,7 @@ static

[PATCH v2 24/71] hw/block: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/block/ecc.c| 2 +- hw/block/fdc-isa.c| 2 +- hw/block/fdc-sysbus.c | 2 +- hw/block/fdc.c| 20 ++-- hw/block/m25p80.c | 12 ++-- hw/block/nand.c | 2 +- hw/block/onenand.c

[PATCH v2 13/71] target/openrisc: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/openrisc/machine.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/openrisc/machine.c b/target/openrisc/machine.c index b7d7388640..3574e571cb 100644 --- a/target/openrisc/machine.c +++ b/target/openrisc/machine.c @@

[PATCH v2 21/71] hw/acpi: Constify VMState

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/acpi/cpu.c | 4 ++-- hw/acpi/erst.c | 2 +- hw/acpi/generic_event_device.c | 12 ++-- hw/acpi/ich9.c | 12 ++-- hw/acpi/ich9_tco.c | 2 +- hw/acpi/memory_hotplug.c | 4

[PATCH v2 00/71] *: Constify VMState

2023-12-20 Thread Richard Henderson
Most of this can be done without the first patch. But with it, we get to constify subsections as well. For qemu-system-aarch64, this moves 472k from .data to .data.ro and/or .rodata (mostly depending on -fpie). For qemu-system-x86_64, 272k. For qemu-system-ppc64, 267k. No significant changes

[PATCH v2 08/71] target/i386: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/i386/machine.c | 128 +- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/target/i386/machine.c b/target/i386/machine.c index a1041ef828..c3ae320814 100644 --- a/target/i386/machine.c +++

[PATCH v2 02/71] target/arm: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/machine.c | 54 ++-- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/target/arm/machine.c b/target/arm/machine.c index

[PATCH v2 06/71] target/cris: Constify VMState in machine.c

2023-12-20 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/cris/machine.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/cris/machine.c b/target/cris/machine.c index f370f33486..7b9bde872a 100644 --- a/target/cris/machine.c +++

  1   2   3   >