Re: [PATCH v5 14/14] spapr: nested: Introduce cap-nested-papr for Nested PAPR API

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > Introduce a SPAPR capability cap-nested-papr which enables nested PAPR > API for nested guests. This new API is to enable support for KVM on PowerVM > and the support in Linux kernel has already merged upstream. > > Signed-off-by:

Re: [PATCH v4 00/25] migration: Improve error reporting

2024-03-12 Thread Peter Xu
On Tue, Mar 12, 2024 at 10:58:51AM +0100, Cédric Le Goater wrote: > On 3/12/24 08:16, Cédric Le Goater wrote: > > On 3/11/24 21:24, Peter Xu wrote: > > > On Fri, Mar 08, 2024 at 04:15:08PM +0800, Peter Xu wrote: > > > > On Wed, Mar 06, 2024 at 02:34:15PM +0100, Cédric Le Goater wrote: > > > > > *

Re: [PATCH v5 14/14] spapr: nested: Introduce cap-nested-papr for Nested PAPR API

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > Introduce a SPAPR capability cap-nested-papr which enables nested PAPR > API for nested guests. This new API is to enable support for KVM on PowerVM > and the support in Linux kernel has already merged upstream. > > Signed-off-by:

Re: [PATCH 3/9] backends/confidential-guest-support: Add functions to support IGVM

2024-03-12 Thread Roy Hopkins
On Fri, 2024-03-01 at 16:37 +, Daniel P. Berrangé wrote: > On Tue, Feb 27, 2024 at 02:50:09PM +, Roy Hopkins wrote: > > In preparation for supporting the processing of IGVM files to configure > > guests, this adds a set of functions to ConfidentialGuestSupport > > allowing configuration of

Re: [PATCH v5 13/14] spapr: nested: Introduce H_GUEST_RUN_VCPU hcall.

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > The H_GUEST_RUN_VCPU hcall is used to start execution of a Guest VCPU. > The Hypervisor will update the state of the Guest VCPU based on the > input buffer, restore the saved Guest VCPU state, and start its > execution. > > The Guest

Re: [PATCH v5 12/14] spapr: nested: Use correct source for parttbl info for nested PAPR API.

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > For nested PAPR API, we use SpaprMachineStateNestedGuest struct to store > partition table info, use the same in spapr_get_pate_nested() via > helper. > > Signed-off-by: Michael Neuling > Signed-off-by: Harsh Prateek Bora > --- >

Re: [PATCH v5 10/14] spapr: nested: Initialize the GSB elements lookup table.

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > Nested PAPR API provides a standard Guest State Buffer (GSB) format > with unique IDs for each guest state element for which get/set state is > supported by the API. Some of the elements are read-only and/or guest-wide. > Introducing

[PULL 5/8] ebpf: Added eBPF initialization by fds.

2024-03-12 Thread Jason Wang
From: Andrew Melnychenko It allows using file descriptors of eBPF provided outside of QEMU. QEMU may be run without capabilities for eBPF and run RSS program provided by management tool(g.e. libvirt). Signed-off-by: Andrew Melnychenko Signed-off-by: Jason Wang --- ebpf/ebpf_rss-stub.c | 6

[PULL 3/8] Avoid unaligned fetch in ladr_match()

2024-03-12 Thread Jason Wang
From: Nick Briggs There is no guarantee that the PCNetState is allocated such that csr[8] is allocated on an 8-byte boundary. Since not all hosts are capable of unaligned fetches the 16-bit elements need to be fetched individually to avoid a potential fault. Closes issue #2143 Resolves:

Re: [PATCH v5 11/14] spapr: nested: Introduce H_GUEST_[GET|SET]_STATE hcalls.

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > Introduce the nested PAPR hcalls: > - H_GUEST_GET_STATE which is used to get state of a nested guest or > a guest VCPU. The value field for each element in the request is > destination to be updated to reflect current

[PULL 8/8] ebpf: Updated eBPF program and skeleton.

2024-03-12 Thread Jason Wang
From: Andrew Melnychenko Updated section name, so libbpf should init/gues proper program type without specifications during open/load. Also, added map_flags with explicitly declared BPF_F_MMAPABLE. Added check for BPF_F_MMAPABLE flag to meson script and requirements to libbpf version. Also

[PULL 6/8] virtio-net: Added property to load eBPF RSS with fds.

2024-03-12 Thread Jason Wang
From: Andrew Melnychenko eBPF RSS program and maps may now be passed during initialization. Initially was implemented for libvirt to launch qemu without permissions, and initialized eBPF program through the helper. Signed-off-by: Andrew Melnychenko Signed-off-by: Jason Wang ---

[PULL 2/8] e1000e: fix link state on resume

2024-03-12 Thread Jason Wang
From: Laurent Vivier On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume() that sets link_down to false, and thus activates the link even if we have disabled it. The problem can be reproduced starting qemu in paused state (-S) and then set the link to down. When we resume the

[PULL 7/8] qmp: Added new command to retrieve eBPF blob.

2024-03-12 Thread Jason Wang
From: Andrew Melnychenko Now, the binary objects may be retrieved by id. It would require for future qmp commands that may require specific eBPF blob. Added command "request-ebpf". This command returns eBPF program encoded base64. The program taken from the skeleton and essentially is an ELF

Re: [PATCH v5 09/14] spapr: nested: Extend nested_ppc_state for nested PAPR API

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > Currently, nested_ppc_state stores a certain set of registers and works > with nested_[load|save]_state() for state transfer as reqd for nested-hv API. > Extending these with additional registers state as reqd for nested PAPR API. > >

[PULL 4/8] ebpf: Added eBPF map update through mmap.

2024-03-12 Thread Jason Wang
From: Andrew Melnychenko Changed eBPF map updates through mmaped array. Mmaped arrays provide direct access to map data. It should omit using bpf_map_update_elem() call, which may require capabilities that are not present. Signed-off-by: Andrew Melnychenko Signed-off-by: Jason Wang ---

[PULL 1/8] igb: fix link state on resume

2024-03-12 Thread Jason Wang
From: Laurent Vivier On resume igb_vm_state_change() always calls igb_autoneg_resume() that sets link_down to false, and thus activates the link even if we have disabled it. The problem can be reproduced starting qemu in paused state (-S) and then set the link to down. When we resume the

[PULL 0/8] Net patches

2024-03-12 Thread Jason Wang
The following changes since commit 05ec974671200814fa5c1d5db710e0e4b88a40af: Merge tag 'm68k-for-9.0-pull-request' of https://github.com/vivier/qemu-m68k into staging (2024-03-11 18:42:53 +) are available in the Git repository at: https://github.com/jasowang/qemu.git

Re: [PULL 0/6] hw/nvme updates

2024-03-12 Thread Peter Maydell
On Mon, 11 Mar 2024 at 19:11, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi, > > The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f: > > Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging > (2024-03-09 20:12:21 +) > > are available in

Re: [PATCH 0/2] trace: fix ability to use systemtap with qemu tools

2024-03-12 Thread Daniel P . Berrangé
Ping again for these patches to get into this release. On Fri, Feb 16, 2024 at 01:09:33PM +, Daniel P. Berrangé wrote: > Ping: Stefan, are you OK with picking up these trace patches > for merge ? > > On Mon, Jan 08, 2024 at 05:13:54PM +, Daniel P. Berrangé wrote: > > Currently we're only

Re: [PATCH v2] virtio-gpu: first surface update with blob scanout after resumed

2024-03-12 Thread Marc-André Lureau
Hi On Thu, Mar 7, 2024 at 2:27 AM wrote: > > From: Dongwon Kim > > The guest surface needs to be updated with a blob scanout after resumed > from saved vm state if blob is enabled. > > v2: Rebased > This patch conflicts with the already reviewed (and almost in queue) patch from

Re: [PATCH v5 08/14] spapr: nested: Introduce H_GUEST_CREATE_VCPU hcall.

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > Introduce the nested PAPR hcall H_GUEST_CREATE_VCPU which is used to > create and initialize the specified VCPU resource for the previously > created guest. Each guest can have multiple VCPUs upto max 2048. > All VCPUs for a guest

Re: [PATCH v5 06/14] spapr: nested: Introduce H_GUEST_[GET|SET]_CAPABILITIES hcalls.

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > Introduce the nested PAPR hcalls: > - H_GUEST_GET_CAPABILITIES which is used to query the capabilities >of the API and the L2 guests it provides. > - H_GUEST_SET_CAPABILITIES which is used to set the Guest API >capabilities

Re: [PATCH v5 07/14] spapr: nested: Introduce H_GUEST_[CREATE|DELETE] hcalls.

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > Introduce the nested PAPR hcalls: > - H_GUEST_CREATE which is used to create and allocate resources for > nested guest being created. > - H_GUEST_DELETE which is used to delete and deallocate resources > for the nested guest

Re: [PATCH v5 04/14] spapr: nested: keep nested-hv related code restricted to its API.

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > spapr_exit_nested and spapr_get_pate_nested_hv contains code which > is specific to nested-hv API. Isolating code flows based on API > helps extending it to be used with different API as well. > > Signed-off-by: Harsh Prateek Bora >

Re: [PATCH v5 05/14] spapr: nested: Document Nested PAPR API

2024-03-12 Thread Nicholas Piggin
On Fri Mar 8, 2024 at 9:19 PM AEST, Harsh Prateek Bora wrote: > Adding initial documentation about Nested PAPR API to describe the set > of APIs and its usage. Also talks about the Guest State Buffer elements > and it's format which is used between L0/L1 to communicate L2 state. > > Signed-off-by:

Re: [PATCH v3] ui/gtk: flush display pipeline before saving vmstate when blob=true

2024-03-12 Thread Marc-André Lureau
Hi On Thu, Mar 7, 2024 at 2:27 AM wrote: > > From: Dongwon Kim > > If the guest state is paused before it gets a response for the current > scanout frame submission (resource-flush), it won't flush new frames > after being restored as it still waits for the old response, which is > accepted as

[PULL 8/8] gdbstub: Fix double close() of the follow-fork-mode socket

2024-03-12 Thread Alex Bennée
From: Ilya Leoshkevich When the terminal GDB_FORK_ENABLED state is reached, the coordination socket is not needed anymore and is therefore closed. However, if there is a communication error between QEMU gdbstub and GDB, the generic error handling code attempts to close it again. Fix by closing

[PULL 5/8] gdbstub: Save target's siginfo

2024-03-12 Thread Alex Bennée
From: Gustavo Romero Save target's siginfo into gdbserver_state so it can be used later, for example, in any stub that requires the target's si_signo and si_code. This change affects only linux-user mode. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson Message-Id:

[PULL 7/8] tests/tcg: Add multiarch test for Xfer:siginfo:read stub

2024-03-12 Thread Alex Bennée
From: Gustavo Romero Add multiarch test for testing if Xfer:siginfo:read query is properly handled by gdbstub. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Message-Id: <20240309030901.1726211-6-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée diff --git

[PULL 2/8] tests/vm: ensure we build everything by default

2024-03-12 Thread Alex Bennée
The "check" target by itself is not enough to ensure we build the user mode binaries. While we can't test them with check-tcg we can at least include them in the build. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Cc: Richard Henderson Cc: Gustavo Romero diff --git

[PULL 3/8] gdbstub: Rename back gdb_handlesig

2024-03-12 Thread Alex Bennée
From: Gustavo Romero Rename gdb_handlesig_reason back to gdb_handlesig. There is no need to add a wrapper for gdb_handlesig and rename it when a new parameter is added. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id:

[PULL 4/8] linux-user: Move tswap_siginfo out of target code

2024-03-12 Thread Alex Bennée
From: Gustavo Romero Move tswap_siginfo from target code to handle_pending_signal. This will allow some cleanups and having the siginfo ready to be used in gdbstub. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Message-Id:

[PULL 6/8] gdbstub: Add Xfer:siginfo:read stub

2024-03-12 Thread Alex Bennée
From: Gustavo Romero Add stub to handle Xfer:siginfo:read packet query that requests the machine's siginfo data. This is used when GDB user executes 'print $_siginfo' and when the machine stops due to a signal, for instance, on SIGSEGV. The information in siginfo allows GDB to determiner

[PULL 1/8] gitlab: aggressively avoid extra GIT data

2024-03-12 Thread Alex Bennée
This avoids fetching blobs and tree references for branches we are not going to worry about. Also skip tag references which are similarly not useful and keep the default --prune. This keeps the .git data to around 100M rather than the ~400M even a shallow clone takes. So we can check the savings

[PULL for 9.0 0/8] final maintainer updates (testing, gdbstub)

2024-03-12 Thread Alex Bennée
The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f: Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging (2024-03-09 20:12:21 +) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git

Re: [PATCH v3 14/29] target/i386: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
On 30/01/2024 14.01, Igor Mammedov wrote: On Mon, 29 Jan 2024 17:44:56 +0100 Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. commenting here since, I'm not expert on coccinelle scripts. On negative

Re: [PATCH] virtio-blk: iothread-vq-mapping coroutine pool sizing

2024-03-12 Thread Kevin Wolf
Am 11.03.2024 um 21:14 hat Stefan Hajnoczi geschrieben: > It is possible to hit the sysctl vm.max_map_count limit when the > coroutine pool size becomes large. Each coroutine requires two mappings > (one for the stack and one for the guard page). QEMU can crash with > "failed to set up stack guard

Re: [PATCH v3 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-03-12 Thread Anthony Harivel
Hi Daniel, Paolo, Here my last questions before wrapping up and send v4, or maybe call off my attempt to add RAPL interface in QEMU. Daniel P. Berrangé, Jan 30, 2024 at 10:39: > > +rcu_register_thread(); > > + > > +/* Get QEMU PID*/ > > +pid = getpid(); > > + > > +/* Nb of

Re: [PATCH] tests: Raise timeouts for bufferiszero and crypto-tlscredsx509

2024-03-12 Thread Daniel P . Berrangé
On Tue, Mar 12, 2024 at 11:08:15AM +, Peter Maydell wrote: > On our gcov CI job, the bufferiszero and crypto-tlscredsx509 > tests time out occasionally, making the job flaky. Double the > timeout on these two tests. > > Cc: qemu-sta...@nongnu.org > Resolves:

Re: [PATCH v4 11/24] net: Use virtual time for net announce

2024-03-12 Thread Pavel Dovgalyuk
On 12.03.2024 14:05, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 7:09 PM AEST, Pavel Dovgalyuk wrote: This won't work, as needed. Announce timer can't be enabled, because it is set in post_load function. Therefore announce callbacks break the replay, when virtio-net is used with snapshots.

Re: [PATCH] disas/riscv: Further correction to LUI disassembly

2024-03-12 Thread Andrew Jones
On Mon, Mar 11, 2024 at 11:56:42AM -0700, Richard Bagley wrote: > I have realized that *the patch is indeed a fix*, not a workaround. > > In fact, the argument to LUI and AUIPC in assembly *must* be a number > between [0x0, 0xf]. > RISC-V Assembly Programmer's Manual : Load Upper Immediate's

[PATCH] tests: Raise timeouts for bufferiszero and crypto-tlscredsx509

2024-03-12 Thread Peter Maydell
On our gcov CI job, the bufferiszero and crypto-tlscredsx509 tests time out occasionally, making the job flaky. Double the timeout on these two tests. Cc: qemu-sta...@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2221 Signed-off-by: Peter Maydell --- cc stable just because

Re: [PULL 0/1] M68k for 9.0 patches

2024-03-12 Thread Peter Maydell
On Mon, 11 Mar 2024 at 17:55, Laurent Vivier wrote: > > The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f: > > Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging > (2024-03-09 20:12:21 +) > > are available in the Git repository at: > >

Re: [PATCH v4 11/24] net: Use virtual time for net announce

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 7:09 PM AEST, Pavel Dovgalyuk wrote: > This won't work, as needed. Announce timer can't be enabled, because > it is set in post_load function. Therefore announce callbacks break > the replay, when virtio-net is used with snapshots. I see. Is that somehow marked as being

Re: [PULL 0/3] Misc QGA patches for 2024-03-11

2024-03-12 Thread Peter Maydell
On Mon, 11 Mar 2024 at 16:57, Konstantin Kostiuk wrote: > > The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f: > > Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging > (2024-03-09 20:12:21 +) > > are available in the Git repository at: > >

Re: [PULL 0/2] vfio queue

2024-03-12 Thread Peter Maydell
On Sun, 10 Mar 2024 at 19:20, Cédric Le Goater wrote: > > The following changes since commit cbccded4a2b5d685a426a437e25f67d3a375b292: > > Merge tag 'pull-riscv-to-apply-20240308-1' of > https://github.com/alistair23/qemu into staging (2024-03-08 11:47:01 +) > > are available in the Git

Re: [PATCH v3 00/29] hw, target: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
On 29/01/2024 17.44, Philippe Mathieu-Daudé wrote: Patches missing review: 1, 2, 5, 6, 8, 11, 14, 15, 29 It will be simpler if I get the whole series via my hw-cpus tree once fully reviewed. Since v2: - Rebased - bsd/linux-user - Preliminary clean cpu_reset_hold - Add R-b Since v1: - Avoid

Re: [PATCH v4 20/24] replay: simple auto-snapshot mode for record

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 7:00 PM AEST, Pavel Dovgalyuk wrote: > On 11.03.2024 20:40, Nicholas Piggin wrote: > > record makes an initial snapshot when the machine is created, to enable > > reverse-debugging. Often the issue being debugged appears near the end of > > the trace, so it is important for

Re: [PATCH v2 00/29] Cleanup up to fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
On 12/03/2024 11.26, Zhao Liu wrote: On Tue, Mar 12, 2024 at 09:50:25AM +0100, Thomas Huth wrote: Date: Tue, 12 Mar 2024 09:50:25 +0100 From: Thomas Huth Subject: Re: [PATCH v2 00/29] Cleanup up to fix missing ERRP_GUARD() for error_prepend() On 12/03/2024 09.43, Zhao Liu wrote: Hi

Re: [PATCH] spapr: avoid overhead of finding vhyp class in critical operations

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 6:56 PM AEST, Harsh Prateek Bora wrote: > > > On 3/12/24 14:18, Nicholas Piggin wrote: > > On Tue Mar 12, 2024 at 4:38 PM AEST, Harsh Prateek Bora wrote: > >> Hi Nick, > >> > >> One minor comment below: > >> > >> On 2/24/24 13:03, Nicholas Piggin wrote: > >>>

Re: [PATCH v2 5/7] hw/pci-bridge/cxl_upstream: Fix missing ERRP_GUARD() in cxl_usp_realize()

2024-03-12 Thread Thomas Huth
On 23/02/2024 09.56, Zhao Liu wrote: From: Zhao Liu As the comment in qapi/error, dereferencing @errp requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: * - It must not be dereferenced, because it may be null.

Re: [PATCH v3] docs/system/ppc: Document running Linux on AmigaNG machines

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 7:28 PM AEST, Bernhard Beschow wrote: > > > Am 9. März 2024 11:34:56 UTC schrieb BALATON Zoltan : > >On Thu, 29 Feb 2024, BALATON Zoltan wrote: > >> On Wed, 21 Feb 2024, BALATON Zoltan wrote: > >>> Documentation on how to run Linux on the amigaone, pegasos2 and > >>>

Re: [PATCH] gdbstub: Fix double close() of the follow-fork-mode socket

2024-03-12 Thread Alex Bennée
Ilya Leoshkevich writes: > When the terminal GDB_FORK_ENABLED state is reached, the coordination > socket is not needed anymore and is therefore closed. However, if there > is a communication error between QEMU gdbstub and GDB, the generic > error handling code attempts to close it again. > >

Re: [PATCH 06/13] ppc/spapr: Add pa-features for POWER10 machines

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 7:34 PM AEST, Harsh Prateek Bora wrote: > > > On 3/12/24 00:21, Nicholas Piggin wrote: > > From: Benjamin Gray > > > > Add POWER10 pa-features entry. > > > > Notably DEXCR and and [P]HASHST/[P]HASHCHK instruction support is > > s/and and/and > > > advertised. Each DEXCR

Re: [PATCH 10/13] spapr: set MSR[ME] and MSR[FP] on client entry

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 8:03 PM AEST, Harsh Prateek Bora wrote: > > > On 3/12/24 00:21, Nicholas Piggin wrote: > > The initial MSR state for PAPR specifies MSR[ME] and MSR[FP] are set. > > > > Signed-off-by: Nicholas Piggin > > It would be good to mention PAPR section numbers suggesting the same.

Re: [PATCH 06/13] ppc/spapr: Add pa-features for POWER10 machines

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 7:59 PM AEST, BALATON Zoltan wrote: > On Tue, 12 Mar 2024, Nicholas Piggin wrote: > > On Tue Mar 12, 2024 at 7:07 AM AEST, BALATON Zoltan wrote: > >> On Mon, 11 Mar 2024, Philippe Mathieu-Daudé wrote: > >>> On 11/3/24 19:51, Nicholas Piggin wrote: > From: Benjamin Gray

Re: [PATCH 09/13] target/ppc: Prevent supervisor from modifying MSR[ME]

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 8:27 PM AEST, Harsh Prateek Bora wrote: > > > On 3/12/24 00:21, Nicholas Piggin wrote: > > Prevent guest state modifying the MSR[ME] bit. Per ISA: > > > >An attempt to modify MSRME in privileged but non-hypervisor state is > > s/MSRME/MSR[ME] ? Yes, thanks. > > >

Re: [PATCH 09/13] target/ppc: Prevent supervisor from modifying MSR[ME]

2024-03-12 Thread Harsh Prateek Bora
On 3/12/24 00:21, Nicholas Piggin wrote: Prevent guest state modifying the MSR[ME] bit. Per ISA: An attempt to modify MSRME in privileged but non-hypervisor state is s/MSRME/MSR[ME] ? ignored (i.e., the bit is not changed). Signed-off-by: Nicholas Piggin ---

Re: [PATCH v2 00/29] Cleanup up to fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Zhao Liu
On Tue, Mar 12, 2024 at 09:50:25AM +0100, Thomas Huth wrote: > Date: Tue, 12 Mar 2024 09:50:25 +0100 > From: Thomas Huth > Subject: Re: [PATCH v2 00/29] Cleanup up to fix missing ERRP_GUARD() for > error_prepend() > > On 12/03/2024 09.43, Zhao Liu wrote: > > Hi Thomas/Markus/Michael, > > > >

Re: [PATCH 10/13] spapr: set MSR[ME] and MSR[FP] on client entry

2024-03-12 Thread Harsh Prateek Bora
On 3/12/24 00:21, Nicholas Piggin wrote: The initial MSR state for PAPR specifies MSR[ME] and MSR[FP] are set. Signed-off-by: Nicholas Piggin It would be good to mention PAPR section numbers suggesting the same. Anyways, Reviewed-by: Harsh Prateek Bora --- hw/ppc/spapr_cpu_core.c |

Re: [PATCH] target/ppc: Move floating-point arithmetic instructions to decodetree.

2024-03-12 Thread Nicholas Piggin
On Thu Mar 7, 2024 at 9:03 PM AEST, Chinmay Rath wrote: > diff --git a/target/ppc/translate/fp-impl.c.inc > b/target/ppc/translate/fp-impl.c.inc > index 189cd8c979..03b84ba79b 100644 > --- a/target/ppc/translate/fp-impl.c.inc > +++ b/target/ppc/translate/fp-impl.c.inc > @@ -30,96 +30,73 @@ static

RE: [PATCH v2 4/9] aspeed/smc: Add AST2700 support

2024-03-12 Thread Jamin Lin
> On 3/4/24 10:29, Jamin Lin wrote: > > AST2700 fmc/spi controller's address decoding unit is 64KB and only > > bits [31:16] are used for decoding. Introduce seg_to_reg and > > reg_to_seg handlers for ast2700 fmc/spi controller. > > In addition, adds ast2700 fmc, spi0, spi1, and spi2 class init

Re: [PATCH 06/13] ppc/spapr: Add pa-features for POWER10 machines

2024-03-12 Thread BALATON Zoltan
On Tue, 12 Mar 2024, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 7:07 AM AEST, BALATON Zoltan wrote: On Mon, 11 Mar 2024, Philippe Mathieu-Daudé wrote: On 11/3/24 19:51, Nicholas Piggin wrote: From: Benjamin Gray Add POWER10 pa-features entry. Notably DEXCR and and [P]HASHST/[P]HASHCHK

Re: [PATCH v9 02/21] hw/core/machine: Support modules in -smp

2024-03-12 Thread Zhao Liu
> > @@ -51,6 +51,10 @@ static char *cpu_hierarchy_to_string(MachineState *ms) > > g_string_append_printf(s, " * clusters (%u)", ms->smp.clusters); > > } > > +if (mc->smp_props.modules_supported) { > > +g_string_append_printf(s, " * modules (%u)", ms->smp.clusters); > >

Re: [PATCH v4 00/25] migration: Improve error reporting

2024-03-12 Thread Cédric Le Goater
On 3/12/24 08:16, Cédric Le Goater wrote: On 3/11/24 21:24, Peter Xu wrote: On Fri, Mar 08, 2024 at 04:15:08PM +0800, Peter Xu wrote: On Wed, Mar 06, 2024 at 02:34:15PM +0100, Cédric Le Goater wrote: * [1-4] already queued in migration-next.    migration: Report error when shutdown fails   

Re: [PATCH v9 11/21] i386/cpu: Decouple CPUID[0x1F] subleaf with specific topology level

2024-03-12 Thread Zhao Liu
On Mon, Mar 11, 2024 at 04:45:41PM +0800, Xiaoyao Li wrote: > Date: Mon, 11 Mar 2024 16:45:41 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v9 11/21] i386/cpu: Decouple CPUID[0x1F] subleaf with > specific topology level > > On 2/27/2024 6:32 PM, Zhao Liu wrote: > > From: Zhao Liu > > > > At

Re: [PATCH 2/2] migration: Fix error handling after dup in file migration

2024-03-12 Thread Daniel P . Berrangé
On Mon, Mar 11, 2024 at 08:33:35PM -0300, Fabiano Rosas wrote: > The file migration code was allowing a possible -1 from a failed call > to dup() to propagate into the new QIOFileChannel::fd before checking > for validity. Coverity doesn't like that, possibly due to the the > lseek(-1, ...) call

Re: [PATCH 1/2] io: Introduce qio_channel_file_new_dupfd

2024-03-12 Thread Daniel P . Berrangé
On Mon, Mar 11, 2024 at 08:33:34PM -0300, Fabiano Rosas wrote: > Add a new helper function for creating a QIOChannelFile channel with a > duplicated file descriptor. This saves the calling code from having to > do error checking on the dup() call. > > Suggested-by: Daniel P. Berrangé >

Re: [PATCH v2] linux-aio: add IO_CMD_FDSYNC command support

2024-03-12 Thread Kevin Wolf
Am 11.03.2024 um 20:36 hat Stefan Hajnoczi geschrieben: > On Mon, Mar 11, 2024 at 04:40:05PM +0100, Kevin Wolf wrote: > > Am 11.03.2024 um 14:09 hat Stefan Hajnoczi geschrieben: > > > On Mon, Mar 11, 2024 at 11:13:33AM +0530, Prasad Pandit wrote: > > > > From: Prasad Pandit > > > > > > > >

Re: [PATCH] target/ppc: Move floating-point arithmetic instructions to decodetree.

2024-03-12 Thread Nicholas Piggin
On Thu Mar 7, 2024 at 9:03 PM AEST, Chinmay Rath wrote: > This patch moves the below instructions to decodetree specification : > > f{add, sub, mul, div, re, rsqrte, madd, msub, nmadd, nmsub}[s][.] : A-form > ft{div, sqrt} : X-form > >

Re: [PATCH 06/13] ppc/spapr: Add pa-features for POWER10 machines

2024-03-12 Thread Harsh Prateek Bora
On 3/12/24 00:21, Nicholas Piggin wrote: From: Benjamin Gray Add POWER10 pa-features entry. Notably DEXCR and and [P]HASHST/[P]HASHCHK instruction support is s/and and/and advertised. Each DEXCR aspect is allocated a bit in the device tree, using the 68--71 byte range (inclusive). The

Re: [PATCH v3] docs/system/ppc: Document running Linux on AmigaNG machines

2024-03-12 Thread Bernhard Beschow
Am 9. März 2024 11:34:56 UTC schrieb BALATON Zoltan : >On Thu, 29 Feb 2024, BALATON Zoltan wrote: >> On Wed, 21 Feb 2024, BALATON Zoltan wrote: >>> Documentation on how to run Linux on the amigaone, pegasos2 and >>> sam460ex machines is currently buried in the depths of the qemu-devel >>>

Re: [PULL 09/34] target/riscv: add remaining named features

2024-03-12 Thread Daniel Henrique Barboza
Hi Clément, Alistair, On 3/11/24 11:39, Daniel Henrique Barboza wrote: On 3/11/24 10:47, Clément Chigot wrote: Hi Alistair, Since this series, I'm getting warnings when using a CPU not supporting the latest ISA, such as the SIFIVE_E series.    | $ qemu-system-riscv32  -M sifive_e    |

Re: [PATCH v2 1/1] memory tier: acpi/hmat: create CPUless memory tiers after obtaining HMAT info

2024-03-12 Thread Huang, Ying
"Ho-Ren (Jack) Chuang" writes: > The current implementation treats emulated memory devices, such as > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > (E820_TYPE_RAM). However, these emulated devices have different > characteristics than traditional DRAM, making it

Re: [PATCH 08/13] ppc/pnv: Set POWER9, POWER10 ibm,pa-features bits

2024-03-12 Thread Cédric Le Goater
On 3/12/24 09:54, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 6:06 PM AEST, Cédric Le Goater wrote: On 3/11/24 19:51, Nicholas Piggin wrote: Copy the pa-features arrays from spapr, adjusting slightly as described in comments. Cc: "Cédric Le Goater" Cc: "Frédéric Barrat" Signed-off-by:

Re: [PATCH 05/13] ppc/spapr: Adjust ibm,pa-features for POWER9

2024-03-12 Thread Harsh Prateek Bora
On 3/12/24 00:21, Nicholas Piggin wrote: "MMR" and "SPR SO" are not implemented in POWER9, so clear those bits. HTM is not set by default, and only later if the cap is set, so remove the comment that suggests otherwise. Signed-off-by: Nicholas Piggin Reviewed-by: Harsh Prateek Bora ---

Re: [PATCH v4 11/24] net: Use virtual time for net announce

2024-03-12 Thread Pavel Dovgalyuk
This won't work, as needed. Announce timer can't be enabled, because it is set in post_load function. Therefore announce callbacks break the replay, when virtio-net is used with snapshots. On 11.03.2024 20:40, Nicholas Piggin wrote: Using virtual time for announce ensures that guest visible

Re: [PATCH v2 26/29] hw/virtio/vhost: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
On 11/03/2024 04.38, Zhao Liu wrote: From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to

Re: [PATCH 01/13] ppc: Drop support for POWER9 and POWER10 DD1 chips

2024-03-12 Thread Harsh Prateek Bora
On 3/12/24 14:29, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 2:55 PM AEST, Harsh Prateek Bora wrote: On 3/12/24 10:20, Harsh Prateek Bora wrote: On 3/12/24 00:21, Nicholas Piggin wrote: The POWER9 DD1 and POWER10 DD1 chips are not public and are no longer of any use in QEMU. Remove

Re: [PATCH v4 20/24] replay: simple auto-snapshot mode for record

2024-03-12 Thread Pavel Dovgalyuk
On 11.03.2024 20:40, Nicholas Piggin wrote: record makes an initial snapshot when the machine is created, to enable reverse-debugging. Often the issue being debugged appears near the end of the trace, so it is important for performance to keep snapshots close to the end. This implements a

Re: [RFC 0/2] Add RISC-V Server Platform Reference Board

2024-03-12 Thread Wu, Fei
On 3/8/2024 6:15 AM, Marcin Juszkiewicz wrote: > W dniu 4.03.2024 o 11:25, Fei Wu pisze: > >> The RISC-V Server Platform specification[1] defines a standardized >> set of hardware and software capabilities, that portable system >> software, such as OS and hypervisors can rely on being present in

Re: [PATCH 01/13] ppc: Drop support for POWER9 and POWER10 DD1 chips

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 2:55 PM AEST, Harsh Prateek Bora wrote: > > > On 3/12/24 10:20, Harsh Prateek Bora wrote: > > > > > > On 3/12/24 00:21, Nicholas Piggin wrote: > >> The POWER9 DD1 and POWER10 DD1 chips are not public and are no longer of > >> any use in QEMU. Remove them. > >> > >>

Re: [PATCH] spapr: avoid overhead of finding vhyp class in critical operations

2024-03-12 Thread Harsh Prateek Bora
On 3/12/24 14:18, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 4:38 PM AEST, Harsh Prateek Bora wrote: Hi Nick, One minor comment below: On 2/24/24 13:03, Nicholas Piggin wrote: PPC_VIRTUAL_HYPERVISOR_GET_CLASS is used in critical operations like interrupts and TLB misses and is quite

Re: [PATCH 02/13] target/ppc: POWER10 does not have transactional memory

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 6:10 PM AEST, Harsh Prateek Bora wrote: > Hi Nick, > > One query/comment below: > > On 3/12/24 00:21, Nicholas Piggin wrote: > > POWER10 hardware implements a degenerate transactional memory facility > > in POWER8/9 PCR compatibility modes to permit migration from older > >

Re: [PATCH 08/13] ppc/pnv: Set POWER9, POWER10 ibm,pa-features bits

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 6:06 PM AEST, Cédric Le Goater wrote: > On 3/11/24 19:51, Nicholas Piggin wrote: > > Copy the pa-features arrays from spapr, adjusting slightly as > > described in comments. > > > > Cc: "Cédric Le Goater" > > Cc: "Frédéric Barrat" > > Signed-off-by: Nicholas Piggin > >

Re: [PATCH v2 25/29] hw/virtio/vhost-vsock: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
On 11/03/2024 04.38, Zhao Liu wrote: From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to

Re: [PATCH v2 00/29] Cleanup up to fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
On 12/03/2024 09.43, Zhao Liu wrote: Hi Thomas/Markus/Michael, For the remaing patches, could you please help me merge them next? Many thanks! Yes, I'm currently reviewing the ones that don't have a Reviewed-by yet. I can pick up the remaining patches if the other maintainers won't pick

Re: [PATCH v9 06/21] i386/cpu: Use APIC ID info to encode cache topo in CPUID[4]

2024-03-12 Thread Zhao Liu
On Mon, Mar 11, 2024 at 05:03:02PM +0800, Xiaoyao Li wrote: > Date: Mon, 11 Mar 2024 17:03:02 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v9 06/21] i386/cpu: Use APIC ID info to encode cache > topo in CPUID[4] > > On 3/10/2024 9:38 PM, Zhao Liu wrote: > > Hi Xiaoyao, > > > > > >

Re: [PATCH 04/13] ppc/spapr: Remove copy-paste from pa-features

2024-03-12 Thread Harsh Prateek Bora
Hi Nick, On 3/12/24 00:21, Nicholas Piggin wrote: TCG does not support copy/paste instructions. Remove it from ibm,pa-features. This has never been implemented under TCG or s/or/nor ? practically usable under KVM, so it won't be missed. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c

Re: [PATCH] spapr: avoid overhead of finding vhyp class in critical operations

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 4:38 PM AEST, Harsh Prateek Bora wrote: > Hi Nick, > > One minor comment below: > > On 2/24/24 13:03, Nicholas Piggin wrote: > > PPC_VIRTUAL_HYPERVISOR_GET_CLASS is used in critical operations like > > interrupts and TLB misses and is quite costly. Running the > >

Re: [PATCH v5] pc: q35: Bump max_cpus to 4096 vcpus

2024-03-12 Thread Zhao Liu
On Wed, Feb 28, 2024 at 08:03:51PM +0530, Ani Sinha wrote: > Date: Wed, 28 Feb 2024 20:03:51 +0530 > From: Ani Sinha > Subject: [PATCH v5] pc: q35: Bump max_cpus to 4096 vcpus > X-Mailer: git-send-email 2.42.0 > > Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to allow > up

Re: [PATCH 03/13] ppc/spapr|pnv: Remove SAO from pa-features

2024-03-12 Thread Harsh Prateek Bora
Hi Nick, One cosmetic comment, in case you are doing a re-spin: On 3/12/24 00:21, Nicholas Piggin wrote: SAO is a page table attribute that strengthens the memory ordering of accesses. QEMU with MTTCG does not implement this, so clear it in ibm,pa-features. This is an obscure feature that has

[PATCH v2 0/2] ARM Sbsa-ref: Enable CPU cluster topology

2024-03-12 Thread Xiong Yining
Enable CPU cluster support on SbsaQemu platform, so that users can specify a 4-level CPU hierarchy sockets/clusters/cores/threads. And this topology can be passed to the firmware through DT cpu-map. Changes in v2: - put this code before sbsa_fdt_add_gic_node(). xiongyining1480 (2):

[PATCH v2 1/2] hw/arm/sbsa-ref:Enable CPU cluster on ARM sbsa machine

2024-03-12 Thread Xiong Yining
From: xiongyining1480 Enable the CPU cluster on ARM sbsa machine, so user can configure the cluster hierarchy. Signed-off-by: Xiong Yining Signed-off-by: Chen Baozi Tested-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/sbsa-ref.c

[PATCH v2 2/2] hw/arm/sbsa-ref: Add cpu-map to device tree

2024-03-12 Thread Xiong Yining
From: xiongyining1480 Support CPU topology description through device tree. Signed-off-by: Xiong Yining Signed-off-by: Chen Baozi Reviewed-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/hw/arm/sbsa-ref.c

Re: [PATCH v2 00/29] Cleanup up to fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Zhao Liu
Hi Thomas/Markus/Michael, For the remaing patches, could you please help me merge them next? Many thanks! Zhao On Tue, Mar 12, 2024 at 09:17:30AM +0100, Philippe Mathieu-Daudé wrote: > Date: Tue, 12 Mar 2024 09:17:30 +0100 > From: Philippe Mathieu-Daudé > Subject: Re: [PATCH v2 00/29] Cleanup

Re: [PATCH v2 00/14] libvhost-user: support more memslots and cleanup memslot handling code

2024-03-12 Thread David Hildenbrand
On 11.03.24 21:03, Mario Casquero wrote: This series has been successfully tested by QE. Start the qemu-storage-daemon in the background with a rhel 9.5 image and vhost-user-blk. After that, boot up a VM with virtio-mem and vhost-user-blk-pci. Check with the HMP command 'info mtree' that

[PULL 09/13] hw/core: Cleanup unused included header in machine-qmp-cmds.c

2024-03-12 Thread Philippe Mathieu-Daudé
From: Zhao Liu Remove unused header (qemu/main-loop.h) in machine-qmp-cmds.c. Tested by "./configure" and then "make". Signed-off-by: Zhao Liu Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240311075621.3224684-3-zhao1@linux.intel.com> Signed-off-by: Philippe Mathieu-Daudé ---

[PULL 06/13] hw/misc/ivshmem: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Philippe Mathieu-Daudé
From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_prepend(), error_vprepend() or *

<    1   2   3   4   5   6   7   >