Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

Am 10.12.2015 um 07:15 schrieb Bharata B Rao: > CPU hotplug granularity > --- > CPU hotplug will now be done in cpu-core device granularity. Nack. > Are there archs that would need thread level CPU addition ? Yes, s390. And for x86 people called for socket level. Andreas

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

Am 10.12.2015 um 13:35 schrieb Igor Mammedov: > wrt CLI can't we do something like this? > > -device some-cpu-model,socket=x[,core=y[,thread=z]] That's problematic and where my x86 remodeling got stuck. It works fine (more or less) to model sockets, cores and hyperthreads for -smp, but doing it

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

Am 16.12.2015 um 16:44 schrieb Igor Mammedov: > On Wed, 16 Dec 2015 16:19:06 +0100 > Andreas Färber <afaer...@suse.de> wrote: > >> Am 10.12.2015 um 07:15 schrieb Bharata B Rao: >>> CPU hotplug granularity >>> --- >>> CPU hotplug

[Qemu-devel] [PULL v2 4/4] qom-test: Fix qmp() leaks

andre.lur...@redhat.com> Message-Id: <1448551895-871-1-git-send-email-marcandre.lur...@redhat.com> [Straightforwardly rebased onto the previous patch] Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Andreas Färber

[Qemu-devel] [PULL v2 1/4] tests: Fix check-report-qtest-% target

by adding $(qtest-generic-y) in check-report-qtest-%. Also add it in check-clean target, spotted by Markus. Reviewed-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- tests/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PULL for-2.5 v2 0/4] QOM devices patch queue 2015-12-04

f7f4b63ae4a2430be3: qom-test: Fix qmp() leaks (2015-12-04 18:29:31 +0100) QOM infrastructure fixes and device conversions * Documentation update * qom-test and related fixes ---------

[Qemu-devel] [PULL v2 2/4] qom: Update documentation comment of struct Object

From: Cao jin <caoj.f...@cn.fujitsu.com> It doesn't have "GSList *interfaces" anymore, drop the paragraph. Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/qom/object.h | 3 --- 1 file changed, 3 deleti

[Qemu-devel] [PULL v2 3/4] tests: Use proper functions types instead of void (*fn)

gt; Reviewed-by: Eric Blake <ebl...@redhat.com> [AF/armbru: Inline GTestFunc/GTestDataFunc typedef for old GLib] Signed-off-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- tests/ide-test.c| 4 ++-- tests/libqtest.c| 14 ++

Re: [Qemu-devel] [PATCH for-2.5 0/2] tests: A cleanup and a fix

Am 03.12.2015 um 13:06 schrieb Markus Armbruster: > Peter Maydell writes: > >> On 2 December 2015 at 20:20, Markus Armbruster wrote: >>> PATCH 1 cleans up unnecessary type punning. >>> >>> PATCH 2 plugs a massive memory leak in qom-test. I think it

Re: [Qemu-devel] [PATCH] Trivial: update comment of struct Object

Am 29.11.2015 um 11:48 schrieb Michael Tokarev: > 05.11.2015 10:39, Cao jin wrote: >> it don`t has "GSList *interfaces" anymore > > Andreas, should this be applied? It's been on the list for long already, > and you said I shouldn't apply qom patches... I seem to have missed this for the last

[Qemu-devel] [PULL for-2.5 0/4] QOM devices patch queue 2015-12-03

qmp() leaks (2015-12-03 20:22:15 +0100) QOM infrastructure fixes and device conversions * Typo fix * qom-test and related fixes ------------ Andreas Färber (1): tests: Fix

[Qemu-devel] [PULL 2/4] qom: Update documentation comment of struct Object

From: Cao jin <caoj.f...@cn.fujitsu.com> It doesn't have "GSList *interfaces" anymore, drop the paragraph. Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/qom/object.h | 3 --- 1 file changed, 3 deleti

[Qemu-devel] [PULL 4/4] qom-test: Fix qmp() leaks

andre.lur...@redhat.com> Message-Id: <1448551895-871-1-git-send-email-marcandre.lur...@redhat.com> [Straightforwardly rebased onto the previous patch] Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Andreas Färber

[Qemu-devel] [PULL 1/4] tests: Fix check-report-qtest-% target

by adding $(qtest-generic-y) in check-report-qtest-%. Also add it in check-clean target, spotted by Markus. Reviewed-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- tests/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH for-2.5 v2] tests: Fix check-report-qtest-% target

Am 03.12.2015 um 20:06 schrieb Markus Armbruster: > Andreas Färber <afaer...@suse.de> writes: > >> Commit e253c28 ("tests: Fix how qom-test is run") introduced >> $(qtest-generic-y) and used it for check-qtest-% target, but did not >> update check-report

Re: [Qemu-devel] [PATCH for-2.5 2/2] qom-test: fix qmp() leaks

Am 02.12.2015 um 21:44 schrieb Eric Blake: > On 12/02/2015 01:20 PM, Markus Armbruster wrote: >> From: Marc-André Lureau >> >> Before this patch ASAN reported: >> SUMMARY: AddressSanitizer: 677165875 byte(s) leaked in 1272437 allocation(s) >> >> After this patch: >>

[Qemu-devel] [PULL 3/4] tests: Use proper functions types instead of void (*fn)

gt; Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- tests/ide-test.c| 4 ++-- tests/libqtest.c| 13 + tests/libqtest.h| 6 +++--- tests/vhost-user-test.c | 3 ++- 4 files changed, 16 insertions(+), 10

[Qemu-devel] [PATCH for-2.5 v2] tests: Fix check-report-qtest-% target

by adding $(qtest-generic-y) in check-report-qtest-%. Also add it in check-clean target, spotted by Markus. Cc: Markus Armbruster <arm...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- tests/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

Re: [Qemu-devel] Highlighting changes in QEMU 2.5

Hi, Am 01.12.2015 um 13:16 schrieb Amit Shah: > Ping. > > I haven't received any responses so far, please let me know if you're > planning on doing this. No. I don't recall merging any big 2.5 feature worth describing, and I have neither time nor sufficient knowledge for producing videos

Re: [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default

Hi, CC'ing qemu-devel. Am 21.11.2015 um 00:01 schrieb Borislav Petkov: > From: Borislav Petkov > > Software Error Recovery, i.e. SER, is purely an Intel feature and it > shouldn't be set by default. Enable it only on Intel. Is this new in 2.5? Otherwise we would probably need

[Qemu-devel] [PATCH for-2.5] tests: Fix check-report-qtest-% target

by adding $(qtest-generic-y) in check-report-qtest-%. Cc: Markus Armbruster <arm...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- tests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index b937984..592cba9 10064

Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration

Am 19.11.2015 um 10:20 schrieb Markus Armbruster: > Andreas Färber <afaer...@suse.de> writes: > >> From: "Daniel P. Berrange" <berra...@redhat.com> >> >> Some users of QOM need to be able to iterate over properties >> defined against an object

[Qemu-devel] [PULL v2 03/10] qmp: Convert QMP code to use object property iterators

Berrange <berra...@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- qmp.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/qmp.c b/qmp.c index ddc63ea..0a1fa19 100644 --- a/

[Qemu-devel] [PULL v2 05/10] ppc: Convert spapr code to use object property iterators

Berrange <berra...@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- hw/ppc/spapr_drc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 5d6ea7c..f34bc

[Qemu-devel] [PULL v2 10/10] MAINTAINERS: Add check-qom-{interface, proplist} to QOM

Add the QOM unit tests to the QOM maintenance area so that maintainers get CC'ed on changes and to document QOM test coverage. Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Reviewed-by: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de>

[Qemu-devel] [PULL v2 06/10] net: Convert net filter code to use object property iterators

Berrange <berra...@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- net/filter.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/filter.c b/net/filter.c index 326f2b5..1365bad 100644 ---

Re: [Qemu-devel] [PULL for-2.5 00/10] QOM devices patch queue 2015-11-18

Am 19.11.2015 um 12:53 schrieb Daniel P. Berrange: > On Thu, Nov 19, 2015 at 10:54:15AM +, Peter Maydell wrote: >> On 18 November 2015 at 20:39, Andreas Färber <afaer...@suse.de> wrote: >>> Hello Peter, >>> >>> This is my late QOM (devices)

[Qemu-devel] [PULL v2 07/10] qom: Add a test case for complex property finalization

operty test case to replicate the device like structure and expose any potential bugs in the object_property_del_all() function. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- test

[Qemu-devel] [PULL v2 01/10] qdev: Change Property::offset field to ptrdiff_t type

assert(qdev_get_prop_ptr(dev, >prop) == eltptr); So ptrdiff_t should be used instead. Signed-off-by: Ildar Isaev <i...@inbox.ru> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/hw/qdev-core.h | 2 +- 1 file chang

[Qemu-devel] [PULL v2 09/10] qom: Clean up assertions to display values on failure

Instead of using g_assert() for integer comparisons, use g_assert_cmpint() so that we can see the respective values. While at it, fix one stray indentation. Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- qom/o

[Qemu-devel] [PULL v2 02/10] qom: Introduce ObjectPropertyIterator struct for iteration

@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> [AF: Fixed examples, style cleanups] Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/qom/object.h | 49 ++ qom/object.c | 28 +

[Qemu-devel] [PULL v2 08/10] qom: Replace object property list with GHashTable

msung.com> [AF: Fixed object_property_del_{all,child}() issues; g_hash_table_contains() -> g_hash_table_lookup(), suggested by Daniel] Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/qom/object.h

[Qemu-devel] [PULL for-2.5 v2 00/10] QOM devices patch queue 2015-11-19

; 4 GiB * Performance improvements for QOM property handling * Assertion cleanups * MAINTAINERS additions -------- Andreas Färber (2): qom: Clean up assertions to display values on failure MAINTAINERS: Add check-qom-{interface,propl

[Qemu-devel] [PULL v2 04/10] vl: Convert machine help code to use object property iterators

Berrange <berra...@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- vl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 7d993a5..4211ff1 100644 --- a/vl.c +++ b/vl.c @@ -1

Re: [Qemu-devel] [PATCH qom-next] MAINTAINERS: Add check-qom-proplist to QOM

Am 18.11.2015 um 19:13 schrieb Andreas Färber: > Add the QOM unit test to the QOM maintenance area so that maintainers > get CC'ed on changes and to document QOM test coverage. > > Cc: Daniel P. Berrange <berra...@redhat.com> > Signed-off-by: Andreas Färber <afaer...@suse.

Re: [Qemu-devel] [PATCH] qom: add a test case for complex property finalization

Am 16.11.2015 um 16:37 schrieb Daniel P. Berrange: > QDev has some quite complex object child/link relationships > which place some requirements on the object_property_del_all > method to consider that properties can be modified while > being iterated over. > > This extends the QOM property test

[Qemu-devel] [PATCH qom-next] MAINTAINERS: Add check-qom-proplist to QOM

Add the QOM unit test to the QOM maintenance area so that maintainers get CC'ed on changes and to document QOM test coverage. Cc: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)

[Qemu-devel] [PULL 04/10] vl: Convert machine help code to use object property iterators

Berrange <berra...@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- vl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 7d993a5..4211ff1 100644 --- a/vl.c +++ b/vl.c @@ -1

[Qemu-devel] [PULL 01/10] qdev: Change Property::offset field to ptrdiff_t type

assert(qdev_get_prop_ptr(dev, >prop) == eltptr); So ptrdiff_t should be used instead. Signed-off-by: Ildar Isaev <i...@inbox.ru> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/hw/qdev-core.h | 2 +- 1 file chang

[Qemu-devel] [PULL 03/10] qmp: Convert QMP code to use object property iterators

Berrange <berra...@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- qmp.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/qmp.c b/qmp.c index ddc63ea..0a1fa19 100644 --- a/

[Qemu-devel] [PULL for-2.5 00/10] QOM devices patch queue 2015-11-18

* Assertion cleanups * MAINTAINERS additions -------- Andreas Färber (2): qom: Clean up assertions to display values on failure MAINTAINERS: Add check-qom-{interface,proplist} to QOM Daniel P. Berrange (6): qom: Introduce ObjectPr

[Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration

@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> [AF: Fixed examples, style cleanups] Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/qom/object.h | 49 ++ qom/object.c | 28 +

[Qemu-devel] [PULL 04/10] vl: Convert machine help code to use object property iterators

Berrange <berra...@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- vl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 7d993a5..4211ff1 100644 --- a/vl.c +++ b/vl.c @@ -1

[Qemu-devel] [PULL for-2.5 00/10] QOM devices patch queue 2015-11-18

* Assertion cleanups * MAINTAINERS additions -------- Andreas Färber (2): qom: Clean up assertions to display values on failure MAINTAINERS: Add check-qom-{interface,proplist} to QOM Daniel P. Berrange (6): qom: Introduce ObjectPr

[Qemu-devel] [PULL 08/10] qom: Replace object property list with GHashTable

msung.com> [AF: Fixed object_property_del_{all,child}() issues] Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/qom/object.h | 10 +++-- qom/object.c | 120 --- 2 files cha

[Qemu-devel] [PULL 03/10] qmp: Convert QMP code to use object property iterators

Berrange <berra...@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- qmp.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/qmp.c b/qmp.c index ddc63ea..0a1fa19 100644 --- a/

[Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration

@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> [AF: Fixed examples, style cleanups] Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/qom/object.h | 49 ++ qom/object.c | 28 +

[Qemu-devel] [PULL 09/10] qom: Clean up assertions to display values on failure

Instead of using g_assert() for integer comparisons, use g_assert_cmpint() so that we can see the respective values. While at it, fix one stray indentation. Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- qom/o

Re: [Qemu-devel] [PULL 37/40] Add David Gibson for sPAPR in MAINTAINERS file

Am 18.11.2015 um 21:51 schrieb Eric Blake: > On 11/18/2015 01:46 PM, Andreas Färber wrote: >>> +++ b/MAINTAINERS >>> @@ -486,7 +486,8 @@ F: hw/ppc/prep.c >>> F: hw/pci-host/prep.[hc] >>> F: hw/isa/pc87312.[hc] >>> >>> -sPAPR >>

[Qemu-devel] [PULL 05/10] ppc: Convert spapr code to use object property iterators

Berrange <berra...@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- hw/ppc/spapr_drc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 5d6ea7c..f34bc

[Qemu-devel] [PULL 01/10] qdev: Change Property::offset field to ptrdiff_t type

assert(qdev_get_prop_ptr(dev, >prop) == eltptr); So ptrdiff_t should be used instead. Signed-off-by: Ildar Isaev <i...@inbox.ru> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/hw/qdev-core.h | 2 +- 1 file chang

[Qemu-devel] [PULL 06/10] net: Convert net filter code to use object property iterators

Berrange <berra...@redhat.com> Tested-by: Pavel Fedin <p.fe...@samsung.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- net/filter.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/filter.c b/net/filter.c index 326f2b5..1365bad 100644 ---

[Qemu-devel] [PULL 07/10] qom: Add a test case for complex property finalization

operty test case to replicate the device like structure and expose any potential bugs in the object_property_del_all() function. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- test

Re: [Qemu-devel] [PULL 37/40] Add David Gibson for sPAPR in MAINTAINERS file

Am 03.06.2015 um 23:45 schrieb Alexander Graf: > From: David Gibson > > At Alex Graf's request I'm now acting as sub-maintainer for the sPAPR > (-machine pseries) code. This updates MAINTAINERS accordingly. > > While we're at it, change the label to mention pseries

[Qemu-devel] [PULL 10/10] MAINTAINERS: Add check-qom-{interface, proplist} to QOM

Add the QOM unit tests to the QOM maintenance area so that maintainers get CC'ed on changes and to document QOM test coverage. Cc: Daniel P. Berrange <berra...@redhat.com> Cc: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- MAINTAIN

Re: [Qemu-devel] [PATCH v4 7/7] qom: allow properties to be registered against classes

Am 06.11.2015 um 10:32 schrieb Daniel P. Berrange: > On Thu, Nov 05, 2015 at 07:12:39PM +0100, Andreas Färber wrote: >> Am 13.10.2015 um 15:18 schrieb Pavel Fedin: >>>> diff --git a/include/qom/object.h b/include/qom/object.h >>>> index 2a54515..38f41d3 10064

Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue

Am 12.11.2015 um 14:36 schrieb Markus Armbruster: > Peter Maydell writes: > >> [...] it's usually painful to get a >> backtrace out of this kind of qtest, because it's clearly starting >> a whole pile of QEMUs and there's no way I know of to say "only >> run a few of

Re: [Qemu-devel] [PATCH v2 04/19] include/qom/cpu.h: Add new get_phys_page_attrs_debug method

Am 16.11.2015 um 15:07 schrieb Andreas Färber: > Am 16.11.2015 um 15:05 schrieb Peter Maydell: >> Add a new optional method get_phys_page_attrs_debug to CPUClass. >> This is like the existing get_phys_page_debug, but also returns >> the memory transaction attributes

Re: [Qemu-devel] [PATCH v2 04/19] include/qom/cpu.h: Add new get_phys_page_attrs_debug method

Am 16.11.2015 um 15:05 schrieb Peter Maydell: > Add a new optional method get_phys_page_attrs_debug to CPUClass. > This is like the existing get_phys_page_debug, but also returns > the memory transaction attributes to use for the access. > This will be necessary for CPUs which have multiple

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

Am 16.11.2015 um 09:16 schrieb Christian Borntraeger: > On 11/16/2015 08:13 AM, Pavel Fedin wrote: > (process:4102): GLib-CRITICAL **: g_hash_table_iter_next: assertion > 'ri->version == ri->hash_table->version' failed > > (process:4102): GLib-CRITICAL **: g_hash_table_iter_next:

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

Am 16.11.2015 um 09:53 schrieb Paolo Bonzini: > On 13/11/2015 22:25, Andreas Färber wrote: >> Thanks! sclp_init() seems to violate several QOM design principles in >> that it uses object_new() during TypeInfo::instance_init() > > There's nothing wrong with that. It's

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

Am 16.11.2015 um 10:38 schrieb Andreas Färber: > Am 16.11.2015 um 09:16 schrieb Christian Borntraeger: >> On 11/16/2015 08:13 AM, Pavel Fedin wrote: >>>>>> (process:4102): GLib-CRITICAL **: g_hash_table_iter_next: assertion >>>>>> 'r

[Qemu-devel] [PATCH] qom: Clean up assertions to display values on failure

Instead of using g_assert() for integer comparisons, use g_assert_cmpint() so that we can see the respective values. While at it, fix one stray indentation. Cc: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- qom/object.c | 12 ++--

Re: [Qemu-devel] [PATCH v2 1/7] vl: Add DT_COCOA DisplayType value

break; > #elif defined(CONFIG_COCOA) > -case DT_SDL: > +case DT_COCOA: > cocoa_display_init(ds, full_screen); > break; > #endif Sounds like a good idea, but haven't reviewed those extra DT_SDL uses, Acked-by: Andreas Färber <andreas.faer...@web.de> Regards, Andreas

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

Am 13.10.2015 um 14:37 schrieb Daniel P. Berrange: > From: Pavel Fedin > > ARM GICv3 systems with large number of CPUs create lots of IRQ pins. Since > every pin is represented as a property, number of these properties becomes > very large. Every property add first makes

Re: [Qemu-devel] [PATCH] include/hw: field 'offset' in struct Property should be ptrdiff_t as int causes overflow

Am 13.11.2015 um 19:32 schrieb John Snow: > On 11/12/2015 12:41 PM, Andreas Färber wrote: >> [...] Testing >> got stuck in ahci though, investigating. >> >> Thanks, >> Andreas >> > > Did you ever reproduce this, or does it seem to just be a

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

Am 13.11.2015 um 22:00 schrieb Christian Borntraeger: > On 11/13/2015 07:14 PM, Andreas Färber wrote: >> Am 13.10.2015 um 14:37 schrieb Daniel P. Berrange: >>> From: Pavel Fedin <p.fe...@samsung.com> >>> >>> ARM GICv3 systems with large number of CPUs cr

Re: [Qemu-devel] [RFC PATCH v4 01/11] exec: Remove cpu from cpus list during cpu_exec_exit()

Am 12.11.2015 um 10:30 schrieb Bharata B Rao: > On Thu, Nov 12, 2015 at 05:11:02PM +0800, Zhu Guihua wrote: >> Hi Bharata, >> >> On 09/09/2015 03:56 PM, Bharata B Rao wrote: >>> On Wed, Sep 09, 2015 at 03:41:30PM +0800, Zhu Guihua wrote: On 09/09/2015 01:52 PM, Bharata B Rao wrote: > On

Re: [Qemu-devel] [PATCH] include/hw: field 'offset' in struct Property should be ptrdiff_t as int causes overflow

Am 11.11.2015 um 09:54 schrieb Markus Armbruster: > Peter Maydell writes: >> On 25 August 2015 at 15:17, Markus Armbruster wrote: >>> Stumbled over this while throwing away old mail. Andreas, what do you >>> think? >> >> Seems right to me -- I

Re: [Qemu-devel] [PULL 17/24] qom/object: fix 2 comment typos

Am 06.11.2015 um 13:43 schrieb Michael Tokarev: > From: Cao jin > > Also change the misleading definition of macro OBJECT_CLASS_CHECK > > Signed-off-by: Cao jin > Signed-off-by: Michael Tokarev Michael, please *STOP*

Re: [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

t; + error_set(errp, ERROR_CLASS_DEVICENOTFOUND, >"Device '%s' not found", path); > } > target = NULL; That spelling is not exactly an improvement, but well, Reviewed-by: Andreas Färber <afaer...@suse.de> Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage

ERIC_ERROR, > - "Path '%s' does not uniquely identify an object", path); > +error_setg(errp, "Path '%s' does not uniquely identify an object", > + path); > } else if (!target) { > target = object_resolve_path(path, )

Re: [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage

Am 11.11.2015 um 15:21 schrieb Markus Armbruster: > Eric Blake writes: > >> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in >> since c6bd8c706. Nuke them. > > Doesn't really belong to this series, but that's okay. It seemed to avoid a GENERIC_ERROR ->

Re: [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests

Am 25.09.2015 um 17:01 schrieb Daniel P. Berrange: > On Fri, Sep 25, 2015 at 02:39:45PM +0200, Andreas Färber wrote: >> Add a test for parsing and setting a uint64 property. >> >> Signed-off-by: Andreas Färber <afaer...@suse.de> >> --- >> MAINTAINERS

Re: [Qemu-devel] [PATCH 1/7] string-input-visitor: Fix uint64 parsing

Am 25.09.2015 um 16:49 schrieb Eric Blake: > On 09/25/2015 06:39 AM, Andreas Färber wrote: >> All integers would get parsed by strtoll(), not handling the case of >> UINT64 properties with the most significient bit set. >> >> Implement a .type_uint64 visitor cal

Re: [Qemu-devel] [PATCH 1/3] qemu, pkeys: add pkeys support for qemu cpuid handling

Am 09.11.2015 um 13:24 schrieb Paolo Bonzini: > On 09/11/2015 12:55, Huaitong Han wrote: >> @@ -351,6 +362,7 @@ static const char *cpuid_6_feature_name[] = { >>CPUID_7_0_EBX_FSGSBASE, CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_AVX2, >>CPUID_7_0_EBX_ERMS, CPUID_7_0_EBX_INVPCID,

Re: [Qemu-devel] [PATCH 0/4] s390: Allow hotplug of s390 CPUs

Hi, Am 09.11.2015 um 16:17 schrieb Matthew Rosato: > To subsequently hotplug a CPU: > > Issue 'cpu-add ' from qemu monitor, or use virsh setvcpus --count > , where is the total number of desired guest CPUs. What exactly is still missing for you to use the standard device_add? Last time I

Re: [Qemu-devel] [PATCH 0/4] s390: Allow hotplug of s390 CPUs

Am 09.11.2015 um 16:37 schrieb Christian Borntraeger: > Am 09.11.2015 um 16:35 schrieb Christian Borntraeger: >> Am 09.11.2015 um 16:28 schrieb Andreas Färber: >>> Hi, >>> >>> Am 09.11.2015 um 16:17 schrieb Matthew Rosato: >>>> To subsequently hot

Re: [Qemu-devel] [PATCH] qdev: free qemu-opts when the QOM path goes away

Am 04.11.2015 um 19:34 schrieb Markus Armbruster: > Paolo Bonzini writes: > >> Otherwise there is a race where the DEVICE_DELETED event has been sent but >> attempts to reuse the ID will fail. >> >> Reported-by: Michael S. Tsirkin >> Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH v4 4/7] ppc: convert spapr code to use object property iterators

property_iter_free(iter); > > /* now write the drc count into the space we reserved at the > * beginning of the arrays previously Reviewed-by: Andreas Färber <afaer...@suse.de> CC'ing PPC for ack. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH v4 1/7] qom: introduce ObjectPropertyIterator struct for iteration

Am 13.10.2015 um 14:37 schrieb Daniel P. Berrange: > Some users of QOM need to be able to iterate over properties > defined against an object instance. Currently they are just > directly using the QTAIL macros against the object properties > data structure. > > This is bad because it exposes them

Re: [Qemu-devel] [PATCH Trivial] hw/intc/arm_gic: Remove the definition of NUM_CPU

The source is more consistent after this tweak. > > Signed-off-by: Wei Huang <w...@redhat.com> > --- > hw/intc/arm_gic.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) I don't mind either way, and it'll go through Peter's queue I guess, Reviewed-by: Andreas Fär

Re: [Qemu-devel] [PATCH v4 5/7] net: convert net filter code to use object property iterators

**errp) > g_free(str); > g_free(info); > } > +object_property_iter_free(iter); > } > > static void netfilter_finalize(Object *obj) Reviewed-by: Andreas Färber <afaer...@suse.de> CC'ing Stefan. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] PING-2: [PATCH v4 0/7] qom: more efficient object property handling

Pavel, Am 27.10.2015 um 12:26 schrieb Pavel Fedin: >>> I can further test cases to do more coverage of object proprty handling >>> wrt to classes, if you want me to. >> >> No, if that is sorted out now, I'll drop v2 and need to review v4. > > How is it? Any problems / advancements? Could i help

Re: [Qemu-devel] [PATCH v4 3/7] vl: convert machine help code to use object property iterators

> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > vl.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Andreas Färber <afaer...@suse.de> Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendör

Re: [Qemu-devel] [PATCH v4 2/7] qmp: convert QMP code to use object property iterators

> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > qmp.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Andreas Färber <afaer...@suse.de> Markus/Luiz, can you ack this change? Markus requested these iterators, I believe. Th

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

Am 13.10.2015 um 14:37 schrieb Daniel P. Berrange: > From: Pavel Fedin > > ARM GICv3 systems with large number of CPUs create lots of IRQ pins. Since > every pin is represented as a property, number of these properties becomes > very large. Every property add first makes

Re: [Qemu-devel] [PATCH v4 7/7] qom: allow properties to be registered against classes

Am 13.10.2015 um 15:18 schrieb Pavel Fedin: >> diff --git a/include/qom/object.h b/include/qom/object.h >> index 2a54515..38f41d3 100644 >> --- a/include/qom/object.h >> +++ b/include/qom/object.h [...] >> @@ -964,8 +975,14 @@ typedef struct ObjectPropertyIterator >> ObjectPropertyIterator; >>

Re: [Qemu-devel] [PATCH v2] qom/object: fix 2 comment typos

Am 03.11.2015 um 14:39 schrieb Peter Maydell: > On 3 November 2015 at 02:36, Cao jin wrote: >> Also change the misleading definition of macro OBJECT_CLASS_CHECK >> >> Signed-off-by: Cao jin > > Reviewed-by: Peter Maydell

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] prep: do not use CPU_LOG_IOPORT, convert to tracepoints

; > > Looks good to me. Applied to ppc-next. Would've been nice to ask first, but Acked-by: Andreas Färber <andreas.faer...@web.de> I do have some PReP refactorings for a 2.4 issue from Markus that I would like to get into 2.5, so please submit your ppc queue early. Thanks, Andreas

[Qemu-devel] [PULL 1/8] disas: QOMify s390x specific disas setup

Acked-by: Richard Henderson <r...@twiddle.net> Signed-off-by: Andreas Färber <afaer...@suse.de> --- disas.c| 6 -- target-s390x/cpu.c | 8 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/disas.c b/disas.c index 45878fa..655f23d 100644 --- a/d

[Qemu-devel] [PULL 7/8] disas: QOMify mips specific disas setup

mail.com> Acked-by: Leon Alrae <leon.al...@imgtec.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- disas.c | 12 target-mips/cpu.c | 9 + 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/disas.c b/disas.c index 2676e2f..bf16c42 1006

[Qemu-devel] [PULL 3/8] disas: QOMify m68k specific disas setup

ur...@vivier.eu> Reviewed-by: Greg Ungerer <g...@uclinux.org> Signed-off-by: Andreas Färber <afaer...@suse.de> --- disas.c | 4 target-m68k/cpu.c | 9 - 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/disas.c b/disas.c index 05d409b..1ef2596 1006

[Qemu-devel] [PULL 8/8] disas: QOMify alpha specific disas setup

he BFD (This was an omission from commit b9bec751c8c8b08d8055da32306eb105db03031b). Signed-off-by: Peter Crosthwaite <crosthwaite.pe...@gmail.com> Acked-by: Richard Henderson <r...@twiddle.net> Signed-off-by: Andreas Färber <afaer...@suse.de> --- disas.c| 5 -

[Qemu-devel] [PULL 0/8] QOM CPUState patch queue 2015-10-22

Hello Peter, This is my QOM CPU patch queue. Please pull. Remaining maintainers should've had more than enough time to object or ack now. Regards, Andreas Cc: Peter Maydell Cc: Peter Crosthwaite The following changes since commit

[Qemu-devel] [PULL 4/8] disas: QOMify sparc specific disas setup

ail.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- disas.c| 10 -- target-sparc/cpu.c | 9 + 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/disas.c b/disas.c index 1ef2596..5b3acf0 100644 --- a/disas.c +++ b/disas.c @@ -214,11 +214,6 @

[Qemu-devel] [PULL 6/8] disas: QOMify sh4 specific disas setup

l32.net> Signed-off-by: Andreas Färber <afaer...@suse.de> --- disas.c | 6 -- target-sh4/cpu.c | 11 ++- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/disas.c b/disas.c index b687c98..2676e2f 100644 --- a/disas.c +++ b/disas.c @@ -236,9 +236,6 @@ voi

[Qemu-devel] [PULL 5/8] disas: QOMify lm32 specific disas setup

.cc> Signed-off-by: Andreas Färber <afaer...@suse.de> --- disas.c | 6 -- target-lm32/cpu.c | 7 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/disas.c b/disas.c index 5b3acf0..b687c98 100644 --- a/disas.c +++ b/disas.c @@ -242,9 +242,6 @@ void target_d

[Qemu-devel] [PULL 2/8] disas: QOMify moxie specific disas setup

com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- disas.c| 6 -- target-moxie/cpu.c | 7 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/disas.c b/disas.c index 655f23d..05d409b 100644 --- a/disas.c +++ b/disas.c @@ -249,9 +249,6 @@ voi

Re: [Qemu-devel] cpu modelling and hotplug

Hi, Am 22.10.2015 um 03:27 schrieb Zhu Guihua: > May I know whether the discussion is still ongoing? We did have some discussions at KVM Forum, you may want to check the video recording of my CPU hot-plug talk (end was cut off, I think). > I checked Andreas's git tree, there was no changes

<    1   2   3   4   5   6   7   8   9   10   >