[Qemu-devel] [PULL 47/47] qdev: Drop legacy_name from qdev properties

2014-10-14 Thread Andreas Färber
From: Gonglei The legacy_name is useless now, better help information is provided by description field of property. Cc: Markus Armbruster Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/core/qdev-properties-system.c

[Qemu-devel] [PULL 46/47] qmp: Print descriptions of object properties

2014-10-14 Thread Andreas Färber
t32 virtio-blk-pci.ioeventfd=bool (on/off) virtio-blk-pci.class=uint32 Cc: Markus Armbruster Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Reviewed-by: Eric Blake Signed-off-by: Andreas Färber --- qapi-schema.json | 4 +++- qdev-monitor.c | 7

[Qemu-devel] [PULL 38/47] usb: Convert usb-ccid to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/usb/dev-smartcard-reader.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index d37ed02..78ce681 100644 --- a/hw/usb

[Qemu-devel] [PULL 43/47] qdev: Add description field in PropertyInfo struct

2014-10-14 Thread Andreas Färber
From: Gonglei The descriptions can serve as documentation in the code, and they can be used to provide better help. Cc: Markus Armbruster Signed-off-by: Gonglei Signed-off-by: Paolo Bonzini Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw

[Qemu-devel] [PULL 35/47] usb-bot: Mark device as non hotpluggable

2014-10-14 Thread Andreas Färber
even before it gets to device initialization point. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/usb/dev-storage.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index bd7cc53..a207507 100644 --- a/hw/usb/dev-storage.c +++ b

[Qemu-devel] [PULL 45/47] qdev: Set the object property's description to the qdev property's.

2014-10-14 Thread Andreas Färber
From: Gonglei Set all static qdev properties' descriptions to object property's description. Cc: Markus Armbruster Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/core/qdev.c | 5 + 1 file changed, 5

[Qemu-devel] [PULL 31/47] scsi: Set SCSI BUS itself as default HotplugHandler

2014-10-14 Thread Andreas Färber
From: Igor Mammedov That would allow to handle SCSI device unplug on HBAs without dedicated hot(un)plug handlers and avoid making such HBAs explicitly hotpluggable. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/scsi/scsi-bus.c | 8 +++- 1

[Qemu-devel] [PULL 42/47] qdev: device_del: Search for to be unplugged device in 'peripheral' container

2014-10-14 Thread Andreas Färber
BUS-less device cases. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- qdev-monitor.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index c721451..754437b 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -

[Qemu-devel] [PULL 37/47] usb-storage: Drop not needed "allow_hotplug = 0"

2014-10-14 Thread Andreas Färber
t;no free target" in scsi_qdev_realize() method. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index bccaa3f..b005783 100644 --- a/hw/usb/d

[Qemu-devel] [PULL 29/47] s390x: Convert s390-virtio to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Beside of conversion, patch drops present unplug handling, effectively disabling hot-unplug of s390-virtio devices. Signed-off-by: Igor Mammedov Reviewed-by: Cornelia Huck Signed-off-by: Andreas Färber --- hw/s390x/s390-virtio-bus.c | 10 +- 1 file changed, 5

[Qemu-devel] [PULL 39/47] usb: Convert usb devices to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/usb/bus.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index da1eba9..986b2d8 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -24,10 +24,12

[Qemu-devel] [PULL 36/47] usb-bot: Drop not needed "allow_hotplug = 0"

2014-10-14 Thread Andreas Färber
() method. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index a207507..bccaa3f 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -65

[Qemu-devel] [PULL 30/47] s390x: Convert virtio-ccw to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/s390x/virtio-ccw.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio

[Qemu-devel] [PULL 33/47] scsi: Convert virtio-scsi HBA to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/scsi/virtio-scsi.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/hw/scsi/virtio-scsi.c b/hw

[Qemu-devel] [PULL 27/47] virtio-mmio: Drop useless bus->allow_hotplug = 0

2014-10-14 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/virtio/virtio-mmio.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 18c6e5b..2450c13 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@ -89,9 +89,6

[Qemu-devel] [PULL 32/47] scsi: Convert pvscsi HBA to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/scsi/vmw_pvscsi.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index 5734d19

[Qemu-devel] [PULL 23/47] qdev: Drop hotplug check from bus_add_child()

2014-10-14 Thread Andreas Färber
check and patch will allow to create complex composite devices during hotplug. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index b1da409..6439a23 1

[Qemu-devel] [PULL 24/47] target-i386: ICC bus: Drop BusState::allow_hotplug

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Since bus_add_child() no longer cares if BUS is hotpluggable or not, there is no need in setting allow_hotplug field. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/cpu/icc_bus.c | 8 1 file changed, 8 deletions

[Qemu-devel] [PULL 12/47] tests: usb: Move uhci port test code to libqos/usb.c

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Move code necessary for testing uhci port into library so it could be used by other USB tests. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- tests/Makefile| 3 ++- tests/libqos/usb.c| 37

[Qemu-devel] [PULL 26/47] virtio-serial: Convert to hotplug-handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/char/virtio-serial-bus.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b

[Qemu-devel] [PULL 44/47] qom: Add description field in ObjectProperty struct

2014-10-14 Thread Andreas Färber
-by: Andreas Färber --- include/qom/object.h | 14 ++ qom/object.c | 20 2 files changed, 34 insertions(+) diff --git a/include/qom/object.h b/include/qom/object.h index 8a05a81..89c3092 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -338,6

[Qemu-devel] [PULL 20/47] qdev: HotplugHandler: Provide unplug callback

2014-10-14 Thread Andreas Färber
ff-by: Andreas Färber --- hw/core/hotplug.c| 11 +++ hw/core/qdev.c | 13 +++-- include/hw/hotplug.h | 12 3 files changed, 34 insertions(+), 2 deletions(-) diff --git a/hw/core/hotplug.c b/hw/core/hotplug.c index 2ec4736..4e01074 100644 --- a/hw/core/hotp

[Qemu-devel] [PULL 22/47] qdev: Add wrapper to set BUS as HotplugHandler

2014-10-14 Thread Andreas Färber
From: Igor Mammedov To be used for conversion of SCSI and USB devices, and would allow to make every HBA/USB host switch to HotplugHandler API without touching each controller explicitly. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core

[Qemu-devel] [PULL 16/47] tests: usb: usb-uas hotplug test

2014-10-14 Thread Andreas Färber
lo Bonzini Signed-off-by: Andreas Färber --- tests/usb-hcd-xhci-test.c | 61 ++- 1 file changed, 60 insertions(+), 1 deletion(-) diff --git a/tests/usb-hcd-xhci-test.c b/tests/usb-hcd-xhci-test.c index d16963d..b1a7dec 100644 --- a/tests/usb-hcd-xhci-test.c +

[Qemu-devel] [PULL 28/47] s390x: Drop not used allow_hotplug in event-facility

2014-10-14 Thread Andreas Färber
dev_unplug() making this unreachable code, so drop it as well. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Cornelia Huck Signed-off-by: Andreas Färber --- hw/s390x/event-facility.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/s390x/event-facility.c b/hw/s

[Qemu-devel] [PULL 14/47] tests: usb: Generic usb device hotplug

2014-10-14 Thread Andreas Färber
From: Igor Mammedov use usb-tablet as a hotplugged usb device. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- tests/Makefile| 4 ++-- tests/libqos/usb.c| 34 ++ tests/libqos/usb.h| 3

[Qemu-devel] [PULL 17/47] Access BusState::allow_hotplug using wraper qbus_is_hotpluggable()

2014-10-14 Thread Andreas Färber
-off-by: Andreas Färber --- hw/core/qdev.c | 6 +++--- hw/i386/acpi-build.c | 2 +- hw/pci/pci-hotplug-old.c | 4 ++-- include/hw/qdev-core.h | 5 + qdev-monitor.c | 2 +- 5 files changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c

[Qemu-devel] [PULL 34/47] scsi: Cleanup not used anymore SCSIBusInfo{hotplug, hot_unplug} fields

2014-10-14 Thread Andreas Färber
From: Igor Mammedov SCSI subsytem was converted to hotplug handler API and doesn't use SCSIBusInfo{hotplug, hot_unplug} fields and related callbacks anymore. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/scsi/scsi-bus.c

[Qemu-devel] [PULL 13/47] tests: usb: add port test to uhci unit test

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- tests/Makefile| 2 +- tests/usb-hcd-uhci-test.c | 18 -- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/tests/Makefile b/tests/Makefile

[Qemu-devel] [PULL 19/47] qdev: HotplugHandler: Rename unplug callback to unplug_request

2014-10-14 Thread Andreas Färber
troduce 'unplug' callback that would perform actual device removal when guest is ready for it. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/acpi/piix4.c| 6 +++--- hw/core/hotplug.c | 10 +- hw/core

[Qemu-devel] [PULL 11/47] tests: virtio-blk: Check if hot-plug/unplug works

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- tests/virtio-blk-test.c | 49 ++--- 1 file changed, 38 insertions(+), 11 deletions(-) diff --git a/tests

[Qemu-devel] [PULL 25/47] virtio-pci: Drop BusState::allow_hotplug

2014-10-14 Thread Andreas Färber
drop not needed 'allow_hotplug' field. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/virtio/virtio-pci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci

[Qemu-devel] [PULL 21/47] qdev: Add simple/generic unplug callback for HotplugHandler

2014-10-14 Thread Andreas Färber
From: Igor Mammedov It will be used in shallow conversion from legacy hotplug mechanism and eventually replace all the uses of old mechanism DeviceClass::unplug = qdev_simple_unplug_cb() Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev.c

[Qemu-devel] [PULL 04/47] qom: Add error handler for object_property_print()

2014-10-14 Thread Andreas Färber
From: Gonglei Avoid the caller of object_property_print() leaking string argument's memory, such as qdev_print_props() when encounter errors. Reviewed-by: Paolo Bonzini Signed-off-by: Gonglei Signed-off-by: Andreas Färber --- qom/object.c | 12 ++-- 1 file changed, 10 inser

[Qemu-devel] [PULL 15/47] tests: usb: usb-storage hotplug test

2014-10-14 Thread Andreas Färber
igned-off-by: Andreas Färber --- tests/usb-hcd-uhci-test.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/tests/usb-hcd-uhci-test.c b/tests/usb-hcd-uhci-test.c index da96f98..8cf2c5b 100644 --- a/tests/usb-hcd-uhci-test.c +++ b/tests/usb-hcd-uhci-test.c @@

[Qemu-devel] [PULL 18/47] qdev: do not allow to instantiate non hotpluggable device with device_add

2014-10-14 Thread Andreas Färber
Bonzini Signed-off-by: Andreas Färber --- qdev-monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index f6db461..c721451 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -487,7 +487,8 @@ DeviceState *qdev_device_add(QemuOpts *opts

[Qemu-devel] [PULL 05/47] qom: Add error handler for object alias property

2014-10-14 Thread Andreas Färber
error handler for security. Cc: Stefan Hajnoczi Cc: Michael S. Tsirkin Cc: Markus Armbruster Reviewed-by: Paolo Bonzini Signed-off-by: Gonglei Signed-off-by: Andreas Färber --- qom/object.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c inde

[Qemu-devel] [PULL 06/47] tests: virtio-scsi: Check if hot-plug/unplug works

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- tests/virtio-scsi-test.c | 29 + 1 file changed, 29 insertions(+) diff --git a/tests/virtio-scsi-test.c b/tests/virtio

[Qemu-devel] [PULL 03/47] qdev: gpio: Register GPIO outputs as QOM links

2014-10-14 Thread Andreas Färber
: Alexander Graf Signed-off-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/core/qdev.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index a140c79..2b42d5b 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -362,12 +362,24 @@ void

[Qemu-devel] [PULL 08/47] libqos: Add qpci_plug_device_test() and qpci_unplug_acpi_device_test()

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Functions will be used for testing hot(un)plug of PCI devices. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- tests/libqos/pci-pc.c | 49 + tests

[Qemu-devel] [PULL 09/47] tests: virtio-rng: Check if hot-plug/unplug works

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- tests/Makefile | 2 +- tests/virtio-rng-test.c | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/tests

[Qemu-devel] [PULL 10/47] tests: virtio-net: Check if hot-plug/unplug works

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- tests/Makefile | 2 +- tests/virtio-net-test.c | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/tests

[Qemu-devel] [PULL 00/47] QOM devices patch queue 2014-10-15

2014-10-14 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. Regards, Andreas Cc: Peter Maydell The following changes since commit b1d28ec6a7dbdaadda39d29322f0de694aeb0b74: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20141010' into staging (2014-10-10 14:55:29 +0100) are av

[Qemu-devel] [PULL 02/47] qdev: gpio: Register GPIO inputs as child objects

2014-10-14 Thread Andreas Färber
From: Peter Crosthwaite To the device that contains them. This will allow for referencing a GPIO input from it's canonical path (exciting for dynamic machine generation!) Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/core/qdev.

[Qemu-devel] [PULL 01/47] qdev: gpio: Don't allow name share between I and O

2014-10-14 Thread Andreas Färber
; or "-out" suffixes when giving QOM names. But that reduces clarity and if there are cases out there where users want I and O with same name they can manually add their own suffixes. Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/core/q

[Qemu-devel] [PULL 07/47] tests: virtio-serial: Check if hot-plug/unplug works

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- tests/virtio-serial-test.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/tests/virtio-serial-test.c b/tests/virtio

Re: [Qemu-devel] [PATCH v2 00/36] complete conversion to hotplug-handler API

2014-10-13 Thread Andreas Färber
Hi, All 37 patches should be applied now, in their latest version, with Reviewed-bys and my Sob... https://github.com/afaerber/qemu-cpu/commits/qom-next This is a series size that I would ask to split in the future. Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Ge

Re: [Qemu-devel] [PATCH v5 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-10-13 Thread Andreas Färber
Am 13.10.2014 um 15:40 schrieb Andreas Färber: > Already queued, not yet pushed. On my way to KVM Forum... Fixed up the preceding series and pushed this one now: https://github.com/afaerber/qemu-cpu/commits/qom-next Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnb

Re: [Qemu-devel] [PATCH v5 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-10-13 Thread Andreas Färber
Am 13.10.2014 um 12:55 schrieb Gonglei: > On 2014/10/9 19:51, Gonglei wrote: > >> Andreas, ping? >> > > > Ping..., again. Already queued, not yet pushed. On my way to KVM Forum... Regards, Andreas > >> Best regards, >> -Gonglei >> >>> -Original Message- >>> From: qemu-devel-bounces+a

Re: [Qemu-devel] [PATCH 1/1] hmp: Remove "info pcmcia"

2014-10-09 Thread Andreas Färber
. Remove it. > > Sorry for the long delay on this one. But this patch is more about PCMCIA > support in QEMU than HMP, so I can provide my ACK, but I don't think this > is HMP material. > > Acked-by: Luiz Capitulino As the probably last one to have touched the ugly PCMCI

Re: [Qemu-devel] [PATCH v11 00/34] modify boot order of guest, and take effect after rebooting

2014-10-09 Thread Andreas Färber
Am 09.10.2014 um 12:09 schrieb Gonglei: > On 2014/10/9 17:47, Gerd Hoffmann wrote: > >> On Mi, 2014-10-08 at 19:00 +0800, Gonglei wrote: >>> On 2014/10/7 16:00, Gonglei (Arei) wrote: >>> From: Gonglei Changes since v10: 1. add handler for virtio-blk-pci/s390/ccw in PATCH 28.

qemu-devel@nongnu.org

2014-10-08 Thread Andreas Färber
Hi, Am 08.10.2014 um 16:19 schrieb Fabien Chouteau: > From: Jiri Gaisler > > AMBA plug&play is used by kernels to probe available devices (Timers, > UART, etc...). This is a static declaration of devices implemented in > QEMU. In the future, a more advanced version could compute those > informat

Re: [Qemu-devel] [PATCH v2 37/36] qdev: device_del: search for to be unplugged device in 'peripheral' container

2014-10-07 Thread Andreas Färber
Am 07.10.2014 um 14:10 schrieb Igor Mammedov: > On Tue, 7 Oct 2014 19:59:51 +0800 > Zhu Guihua wrote: > >> On Thu, 2014-10-02 at 10:08 +, Igor Mammedov wrote: >>> device_add puts every device with 'id' inside of 'peripheral' >>> container using id's value as the last component name. >>> Use i

Re: [Qemu-devel] IDs in QOM

2014-10-02 Thread Andreas Färber
Am 02.10.2014 um 16:21 schrieb Markus Armbruster: > Andreas Färber writes: > >> Am 02.10.2014 um 15:21 schrieb Stefan Hajnoczi: >>> On Wed, Oct 01, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: >>>> Markus Armbruster writes: >>> >>> This

Re: [Qemu-devel] IDs in QOM

2014-10-02 Thread Andreas Färber
Am 02.10.2014 um 15:21 schrieb Stefan Hajnoczi: > On Wed, Oct 01, 2014 at 02:33:47PM +0200, Markus Armbruster wrote: >> Markus Armbruster writes: > > This discussion seems orthogonal to your patch. But I'm not applying it > yet to give more time for discussion/review of the patch. > >> Is mangl

Re: [Qemu-devel] pending target-mips patches

2014-10-01 Thread Andreas Färber
Hi Leon, Am 01.10.2014 um 17:35 schrieb Leon Alrae: > I noticed that it's quite difficult to get target-mips changes > reviewed/accepted. There is already a queue of relatively big features > and bug fixes which are stuck for months. Does anyone have an idea how > to improve this situation? Wouldn

Re: [Qemu-devel] [PATCH v2 36/36] qdev: HotplugHandler: add support for unplugging BUS-less devices

2014-10-01 Thread Andreas Färber
Am 01.10.2014 um 14:43 schrieb Igor Mammedov: > On Wed, 1 Oct 2014 16:22:23 +0530 > Bharata B Rao wrote: > >> On Wed, Oct 01, 2014 at 11:57:37AM +0200, Igor Mammedov wrote: >>> On Wed, 1 Oct 2014 14:27:19 +0530 >>> Bharata B Rao wrote: >>> On Fri, Sep 26, 2014 at 09:28:41AM +, Igor Mamm

Re: [Qemu-devel] [PATCH qom v3 04/14] qmp: qstring: Handle NULL strings

2014-09-29 Thread Andreas Färber
Am 26.09.2014 um 15:27 schrieb Paolo Bonzini: > Il 26/09/2014 07:18, Peter Crosthwaite ha scritto: >> Create a valid qobject even if the input string is null. >> qstring->string will be NULL and length will be 0. >> >> This prepares support for clearing of QOM Link properties >> where NULL canonica

Re: [Qemu-devel] [PATCH v3 0/7] add description field in ObjectProperty and PropertyInfo struct

2014-09-29 Thread Andreas Färber
Hi, Am 27.09.2014 um 07:13 schrieb arei.gong...@huawei.com: > Gonglei (7): > qom: add error handler for object_property_print() > qom: add error handler for object alias property I've applied these two to qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next As I understand there w

Re: [Qemu-devel] [PATCH qom v3 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs

2014-09-26 Thread Andreas Färber
Am 26.09.2014 um 15:13 schrieb Paolo Bonzini: > Il 26/09/2014 07:16, Peter Crosthwaite ha scritto: >> Hi All, >> >> So phase one was the QOMification of qemu_irq. This is the next step. >> We start to setup GPIOs as proper QOM objects. Inputs are child objects >> of their device. Outputs are settab

Re: [Qemu-devel] [PULL 3/3] s390x/css: catch ccw sequence errors

2014-09-26 Thread Andreas Färber
Am 26.09.2014 um 12:49 schrieb Christian Borntraeger: > On 09/26/2014 12:36 PM, Andreas Färber wrote: > >>> @@ -1414,6 +1423,7 @@ int subch_device_load(SubchDev *s, QEMUFile *f) >>> s->id.ciw[i].count = qemu_get_be16(f); >>> } >>>

Re: [Qemu-devel] [PULL 2/3] s390x/css: support format-0 ccws

2014-09-26 Thread Andreas Färber
Am 23.09.2014 um 14:14 schrieb Christian Borntraeger: > From: Cornelia Huck > > Add support for format-0 ccws in channel programs. As a format-1 ccw > contains the same information as format-0 ccws, only supporting larger > addresses, simply convert every ccw to format-1 as we walk the chain. >

Re: [Qemu-devel] [PULL 3/3] s390x/css: catch ccw sequence errors

2014-09-26 Thread Andreas Färber
Christian, Conny, Am 23.09.2014 um 14:14 schrieb Christian Borntraeger: > From: Cornelia Huck > > We must not allow chains of more than 255 ccws without data transfer. > > Reviewed-by: David Hildenbrand > Signed-off-by: Cornelia Huck > Signed-off-by: Jens Freimann > Signed-off-by: Christian

Re: [Qemu-devel] [PATCH v1 2/3] qom: export object_property_is_child()

2014-09-26 Thread Andreas Färber
Am 18.09.2014 um 09:53 schrieb Zhu Guihua: > Export object_property_is_child() to let it be invoked in other places. > > Signed-off-by: Zhu Guihua > --- > include/qom/object.h | 1 + > qom/object.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/qom/ob

Re: [Qemu-devel] [PATCH v1 3/3] monitor: add del completion for peripheral device

2014-09-26 Thread Andreas Färber
Hi, Am 18.09.2014 um 09:53 schrieb Zhu Guihua: > Add peripheral_device_del_completion() to let peripheral device del completion > be possible. > > Signed-off-by: Zhu Guihua > --- > monitor.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/monitor.c b/monitor.

Re: [Qemu-devel] [PATCH 1/2] qom: add error handler for object_property_print()

2014-09-23 Thread Andreas Färber
Hi, Am 23.09.2014 um 05:25 schrieb arei.gong...@huawei.com: > From: Gonglei > > Avoid the caller of object_property_print() leaking string > argument's memory, such as qdev_print_props() when > encounter errors. > > Cc: Paolo Bonzini > Signed-off-by: Gonglei > --- > qom/object.c | 12 +++

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Andreas Färber
Am 22.09.2014 um 17:57 schrieb Paolo Bonzini: > Il 22/09/2014 15:15, Laszlo Ersek ha scritto: >> $ git grep -E '\' | wc -l >> 115 >> >> Even if we just count the clusters, they're way too many: >> >> $ git grep -E '\' | wc -l >> 66 > > There are just a couple of multi-machine clusters (well, three

Re: [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Andreas Färber
Am 22.09.2014 um 15:05 schrieb Alex Bligh: >>> Sadly that is not true. For instance on Ubuntu Precise >>> it's invoked as qemu-system-x86_64 by at least one >>> management application known to me. >> >> Well change it to call qemu-kvm then :) >> Also what happens if you install qemu as well? >> Doe

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Andreas Färber
Am 22.09.2014 um 13:26 schrieb Laszlo Ersek: > Based on the registration order captured in the previous patch, we sort > the ad-hoc list printed for > > qemu-system- -M \? Agree that the order is worth sanitizing. I would however argue that registration order is not entirely stable either i

Re: [Qemu-devel] [INVITE] OVMF BoF session at the KVM Forum 2014

2014-09-18 Thread Andreas Färber
Hello Laszlo, Am 18.09.2014 um 10:23 schrieb Laszlo Ersek: > I've been made an offer that I couldn't refuse :) to "organize" a Birds > of a Feather session concerning OVMF at the KVM Forum 2014. > > Interested people, please sign up: > > http://www.linux-kvm.org/page/KVM_Forum_2014_BOF#OVMF N

Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios

2014-09-17 Thread Andreas Färber
Am 17.09.2014 um 18:47 schrieb Peter Maydell: > On 17 September 2014 09:40, Andreas Färber wrote: >> We avoided that by not using DeviceClass::reset but CPUClass::reset. >> It's a question of assuring appropriate reset ordering between CPU and >> devices. PowerPC needed

Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios

2014-09-17 Thread Andreas Färber
Am 17.09.2014 um 18:17 schrieb Peter Maydell: > On 17 September 2014 08:55, Andreas Färber wrote: >> IIRC each machine is responsible for registering a reset hook that calls >> - in most cases - cpu_reset(). >> >> The thing to look out for here is, does any machine

Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios

2014-09-17 Thread Andreas Färber
Am 17.09.2014 um 17:50 schrieb Ard Biesheuvel: > On 9 September 2014 11:14, Peter Maydell wrote: >> On 5 September 2014 16:15, Ard Biesheuvel wrote: >>> When booting with -bios or -pflash rather than -kernel, we need to make sure >>> reset handlers are registered. >>> >>> Signed-off-by: Ard Biesh

Re: [Qemu-devel] [PATCH v4] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Andreas Färber
Hi, As a general comment, when sending a cover letter for a single patch, please use --numbered, so that the cover letter becomes [PATCH 0/1] and the patch [PATCH 1/1] so they don't end up with identical subjects. Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germa

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-17 Thread Andreas Färber
Am 13.09.2014 um 18:45 schrieb Richard Henderson: > In preparation for removing a bunch of ifdefs from cpu_exec. > > Cc: Andreas Färber > Signed-off-by: Richard Henderson > --- > cpu-exec.c| 9 ++--- > include/qom/cpu.h | 5 + > qom/cpu.c | 6 +

[Qemu-devel] [PATCH v3 4/4] ivshmem: Fix fd leak on error

2014-09-15 Thread Andreas Färber
Reported-by: Stefan Hajnoczi Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- hw/misc/ivshmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index ecef82a..bf585b7 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -512,6 +512,7

[Qemu-devel] [PATCH v3 2/4] ivshmem: validate incoming_posn value from server

2014-09-15 Thread Andreas Färber
-sta...@nongnu.org Signed-off-by: Andreas Färber --- hw/misc/ivshmem.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index caeee1e..24f74f6 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -389,6 +389,9 @@ static void close_guest_eventfds

[Qemu-devel] [PATCH v3 1/4] ivshmem: Check ivshmem_read() size argument

2014-09-15 Thread Andreas Färber
Hajnoczi [AF: Handle partial reads via FIFO] Reported-by: Peter Maydell Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- hw/misc/ivshmem.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index

[Qemu-devel] [PATCH v3 0/4] ivshmem security fixes

2014-09-15 Thread Andreas Färber
chael S. Tsirkin Cc: Sebastian Krahmer Cc: Peter Maydell Cc: Gerd Hoffmann Cc: David Marchand Andreas Färber (1): ivshmem: Fix fd leak on error Sebastian Krahmer (1): ivshmem: Fix potential OOB r/w access Stefan Hajnoczi (2): ivshmem: Check ivshmem_read() size argument ivshmem: va

[Qemu-devel] [PATCH v3 3/4] ivshmem: Fix potential OOB r/w access

2014-09-15 Thread Andreas Färber
From: Sebastian Krahmer Fix OOB access via malformed incoming_posn parameters and check that requested memory is actually alloc'ed. Signed-off-by: Sebastian Krahmer [AF: Rebased, cleanups, avoid fd leak] Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- hw/misc/ivshmem.c

Re: [Qemu-devel] [PATCH] cpu-exec: Don't mask out external interrupts when single-stepping an invalid instruction.

2014-09-15 Thread Andreas Färber
Am 15.09.2014 um 18:10 schrieb Peter Maydell: > On 15 September 2014 09:02, Martin Galvan > wrote: >> I did a bit more research on how Cortex-M handles nested interrupts. >> In particular, I noticed if we were to have an invalid instruction >> inside the exception handler itself, trying to single-

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-11 Thread Andreas Färber
Am 11.09.2014 um 07:58 schrieb Gonglei (Arei): >>> ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 -drive \ >>> file=/home/win7_32_2U,if=none,id=drive-ide0-0-0 -device ide-hd,bus=ide.0,\ >>> unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex=1 -drive \ >>> file=/home/rhel-server-7.0-

Re: [Qemu-devel] [PATCH] Fix typos and misspellings in comments

2014-09-09 Thread Andreas Färber
Am 09.09.2014 10:09, schrieb Peter Maydell: > On 9 September 2014 04:23, zhanghailiang > wrote: >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> index 2ab4460..bedef2f 100644 >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -541,7 +541,7 @@ static void *spapr_create_fdt_skel(hwaddr initrd_

Re: [Qemu-devel] qemu-system-s390x and Linux

2014-09-05 Thread Andreas Färber
Hi, Am 05.09.2014 15:55, schrieb Robert Święcki: > 1). Python doesn't work - it works under hercules though (the same / > almost identical image), depending on version it throws marshalling > assertions. > > 2). Kernel throws an error upon testing cryptographic routines (they > produce different

Re: [Qemu-devel] [PULL 0/3] QOM CPUState patch queue 2014-09-04

2014-09-05 Thread Andreas Färber
Am 04.09.2014 20:40, schrieb Peter Maydell: > On 4 September 2014 18:20, Andreas Färber wrote: >> Hello Peter, >> >> This is my QOM CPU patch queue. Please pull. >> >> Regards, >> Andreas >> >> Cc: Peter Maydell >> >>

[Qemu-devel] [PULL v3 2/3] target-i386: Support migratable=no properly

2014-09-05 Thread Andreas Färber
Signed-off-by: Eduardo Habkost Reviewed-by: Michael Roth Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- target-i386/cpu-qom.h | 1 + target-i386/cpu.c | 23 +++ 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/target-i386/cpu-qom.h b/target

[Qemu-devel] [PULL v3 3/3] target-i386: Reject invalid CPU feature names on the command-line

2014-09-05 Thread Andreas Färber
From: Eduardo Habkost Instead of simply printing a warning, report an error when invalid CPU options are provided on the CPU model string. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Andreas Färber --- target-i386/cpu.c | 9 + 1 file changed, 5

[Qemu-devel] [PULL v3 0/3] QOM CPUState patch queue 2014-09-05

2014-09-05 Thread Andreas Färber
Hello Peter, This is my (corrected) QOM CPU patch queue. Please pull. Regards, Andreas Cc: Peter Maydell Cc: Eduardo Habkost The following changes since commit fd884c07658d02a96a882b8457d6d7a5cd71a407: Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter' into stagin

[Qemu-devel] [PULL v3 1/3] exec: Save CPUState::exception_index field

2014-09-05 Thread Andreas Färber
-by: Andreas Färber --- exec.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/exec.c b/exec.c index 5122a33..7dddcc8 100644 --- a/exec.c +++ b/exec.c @@ -430,15 +430,50 @@ static int cpu_common_post_load(void *opaque, int version_id) return 0

Re: [Qemu-devel] [PULL v2 1/3] exec: Save CPUState::exception_index field

2014-09-05 Thread Andreas Färber
Am 05.09.2014 00:50, schrieb Peter Maydell: > On 4 September 2014 18:20, Andreas Färber wrote: >> From: Pavel Dovgaluk >> >> This patch adds a subsection with exception_index field to the VMState for >> correct saving the CPU state. >> Without this patch,

[Qemu-devel] [PULL 4/7] memory: Remove object_property_add_child_array()

2014-09-04 Thread Andreas Färber
From: Peter Crosthwaite Obsoleted by automatic object_property_add() arrayification. Reviewed-by: Paolo Bonzini Signed-off-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- memory.c | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a

[Qemu-devel] [PULL 3/7] qom: Add automatic arrayification to object_property_add()

2014-09-04 Thread Andreas Färber
". Second "foo[1]" and so on. Callers may inspect the ObjectProperty * return value to see what number the added property was given. Signed-off-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- qom/object.c | 21 + 1 file changed, 21 insertions(+) diff -

[Qemu-devel] [PULL 6/7] qdev: Use NULL instead of local_err for qbus_child unrealize

2014-09-04 Thread Andreas Färber
unregister vmsd and unrealize actual object, too. Signed-off-by: Gonglei Reviewed-by: Peter Crosthwaite Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- hw/core/qdev.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index

[Qemu-devel] [PULL 2/7] machine: Clean up -machine handling

2014-09-04 Thread Andreas Färber
Since commit c4090f8, -object options are no longer handled through object_set_property(), so clean up -object leftovers by renaming the function and dropping special-casing of qom-type and id properties. Cc: Paolo Bonzini Reviewed-by: Marcel Apfelbaum Signed-off-by: Andreas Färber --- vl.c

[Qemu-devel] [PULL 5/7] qdev: Use error_abort instead of using local_err

2014-09-04 Thread Andreas Färber
Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/core/qdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index da1ba48..4a1ac5b 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -820,13 +820,13 @@ static void

[Qemu-devel] [PULL for-2.1 0/7] QOM devices patch queue 2014-09-04

2014-09-04 Thread Andreas Färber
qom: Make object_child_foreach() safe for objects removal Andreas Färber (1): machine: Clean up -machine handling Gonglei (3): qdev: Use error_abort instead of using local_err qdev: Use NULL instead of local_err for qbus_child unrealize qdev: Add cleanup logic in device_set_realized(

[Qemu-devel] [PULL 7/7] qdev: Add cleanup logic in device_set_realized() to avoid resource leak

2014-09-04 Thread Andreas Färber
ze |->pci_qdev_init() |->do_pci_register_device() |->etc. Add fuller cleanup logic which assures that function can goto appropriate error label as local_err population is detected at each relevant point. Signed-off-by: Gonglei Reviewed-by: Peter Crosthwaite Cc: qemu-sta...@

[Qemu-devel] [PULL 1/7] qom: Make object_child_foreach() safe for objects removal

2014-09-04 Thread Andreas Färber
-off-by: Andreas Färber --- qom/object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index 79bd0cc..a298b32 100644 --- a/qom/object.c +++ b/qom/object.c @@ -668,10 +668,10 @@ void object_class_foreach(void (*fn)(ObjectClass *klass, void

[Qemu-devel] [PULL v2 3/3] target-i386: Reject invalid CPU feature names on the command-line

2014-09-04 Thread Andreas Färber
From: Eduardo Habkost Instead of simply printing a warning, report an error when invalid CPU options are provided on the CPU model string. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Andreas Färber --- target-i386/cpu.c | 15 --- 1 file changed, 8

[Qemu-devel] [PULL v2 1/3] exec: Save CPUState::exception_index field

2014-09-04 Thread Andreas Färber
From: Pavel Dovgaluk This patch adds a subsection with exception_index field to the VMState for correct saving the CPU state. Without this patch, simulator could miss the pending exception in the saved virtual machine state. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Andreas Färber

<    5   6   7   8   9   10   11   12   13   14   >