[Qemu-devel] [PATCH v3 3/3] s390x/kvm: provide stfle.81

2018-01-18 Thread Christian Borntraeger
stfle.81 (ppa15) is a transparent facility that can be passed to the guest without the need to implement hypervisor support. As this feature can be provided by firmware we add it to all full models. Signed-off-by: Christian Borntraeger --- target/s390x/cpu_features.c | 1 + target/s390x

[Qemu-devel] [PATCH v3 1/3] header sync

2018-01-18 Thread Christian Borntraeger
replace with proper header sync Signed-off-by: Christian Borntraeger --- linux-headers/asm-s390/kvm.h | 9 - linux-headers/linux/kvm.h| 5 +++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 32d372e

Re: [Qemu-devel] [PATCH v2 3/3] s390x/kvm: provide stfle.81

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 10:13 PM, David Hildenbrand wrote: > On 17.01.2018 20:37, Christian Borntraeger wrote: >> stfle.81 (ppa15) is a transparent facility that can be passed to the >> guest without the need to implement hypervisor support. As this feature >> can be provided by firm

Re: [Qemu-devel] [PATCH v2 1/3] header sync

2018-01-17 Thread Christian Borntraeger
It is just a header sync and mimics the kernel. The previous header sync added the the commit that added the SPDX tag and this header sync added the commit that removed the now redundant licence text. On 01/17/2018 08:46 PM, Eric Blake wrote: > On 01/17/2018 01:37 PM, Christian Borntraeger wr

[Qemu-devel] [PATCH v2 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
We need to handle the bpb control on reset and migration. Normally stfle.82 is transparent (and the normal guest part works without hypervisor activity). To prevent any issues we require full host kernel support for this feature. Signed-off-by: Christian Borntraeger --- target/s390x/cpu.c

[Qemu-devel] [PATCH v2 1/3] header sync

2018-01-17 Thread Christian Borntraeger
replace with proper header sync Signed-off-by: Christian Borntraeger --- linux-headers/asm-s390/kvm.h | 9 - linux-headers/linux/kvm.h| 5 +++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 32d372e

[Qemu-devel] [PATCH v2 0/3] s390x/kvm: implement new hardware/firmware features

2018-01-17 Thread Christian Borntraeger
;v2: - style and comment fixes - drop transparent facility patch - add patch to introduce facility 81 Christian Borntraeger (3): header sync s390x/kvm: Handle bpb feature s390x/kvm: provide stfle.81 linux-headers/asm-s390/kvm.h| 9 - linux-headers/linux/kvm.h |

[Qemu-devel] [PATCH v2 3/3] s390x/kvm: provide stfle.81

2018-01-17 Thread Christian Borntraeger
stfle.81 (ppa15) is a transparent facility that can be passed to the guest without the need to implement hypervisor support. As this feature can be provided by firmware we add it to all full models. Signed-off-by: Christian Borntraeger --- target/s390x/cpu_features.c | 1 + target/s390x

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 04:10 PM, David Hildenbrand wrote: > >>> And exactly for this reason I tend to nack patch nr 3 (if that is of any >>> weight :) ). >> >> I have communicated the mistake to asll relevant parties - it will not >> happen again >> (famous last words). > > An I already saw it happen i

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 03:50 PM, David Hildenbrand wrote: > On 17.01.2018 15:37, Cornelia Huck wrote: >> On Wed, 17 Jan 2018 15:18:48 +0100 >> Christian Borntraeger wrote: >> >>> We need to handle the bpb control on reset and migration. Normally >>> stfle.82 is

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 03:37 PM, Cornelia Huck wrote: > On Wed, 17 Jan 2018 15:18:48 +0100 > Christian Borntraeger wrote: > >> We need to handle the bpb control on reset and migration. Normally >> stfle.82 is transparent (and the normal guest part works without >> hyperviso

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 03:30 PM, David Hildenbrand wrote: > On 17.01.2018 15:18, Christian Borntraeger wrote: >> We need to handle the bpb control on reset and migration. Normally >> stfle.82 is transparent (and the normal guest part works without >> hypervisor activity). To prevent

[Qemu-devel] [PATCH/RFC 0/3] s390x/kvm: implement new hardware/firmware features

2018-01-17 Thread Christian Borntraeger
We want to provide more hw features to guests, namely the new bpb control as well as other transparent facilities that might be introduced by firmware updates (e.g. the stfle facility 81). See the kernel discussion for the KVM side https://www.spinics.net/lists/kernel/msg2700551.html Christian

[Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
We need to handle the bpb control on reset and migration. Normally stfle.82 is transparent (and the normal guest part works without hypervisor activity). To prevent any issues we require full host kernel support for this feature. Signed-off-by: Christian Borntraeger --- target/s390x/cpu.c

[Qemu-devel] [PATCH 1/3] header sync

2018-01-17 Thread Christian Borntraeger
replace with proper header sync Signed-off-by: Christian Borntraeger --- linux-headers/asm-s390/kvm.h | 9 - linux-headers/linux/kvm.h| 5 +++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 32d372e

[Qemu-devel] [PATCH 3/3] s390x/cpumodel: fix transparency for non-hyp STFL features

2018-01-17 Thread Christian Borntraeger
ault model (for non-compat machine types). Signed-off-by: Halil Pasic Reviewed-by: Christian Borntraeger Signed-off-by: Christian Borntraeger --- target/s390x/cpu_features.c | 54 + target/s390x/cpu_features_def.h | 54 + target/s390x/gen-featu

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/8] s390-ccw: update libc

2018-01-16 Thread Christian Borntraeger
enamed from _strlen) >>> >>> Added C standard functions: >>>    isdigit >>>    atoi >>> >>> Added non-C standard function: >>>    itostr >>> >>> Signed-off-by: Collin L. Walling >>> Acked-by: Christian Borntrae

Re: [Qemu-devel] [PATCH v1 1/1] s390x: fix storage attributes migration for non-small guests

2018-01-15 Thread Christian Borntraeger
CCing qemu-s390x. On 01/15/2018 05:52 PM, Claudio Imbrenda wrote: > Fix storage attribute migration so that it does not fail for guests > with more than a few GB of RAM. Migration itself was successful, but > storage attributes were not migrated completely. > > This patch fixes the migration of a

[Qemu-devel] [PATCH] s390x/sclp: fixup highest CPU address

2017-12-19 Thread Christian Borntraeger
the highest cpu address is not the same as max_cpus. max_cpus counts from 1 while the cpu address starts at 0. Signed-off-by: Christian Borntraeger Reviewed-by: Jason J. Herne --- hw/s390x/sclp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/sclp.c b/hw/s390x

Re: [Qemu-devel] [PATCH 1/2] pc, q35: add 2.12 machine types

2017-12-18 Thread Christian Borntraeger
On 12/15/2017 04:02 PM, Denis V. Lunev wrote: > include/hw/compat.h | 2 ++ > include/hw/i386/pc.h | 3 +++ > hw/i386/pc_piix.c| 13 - > hw/i386/pc_q35.c | 12 +++- > 4 files changed, 28 insertions(+), 2 deletions(-) > > diff --git a/include/hw/compat.h b/include/h

Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread Christian Borntraeger
On 12/15/2017 10:53 AM, David Hildenbrand wrote: > >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c >> index 80e753a5ef..9abb8de9f9 100644 >> --- a/hw/s390x/s390-virtio-ccw.c >> +++ b/hw/s390x/s390-virtio-ccw.c >> @@ -172,9 +172,10 @@ static void s390_memory_init(ram_addr_

Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

2017-12-15 Thread Christian Borntraeger
On 12/14/2017 08:05 PM, Peter Maydell wrote: > On 14 December 2017 at 17:09, Cornelia Huck wrote: >> The following changes since commit 0ef0583d5adceb9138bdb47494dabd1549ac5b6d: >> >> Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20171214' >> into staging (2017-12-14 15:32:32 +

Re: [Qemu-devel] [qemu-s390x] [PATCH v1] s390x/cpumodel: make qemu cpu model play with "none" machine

2017-12-13 Thread Christian Borntraeger
On 12/13/2017 02:24 PM, David Hildenbrand wrote: > Make sure "-cpu qemu" works with "-M none". > > Signed-off-by: David Hildenbrand > --- > > Conny, if this is okay, can you squash with the original patch? > > hw/s390x/s390-virtio-ccw.c | 4 > target/s390x/cpu_models.c | 7 +-- >

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-13 Thread Christian Borntraeger
On 12/13/2017 10:31 AM, David Hildenbrand wrote: > On 13.12.2017 10:16, Christian Borntraeger wrote: >> >> >> On 12/12/2017 04:28 PM, Cornelia Huck wrote: >>> On Tue, 12 Dec 2017 16:17:17 +0100 >>> David Hildenbrand wrote: >>> >>>> On

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-13 Thread Christian Borntraeger
On 12/12/2017 04:28 PM, Cornelia Huck wrote: > On Tue, 12 Dec 2017 16:17:17 +0100 > David Hildenbrand wrote: > >> On 12.12.2017 15:29, Cornelia Huck wrote: >>> On Tue, 12 Dec 2017 15:13:46 +0100 >>> Christian Borntraeger wrote: >>> >&g

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-12 Thread Christian Borntraeger
On 12/12/2017 02:49 PM, Cornelia Huck wrote: > On Mon, 11 Dec 2017 14:47:31 +0100 > David Hildenbrand wrote: > >> Let the flic device handle it internally. This will allow us to later >> on store floating interrupts in the flic for the TCG case. >> >> This now also simplifies kvm.c. All that's

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB

2017-12-11 Thread Christian Borntraeger
On 12/11/2017 02:55 PM, David Hildenbrand wrote: > On 11.12.2017 13:21, Christian Borntraeger wrote: >> KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically >> limiting the memory per slot to 8TB-4k. As memory slots on s390/kvm must >> be a multiple of

Re: [Qemu-devel] [PATCH v1 for-2-12 04/15] s390x/flic: simplify flic initialization

2017-12-11 Thread Christian Borntraeger
On 12/11/2017 02:47 PM, David Hildenbrand wrote: > This makes it clearer, which device is used for which accelerator. > > Signed-off-by: David Hildenbrand nice. Reviewed-by: Christian Borntraeger > --- > hw/intc/s390_flic.c | 9 +++-- > hw/intc/s390_fl

[Qemu-devel] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB

2017-12-11 Thread Christian Borntraeger
t a 24TB guest on a 1TB system. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 8425534..073f6ed 100644 --- a/hw/s390x/s

Re: [Qemu-devel] [PATCH v2 for-2.12 4/5] s390x/tcg: indicate value of TODPR in STCKE

2017-12-08 Thread Christian Borntraeger
On 12/08/2017 01:45 PM, David Hildenbrand wrote: > On 08.12.2017 01:02, Richard Henderson wrote: >> On 12/07/2017 07:31 AM, David Hildenbrand wrote: >>> +/* 16 bit value store in an uint32_t (only valid bits set) */ >>> +tcg_gen_ld32u_i64(todpr, cpu_env, offsetof(CPUS390XState, todpr)); >

Re: [Qemu-devel] Interactive Boot Menu: New Fields in IPLB

2017-12-08 Thread Christian Borntraeger
On 12/08/2017 12:56 AM, Collin L. Walling wrote: > Hello, > > I'd like to bring up a formal discussion regarding the utilization of > reserved space > in the IPL Parameter Blocks for s390x guests. Particularly the following: > >  * How should we approach "claiming" bytes so that we do not obst

[Qemu-devel] [PATCH/RFC v2] s390x: start a new memory region if the old one exceeds KVM_MEM_MAX_NR_PAGES

2017-12-07 Thread Christian Borntraeger
-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 8425534..3630f6a 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-vir

Re: [Qemu-devel] [PATCH/RFC] s390x: split memory into 4TB chunks

2017-12-06 Thread Christian Borntraeger
On 12/06/2017 02:35 PM, Paolo Bonzini wrote: > On 06/12/2017 13:15, Christian Borntraeger wrote: >>> a) bumping up KVM_MEM_MAX_NR_PAGES makes sense. >> The original limitation comes from the fact that this define is used to limit >> the number of bits in the dirty bitmap

Re: [Qemu-devel] [PATCH/RFC] s390x: split memory into 4TB chunks

2017-12-06 Thread Christian Borntraeger
On 12/06/2017 01:19 PM, David Hildenbrand wrote: > > This will most certainly break migration, no? Probably yes. Thats why the patch has RFC. I was looking for ideas. >>> >>> As other architectures might also run into this problem, wonder if >>> >>> a) bumping up KVM_MEM_MAX_NR_PAG

Re: [Qemu-devel] [PATCH/RFC] s390x: split memory into 4TB chunks

2017-12-06 Thread Christian Borntraeger
On 12/06/2017 01:12 PM, David Hildenbrand wrote: > On 06.12.2017 13:06, Christian Borntraeger wrote: >> >> >> On 12/06/2017 01:04 PM, David Hildenbrand wrote: >>> On 06.12.2017 13:00, Christian Borntraeger wrote: >>>> KVM does not allow memory

Re: [Qemu-devel] [PATCH/RFC] s390x: split memory into 4TB chunks

2017-12-06 Thread Christian Borntraeger
On 12/06/2017 01:04 PM, David Hildenbrand wrote: > On 06.12.2017 13:00, Christian Borntraeger wrote: >> KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically >> limiting the memory per slot to 7.999TB. Lets split the base memory >> into 4TB chunks to allow g

[Qemu-devel] [PATCH/RFC] s390x: split memory into 4TB chunks

2017-12-06 Thread Christian Borntraeger
tem. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 8425534..6735bbb 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s

Re: [Qemu-devel] [PATCH 1/3] s390x/css: unrestrict cssids

2017-12-04 Thread Christian Borntraeger
On 12/04/2017 12:10 PM, Cornelia Huck wrote: [..] > >> >> Signed-off-by: Halil Pasic squashed or non-squashed: Acked-by: Christian Borntraeger

Re: [Qemu-devel] [qemu-s390x] [PATCH RFC 2/2] s390x: attach autogenerated nics

2017-12-04 Thread Christian Borntraeger
On 11/28/2017 02:46 PM, Cornelia Huck wrote: > The autogenerated nics should be treated as any other device; use > qdev_set_id() to have them show up under peripheral-anon. > I think this is fine, but then I ask myself how x86 does this. So I tried to find out how the pc-q35 machine does this b

Re: [Qemu-devel] [PATCH 2/3] s390x/css: advertise unrestricted cssids

2017-12-04 Thread Christian Borntraeger
having the property on the virtual-css-bridge is good form > Libvirt PoV. @Shalini: could you verify that things work out fine > (provided we get at least a preliminary blessing from Connie). > > Consider squashing into "s390x/css: unrestrict cssids". FWIW, a property on th

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-30 Thread Christian Borntraeger
On 11/30/2017 10:50 AM, Cornelia Huck wrote: > On Wed, 29 Nov 2017 19:51:23 +0100 > Christian Borntraeger wrote: > >> On 11/28/2017 03:45 PM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 15:17:49 +0100 >>> Christian Borntraeger wrote: >>> >&g

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-29 Thread Christian Borntraeger
On 11/28/2017 03:45 PM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 15:17:49 +0100 > Christian Borntraeger wrote: > >> On 11/28/2017 03:01 PM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 14:25:08 +0100 >>> Christian Borntraeger wrote: > >>>> W

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Christian Borntraeger
On 11/28/2017 03:01 PM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 14:25:08 +0100 > Christian Borntraeger wrote: > >> On 11/28/2017 02:17 PM, Halil Pasic wrote: > >>> In the meanwhile I strongly prefer option 1 (at the ccw devices). I've just >>> sent a

Re: [Qemu-devel] [PATCH RFC 1/2] s390x/css: attach css bridge

2017-11-28 Thread Christian Borntraeger
Looks good to me and is similar to the other devices (e.g. the IPL device) Reviewed-by: Christian Borntraeger On 11/28/2017 02:46 PM, Cornelia Huck wrote: > Logically, the css bridge should be attached to the machine. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/c

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Christian Borntraeger
On 11/28/2017 02:17 PM, Halil Pasic wrote: > > > On 11/28/2017 01:24 PM, Christian Borntraeger wrote: >> >> >> On 11/28/2017 01:14 PM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 12:49:04 +0100 >>> Boris Fiuczynski wrote: >>> >>>

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-28 Thread Christian Borntraeger
On 11/28/2017 01:14 PM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 12:49:04 +0100 > Boris Fiuczynski wrote: > >> On 11/28/2017 11:22 AM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 09:53:15 +0100 >>> Boris Fiuczynski wrote: >>> On 11/27/2017 05:56 PM, Cornelia Huck wrote: > Prop

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Christian Borntraeger
On 11/27/2017 02:19 PM, Cornelia Huck wrote: > On Mon, 27 Nov 2017 14:11:57 +0100 > Halil Pasic wrote: > >> On 11/27/2017 01:56 PM, Cornelia Huck wrote: >>> On Fri, 24 Nov 2017 17:39:04 +0100 >>> Halil Pasic wrote: >>> On 11/24/2017 05:15 PM, Cornelia Huck wrote: > > (Unless we

Re: [Qemu-devel] [PATCH for-2.12] s390x: introduce 2.12 compat machine

2017-11-24 Thread Christian Borntraeger
On 11/24/2017 04:33 PM, Cornelia Huck wrote: > Signed-off-by: Cornelia Huck Just to be ahead of ARM again? ;-) Acked-by: Christian Borntraeger + > --- > hw/s390x/s390-virtio-ccw.c | 17 - > include/hw/compat.h| 3 +++ > 2 files changed, 19 insertions

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-24 Thread Christian Borntraeger
On 11/24/2017 02:27 PM, Cornelia Huck wrote: > On Fri, 24 Nov 2017 14:01:20 +0100 > Christian Borntraeger wrote: > >> I first liked the idea to have it as a property of the css, but >> this is all pretty unclear how to do right. I start to think that going with >

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-24 Thread Christian Borntraeger
On 11/24/2017 01:46 PM, Cornelia Huck wrote: > On Thu, 23 Nov 2017 14:33:56 +0100 > Halil Pasic wrote: > >> Having an adequate representation for the css in QOM would be certainly >> interesting, but at the same time (IMHO) is somewhat challenging. Let me >> make some observations, which should

Re: [Qemu-devel] [RFC v3 0/4] vITS Reset

2017-11-23 Thread Christian Borntraeger
On 11/23/2017 06:44 PM, Auger Eric wrote: > Hi Cornelia, Peter, > > On 23/11/17 18:14, Cornelia Huck wrote: >> On Thu, 23 Nov 2017 17:01:32 + >> Peter Maydell wrote: >> >>> On 23 November 2017 at 16:05, Auger Eric wrote: When using update-linux-headers.sh I get suspicious errors at th

Re: [Qemu-devel] [qemu-web PATCH] css: avoid over-large images

2017-11-22 Thread Christian Borntraeger
On 11/22/2017 05:37 PM, Paolo Bonzini wrote: > Make sure that images are scaled to fit inside their container. Thanks God. I was thinking "what is wrong with the channel subsystem in QEMU?" when reading your subject. > Tested-by: Thomas Huth > Reviewed-by: Thomas Huth > Signed-off-by: Pao

Re: [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11)

2017-11-22 Thread Christian Borntraeger
Would have been good to have the qemu iotest before we merged 4afeffc8572f40d8844b946a30c00b10da4442b1 blockjob: do not allow coroutine double entry or entry-after-completion and friends. On 11/22/2017 [...] > -Image committed. > +qemu-img: /tmp/qemu-test/src/block/block-backend.c:2088: > blk_

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Christian Borntraeger
On 11/22/2017 03:43 PM, Cornelia Huck wrote: > On Wed, 22 Nov 2017 15:26:26 +0100 > Christian Borntraeger wrote: > >> valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an >> undefined value for flags. Right now this is unused, but we >> better play sa

[Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11)

2017-11-22 Thread Christian Borntraeger
Christian Borntraeger (2): s390x/migration: use zero flag parameter pc-bios/s390-ccw: zero out bss section pc-bios/s390-ccw/start.S | 30 +++--- target/s390x/kvm.c | 16 2 files changed, 35 insertions(+), 11 deletions(-) -- 2.9.4

[Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-22 Thread Christian Borntraeger
corresponding kernel documentation patch will be submitted later. Signed-off-by: Christian Borntraeger --- target/s390x/kvm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index 343fcec..76065ec 100644 --- a/target/s390x

[Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section

2017-11-22 Thread Christian Borntraeger
invalid virtio-scsi LUN when rebooting) Lets fix this once and forever by letting the BIOS zero the bss itself. Suggested-by: Alexander Graf Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/start.S | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

2017-11-22 Thread Christian Borntraeger
On 11/22/2017 04:23 AM, Michael Roth wrote: > Quoting Christian Borntraeger (2017-11-21 15:38:32) >> forgot to cc qemu-devel >> >> On 11/21/2017 10:37 PM, Christian Borntraeger wrote: >>> a quick heads up . Rc2 now triggers >>> +qemu-img: block/blo

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

2017-11-21 Thread Christian Borntraeger
forgot to cc qemu-devel On 11/21/2017 10:37 PM, Christian Borntraeger wrote: > a quick heads up . Rc2 now triggers > +qemu-img: block/block-backend.c:2088: blk_root_drained_end: Assertion > `blk->quiesce_counter' failed. > for several qemu iotests. > > I have n

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-21 Thread Christian Borntraeger
On 11/21/2017 05:06 PM, Cornelia Huck wrote: > On Tue, 21 Nov 2017 15:45:17 +0100 > Christian Borntraeger wrote: > >> On 11/21/2017 02:44 PM, Cornelia Huck wrote: >>> On Tue, 21 Nov 2017 12:18:25 +0100 >>> Halil Pasic wrote: >>> >>> Subject:

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-21 Thread Christian Borntraeger
On 11/21/2017 02:44 PM, Cornelia Huck wrote: > On Tue, 21 Nov 2017 12:18:25 +0100 > Halil Pasic wrote: > > Subject: s/unresrict/unrestrict/ > >> The default css 0xFE is currently restricted to virtual subchannel >> devices. The hope when the decision was made was, that non-virtual >> subchanne

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-21 Thread Christian Borntraeger
On 11/21/2017 02:44 PM, Cornelia Huck wrote: > On Tue, 21 Nov 2017 12:18:25 +0100 > Halil Pasic wrote: > > Subject: s/unresrict/unrestrict/ > >> The default css 0xFE is currently restricted to virtual subchannel >> devices. The hope when the decision was made was, that non-virtual >> subchanne

Re: [Qemu-devel] [PATCH 2/2] s390x/kvm: use valgrind annotations for kvm device attributes

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 02:00 PM, Cornelia Huck wrote: > On Mon, 20 Nov 2017 13:35:25 +0100 > Christian Borntraeger wrote: > >> the KVM_GET/SET_DEVICE_ATTR calls have non-self-describing >> side effects. Use valgrind annotations to properly mark >> all storage changes

Re: [Qemu-devel] [PATCH 2/2] s390x/kvm: use valgrind annotations for kvm device attributes

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 02:00 PM, Cornelia Huck wrote: > On Mon, 20 Nov 2017 13:35:25 +0100 > Christian Borntraeger wrote: > >> the KVM_GET/SET_DEVICE_ATTR calls have non-self-describing >> side effects. Use valgrind annotations to properly mark >> all storage changes

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 01:57 PM, Cornelia Huck wrote: > On Mon, 20 Nov 2017 13:35:24 +0100 > Christian Borntraeger wrote: > >> valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an >> undefined value for flags. Right now this is unused, but we >> better pla

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 02:01 PM, Thomas Huth wrote: > On 20.11.2017 13:35, Christian Borntraeger wrote: >> valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an >> undefined value for flags. Right now this is unused, but we >> better play safe. >> >> Sig

[Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

2017-11-20 Thread Christian Borntraeger
valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an undefined value for flags. Right now this is unused, but we better play safe. Signed-off-by: Christian Borntraeger --- target/s390x/kvm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x

[Qemu-devel] [PATCH 2/2] s390x/kvm: use valgrind annotations for kvm device attributes

2017-11-20 Thread Christian Borntraeger
the KVM_GET/SET_DEVICE_ATTR calls have non-self-describing side effects. Use valgrind annotations to properly mark all storage changes instead of using memset or designated initializers. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-skeys-kvm.c| 12 ++- hw/s390x/s390

[Qemu-devel] [PATCH/RFC 0/2] valgrind fallout for s390x/kvm

2017-11-20 Thread Christian Borntraeger
I need these patches below to run valgrind on s390x/kvm without a lot of false positives. Christian Borntraeger (2): s390x/migration: use zero flag parameter s390x/kvm: use valgrind annotations for kvm device attributes hw/s390x/s390-skeys-kvm.c| 12 - hw/s390x/s390-stattrib

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: build s390 bios with -fno-zero-initialized-in-bss

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 11:24 AM, Alexander Graf wrote: > On 11/20/2017 11:19 AM, Christian Borntraeger wrote: >> >> On 11/20/2017 11:16 AM, Alexander Graf wrote: >>> On 11/20/2017 11:02 AM, Christian Borntraeger wrote: >>>> On 11/20/2017 10:29 AM, Alexander Graf

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: build s390 bios with -fno-zero-initialized-in-bss

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 11:16 AM, Alexander Graf wrote: > On 11/20/2017 11:02 AM, Christian Borntraeger wrote: >> >> On 11/20/2017 10:29 AM, Alexander Graf wrote: >>> On 11/20/2017 10:27 AM, Christian Borntraeger wrote: >>>> On 11/20/2017 10:19 AM, Alexander Graf

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: build s390 bios with -fno-zero-initialized-in-bss

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 10:29 AM, Alexander Graf wrote: > On 11/20/2017 10:27 AM, Christian Borntraeger wrote: >> >> On 11/20/2017 10:19 AM, Alexander Graf wrote: >>> On 11/20/2017 10:15 AM, Christian Borntraeger wrote: >>>> The QEMU ELF loader does not initialize the

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: build s390 bios with -fno-zero-initialized-in-bss

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 10:19 AM, Alexander Graf wrote: > On 11/20/2017 10:15 AM, Christian Borntraeger wrote: >> The QEMU ELF loader does not initialize the bss segment. This has >> triggered several bugs in the past, e.g. see commit 5d739a4787a5 >> ("s390-ccw.img: Fix sporadic

Re: [Qemu-devel] [qemu-s390x] [PATCH for-2.11] pc-bios/s390-ccw: Fix problem with invalid virtio-scsi LUN when rebooting

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 10:18 AM, Thomas Huth wrote: > On 20.11.2017 09:48, Christian Borntraeger wrote: >> Thomas, >> >> does this patch help as well? >> >> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile >> index 6d0c2ee..2687590 100644 >>

[Qemu-devel] [PATCH] pc-bios/s390-ccw: build s390 bios with -fno-zero-initialized-in-bss

2017-11-20 Thread Christian Borntraeger
nitialized-in-bss. This will move the zero variables also into the data segment, which is then part of a LOAD section. Reported-by: Thomas Huth Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/

Re: [Qemu-devel] [qemu-s390x] [PATCH for-2.11] pc-bios/s390-ccw: Fix problem with invalid virtio-scsi LUN when rebooting

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 10:00 AM, Cornelia Huck wrote: > On Mon, 20 Nov 2017 09:48:36 +0100 > Christian Borntraeger wrote: > >> Thomas, >> >> does this patch help as well? >> >> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile >> index 6d0c

Re: [Qemu-devel] [qemu-s390x] [PATCH for-2.11] pc-bios/s390-ccw: Fix problem with invalid virtio-scsi LUN when rebooting

2017-11-20 Thread Christian Borntraeger
-initialized-in-bss QEMU_CFLAGS += $(call cc-option, $(QEMU_CFLAGS), -fno-stack-protector) LDFLAGS += -Wl,-pie -nostdlib On 11/17/2017 07:45 PM, Christian Borntraeger wrote: > > > On 11/17/2017 07:10 PM, Thomas Huth wrote: >> When rebooting a guest that has a virtio-scsi dis

Re: [Qemu-devel] [PATCH for-2.11] pc-bios/s390-ccw: Fix problem with invalid virtio-scsi LUN when rebooting

2017-11-17 Thread Christian Borntraeger
e to 0, so > this variable can contain random values from the OS after the reboot. > By setting this variable explicitly to 0, the problem is fixed and > the reboots always succeed. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1514352 > Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308

2017-11-17 Thread Christian Borntraeger
On 11/17/2017 09:10 AM, Cornelia Huck wrote: > On Thu, 16 Nov 2017 18:23:35 +0100 > Cornelia Huck wrote: > >> On Thu, 16 Nov 2017 18:05:23 +0100 >> David Hildenbrand wrote: >> >>> First one also applies to KVM SIGP handling. The other two only >>> apply to TCG (allowing to IPL from disk with m

Re: [Qemu-devel] [PATCH v1 for-2.11 1/3] s390x: fix storing CPU status (again)

2017-11-16 Thread Christian Borntraeger
gned-off-by: David Hildenbrand Reviewed-by: Christian Borntraeger > --- > target/s390x/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/helper.c b/target/s390x/helper.c > index f78983dd6a..246ba20f0d 100644 > --- a/target/s390x

Re: [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)

2017-11-16 Thread Christian Borntraeger
Please change the subject. In busy times I tend to ignore tcg patches. This code is clearly kvm and tcg. So what about "s390x/diag:" as prefix? On 11/16/2017 06:05 PM, David Hildenbrand wrote: > Currently, single threaded TCG with > 1 VCPU gets stuck during IPL, when > the bios tries to switch to

Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308

2017-11-16 Thread Christian Borntraeger
On 11/16/2017 06:23 PM, Cornelia Huck wrote: > On Thu, 16 Nov 2017 18:05:23 +0100 > David Hildenbrand wrote: > >> First one also applies to KVM SIGP handling. The other two only >> apply to TCG (allowing to IPL from disk with more than 1 VCPU- I >> never tested that before). >> >> David Hildenb

[Qemu-devel] 2 bytes of memory leaking due to MigrationParameters unshadowing

2017-11-16 Thread Christian Borntraeger
Markus, valgrind complains about the following two 1 byte memory leaks during migration: ==40773== 1 bytes in 1 blocks are definitely lost in loss record 3 of 2,127 ==40773==at 0x4834E60: malloc (vg_replace_malloc.c:299) ==40773==by 0x18B1A177: g_malloc (in /usr/lib64/libglib-2.0.so.0.50

Re: [Qemu-devel] [PATCH] s390/kvm_virtio/linux-headers: remove traces of old virtio transport

2017-11-15 Thread Christian Borntraeger
On 11/15/2017 06:10 PM, Cornelia Huck wrote: > On Wed, 15 Nov 2017 16:42:23 +0100 > Christian Borntraeger wrote: > >> We no longer support the old s390 transport, neither does the newest >> Linux kernel. Remove it from the linux header script as well as the >> s

[Qemu-devel] [PATCH] s390/kvm_virtio/linux-headers: remove traces of old virtio transport

2017-11-15 Thread Christian Borntraeger
ignore these events. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-hcall.h | 6 ++- include/standard-headers/asm-s390/kvm_virtio.h | 64 -- scripts/update-linux-headers.sh| 1 - 3 files changed, 4 insertions(+), 67

Re: [Qemu-devel] [PATCH] fix scripts/update-linux-headers.sh here document

2017-11-15 Thread Christian Borntraeger
On 11/10/2017 10:03 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Tested-by: Christian Borntraeger > --- > scripts/update-linux-headers.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/update-linux-headers.sh b/scripts/updat

Re: [Qemu-devel] Questions about usability mess that caused by differentiating address based on devices types

2017-11-14 Thread Christian Borntraeger
On 11/14/2017 11:50 AM, Cornelia Huck wrote: > On Tue, 14 Nov 2017 16:25:47 +0800 > Dong Jia Shi wrote: > >> Dear Conny, >> >> Good day! >> >> Just now, our Libvirt folks pointed out a "usability mess" for the >> design of differentiating address based on devices classes (real | >> virtual). The

[Qemu-devel] [PATCH 0/1] s390/pci more enhancements

2017-11-07 Thread Christian Borntraeger
This patch puts PCI device in the configured state by default, which is the only sane default for KVM guests. Christian Borntraeger (1): s390x/pci: let pci devices start in configured mode hw/s390x/s390-pci-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.4

[Qemu-devel] [PATCH 1/1] s390x/pci: let pci devices start in configured mode

2017-11-07 Thread Christian Borntraeger
r "sharing" a pci function across LPARs. This is not what we are going to use in KVM, so always start configured. Signed-off-by: Christian Borntraeger Acked-by: Yi Min Zhao Reviewed-by: Pierre Morel --- hw/s390x/s390-pci-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [Qemu-devel] [PATCH 0/7] s390x/pci: Improve zPCI to cover more cases

2017-11-07 Thread Christian Borntraeger
On 11/07/2017 06:31 PM, Cornelia Huck wrote: > On Tue, 7 Nov 2017 18:24:32 +0100 > Pierre Morel wrote: > >> Right now the PCI support is very limited (e.g. pass through of a >> host vfio device) >> To enable features like virtio-pci several modifications needs to be >> done. >> >> Virtio-PCI u

Re: [Qemu-devel] [PATCH v1 0/5][RFC] Refactoring of AIS support

2017-11-06 Thread Christian Borntraeger
On 11/06/2017 09:52 AM, Cornelia Huck wrote: > On Mon, 30 Oct 2017 19:58:15 +0100 > Halil Pasic wrote: > >> On 10/30/2017 06:38 PM, Pierre Morel wrote: >>> On 30/10/2017 18:08, Christian Borntraeger wrote: >>>> >>>> On 10/30/2017 05:59 PM, Cor

Re: [Qemu-devel] [PATCH v1 0/5][RFC] Refactoring of AIS support

2017-10-30 Thread Christian Borntraeger
On 10/30/2017 05:59 PM, Cornelia Huck wrote: > On Mon, 30 Oct 2017 14:48:23 +0100 > Christian Borntraeger wrote: > > >> FWIW, I am testing a guest patch that enables zPCI without AIS. Its as >> simple as >> >> >> diff --git a/arch/s390/pci/pci.c b/arc

Re: [Qemu-devel] [PATCH v1 0/5][RFC] Refactoring of AIS support

2017-10-30 Thread Christian Borntraeger
On 10/30/2017 02:44 PM, Pierre Morel wrote: > On 30/10/2017 13:44, Christian Borntraeger wrote: >> >> >> On 10/30/2017 01:42 PM, Cornelia Huck wrote: >>> On Mon, 30 Oct 2017 09:28:09 +0100 >>> Christian Borntraeger wrote: >>> >>>> No

Re: [Qemu-devel] [PATCH v1 0/5][RFC] Refactoring of AIS support

2017-10-30 Thread Christian Borntraeger
On 10/30/2017 01:42 PM, Cornelia Huck wrote: > On Mon, 30 Oct 2017 09:28:09 +0100 > Christian Borntraeger wrote: > >> Now I thought about that for a while and I start to think that we cannot >> implement ais >> in QEMU and cover all cases. >> One aspect wa

[Qemu-devel] [PULL 3/4] s390-ccw: print carriage return with new lines

2017-10-30 Thread Christian Borntraeger
0 Signed-off-by: Collin L. Walling Message-Id: <1509120893-28054-1-git-send-email-wall...@linux.vnet.ibm.com> Reviewed-by: Halil Pasic Acked-by: Cornelia Huck Reviewed-by: Alexander Graf Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/sclp.c | 24 +--- 1 fi

[Qemu-devel] [PULL 2/4] s390x/kvm: use cpu model for gscb on compat machines

2017-10-30 Thread Christian Borntraeger
his will make "host-model" runnable all the time, while relying on the CPU model to reject invalid migration attempts. We also need to change the migration for guarded storage. Additional discussions about host-model are still pending but are out of scope of this patch. Suggested-by: Da

[Qemu-devel] [PULL 0/4] s390: fixups for 2.11

2017-10-30 Thread Christian Borntraeger
- CPU type name is now "s390x-cpu" - fixup for the host-model on z14 and older machine versions ---- Christian Borntraeger (2): s390x/kvm: use cpu model for gscb on compat machines s390-*.img: update s390 bios with la

[Qemu-devel] [PULL 4/4] s390-*.img: update s390 bios with latest fixes

2017-10-30 Thread Christian Borntraeger
includes 7618c0aefed1 ("s390-ccw: print carriage return with new lines") a8fbbf1db7a3 ("s390: set DHCP client architecure id for netboot") Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw.img | Bin 26416 -> 30520 bytes pc-bios/s390-netboot.img | Bin 83864

[Qemu-devel] [PULL 1/4] target/s390x: change CPU type name to "s390x-cpu"

2017-10-30 Thread Christian Borntraeger
20115803.14093-1-da...@redhat.com> Acked-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- qapi-schema.json | 4 ++-- target/s390x/cpu-qom.h| 2 +- target/s390x/cpu_models.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi-schema.json b/qapi-schem

Re: [Qemu-devel] [RFC 00/19] KVM: s390/crypto/vfio: guest dedicated crypto adapters

2017-10-30 Thread Christian Borntraeger
adding qemu devel and add Daniel and Erik from libvirt to keep them in the loop. On 10/29/2017 12:11 PM, Cornelia Huck wrote: > On Fri, 13 Oct 2017 13:38:45 -0400 > Tony Krowiak wrote: > >> Tony Krowiak (19): >> KVM: s390: SIE considerations for AP Queue virtualization >> KVM: s390: refact

<    5   6   7   8   9   10   11   12   13   14   >