API_DEPRECATED_WITH_REPLACEMENT("kAudioObjectPropertyElementMain",
> >macos(10.0, 12.0), ios(2.0, 15.0), watchos(1.0, 8.0), tvos(9.0,
> >15.0)) = kAudioObjectPropertyElementMain ^
> >
> > Replace by kAudioObjectPropertyElementMain, redefining it to
>
side it's
now more common to add a Link: tag, which is a bit more convenient as people
can just click on it to get to the discussion. Not sure if there is config
option for pwclient for that as well.
Best regards,
Christian Schoenebeck
asterPort( MACH_PORT_NULL, &masterPort );
>^~~~
>IOMainPort
>
> Replace by IOMainPort, redefining it to IOMasterPort if not available.
>
> Suggested-by: Akihiko Odaki
> Signed-off-by: Philippe Mathieu-Daudé
> ---
Reviewed-b
tly marked deprecated here FAILED:
> libcommon.fa.p/ui_cocoa.m.o
>
> [*]
> https://lore.kernel.org/qemu-devel/4dde2e66-63cb-4390-9538-c032310db3e3@gma
> il.com/
>
> Suggested-by: Akihiko Odaki
> Reviewed-by: Roman Bolshakov
> Tested-by: Roman Bolshakov
> Signed-off
entMain ^
>
> Replace by kAudioObjectPropertyElementMain, redefining it to
> kAudioObjectPropertyElementMaster if not available.
>
> Suggested-by: Akihiko Odaki
> Suggested-by: Christian Schoenebeck
> Suggested-by: Roman Bolshakov
> Signed-off-by: Philippe Mathieu-Daudé
ap between them.
>
> This patch lets us do this and removes the need for the name
> parameter in the virtio_init function.
>
> [Jonah: added new virtio IDs to virtio device list from rebase].
>
> Signed-off-by: Jonah Palmer
Acked-by: Christian Schoenebeck
> ---
> h
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
---
tests/qtest/virtio-9p-test.c | 90 +++-
1 file changed, 27 insertions(+), 63 deletions(-)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index 41fed41de1
sts.
* Tests: Third patch fixes a memory leak.
* Tests: The remaining two patches are code cleanup.
----
Christian Schoenebeck (2):
tests/9pfs: use g_autofree where possible
tests/9pfs: fix mkdir() being called twice
Greg K
From: Greg Kurz
It is recommended to use g_autofree or g_autoptr as it reduces
the odds of introducing memory leaks in future changes.
Signed-off-by: Greg Kurz
Message-Id: <20220201151508.190035-3-gr...@kaod.org>
Reviewed-by: Christian Schoenebeck
Signed-off-by: Christian Schoe
:
Signed-off-by: Greg Kurz
Message-Id: <20220201151508.190035-2-gr...@kaod.org>
Reviewed-by: Christian Schoenebeck
Signed-off-by: Christian Schoenebeck
---
tests/qtest/libqos/virtio-9p.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/qtest/libqos/virtio-9p.c b/tests/qtest/
t' cloning.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/841
Cc: qemu-sta...@nongnu.org
Co-authored-by: Christian Schoenebeck
Reviewed-by: Dmitry V. Levin
Signed-off-by: Vitaly Chikunov
Acked-by: Greg Kurz
Reviewed-by: Christian Schoenebeck
Message-Id: <20220206013419.849161-1...@al
me systems.
Signed-off-by: Christian Schoenebeck
Fixes: 136b7af2 (tests/9pfs: fix test dir for parallel tests)
Reported-by: Daniel P. Berrangé
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/832
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Greg Kurz
Message-Id:
---
tests/qtest/libqos/virtio
n this macOS issue Akihiko!
Are you sure that "weak_import" is still the preferred way? From behaviour PoV
I do not see any difference at all. I can't even tell what the intended
difference was, and QEMU currently only seems to use "weak" in the entire code
base.
Googling around, "weak_import" seems to be required on ancient OS X versions
only and that it's now deprecated in favour of the more common "weak", no?
Best regards,
Christian Schoenebeck
.
> >
> > On doubt you could just make some tests there by simply "inventing" a non-
> > existent function.
> >
> > Best regards,
> > Christian Schoenebeck
>
> I like the idea of switching it to __attribute__((weak)). I should note
> that I&
/a (n/a +
> 0x0)
>
> While fixing, provide a helper for any future `struct dirent' cloning.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/841
> Cc: qemu-sta...@nongnu.org
> Co-authored-by: Christian Schoenebeck
> Reviewed-by: Dmitry V. Levin
> Signed-off-by
On Dienstag, 8. Februar 2022 19:28:21 CET Christian Schoenebeck wrote:
> On Dienstag, 8. Februar 2022 19:04:31 CET Will Cohen wrote:
> > On Tue, Feb 8, 2022 at 11:19 AM Will Cohen wrote:
> > > On Tue, Feb 8, 2022 at 11:11 AM Christian Schoenebeck <
> > >
>
On Dienstag, 8. Februar 2022 19:04:31 CET Will Cohen wrote:
> On Tue, Feb 8, 2022 at 11:19 AM Will Cohen wrote:
> > On Tue, Feb 8, 2022 at 11:11 AM Christian Schoenebeck <
> >
> > qemu_...@crudebyte.com> wrote:
> >> On Dienstag, 8. Februar 2022 16:5
e system where QEMU is
compiled and the systems where the compiled binary will be running, might be
different ones (i.e. different macOS versions).
Best regards,
Christian Schoenebeck
> guess it's perhaps a tradeoff between predicting the future unknown
> availability of functions versus just
On Dienstag, 8. Februar 2022 14:36:42 CET Will Cohen wrote:
> On Mon, Feb 7, 2022 at 5:56 PM Christian Schoenebeck
>
> wrote:
> > On Montag, 7. Februar 2022 23:40:22 CET Will Cohen wrote:
> > > From: Keno Fischer
> > >
> > > Darwin does not support
On Montag, 7. Februar 2022 23:40:19 CET Will Cohen wrote:
> From: Keno Fischer
>
> Signed-off-by: Keno Fischer
> Signed-off-by: Michael Roitzsch
>
> Because XATTR_SIZE_MAX is not defined on Darwin,
> create a cross-platform P9_XATTR_SIZE_MAX instead.
>
> [Will Cohen: - Adjust coding style
>
On Montag, 7. Februar 2022 23:40:23 CET Will Cohen wrote:
> From: Keno Fischer
>
> To allow VirtFS on darwin, we need to check that pthread_fchdir_np is
> available, which has only been available since macOS 10.12.
>
> Additionally, virtfs_proxy_helper is disabled on Darwin. This patch
> series
On Montag, 7. Februar 2022 23:40:22 CET Will Cohen wrote:
> From: Keno Fischer
>
> Darwin does not support mknodat. However, to avoid race conditions
> with later setting the permissions, we must avoid using mknod on
> the full path instead. We could try to fchdir, but that would cause
> problems
On Montag, 7. Februar 2022 22:07:34 CET Will Cohen wrote:
> On Mon, Feb 7, 2022 at 9:21 AM Christian Schoenebeck
>
> wrote:
> > On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote:
> > > * Greg Kurz (gr...@kaod.org) wrote:
> > > &g
> +
> >> +/**
> >> + * Darwin has d_seekoff, which appears to function similarly to d_off.
> >> + * However, it does not appear to be supported on all file systems,
> >> + * so ensure it is manually injected earlier and call here when
> >> + * needed.
eb7983
> > coroutine_trampoline (/usr/bin/qemu-system-x86_64 + 0x963983) #3
> > 0x773e0be0 n/a (n/a + 0x0)
> >
> > While fixing, provide a helper for any future `struct dirent' cloning.
> >
> > Resolves: https://gitlab.com/qemu-project/qemu/
On Montag, 7. Februar 2022 15:37:00 CET Will Cohen wrote:
> On Mon, Feb 7, 2022 at 9:27 AM Christian Schoenebeck
>
> wrote:
> > On Sonntag, 6. Februar 2022 21:07:18 CET Will Cohen wrote:
> > > From: Keno Fischer
> > >
> > > Signed-off-by: Keno Fisc
On Montag, 7. Februar 2022 15:39:30 CET Greg Kurz wrote:
> On Mon, 07 Feb 2022 15:15:46 +0100
>
> Christian Schoenebeck wrote:
> > On Montag, 7. Februar 2022 02:05:32 CET Will Cohen wrote:
> > > On Sun, Feb 6, 2022 at 4:22 PM Philippe Mathieu-Daudé
> > >
>
On Sonntag, 6. Februar 2022 21:07:12 CET Will Cohen wrote:
> From: Keno Fischer
>
> On darwin d_seekoff exists, but is optional and does not seem to
> be commonly used by file systems. Use `telldir` instead to obtain
> the seek offset and inject it into d_seekoff, and create a
> qemu_dirent_off h
On Sonntag, 6. Februar 2022 21:07:18 CET Will Cohen wrote:
> From: Keno Fischer
>
> Signed-off-by: Keno Fischer
> [Michael Roitzsch: - Rebase for NixOS]
> Signed-off-by: Michael Roitzsch
> [Will Cohen: - Rebase to master]
> Signed-off-by: Will Cohen
> Reviewed-by: Paolo Bonzini
> [Will Cohen:
> > > 9pfs.
> > >
> > > virtiofsd could eventually use it.
> >
> > Indeed but virtiofsd is for linux hosts only AFAICT and I'm not aware of
> > any work to support any other host OS.
> >
> > Cc'ing virtio-fs people for inputs on this topic.
>
> Indeeed, there's a lot of Linux specific code in the virtiofsd - I know
> people are interested in other platforms, but I'm not sure that's the
> right starting point.
>
> Dave
Agreeing with Greg here: i.e. I would have placed this into osdep, but I would
not insist on it either.
Best regards,
Christian Schoenebeck
isions and is on a good way to become
queued soon: it is helpful to immediately see here which patches exactly got
changed, because some of the patches already look fine.
For already reviewed patches that you won't change: you can take over people's
reviewed-by tags in the next revision
l probably deprecate the 9p 'proxy' fs driver anyway.
While it had some good ideas, being realistic though: nobody has worked on the
9p proxy driver/backend for many years and it is not in good shape.
I can imagine that due to the ground being laid by these series, that we will
also open 9p for BSD, but that should be done a bit later and hence does not
belong into these series.
But once again: it would not have hurt to make your intentions clear either in
the commit log or by in-source comment. :)
Best regards,
Christian Schoenebeck
/a (n/a +
> 0x0)
>
> While fixing, provide a helper for any future `struct dirent' cloning.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/841
> Cc: qemu-sta...@nongnu.org
> Co-authored-by: Christian Schoenebeck
> Signed-off-by: Vitaly Chikunov
> ---
>
o has d_seekoff which is almost always zero though.
So please, don't blindly define something, test it! On doubt I stick with
Vitaly's solution, because it just works^TM.
On the long term we can still adjust this to make all people happy, but this
is about fixing a crash, so I am fine with what Greg called "band-aid".
Best regards,
Christian Schoenebeck
On Freitag, 4. Februar 2022 16:16:06 CET Greg Kurz wrote:
> On Fri, 04 Feb 2022 15:12:18 +0100
>
> Christian Schoenebeck wrote:
> > On Freitag, 4. Februar 2022 14:55:45 CET Philippe Mathieu-Daudé via wrote:
> > > On 4/2/22 06:06, Vitaly Chikunov wrote:
> > >
> > coroutine_trampoline (/usr/bin/qemu-system-x86_64 + 0x963983) #3
> > 0x773e0be0 n/a (n/a + 0x0)
> >
> > While fixing, provide a helper for any future `struct dirent' cloning.
> >
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues
> > }
> > struct dirent *dst = g_malloc(sz);
> > return memcpy(dst, dent, sz);
> >
> > }
> >
> > Thus it will use strlen for simulated dirents and d_reclen for real ones
>
> Makes sense.
Then maybe consider to leave your reviewed-by tag on today's v3 Dmitry,
thanks! :)
Best regards,
Christian Schoenebeck
/a (n/a +
> 0x0)
>
> While fixing, provide a helper for any future `struct dirent' cloning.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/841
> Cc: qemu-sta...@nongnu.org
> Co-authored-by: Christian Schoenebeck
> Signed-off-by: Vitaly Chikunov
> ---
>
)
>
> While fixing, provide a helper for any future `struct dirent' cloning.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/841
> Cc: qemu-sta...@nongnu.org
> Co-authored-by: Christian Schoenebeck
> Signed-off-by: Vitaly Chikunov
> ---
> Test
On Donnerstag, 3. Februar 2022 07:20:05 CET Vitaly Chikunov wrote:
> On Thu, Feb 03, 2022 at 07:55:41AM +0300, Vitaly Chikunov wrote:
> > Christian,
> >
> > On Wed, Feb 02, 2022 at 05:55:45PM +0100, Christian Schoenebeck wrote:
> > > On Freitag, 28. Januar 2022 23:3
_sec;
Like already mentioned in v2: please assign some value to
stbuf->st_atim.tv_sec as well, i.e. don't just delete it.
On most systems there is a workaround in place like:
#define st_atime st_atim.tv_sec /* Backward compatibility */
#define st_mtime st_mtim.tv_
dd an inline helper function or a macro to deal with macOS vs.
RoW, e.g.:
inline
off_t qemu_dirent_off(struct dirent *dent)
{
#ifdef CONFIG_DARWIN
return dent->d_seekoff;
#else
return dent->d_off;
#endif
}
And in 9p.c at all locations where dent->d_off is currently accessed, you
would just use that helper instead.
Best regards,
Christian Schoenebeck
)
>
> While fixing, provide a helper for any future `struct dirent' cloning.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/841
> Cc: qemu-sta...@nongnu.org
> Co-authored-by: Christian Schoenebeck
> Signed-off-by: Vitaly Chikunov
> ---
> Tested on x86-6
tests/9pfs: Use g_autofree and g_autoptr where possible
>
> tests/qtest/libqos/virtio-9p.c | 20 +++-
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> --
> 2.34.1
>
Queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next
Thanks!
Best regards,
Christian Schoenebeck
On Dienstag, 1. Februar 2022 11:11:37 CET Greg Kurz wrote:
> On Mon, 31 Jan 2022 18:43:22 +0100
>
> Christian Schoenebeck wrote:
> > On Montag, 31. Januar 2022 17:39:30 CET Greg Kurz wrote:
> > > It is recommended to use g_autofree or g_autoptr as it reduces
> > &g
);
int pthread_fchdir_np(int fd) API_AVAILABLE(macosx(10.12));
...
} // extern "C"
But if you are guarding this with a meson check then sure, no objections from
my side at least.
Adding Peter on CC just in case.
Best regards,
Christian Schoenebeck
On Montag, 31. Januar 2022 17:39:30 CET Greg Kurz wrote:
> It is recommended to use g_autofree or g_autoptr as it reduces
> the odds of introducing memory leaks in future changes. Let's do
> that everywhere a glib allocation is performed.
>
> The virtio_9p_create_local_test_dir() function needs so
On Montag, 31. Januar 2022 17:09:07 CET Greg Kurz wrote:
> On Mon, 31 Jan 2022 16:12:45 +0100
>
> Christian Schoenebeck wrote:
> > On Montag, 31. Januar 2022 15:44:46 CET Greg Kurz wrote:
> > > On Mon, 31 Jan 2022 13:37:23 +0100
> > >
> > > Christian
On Montag, 31. Januar 2022 15:44:46 CET Greg Kurz wrote:
> On Mon, 31 Jan 2022 13:37:23 +0100
>
> Christian Schoenebeck wrote:
> > On Montag, 31. Januar 2022 08:35:24 CET Greg Kurz wrote:
> > > > > > diff --git a/tests/qtest/libqos/virtio-9p.c
> > > &g
uggested to make it clear in the commit log comment here that it
could be both, shorter or longer, but OK, the API doc comment on
qemu_dirent_dup() sais it, so ...
Reviewed-by: Christian Schoenebeck
>
> #0 0x559ebeed v9fs_co_readdir_many (/usr/bin/qemu-system-x86_64 +
> 0x49
mplate:
> > char *template = concat_path(pwd, "qtest-9p-local-XX");
> >
> > And if it helps to silence a leak warning (haven't tested), to prepend
> > g_autofree to the global variable instead:
> >
> > static g_autofree char *local_test_path;
>
> The way to go is either drop the g_autofree annotation as you're
> suggesting, but this would make the comment in 'concat_path()'
> even more awkward, or go forward with the glib way and use
> g_steal_pointer() which maps exactly to what the code is doing.
I am fine either way, as long as the resulting behaviour works.
Best regards,
Christian Schoenebeck
On Freitag, 28. Januar 2022 12:49:58 CET Christian Schoenebeck wrote:
> On Mittwoch, 26. Januar 2022 18:11:36 CET Greg Kurz wrote:
> > The template pointer in virtio_9p_create_local_test_dir() is leaked.
> > Add the g_autofree annotation to fix that. While here, convert the
> &g
mu.org/Hosts/W32
So I suggest leave it as is, it should be fine. Otherwise we can still wrap it
into something like
#if !defined(WIN32)
...
#endif
later on if really required.
Best regards,
Christian Schoenebeck
.org/
Best regards,
Christian Schoenebeck
On Freitag, 28. Januar 2022 01:56:06 CET Will Cohen wrote:
> From: Keno Fischer
>
> Signed-off-by: Keno Fischer
> Signed-off-by: Michael Roitzsch
> [Will Cohen: - Adjust coding style
> - Lower XATTR_SIZE_MAX to 64k]
> Signed-off-by: Will Cohen
> ---
> hw/9pfs/9p.c | 7 +++
>
n Linux, it is not true everywhere, and leads to an
> incorrect test failure on unlink_at, noticed when adding 9p to darwin.
Additionally describing the observed misbehaviour is always useful.
Best regards,
Christian Schoenebeck
pple's side?
> Replacing clang with gcc in v3.
>
> On Wed, Nov 24, 2021 at 12:20 PM Christian Schoenebeck <
>
> qemu_...@crudebyte.com> wrote:
> > On Montag, 22. November 2021 01:49:12 CET Will Cohen wrote:
> > > From: Keno Fischer
> > >
> > &
On Freitag, 28. Januar 2022 15:43:10 CET Christian Schoenebeck wrote:
> Also I would prefer g_malloc0() over g_malloc().
Never mind about that one. g_malloc0() with immediate subsequent memcpy() and
exact same size argument would be pointless.
> Then by adding a variable for the d_reclen
dding a variable for the d_reclen yes/no case, overall code can be
reduced. So I would suggest something like this instead:
struct dirent *
qemu_dirent_dup(struct dirent *dent)
{
#if defined _DIRENT_HAVE_D_RECLEN
/* Avoid use of strlen() if there's d_reclen. */
const size_t sz = dent->d_reclen;
#else
/* Fallback to a most portable way. */
const size_t sz = offsetof(struct dirent, d_name) +
strlen(dent->d_name) + 1;
#endif
struct dirent *dst = g_malloc(sz);
return memcpy(dst, dent, sz);
}
Best regards,
Christian Schoenebeck
On Mittwoch, 26. Januar 2022 18:11:36 CET Greg Kurz wrote:
> The template pointer in virtio_9p_create_local_test_dir() is leaked.
> Add the g_autofree annotation to fix that. While here, convert the
> rest of the virtio 9p test code to using g_autofree or g_autoptr
> where possible, since this is t
On Samstag, 22. Januar 2022 20:12:16 CET Christian Schoenebeck wrote:
> The 9p test cases use mkdtemp() to create a temporary directory for
> running the 'local' 9p tests with real files/dirs. Unlike mktemp()
> which only generates a unique file name, mkdtemp() also crea
ve, and I see that you actually already used this in v1
> > before:
> >
> > #define audio_ring_posb(pos, dist, len) audio_ring_dist(pos, dist, len)
> >
> > I would definitely not copy-paste the body. Thomas just suggested in v1 to
> > add a comment, not to duplicate the actual math code:
> > https://lore.kernel.org/qemu-devel/20220106111718.0ec25...@tuxfamily.org/
> >
> > Also for consistency, I would have called the function audio_ring_rpos()
> > and would have commented each argument.
>
> In the audio subsystem rpos is typically the read position. I chose posb
> to distinguish it from read position.
>
> > /**
> >
> > * Returns new position in ringbuffer in backward direction at given
> > distance. * @pos: current position in ringbuffer
> > * @dist: distance in ringbuffer to walk in reverse direction
> > * @len: size of ringbuffer
> > */
>
> This comment is better than my comment. I'll use it in my v3 series.
>
> > static inline size_t audio_ring_rpos(pos, dist, len) {
> >
> > return audio_ring_dist(pos, dist, len);
> >
> > }
>
> I don't think this inline function improves readability compared to my
> macro from v1. To understand the code you still have to replace
> parameter names in your mind. My v2 inline function can be understood at
> first glance.
I didn't mean readability. Believe it or not, it took me a bit to realize that
it was the exact same code as above.
Best regards,
Christian Schoenebeck
On Dienstag, 25. Januar 2022 16:33:46 CET Greg Kurz wrote:
> On Sat, 22 Jan 2022 20:12:16 +0100
>
> Christian Schoenebeck wrote:
> > The 9p test cases use mkdtemp() to create a temporary directory for
> > running the 'local' 9p tests with real files/dirs. Unlike mk
r for the actual code changes, or both.
> >
> > We've been very short on upstream macOS code reviewers so if people
> > interested in that host platform are able to chip in by
> > reviewing each others' code that helps a lot.
Which reminds me of the automated Xcode project discussion for QEMU. I still
think if there was a simple way to work on QEMU with Xcode there were plenty
of macOS reviewers and contributors, and I think it can be done with Meson.
Best regards,
Christian Schoenebeck
On Montag, 24. Januar 2022 18:49:53 CET Roman Bolshakov wrote:
> On Mon, Jan 24, 2022 at 12:27:40PM +0100, Christian Schoenebeck wrote:
> > On Montag, 24. Januar 2022 10:56:00 CET Roman Bolshakov wrote:
> > > On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote:
> Roman
Such blocks are still Objective-C language specific, they are not C and
therefore won't work with GCC.
$ gcc block.c
block.c: In function ‘main’:
block.c:2:14: error: expected identifier or ‘(’ before ‘^’ token
int (^x)(void) = ^{
^
block.c:6:16: warning: implicit declaration of function ‘x’ [-Wimplicit-
function-declaration]
return x();
^
Best regards,
Christian Schoenebeck
data for a longer period of time as with a smaller buffer
> and more audio data in the mixing engine buffer that they can't
> access.
>
> Signed-off-by: Volker Rümelin
Reviewed-by: Christian Schoenebeck
> ---
> audio/jackaudio.c | 4 ++--
> 1 file changed, 2 insert
o.c
> @@ -224,12 +224,11 @@ static void sdl_callback_out(void *opaque, Uint8 *buf,
> int len) /* dolog("callback_out: len=%d avail=%zu\n", len,
> hw->pending_emul); */
>
> while (hw->pending_emul && len) {
> - size_t write_len;
> -ssize_t start = (ssize_t)hw->pos_emul - hw->pending_emul;
> -if (start < 0) {
> -start += hw->size_emul;
> -}
> -assert(start >= 0 && start < hw->size_emul);
> +size_t write_len, start;
> +
> +start = audio_ring_posb(hw->pos_emul, hw->pending_emul,
> +hw->size_emul);
> +assert(start < hw->size_emul);
>
> write_len = MIN(MIN(hw->pending_emul, len),
> hw->size_emul - start);
This rest looks fine to me.
Best regards,
Christian Schoenebeck
On Samstag, 22. Januar 2022 20:12:16 CET Christian Schoenebeck wrote:
> The 9p test cases use mkdtemp() to create a temporary directory for
> running the 'local' 9p tests with real files/dirs. Unlike mktemp()
> which only generates a unique file name, mkdtemp() also crea
me systems.
Signed-off-by: Christian Schoenebeck
Fixes: 136b7af2 (tests/9pfs: fix test dir for parallel tests)
Reported-by: Daniel P. Berrangé
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/832
---
tests/qtest/libqos/virtio-9p.c | 18 +++---
1 file changed, 3 insertions(+), 15
On Montag, 17. Januar 2022 15:03:05 CET Philippe Mathieu-Daudé wrote:
> On 17/1/22 14:14, Christian Schoenebeck wrote:
> > As I was still reading claims on the net that 9p was not usable for more
> > complex use cases, I decided to write a complete HOWTO for installing and
>
g/Documentation/9p_root_fs
With this being setup this way, I am not encountering any issues no matter
which software I am additionally installing and running.
Best regards,
Christian Schoenebeck
On Dienstag, 11. Januar 2022 13:35:05 CET Christian Schoenebeck wrote:
> Curiousity was stronger: the original clang behaviour was as I explained:
> https://github.com/llvm-mirror/clang/commit/0a0d2b179085a52c10402feebeb6db8b
> 4d96
On Montag, 10. Januar 2022 22:05:43 CET Christian Schoenebeck wrote:
> On Montag, 10. Januar 2022 21:39:28 CET Akihiko Odaki wrote:
> > On 2022/01/11 5:22, Christian Schoenebeck wrote:
> > > On Montag, 10. Januar 2022 20:01:40 CET Akihiko Odaki wrote:
> > >>
On Montag, 10. Januar 2022 21:39:28 CET Akihiko Odaki wrote:
> On 2022/01/11 5:22, Christian Schoenebeck wrote:
> > On Montag, 10. Januar 2022 20:01:40 CET Akihiko Odaki wrote:
> >> On 2022/01/11 3:46, Christian Schoenebeck wrote:
> >>> On Montag, 10. Januar 2022 19
On Montag, 10. Januar 2022 20:01:40 CET Akihiko Odaki wrote:
> On 2022/01/11 3:46, Christian Schoenebeck wrote:
> > On Montag, 10. Januar 2022 19:20:15 CET Akihiko Odaki wrote:
> >> On 2022/01/10 22:22, Peter Maydell wrote:
> >>> On Mon, 10 Jan 2022 a
On Montag, 10. Januar 2022 19:20:15 CET Akihiko Odaki wrote:
> On 2022/01/10 22:22, Peter Maydell wrote:
> > On Mon, 10 Jan 2022 at 13:14, Christian Schoenebeck
> >
> > wrote:
> >> I'd suggest to use:
> >>
> >> #if !defined(MAC_OS_VERSION_1
d be avoided
> > #10: FILE: audio/coreaudio.c:47:
> > +#if !__is_identifier(kAudioObjectPropertyElementMain) /* macOS >= 12.0
> > */
> >
> > Should we define __is_identifier() to 0 for GCC on macOS?
>
> So apparently yes:
>
On Sonntag, 9. Januar 2022 18:06:44 CET Volker Rümelin wrote:
> > On Donnerstag, 6. Januar 2022 10:21:47 CET Volker Rümelin wrote:
> >> This patch series reduces the playback latency for audio backends,
> >> in some cases significantly. For PulseAudio, the audio buffer is
> >> also moved from the Q
tyElementMaster
> >> #endif
>
> Apparently __is_identifier() is Clang specific. It might be acceptable
> since this file is restricted to macOS. Similarly for the other
> block/file-posix.c patch, the section is conditional to __APPLE__
> being defined.
Correct, __is_identifier() is a clang extension and does not work with GCC
(tested). I would not use it. People on Mac usually use clang, but there are
also cross compilers for macOS binaries.
I'd suggest to use:
#if !defined(MAC_OS_VERSION_12_0) ||
(MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_VERSION_12_0)
#define kAudioObjectPropertyElementMain kAudioObjectPropertyElementMaster
#endif
Best regards,
Christian Schoenebeck
On Donnerstag, 6. Januar 2022 10:21:47 CET Volker Rümelin wrote:
> This patch series reduces the playback latency for audio backends,
> in some cases significantly. For PulseAudio, the audio buffer is
> also moved from the QEMU side to the PulseAudio server side. This
> improves the drop-out safety
ntry
point is on JACK server side, so for now ...
Reviewed-by: Christian Schoenebeck
> From the jack_set_thread_creator() documentation:
> (...)
>
> No normal application/client should consider calling this. (...)
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues
On Montag, 20. Dezember 2021 16:41:31 CET Christian Schoenebeck wrote:
> On Freitag, 17. Dezember 2021 10:38:32 CET Alexandre Ratchov wrote:
> > sndio is the native API used by OpenBSD, although it has been ported to
> > other *BSD's and Linux (packages for Ubuntu, Deb
/paaudio.c
> X: audio/sdlaudio.c
> +X: audio/sndio.c
> X: audio/spiceaudio.c
> F: qapi/audio.json
>
> @@ -2349,6 +2350,10 @@ R: Thomas Huth
> S: Odd Fixes
> F: audio/sdlaudio.c
>
> +Sndio Audio backend
> +R: Alexandre Ratchov
> +F: audio/sndio.c
> +
Thanks Alexandre for volunteering as reviewer!
Gerd, would it be OK to set you as maintainer for now until new maintainer(s)
adopt audio sections? Or should this start with "S: Orphan" instead?
Best regards,
Christian Schoenebeck
On Montag, 6. Dezember 2021 17:09:45 CET Jonah Palmer wrote:
> On 12/6/21 08:50, Christian Schoenebeck wrote:
> > On Montag, 6. Dezember 2021 13:43:18 CET Jonah Palmer wrote:
> >> This series introduces new QMP/HMP commands to dump the status of a
> >> virtio
s information on virtio level only, like virtqueue fill status, etc.
One thing that I am looking for is monitoring device specific information
above virtio level, e.g. certain performance numbers or statistics that only
make sense for the specific device. That would not fit into any of these
commands, right?
Best regards,
Christian Schoenebeck
ap between them.
>
> This patch lets us do this and removes the need for the name
> parameter in the virtio_init function.
>
> Signed-off-by: Jonah Palmer
> ---
Acked-by: Christian Schoenebeck
> hw/9pfs/virtio-9p-device.c | 2 +-
> hw/block/vhost-user-blk.
On Mittwoch, 1. Dezember 2021 23:46:43 CET Will Cohen wrote:
> On Wed, Nov 24, 2021 at 9:23 AM Christian Schoenebeck <
>
> qemu_...@crudebyte.com> wrote:
> > On Montag, 22. November 2021 01:49:05 CET Will Cohen wrote:
> > > From: Keno Fischer
> >
macOS in
the individual fs drivers [9p-local.c, 9p-synth.c, 9p-proxy.c] directly on
dirent instead, and not rely on fidp not having mutated on server.
And please make sure the 9p test cases pass.
Best regards,
Christian Schoenebeck
On Montag, 22. November 2021 01:49:12 CET Will Cohen wrote:
> From: Keno Fischer
>
> Darwin does not support mknodat. However, to avoid race conditions
> with later setting the permissions, we must avoid using mknod on
> the full path instead. We could try to fchdir, but that would cause
> proble
On Montag, 22. November 2021 01:49:11 CET Will Cohen wrote:
> From: Keno Fischer
>
> This function is new in Mac OS 10.13. Provide a fallback implementation
> when building against older SDKs. The complication in the definition comes
> having to separately handle the used SDK version and the targ
On Montag, 22. November 2021 01:49:10 CET Will Cohen wrote:
> From: Keno Fischer
>
> On darwin `fgetxattr` takes two extra optional arguments,
> and the l* variants are not defined (in favor of an extra
> flag to the regular variants.
>
> Signed-off-by: Keno Fischer
> [Michael Roitzsch: - Rebas
On Montag, 22. November 2021 01:49:08 CET Will Cohen wrote:
> From: Keno Fischer
>
> Signed-off-by: Keno Fischer
> Signed-off-by: Michael Roitzsch
> [Will Cohen: - Adjust coding style]
> Signed-off-by: Will Cohen
> ---
> hw/9pfs/9p.c | 8
> 1 file changed, 8 insertions(+)
>
> diff -
On Montag, 22. November 2021 01:49:06 CET Will Cohen wrote:
> From: Keno Fischer
>
> On darwin d_seekoff exists, but is optional and does not seem to
> be commonly used by file systems. Use `telldir` instead to obtain
> the seek offset.
Are you sure d_seekoff doesn't work on macOS? Because using
On Montag, 22. November 2021 01:49:05 CET Will Cohen wrote:
> From: Keno Fischer
>
> Signed-off-by: Keno Fischer
> Signed-off-by: Michael Roitzsch
> Signed-off-by: Will Cohen
> ---
> hw/9pfs/9p-proxy.c | 17 ++---
> hw/9pfs/9p-synth.c | 2 ++
> hw/9pfs/9p.c | 16 +++
On Montag, 22. November 2021 01:49:03 CET Will Cohen wrote:
> From: Keno Fischer
>
> - Guard Linux only headers.
> - Add qemu/statfs.h header to abstract over the which
>headers are needed for struct statfs
> - Define `ENOATTR` only if not only defined
>(it's defined in system headers
On Dienstag, 16. November 2021 17:40:08 CET Christian Schoenebeck wrote:
> Signed-off-by: Christian Schoenebeck
> ---
> tests/qtest/virtio-9p-test.c | 86 +++-
> 1 file changed, 25 insertions(+), 61 deletions(-)
>
> diff --git a/tests/qtest/
On Dienstag, 16. November 2021 19:12:21 CET Greg Kurz wrote:
> On Tue, 16 Nov 2021 17:40:08 +0100
>
> Christian Schoenebeck wrote:
> > Signed-off-by: Christian Schoenebeck
> > ---
>
> Since g_autofree is scope based, I guess you could also convert this
> snippet,
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 86 +++-
1 file changed, 25 insertions(+), 61 deletions(-)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index 41fed41de1..11861aaf7d 100644
--- a/tests/qtest
On Montag, 15. November 2021 12:54:32 CET Stefan Hajnoczi wrote:
> On Thu, Nov 11, 2021 at 06:54:03PM +0100, Christian Schoenebeck wrote:
> > On Donnerstag, 11. November 2021 17:31:52 CET Stefan Hajnoczi wrote:
> > > On Wed, Nov 10, 2021 at 04:53:33PM +0100, Christian Schoenebeck
501 - 600 of 1406 matches
Mail list logo
