Re: [Qemu-devel] [RFT PATCH] configure: Simplify alternate .text segment

2013-06-19 Thread Ed Maste
On 19 June 2013 14:25, Richard Henderson r...@twiddle.net wrote: Given the large variance in the true default, I wonder if we shouldn't ignore it entirely. I wonder if we can't edit more like this: s/[.] = .* [+] SIZEOF_HEADERS/. = $textseg_addr + SIZEOF_HEADERS/ Sounds good, although we

[Qemu-devel] [Bug 830723] Re: bad patch net_h.patch on freebsd ports

2013-06-13 Thread Ed Maste
Does not appear to be an issue any longer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/830723 Title: bad patch net_h.patch on freebsd ports Status in QEMU: New Bug description: work patch

Re: [Qemu-devel] [PATCH 2/2] usb/host-libusb: Fix building with libusb git master code

2013-06-07 Thread Ed Maste
On 6 June 2013 10:39, Hans de Goede hdego...@redhat.com wrote: +#if LIBUSBX_API_VERSION = 0x01000102 +rc = libusb_get_port_numbers(dev, path, 7); +#else rc = libusb_get_port_path(ctx, dev, path, 7); +#endif I just added libusb_get_port_numbers to FreeBSD's libusb, but we don't have

[Qemu-devel] [PATCH] configure: remove ${config_host_ld} variable

2013-06-06 Thread Ed Maste
It was only used in one place (and already expanded in one other). Signed-off-by: Ed Maste ema...@freebsd.org --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 1654413..e197b91 100755 --- a/configure +++ b/configure @@ -3556,7 +3556,6

[Qemu-devel] [PATCH] configure: Disable host-bsd USB on FreeBSD

2013-06-06 Thread Ed Maste
It hasn't built since FreeBSD 8.x, and is disabled by a patch in the FreeBSD ports tree. FreeBSD is migrating to QEMU's libusb support. Signed-off-by: Ed Maste ema...@freebsd.org --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index

[Qemu-devel] [PATCH] configure: Use ${config_host_ld} variable

2013-06-05 Thread Ed Maste
Signed-off-by: Ed Maste ema...@freebsd.org --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1654413..ec833df 100755 --- a/configure +++ b/configure @@ -4445,7 +4445,7 @@ fi if test $ARCH = tci; then linker_script= else

Re: [Qemu-devel] [PATCH] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-05 Thread Ed Maste
On 5 June 2013 10:51, Michael Tokarev m...@tls.msk.ru wrote: This change removes #including of pty.h, termios.h and other rather specific system headers out of qemu-common.h, which isn't a place for such specific headers really. I needed to add the #include of termios.h in qemu-openpty.h in

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-06-05 Thread Ed Maste
On 5 June 2013 10:04, Anthony Liguori aligu...@us.ibm.com wrote: In terms of policy, we should consider buildbot coverage as a requirement for a platform/architecture to be fully supported. Fully supported means (1) that code will be rejected/reverted if it breaks one of these platforms (2)

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Use ${config_host_ld} variable

2013-06-05 Thread Ed Maste
On 5 June 2013 16:03, Michael Tokarev m...@tls.msk.ru wrote: 05.06.2013 19:02, Ed Maste wrote: - linker_script=-Wl,-T../config-host.ld -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld + linker_script=-Wl,-T../${config_host_ld} -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld Do we really care? To me

Re: [Qemu-devel] kFreeBSD and USB support

2013-06-05 Thread Ed Maste
On 5 June 2013 16:17, Michael Tokarev m...@tls.msk.ru wrote: Hello. On debian we, for a long time, used the following hack in a build script of qemu: # Hack alert. qemu-1.3 still needs this. # On recent kFreebsd, old USB host API has been removed, # but qemu did not learn to use new USB

Re: [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a

2013-06-04 Thread Ed Maste
On 4 June 2013 07:31, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: /* Micron */ +{ INFO(n25q032a,0x20bb16, 0, 64 10, 64, ER_4K) }, Does this have a11 and a13 variants as well? { INFO(n25q128a11, 0x20bb18, 0, 64 10, 256, 0) }, {

Re: [Qemu-devel] [PATCH 1/2] configure: Autogenerate default target list

2013-06-04 Thread Ed Maste
On 20 May 2013 19:09, Peter Maydell peter.mayd...@linaro.org wrote: I'm not sure that's worth the effort at this point when we don't actually have any targets in tree which aren't enabled by default, though. (I did cross-check the old and new lists so this patch isn't accidentally enabling a

[Qemu-devel] [PATCH] block/m25p80: Update Micron entries

2013-06-04 Thread Ed Maste
- Split 32Mb and 256Mb parts into a11 and a13 variants. - Add the 4K sector flag to the 128Mb parts. (These entries were taken from the Linux kernel list, which is missing the flag.) - Fill out the table of sizes with entries for 64Mb parts. Prodded by Peter Crosthwaite. Signed-off-by: Ed

Re: [Qemu-devel] [PATCH 1/2] configure: Autogenerate default target list

2013-06-04 Thread Ed Maste
On 4 June 2013 12:04, Peter Maydell peter.mayd...@linaro.org wrote: You don't need to do this, because there are no config files in default-configs/ for these, so this patch set will not change the behaviour for them. Oh, my apologies; I tested the bsd-user WIP at some point in the past, and

[Qemu-devel] [PATCH] m25p80: Add Micron n25q032a

2013-05-29 Thread Ed Maste
Based on the datasheet at http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_32mb_1_8v_65nm.pdf Signed-off-by: Ed Maste ema...@freebsd.org --- hw/block/m25p80.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: try pkg-config ncurses first

2013-05-25 Thread Ed Maste
On 25 May 2013 00:25, Michael Tokarev m...@tls.msk.ru wrote: 25.05.2013 00:07, Ed Maste wrote: When probing for ncurses, try pkg-config first rather than after explicit -lncurses and -lcurses. This fixes static linking in the case that ncurses has additional dependencies, such as -ltinfo

[Qemu-devel] [PATCH] configure: try pkg-config ncurses first

2013-05-24 Thread Ed Maste
When probing for ncurses, try pkg-config first rather than after explicit -lncurses and -lcurses. This fixes static linking in the case that ncurses has additional dependencies, such as -ltinfo (as on FreeBSD). Signed-off-by: Ed Maste ema...@freebsd.org --- configure | 2 +- 1 file changed, 1

[Qemu-devel] [Bug 1094786] Re: static build with curses fails if requires -ltinfo

2013-05-24 Thread Ed Maste
** Also affects: freebsd-ports-mirror Importance: Undecided Status: New ** No longer affects: freebsd-ports-mirror -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1094786 Title: static

[Qemu-devel] [Bug 1094786] Re: static build with curses fails if requires -ltinfo

2013-05-24 Thread Ed Maste
I ran into the same issue on FreeBSD, and just posted my patch to the qemu-devel list. It's the same solution stefanha describes above. (On FreeBSD we have an additional issue; we don't ship the .pc file with the ncurses port right now. I just hacked one together to include -ltinfo in

[Qemu-devel] [PATCH] configure: remove confusing file manipulation

2013-05-22 Thread Ed Maste
The configure script had some code to manipulate config-host.ld~ (i.e., a common backup filename), comparing it with the newly-generated file. I believe the sense of the comparison was backwards. Since it seemed to serve little purpose anyway, remove it to avoid any confusion. Signed-off-by: Ed

Re: [Qemu-devel] [PATCH] host-libusb: Correct test for USB packet state

2013-05-21 Thread Ed Maste
On 7 May 2013 10:06, Ed Maste ema...@freebsd.org wrote: USB_RET_ASYNC is -6, so inflight was always false. Ping. I believe the if (inflight) block in usb_host_req_abort() can never be executed in the current code. Signed-off-by: Ed Maste ema...@freebsd.org --- hw/usb/host-libusb.c | 2

Re: [Qemu-devel] Could configure generate QEMU's linker scripts?

2013-05-21 Thread Ed Maste
On 20 May 2013 13:21, Richard Henderson r...@twiddle.net wrote: In general I believe that using the -Ttext-segment ADDR flag for ld would completely obviate the need for even editing the link script. That sounds cleaner, although there's a wrinkle for FreeBSD. We're still using binutils

[Qemu-devel] Could configure generate QEMU's linker scripts?

2013-05-19 Thread Ed Maste
On 19 May 2013 10:51, in a thread relating to the sparc-linux-user linker script, Michael Tokarev m...@tls.msk.ru wrote: If we apply this for 1.5, it will be the first release of debian package without extra fixes. Hopefully anyway :) (Ofcourse we may add more fixes later but... ;) Would it

[Qemu-devel] [PATCH v2] Rename hexdump to avoid FreeBSD libutil conflict

2013-05-16 Thread Ed Maste
On FreeBSD libutil is used for openpty(), but it also provides a hexdump() which conflicts with QEMU's. Signed-off-by: Ed Maste ema...@freebsd.org --- v1-v2: Add hexdump() use in iov.c If desired I can workaround this via #define hacks in qemu-common.h instead; please let me know and I

[Qemu-devel] [PATCH] host-libusb: Correct test for USB packet state

2013-05-07 Thread Ed Maste
USB_RET_ASYNC is -6, so inflight was always false. Signed-off-by: Ed Maste ema...@freebsd.org --- hw/usb/host-libusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index d1186b8..0af6ce3 100644 --- a/hw/usb/host-libusb.c +++ b/hw

Re: [Qemu-devel] [PATCH 4/4] usb-host: raise libusbx minimum version to 1.0.13

2013-05-02 Thread Ed Maste
I recently discovered QEMU's libusb support and hoped that this would provide a good solution for the USB host issue on current FreeBSD versions. (Right now the FreeBSD ports tree sets USB_HOST=stub, since the bsd USB code isn't compatible with FreeBSD 8.x and later.) I'm wondering how best to

[Qemu-devel] [PATCH] m25p80.c: Sync Flash chip list with Linux

2013-05-01 Thread Ed Maste
, s25fl016k, s25fl064k (These devices have only some blocks that support small erase sizes.) - Linux lacks n25q128 - Devices without a Jedec ID have been excluded Signed-off-by: Ed Maste ema...@freebsd.org --- hw/block/m25p80.c | 31 ++- 1 file changed, 26 insertions(+), 5

[Qemu-devel] [PATCH v2] bsd-user: OS-agnostic 64-bit SYSCTL types

2013-04-30 Thread Ed Maste
-user-001). Signed-off-by: Ed Maste ema...@freebsd.org --- v2: Delete stray : at end of #ifdef conditional bsd-user/syscall.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 69e3466..a4d1583 100644 --- a/bsd-user/syscall.c

[Qemu-devel] [PATCH] bsd-user: OS-agnostic 64-bit SYSCTL types

2013-04-29 Thread Ed Maste
-user-001). Signed-off-by: Ed Maste ema...@freebsd.org --- bsd-user/syscall.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 69e3466..34b8dfc 100644 --- a/bsd-user/syscall.c +++ b/bsd-user/syscall.c @@ -211,10 +211,11

[Qemu-devel] [PATCH] Remove unnecessary FreeBSD #include

2013-04-25 Thread Ed Maste
sys/param.h was included to define __FreeBSD_version, but the conditional using it was removed by commit d05ef160453e98546a4197496dc8a3cb2defac53 (Brad Smith, Allow clock_gettime() monotonic clock to be utilized on more OS's), so the include is no longer needed here. Signed-off-by: Ed Maste ema

Re: [Qemu-devel] [PATCH] Remove unnecessary FreeBSD #include

2013-04-25 Thread Ed Maste
On 25 April 2013 12:59, Peter Maydell peter.mayd...@linaro.org wrote: (Our other use of __FreeBSD_version is preceded by a direct include of sys/param.h in translate-all.c.) I noticed that one. It's checking for __FreeBSD_version = 700104, which corresponds to a point in time a little before

[Qemu-devel] [PATCH] Rename hexdump to avoid FreeBSD libutil conflict

2013-04-25 Thread Ed Maste
On FreeBSD libutil is used for openpty(), but it also provides a hexdump() which conflicts with QEMU's. Signed-off-by: Ed Maste ema...@freebsd.org --- hw/dma/pl330.c| 4 ++-- include/qemu-common.h | 2 +- util/hexdump.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions

<    1   2