On 07/27/2017 03:40 PM, Cornelia Huck wrote:
> On Thu, 27 Jul 2017 15:18:01 +0200
> Halil Pasic wrote:
>
>> [Re-posting my previous reply because I've accidentally
>> dropped almost all addresses.]
>>
>> On 07/27/2017 10:26 AM, Cornelia Huck wrote:
[Re-posting my previous reply because I've accidentally
dropped almost all addressees.]
On 07/27/2017 10:01 AM, Cornelia Huck wrote:
> On Wed, 26 Jul 2017 00:44:42 +0200
> Halil Pasic wrote:
>
>> According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must
>&
On 07/27/2017 01:59 PM, Cornelia Huck wrote:
> On Thu, 27 Jul 2017 03:54:18 +0200
> Dong Jia Shi wrote:
>
>> When a channel path is hot plugged into a CSS, we should generate
>> a channel path initialized CRW (channel report word). The current
>> code does not do that, instead it puts a stub fu
[Re-posting my previous reply because I've accidentally
dropped almost all addresses.]
On 07/27/2017 10:26 AM, Cornelia Huck wrote:
> On Wed, 26 Jul 2017 00:44:40 +0200
> Halil Pasic wrote:
>
>> There were some missing checks. There might be some more missing. For
&g
On 07/27/2017 10:26 AM, Cornelia Huck wrote:
> On Wed, 26 Jul 2017 00:44:40 +0200
> Halil Pasic wrote:
>
>> There were some missing checks. There might be some more missing. For
>> details,
>> see the individual patches.
>
> The checks are not perfect? Colou
On 07/27/2017 10:01 AM, Cornelia Huck wrote:
> On Wed, 26 Jul 2017 00:44:42 +0200
> Halil Pasic wrote:
>
>> According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must
>> contain zeros. Bits 0-3 are already covered by cmd_code validity
>> checking, a
On 07/26/2017 02:05 PM, Halil Pasic wrote:
>
>
> On 07/26/2017 05:31 AM, Dong Jia Shi wrote:
>> * Halil Pasic [2017-07-26 00:44:41 +0200]:
>>
>>> According to the PoP channel command words (CCW) must be doubleword
>>> aligned and 31 bit addressable
On 07/26/2017 05:31 AM, Dong Jia Shi wrote:
> * Halil Pasic [2017-07-26 00:44:41 +0200]:
>
>> According to the PoP channel command words (CCW) must be doubleword
>> aligned and 31 bit addressable for format 1 and 24 bit addressable for
>> format 0 CCWs.
>&g
On 07/26/2017 05:01 AM, Dong Jia Shi wrote:
> Hello Halil,
>
> * Halil Pasic [2017-07-26 00:44:42 +0200]:
>
>> According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must
>> contain zeros. Bits 0-3 are already covered by cmd_code validity
>> chec
There were some missing checks. There might be some more missing. For details,
see the individual patches.
Regarding testing: did not do much more than a simple smoke test
with virtio-ccw.
Halil Pasic (2):
s390x/css: check ccw address validity
s390x/css: fix bits must be zero check for TIC
ss is composed of a halfword and a byte portion (no additional zero
bit requirements) and just slightly complicates the ORB case where also
bits 1-7 need to be zero.
Let's make our CSS implementation follow the AR more closely.
Signed-off-by: Halil Pasic
---
Note: Checking for 31 bit address
certain flags. Let's fix this.
Signed-off-by: Halil Pasic
---
hw/s390x/css.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index d17e21b7af..1f04ce4a1b 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -884,7 +884,8 @@ stati
bytes and ILC which does the same but in halfwords.
If kvm_enabled() this does not actually matter, because the ilen
parameter of program_interrupt is effectively unused.
Let's provide the correct ilen to program_interrupt.
Signed-off-by: Halil Pasic
Fixes: 7b18aad543 ("s390: Add cha
On 07/18/2017 12:31 PM, Juan Quintela wrote:
> Halil Pasic wrote:
>> On 07/13/2017 05:11 PM, Dr. David Alan Gilbert wrote:
>>> * Christian Borntraeger (borntrae...@de.ibm.com) wrote:
>>>> On 07/13/2017 04:49 PM, Dr. David Alan Gilbert wrote:
>>>>> *
On 07/12/2017 08:48 PM, Eduardo Habkost wrote:
> On Wed, Jul 12, 2017 at 08:06:14PM +0200, Halil Pasic wrote:
>>
>>
>> On 07/11/2017 02:43 AM, Eduardo Habkost wrote:
>>> Test case to detect the bug fixed by commit
>>> "qdev: fix the order compat and gl
On 07/13/2017 06:15 PM, Eduardo Habkost wrote:
> On Thu, Jul 13, 2017 at 01:54:01PM +0200, Halil Pasic wrote:
>>
>>
>> On 07/12/2017 08:29 PM, Eduardo Habkost wrote:
>>> On Wed, Jul 12, 2017 at 07:33:15PM +0200, Halil Pasic wrote:
>>>>
>>>&
On 07/13/2017 05:11 PM, Dr. David Alan Gilbert wrote:
> * Christian Borntraeger (borntrae...@de.ibm.com) wrote:
>> On 07/13/2017 04:49 PM, Dr. David Alan Gilbert wrote:
>>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>>>
>>>>
>>>> On 07
On 07/13/2017 03:10 PM, Cornelia Huck wrote:
> On Thu, 13 Jul 2017 15:02:08 +0200
> Christian Borntraeger wrote:
>
>> On 07/13/2017 02:27 PM, Cornelia Huck wrote:
>>> On Thu, 13 Jul 2017 12:40:29 +0200
>>> Christian Borntraeger wrote:
>>>
From: Yi Min Zhao
During migration w
On 07/13/2017 02:27 PM, Cornelia Huck wrote:
>> +static void kvm_flic_ais_pre_save(void *opaque)
>> +{
>> +KVMS390FLICStateMigTmp *tmp = opaque;
>> +KVMS390FLICState *flic = tmp->parent;
>> +struct kvm_s390_ais_all ais;
>> +struct kvm_device_attr attr = {
>> +.group = KVM_
On 07/13/2017 02:57 PM, Cornelia Huck wrote:
> On Thu, 13 Jul 2017 14:41:05 +0200
> Christian Borntraeger wrote:
>
>> On 07/13/2017 02:11 PM, Cornelia Huck wrote:
>>> On Thu, 13 Jul 2017 12:40:28 +0200
>>> Christian Borntraeger wrote:
>>>
From: Yi Min Zhao
zPCI instructions
On 07/12/2017 09:20 PM, Eduardo Habkost wrote:
> On Wed, Jul 12, 2017 at 07:49:22PM +0200, Halil Pasic wrote:
>> On 07/11/2017 02:43 AM, Eduardo Habkost wrote:
>>> This reverts commit 0bcba41fe379e4c6834adcf1456d9099db31a5b2.
>>>
>>> The bug addressed by that
On 07/12/2017 08:29 PM, Eduardo Habkost wrote:
> On Wed, Jul 12, 2017 at 07:33:15PM +0200, Halil Pasic wrote:
>>
>>
>> On 07/11/2017 02:43 AM, Eduardo Habkost wrote:
>>> From: Greg Kurz
>>>
>>> The current code recursively applies global proper
On 07/11/2017 02:43 AM, Eduardo Habkost wrote:
> Test case to detect the bug fixed by commit
> "qdev: fix the order compat and global properties are applied".
>
> Signed-off-by: Eduardo Habkost
Reviewed-by: Halil Pasic
Please see below nevertheless.
> ---
> te
gned-off-by: Eduardo Habkost
Reviewed-by: Halil Pasic
Note: It is not like the effect of commit 0bcba41fe3 is canceled
out with your first patch in place. It depends on the client
code (the implementation of the individual devices) wether
this patch changes something or not. I did not check myself
'size' type --- */
>
> static void get_size(Object *obj, Visitor *v, const char *name, void *opaque,
>
Code looks good to me. Given that high profile people are happy with the
patch I won't object on the behavior aspect which I don't understand fully.
Thus:
Reviewed
On 07/12/2017 10:01 AM, Christian Borntraeger wrote:
> On 07/11/2017 04:54 PM, Halil Pasic wrote:
>> Like for v2 the scope of this patch series is now limited to decoupling
>> channel subsystem migration from the migration of virtio-ccw proxies.
>>
>> There wasn
w part, reorganize
* Use WITH_TMP instead of one-shot VMStateInfo's
Halil Pasic (6):
s390x: add helper get_machine_class
s390x: add css_migration_enabled to machine class
s390x/css: add missing css state conditionally
s390x/css: add ORB to SubchDev
s390x/css: activate ChannelSubSys mig
Turn on migration for the channel subsystem for the next machine. For
legacy machines we still have to do things the old way.
Signed-off-by: Halil Pasic
Reviewed-by: Cornelia Huck
---
hw/s390x/css.c | 5 +
hw/s390x/s390-virtio-ccw.c | 9 -
include/hw/s390x/css.h
async handling of
subchannel work.
Signed-off-by: Halil Pasic
Reviewed-by: Guenther Hutzl
Reviewed-by: Cornelia Huck
---
hw/s390x/css.c | 35 +++
include/hw/s390x/css.h | 1 +
2 files changed, 36 insertions(+)
diff --git a/hw/s390x/css.c b/hw/s390x/css.c
Instead of passing around a pointer to ORB let us simplify some
function signatures by using the previously introduced ORB saved at the
subchannel (SubchDev).
Signed-off-by: Halil Pasic
Reviewed-by: Cornelia Huck
---
hw/s390x/css.c | 30 +++---
include/hw/s390x
rations are met. For compatibility machines the switch will stay
'off'.
Signed-off-by: Halil Pasic
Acked-by: Cornelia Huck
---
hw/s390x/s390-virtio-ccw.c | 13 +
include/hw/s390x/s390-virtio-ccw.h | 7 +++
2 files changed, 20 insertions(+)
diff --git a/hw/s390x/s39
We will need the machine class at machine initialization time, so the
usual way via qdev won't do. Let's cache the machine class and also use
the default values of the base machine for capability discovery.
Signed-off-by: Halil Pasic
Acked-by: Cornelia Huck
---
hw/s390x/s390-virtio-
vmstate descriptions so
that we have everything we need. Let us guard the added state via
css_migration_enabled, so we keep the compatible behavior if css
migration is disabled.
Let's also annotate the bits which do not need to be migrated for better
readability.
Signed-off-by: Halil Pasic
Review
On 07/05/2017 06:27 PM, Christian Borntraeger wrote:
> On 07/05/2017 05:29 PM, Cornelia Huck wrote:
>> On Wed, 5 Jul 2017 15:54:07 +0200
>> Halil Pasic wrote:
>>
>>> My patch "s390x: fix error propagation in kvm-flic's realize" accidentally
>>
My patch "s390x: fix error propagation in kvm-flic's realize" accidentally
replaced with. That's wrong! So please apply this fixup before including
that patch into mainline (or any other repo).
Signed-off-by: Halil Pasic
---
Hope this is appropriate.
---
hw/intc/s390_flic_
On 07/05/2017 12:20 PM, Christian Borntraeger wrote:
> On 07/04/2017 04:51 PM, Halil Pasic wrote:
>>
>>
>> On 07/04/2017 04:37 PM, Cornelia Huck wrote:
>>> On Tue, 4 Jul 2017 16:07:56 +0200
>>> Christian Borntraeger wrote:
>>>
>>>>
On 07/04/2017 04:46 PM, Halil Pasic wrote:
>
>
> On 07/04/2017 04:31 PM, Cornelia Huck wrote:
>> On Tue, 4 Jul 2017 16:07:55 +0200
>> Christian Borntraeger wrote:
>>
>>> From: Halil Pasic
>>>
>>> From the moment it was introduced by
On 07/04/2017 04:37 PM, Cornelia Huck wrote:
> On Tue, 4 Jul 2017 16:07:56 +0200
> Christian Borntraeger wrote:
>
>> From: Halil Pasic
>>
>> Commit f6f4ce4211 ("s390x: add property adapter_routes_max_batch",
>> 2016-12-09) introduces a common re
On 07/04/2017 04:31 PM, Cornelia Huck wrote:
> On Tue, 4 Jul 2017 16:07:55 +0200
> Christian Borntraeger wrote:
>
>> From: Halil Pasic
>>
>> From the moment it was introduced by commit a2875e6f98 ("s390x/kvm:
>> implement floating-interrupt controller d
On 07/04/2017 08:42 AM, Markus Armbruster wrote:
> Halil Pasic writes:
>
>> On 07/03/2017 03:52 PM, Markus Armbruster wrote:
>>> Halil Pasic writes:
>>>
>>>> On 06/30/2017 04:54 PM, Eric Blake wrote:
>>>>> On 06/30/2017 09:41 AM, Ha
is is somewhat ugly, but we have no choice because the
stream format needs to be preserved.
Almost no changes in behavior. Exception is everything that comes with
vmstate like extra bookkeeping about what's in the stream, and maybe some
extra checks and better error reporting.
Signed-off-by: H
On 07/03/2017 03:52 PM, Markus Armbruster wrote:
> Halil Pasic writes:
>
>> On 06/30/2017 04:54 PM, Eric Blake wrote:
>>> On 06/30/2017 09:41 AM, Halil Pasic wrote:
>>>>>> 'This' basically boils down to the question and
>>>>>
On 06/30/2017 04:54 PM, Eric Blake wrote:
> On 06/30/2017 09:41 AM, Halil Pasic wrote:
>>>> 'This' basically boils down to the question and
>>>> 'Why aren't hints reported in QMP context?'
>>>
>>> QMP is supposed to be machin
On 06/29/2017 09:04 PM, Eric Blake wrote:
> On 06/14/2017 08:51 AM, Halil Pasic wrote:
>
> [apologies for the delayed response, and also adding Markus]
>
No problem. Many thanks for the effort. I see I've ended up with a
lengthy email. A disclaimer before I start: No str
On 06/28/2017 01:33 PM, Juan Quintela wrote:
> Halil Pasic wrote:
>> In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug,
>> but it's actually the best we can do. Especially in these cases a verbose
>> error message is required.
>>
>&
his by adding a parameter to the _EQUAL
macros called _err_hint. Also change all current users to pass NULL as
last parameter so nothing changes for them.
Signed-off-by: Halil Pasic
---
I have already had an RFC series prior to this patch trying to do the
same: https://lists.gnu.org/archive/html/qem
On 06/22/2017 10:22 AM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>
>>
>> On 06/08/2017 01:05 PM, Halil Pasic wrote:
>>>
>>>
>>> On 06/07/2017 11:51 AM, Dr. David Alan Gilbert wrote:
>>>> * Halil P
On 06/08/2017 01:05 PM, Halil Pasic wrote:
>
>
> On 06/07/2017 11:51 AM, Dr. David Alan Gilbert wrote:
>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>> In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug
>>> (it's actually th
On 06/07/2017 11:51 AM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>> In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug
>> (it's actually the best we can do). Especially in these cases a verbose
>> error messag
On 06/07/2017 08:03 PM, Juan Quintela wrote:
> Halil Pasic wrote:
>> On 06/01/2017 01:32 PM, Cornelia Huck wrote:
>>> On Thu, 1 Jun 2017 11:35:27 +0200
>>> Halil Pasic wrote:
>>>
>
>>>>>
>>>>> I was about to suggest to mov
On 06/07/2017 07:10 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>
>>
>> On 06/07/2017 02:01 PM, Dr. David Alan Gilbert wrote:
>>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>>>
>>>>
>
On 06/07/2017 06:35 PM, Juan Quintela wrote:
> Halil Pasic wrote:
>> Verbose error reporting for the _EQUAL family. Modify the standard _EQUAL
>> so the hint states the assertion probably failed due to a bug. Introduce
>> _EQUAL_HINT for specifying a context specific hint
On 06/07/2017 02:01 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>
>>
>> On 06/07/2017 01:07 PM, Dr. David Alan Gilbert wrote:
>>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>>> Verbose error reporting
On 06/07/2017 01:22 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>> This one has to be fixed up to 's390x: vmstatify config migration for
>> virtio-ccw' provided we want to achieve the same as 's390x/css: catch
>
On 06/07/2017 01:07 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>> Verbose error reporting for the _EQUAL family. Modify the standard _EQUAL
>> so the hint states the assertion probably failed due to a bug. Introduce
>> _EQUAL_HINT for
On 06/06/2017 08:07 PM, Christian Borntraeger wrote:
> On 06/06/2017 08:02 PM, Halil Pasic wrote:
>>
>>
>> On 06/06/2017 10:21 AM, Christian Borntraeger wrote:
>>> On 06/02/2017 04:05 PM, Halil Pasic wrote:
>>>> Let's vmstatify virtio
On 06/06/2017 10:21 AM, Christian Borntraeger wrote:
> On 06/02/2017 04:05 PM, Halil Pasic wrote:
>> Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
>> flexibility (extending using subsections) and for fun.
>>
>> To achieve this we need to
In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug
(it's actually the best we can do). Especially in these cases a verbose
error message is required.
Let's introduce infrastructure for specifying a error hint to be used if
equal check fails.
Signed-off-by: H
This one has to be fixed up to 's390x: vmstatify config migration for
virtio-ccw' provided we want to achieve the same as 's390x/css: catch
section mismatch on load' does.
Signed-off-by: Halil Pasic
---
This is on tom of 's390x: vmstatify config migration for virtio-c
Verbose error reporting for the _EQUAL family. Modify the standard _EQUAL
so the hint states the assertion probably failed due to a bug. Introduce
_EQUAL_HINT for specifying a context specific hint.
Signed-off-by: Halil Pasic
---
Keeping this separate for now because we may want something
h and mimics the behavior of the patch reference above.
I have faked the subject of this third patch so patchew
does not complain about that not applying on top of master
(let's see if that works).
Halil Pasic (3):
vmstate: error hint for failed equal checks
vmstate: error hint for fa
On 06/06/2017 10:57 AM, David Hildenbrand wrote:
>> Let me add one meta comment too. IMHO what makes the function hard to
>> understand, is that we have a bunch of optional parameters, and that
>> although this seems to be some sort of approximation problem (find the
>> best good enough), the met
r somebody not to familiar
with the problem domain (like me). AFAIU you are fixing the following
problem domain (me). Seems that the metric implemented was sub-optimal:
if parameters present {type}, absent {ec_ga} maybe present {gen,
features}, then type is not honored appropriately. One can pro
is is somewhat ugly, but we have no choice because the
stream format needs to be preserved.
Almost no changes in behavior. Exception is everything that comes with
vmstate like extra bookkeeping about what's in the stream, and maybe some
extra checks and better error reporting.
Signed-off-by: H
On 06/01/2017 01:32 PM, Cornelia Huck wrote:
> On Thu, 1 Jun 2017 11:35:27 +0200
> Halil Pasic wrote:
>
>> On 05/31/2017 08:52 PM, Juan Quintela wrote:
>>> Halil Pasic wrote:
>>>> Although we have recently vmstatified the migration of some css
>>>&
On 06/01/2017 01:19 PM, Christian Borntraeger wrote:
> On 06/01/2017 01:02 PM, Halil Pasic wrote:
>>
>>
>> On 06/01/2017 12:52 PM, Cornelia Huck wrote:
>>> On Mon, 29 May 2017 15:17:16 +0200
>>> Halil Pasic wrote:
>>>
>>>> Let'
On 06/01/2017 12:52 PM, Cornelia Huck wrote:
> On Mon, 29 May 2017 15:17:16 +0200
> Halil Pasic wrote:
>
>> Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
>> flexibility (extending using subsections) and for fun.
>
> You have interes
On 06/01/2017 10:40 AM, Thomas Huth wrote:
> On 29.05.2017 15:55, Halil Pasic wrote:
>> Turn on migration for the channel subsystem for the next machine. For
>> legacy machines we still have to do things the old way.
>>
>> Signed-off-by: Halil Pasic
>> ---
&
On 05/31/2017 08:13 PM, Juan Quintela wrote:
> Halil Pasic wrote:
>> Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
>> flexibility (extending using subsections) and for fun.
>>
>> To achieve this we need to hack the config_vector, which is
On 05/31/2017 08:52 PM, Juan Quintela wrote:
> Halil Pasic wrote:
>> Although we have recently vmstatified the migration of some css
>> infrastructure, for some css entities there is still state to be
>> migrated left, because the focus was keeping migration stream
>
On 05/31/2017 06:00 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>> Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
>> flexibility (extending using subsections) and for fun.
>>
>> To achieve this w
On 05/18/2017 03:21 PM, Gonglei (Arei) wrote:
Besides if you look at
+Stateless mode HASH service requests are as follows:
+
+\begin{lstlisting}
+struct virtio_crypto_hash_para_statelesss {
+struct {
+/* See VIRTIO_CRYPTO_HASH_* above */
+
async handling of
subchannel work.
Signed-off-by: Halil Pasic
Reviewed-by: Guenther Hutzl
---
hw/s390x/css.c | 35 +++
include/hw/s390x/css.h | 1 +
2 files changed, 36 insertions(+)
diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index a15b58d303..e840dfba2a
Instead of passing around a pointer to ORB let us simplify some
functions signatures by using the previously introduced ORB saved at the
subchannel (SubchDev).
Signed-off-by: Halil Pasic
Reviewed-by: Guenther Hutzl
---
hw/s390x/css.c | 19 +--
1 file changed, 9 insertions
n for virtio-ccw'. Since this series depends on that
patch, I have included it here too (for convenience).
The reorganization was requested by Dave.
v1 --> v2:
* Split out the vmystatify virtio-ccw part, reorganize
* Use WITH_TMP instead of one-shot VMStateInfo's
Halil Pasic (7):
rations are met. For compatibility machines the switch will stay
'off'.
Signed-off-by: Halil Pasic
---
hw/s390x/s390-virtio-ccw.c | 13 +
include/hw/s390x/s390-virtio-ccw.h | 7 +++
2 files changed, 20 insertions(+)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390
vmstate descriptions so
that we have everything we need. Let us guard the added state with via
css_migration_enabled, so we keep the compatible behavior if css
migration is disabled.
Let's also annotate the bits which do not need to be migrated for better
readability.
Signed-off-by: Halil Pasic
--
Turn on migration for the channel subsystem for the next machine. For
legacy machines we still have to do things the old way.
Signed-off-by: Halil Pasic
---
hw/s390x/css.c | 5 +
hw/s390x/s390-virtio-ccw.c | 9 -
hw/s390x/virtio-ccw.c | 1 -
include/hw/s390x/css.h
This somewhat ugly, but we have no choice because the
stream format needs to be preserved.
Almost no changes in behavior. Exception is everything that comes with
vmstate like extra bookkeeping about what's in the stream, and maybe some
extra checks and better error reporting.
Signed-off-by: H
We will need the machine class at machine initialization time, so the
usual way via qdev won't do. Let's cache the machine class and also use
the default values of the base machine for capability discovery.
Signed-off-by: Halil Pasic
---
hw/s390x/s390-virtio-
This somewhat ugly, but we have no choice because the
stream format needs to be preserved.
Almost no changes in behavior. Exception is everything that comes with
vmstate like extra bookkeeping about what's in the stream, and maybe some
extra checks and better error reporting.
Signed-off-by: H
On 05/19/2017 07:47 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>
>>
>> On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote:
>>>> We could also consider making WITH_TMP act as a normal field.
>>>> Worki
On 05/19/2017 07:28 PM, Dr. David Alan Gilbert wrote:
>> To sum it up although I'm currently leaning towards abandoning my idea
>> of two sections for two devices, I'm not comfortable with making the
>> call myself. I'm hoping for some maintainer guidance (s390x, virtio
>> and migration).
> dhi
On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote:
>> We could also consider making WITH_TMP act as a normal field.
>> Working on the whole state looks like a bit like a corner case:
>> we have some stuff adjacent in the migration stream, and we have
>> to map it on multiple fields (and vice-
On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>
>>
>> On 05/15/2017 08:01 PM, Dr. David Alan Gilbert wrote:
>>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>>>
>>>>
>
On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote:
> Dave
> P.S. I'm out for about a week.
Thanks for the info! Could you say something about our 'two
devices two sections vs two devices one section' dilemma
form PATCH 06/10 before leaving? I do not want to be pushy,
but I'm also eager to mak
On 05/18/2017 07:47 PM, Dr. David Alan Gilbert wrote:
>> Hi!
>>
>> I also wonder what is the best way to do this with vmstate. I know there
>> are VMSTATE_*_EQUAL macros for integers, and I have partially modelled my
>> patch after that, but there we only get a != b as error message, which is
>>
On 05/15/2017 08:01 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>
>>
>> On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote:
>>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>>> As a preparation for swi
On 05/17/2017 11:12 AM, Gonglei (Arei) wrote:
>> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com]
>> Sent: Wednesday, May 17, 2017 6:18 AM
>>
>>
>> On 05/16/2017 04:52 AM, Gonglei (Arei) wrote:
>>>> On 05/13/2017 03:16 AM, Gonglei (Arei)
e problem (while trying to to load the saved vm)
CC: qemu-sta...@nongnu.org
Signed-off-by: Halil Pasic
Reviewed-by: Dong Jia Shi
---
v1 --> v2:
* Fixed grammar in error message (s/prior/prior to/).
We (Connie and me) are still interested in learning how to do verbose
error messages with VM
On 05/17/2017 01:10 PM, Cornelia Huck wrote:
> On Wed, 17 May 2017 12:33:20 +0200
> Halil Pasic wrote:
>
>> On 05/17/2017 12:13 PM, Gonglei (Arei) wrote:
>>>>
>>>> On 05/17/2017 11:12 AM, Gonglei (Arei) wrote:
>>>>>>>> By th
On 05/17/2017 12:13 PM, Gonglei (Arei) wrote:
>>
>> On 05/17/2017 11:12 AM, Gonglei (Arei) wrote:
>> By the way, I'm having a hard time understing how is the requirement
>> form
>>
>> http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1-260
>> 004
>> (2
On 05/17/2017 11:12 AM, Gonglei (Arei) wrote:
By the way, I'm having a hard time understing how is the requirement form
>> http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1-260
004
(2.4.4 Message Framing) satisfied by this code. Could you explain this
On 05/16/2017 05:33 PM, Stefan Hajnoczi wrote:
> On Sat, Apr 22, 2017 at 02:23:50PM +0800, Gonglei wrote:
>> +Dataq requests for both session and stateless modes are as follows:
>> +
>> +\begin{lstlisting}
>> +struct virtio_crypto_op_data_req_mux {
>> +struct virtio_crypto_op_header header;
>
On 05/16/2017 04:52 AM, Gonglei (Arei) wrote:
>>
>> On 05/13/2017 03:16 AM, Gonglei (Arei) wrote:
>>>
>>>> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com]
>>>> Sent: Friday, May 12, 2017 7:02 PM
>>>>
>>>>
>>>>
On 05/15/2017 09:07 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>
>>
>> On 05/08/2017 08:42 PM, Dr. David Alan Gilbert wrote:
>>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>>>
>>>>
>
On 05/16/2017 05:48 AM, Gonglei (Arei) wrote:
[..]
>>> +\begin{itemize*}
>>> +\item The device MUST set the \field{session_id} field to a unique session
>> identifier when the device finishes processing session creation.
>>
>> I guess only if successfull (that is status == VIRTIO_CRYPTO_OK).
>>
On 05/10/2017 08:02 PM, Halil Pasic wrote:
>
>
> On 04/22/2017 08:23 AM, Gonglei wrote:
>> The virtio crypto device is a virtual crypto device (ie. hardware
>> crypto accelerator card). Currently, the virtio crypto device provides
>> the following crypto services:
On 05/13/2017 03:16 AM, Gonglei (Arei) wrote:
>
>> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com]
>> Sent: Friday, May 12, 2017 7:02 PM
>>
>>
>> On 05/08/2017 01:38 PM, Gonglei wrote:
>>> According to the new spec, we should use different
>
On 05/11/2017 01:02 PM, Cornelia Huck wrote:
> On Wed, 10 May 2017 17:12:09 +0200
> Halil Pasic wrote:
>
>> Prior to the virtio-ccw-2.7 machine (and commit 2a79eb1a), our virtio
>> devices residing under the virtual-css bus do not have qdev_path based
>> migration
701 - 800 of 1027 matches
Mail list logo
