[Qemu-devel] [PATCH 2/7] No need for kvm_init() stub as already defined in qemu-kvm.h

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com No need for kvm_init() stub in kvm-stub.c as already defined in qemu-kvm.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- kvm-stub.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index

[Qemu-devel] [PATCH 4/7] Build certain drivers for MIPS as well.

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com pcspk.o i8254.o acpi.o acpi_piix4.o are all required for MIPS as well, add them to Makefile.target accordingly. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- Makefile.target |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 1/7] Only call kvm_set_irqfd() if CONFIG_KVM is defined

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Only call kvm_set_irqfd() if CONFIG_KVM is defined to avoid breaking the build for non x86. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/virtio-pci.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/virtio

[Qemu-devel] [PATCH 3/7] time_drift_fix is x86 only, rather than !ia64

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com time_drift_fix is x86 only, rather than !ia64, to allow the code to build for other archs, like MIPS. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/i8259.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/i8259

[Qemu-devel] [PATCH 5/7] Only export phys_mem create functions for !CONFIG_USER_ONLY builds

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Only export phys_mem create functions for !CONFIG_USER_ONLY builds Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-kvm.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-kvm.h b/qemu-kvm.h index 6f6c6d8

[Qemu-devel] [PATCH 6/7] Only treat KVM specific cmdline options for KVM enabled builds

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Only treat KVM specific cmdline options for KVM enabled builds. This fixes build breakage for target MIPS etc. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b

[Qemu-devel] [PATCH 0/7] Fix building qemu-kvm for non KVM target

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, This set of patches fixes building qemu-kvm for non KVM targets, as reported in http://sourceforge.net/tracker/?func=detailatid=893831aid=2984626group_id=180599 One of the main problem is that we have a tendency to move things from Makefile.objs

[Qemu-devel] [PATCH 7/7] Only accept -no-hpet for i386 targets

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Only accept -no-hpet for i386 targets Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index e4a9aa9..1977409 100644 --- a/vl.c +++ b/vl.c @@ -3328,9

[Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target

2010-06-15 Thread Jes Sorensen
On 06/15/10 14:04, Avi Kivity wrote: It's the other way round. Upstream keeps moving stuff out of Makefile.target, and I move them back during merges, because the only thing I can think of during a merge is how quickly can I complete this merge. Thanks for tackling this. I see. I found at

[Qemu-devel] Re: [PATCH 7/7] Only accept -no-hpet for i386 targets

2010-06-15 Thread Jes Sorensen
On 06/15/10 14:20, Jan Kiszka wrote: @@ -3328,9 +3328,11 @@ int main(int argc, char **argv, char **envp) case QEMU_OPTION_no_acpi: acpi_enabled = 0; break; +#ifdef TARGET_I386 case QEMU_OPTION_no_hpet: no_hpet = 1;

[Qemu-devel] Re: [PATCH 7/7] Only accept -no-hpet for i386 targets

2010-06-15 Thread Jes Sorensen
On 06/15/10 14:37, Jan Kiszka wrote: Upstream seems to have removed the TARGET_I386 around 'int no_hpet = 0;' but to be honest, I think the correct solution is to not expose no_hpet to non x86 targets in upstream. Then I would suggest to address this upstream first. The goal should be to

[Qemu-devel] [PATCH 1/7] Only call kvm_set_irqfd() if CONFIG_KVM is defined

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Only call kvm_set_irqfd() if CONFIG_KVM is defined to avoid breaking the build for non x86. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/virtio-pci.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/virtio

[Qemu-devel] [PATCH 3/7] time_drift_fix is x86 only, rather than !ia64

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com time_drift_fix is x86 only, rather than !ia64, to allow the code to build for other archs, like MIPS. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/i8259.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/i8259

[Qemu-devel] [PATCH 4/7] Build certain drivers for MIPS as well.

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com pcspk.o i8254.o acpi.o acpi_piix4.o are all required for MIPS as well, add them to Makefile.target accordingly. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- Makefile.target |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 6/7] Only treat KVM specific cmdline options for KVM enabled builds

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Only treat KVM specific cmdline options for KVM enabled builds. This fixes build breakage for target MIPS etc. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b

[Qemu-devel] [PATCH v2 0/7] Fix building qemu-kvm for non KVM target

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, This set of patches fixes building qemu-kvm for non KVM targets, as reported in http://sourceforge.net/tracker/?func=detailatid=893831aid=2984626group_id=180599 One of the main problem is that we have a tendency to move things from Makefile.objs

[Qemu-devel] [PATCH 2/7] No need for kvm_init() stub as already defined in qemu-kvm.h

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com No need for kvm_init() stub in kvm-stub.c as already defined in qemu-kvm.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- kvm-stub.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index

[Qemu-devel] [PATCH 5/7] Only export phys_mem create functions for !CONFIG_USER_ONLY builds

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Only export phys_mem create functions for !CONFIG_USER_ONLY builds Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-kvm.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-kvm.h b/qemu-kvm.h index 6f6c6d8

[Qemu-devel] [PATCH 7/7] Declare no_hpet variable for all targets

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com We need to declare 'int no_hpet' for all targets to avoid build failure on no x86 builds. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index e4a9aa9

[Qemu-devel] Re: [PATCH 7/7] Only accept -no-hpet for i386 targets

2010-06-15 Thread Jes Sorensen
On 06/15/10 15:38, Paolo Bonzini wrote: This can alternatively be made to match upstream by just removing the #ifdef on no_hpet's declaration. Not saying that -no-hpet makes any sense on non-i386 targets, mind, but it seems pointless to deviate from upstream. Paolo Fixed in v2 of the

[Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target

2010-06-15 Thread Jes Sorensen
On 06/15/10 15:42, Juan Quintela wrote: On my hpet removal patches, the important bit was that I enabled #define CONFIG_HPET 1 in C land, that makes it easy to do this kind of tests. As it is today, it is very difficult to test for a feature, as we only have TARGET_* defines. Instead of

[Qemu-devel] Re: [PATCH 2/7] No need for kvm_init() stub as already defined in qemu-kvm.h

2010-06-15 Thread Jes Sorensen
On 06/15/10 15:34, Paolo Bonzini wrote: On 06/15/2010 01:04 PM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com No need for kvm_init() stub in kvm-stub.c as already defined in qemu-kvm.h Why not keep the other one and match upstream? Instead, I'd remove this one

[Qemu-devel] [PATCH 6/7] Only treat KVM specific cmdline options for KVM enabled builds

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Only treat KVM specific cmdline options for KVM enabled builds. This fixes build breakage for target MIPS etc. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b

[Qemu-devel] [PATCH 5/7] Only export phys_mem create functions for !CONFIG_USER_ONLY builds

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Only export phys_mem create functions for !CONFIG_USER_ONLY builds Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-kvm.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-kvm.h b/qemu-kvm.h index 665c4f2

[Qemu-devel] [PATCH 7/7] Declare no_hpet variable for all targets

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com We need to declare 'int no_hpet' for all targets to avoid build failure on no x86 builds. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index e4a9aa9

[Qemu-devel] [PATCH 2/7] Remove duplicate kvm_init() stub from qemu-kvm.h

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Remove duplicate kvm_init() stub from qemu-kvm.h to avoid build conflicts and move prototype out of CONFIG_KVM to make the stub in kvm-stub.c visible. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-kvm.h | 29

[Qemu-devel] [PATCH v3 0/7] Fix building qemu-kvm for non KVM target

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, This set of patches fixes building qemu-kvm for non KVM targets, as reported in http://sourceforge.net/tracker/?func=detailatid=893831aid=2984626group_id=180599 One of the main problem is that we have a tendency to move things from Makefile.objs

[Qemu-devel] [PATCH 4/7] Build certain drivers for MIPS as well.

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com pcspk.o i8254.o acpi.o acpi_piix4.o are all required for MIPS as well, add them to Makefile.target accordingly. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- Makefile.target |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 1/7] Only call kvm_set_irqfd() if CONFIG_KVM is defined

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Only call kvm_set_irqfd() if CONFIG_KVM is defined to avoid breaking the build for non x86. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/virtio-pci.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/virtio

[Qemu-devel] [PATCH 3/7] time_drift_fix is x86 only, rather than !ia64

2010-06-15 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com time_drift_fix is x86 only, rather than !ia64, to allow the code to build for other archs, like MIPS. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/i8259.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/i8259

[Qemu-devel] Re: [PATCH 17/19] Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE

2010-06-15 Thread Jes Sorensen
On 06/15/10 16:52, Kevin Wolf wrote: Am 15.06.2010 16:47, schrieb Jes Sorensen: Hmmm maybe I am messing something up. I started with strange duplicate lines because I thought git send-email would cut the first line for the subject line and then just leave the rest in. Probably just me getting

[Qemu-devel] Re: [PATCH 17/19] Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE

2010-06-15 Thread Jes Sorensen
On 06/15/10 16:42, Kevin Wolf wrote: Am 15.06.2010 16:28, schrieb Anthony Liguori: On 06/15/2010 09:19 AM, Kevin Wolf wrote: From: Jes Sorensenjes.soren...@redhat.com Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE in hw/fdc.c FYI, the subject is duplicated here so the commit

[Qemu-devel] Re: [PATCH 1/7] Only call kvm_set_irqfd() if CONFIG_KVM is defined

2010-06-15 Thread Jes Sorensen
On 06/15/10 15:31, Paolo Bonzini wrote: On 06/15/2010 01:04 PM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com Only call kvm_set_irqfd() if CONFIG_KVM is defined to avoid breaking the build for non x86. You can just add a stub to kvm-stub.c that returns -ENOSYS.

[Qemu-devel] [Bug 424453] Re: FDC save and restore commands

2010-06-15 Thread Jes Sorensen
Hi, I pushed the patch upstream, commit bb350a5e9b961a8c3940b3451c329ff07c027aa1 Closing Jes ** Changed in: qemu Status: New = Fix Committed ** Changed in: qemu Status: Fix Committed = Fix Released -- FDC save and restore commands https://bugs.launchpad.net/bugs/424453 You

[Qemu-devel] [PATCH] SeaBIOS: Fix bvprintf() to respect padding for hex printing.

2010-06-14 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Fix bvprintf to respect space padding when printing hex numbers and the caller specifies alignment without zero padding, eg. %2x as opposed to %02x Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- src/output.c | 27

[Qemu-devel] [PATCH 1/2] Remove unused DEBUG defines from hw/msix.c

2010-06-14 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Remove unused DEBUG defines from hw/msix.c to avoid having anything define the word DEBUG without any additions such as MSIX_DEBUG. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/msix.c |9 - 1 files changed, 0 insertions(+), 9

[Qemu-devel] [PATCH 2/2] Change #define DEBUG to #define E1000_DEBUG in hw/e1000.c

2010-06-14 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Change #define DEBUG to #define E1000_DEBUG in hw/e1000.c to make it possible to build QEMU with -DDEBUG Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/e1000.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw

[Qemu-devel] [Bug 322602] Re: Snapshot usage makes qcow2 image unusable due to large tables

2010-06-11 Thread Jes Sorensen
Hi, Could you please let us know whether this is still a problem and if it isn't, lets close this bug. In addition, you haven't listed which version of qemu-kvm you are running. I am guessing it is something Ubuntu based based on the version number, but since not all of us are running Ubuntu it

[Qemu-devel] [PATCH] Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE

2010-06-11 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE in hw/fdc.c Per https://bugs.launchpad.net/qemu/+bug/424453 the correct values for FD_CMD_SAVE is 0x2e and FD_CMD_RESTORE is 0x4e. Verified against the Intel 82078 manual which can be found at: http

[Qemu-devel] [PATCH 01/17] vl.c: Remove double include of netinet/in.h for Solaris

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com vl.c: netinet/in.h is already included once above for the Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Andreas Faerber afaer...@opensolaris.org Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r...@redhat.com

[Qemu-devel] [PATCH 04/17] vl.c: Move host_main_loop_wait() to OS specific files.

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move host_main_loop_wait() to OS specific files. Create qemu-os-posix.h and provide empty inline for the POSIX case. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r

[Qemu-devel] [PATCH 02/17] Create qemu-os-win32.h and move WIN32 specific declarations there

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Create qemu-os-win32.h for WIN32 specific declarations. Move polling handling declaration into this file from sysemu.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r

[Qemu-devel] [PATCH 03/17] Introduce os-win32.c and move polling functions from vl.c

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This introduces os-win32.c. It is meant to carry win32 specific functions thata are not relevant for all of QEMU as well as win32 versions of various pieces like signal handling etc. Move win32 polling handler helper functions from vl.c to os-win32.c

[Qemu-devel] [PATCH 06/17] Move win32 early signal handling setup to os_setup_signal_handling()

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move win32 early signal handling setup to os_setup_signal_handling() Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r...@redhat.com --- os-win32.c | 29

[Qemu-devel] [PATCH 09/17] Move find_datadir to OS specific files.

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This moves the win32 and POSIX versions of find_datadir() to OS specific files, and removes some #ifdef clutter from vl.c Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r

[Qemu-devel] [PATCH 05/17] Introduce os-posix.c and create os_setup_signal_handling()

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Introcuce os-posix.c and move posix specific signal handling there. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r...@redhat.com --- Makefile.objs |1 + os-posix.c

[Qemu-devel] [PATCH v4 00/17] clean up vl.c code

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com v4 of the vl.c clean up patch. This one just fixes a merge conflict due to some recent changes to vl.c, and I added the Acked-By: lines I received for v3. Consider it a house-keeping update to make it easier to merge. The patches try to clean up

[Qemu-devel] [PATCH 07/17] Rename os_setup_signal_handling() to os_setup_early_signal_handling()

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Rename os_setup_signal_handling() to os_setup_early_signal_handling() Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r...@redhat.com --- os-posix.c |2 +- os-win32.c

[Qemu-devel] [PATCH 16/17] Move line-buffering setup to OS specific files.

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move line-buffering setup to OS specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r...@redhat.com --- os-posix.c |5 + qemu-os-posix.h |1 + qemu

[Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move daemonize handling from vl.c to OS specific files. Provide dummy stubs for Win32. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r...@redhat.com --- os-posix.c

[Qemu-devel] [PATCH 08/17] Move main signal handler setup to os specificfiles.

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move main signal handler setup to os specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r...@redhat.com --- os-posix.c | 27

[Qemu-devel] [PATCH 10/17] Rename qemu-options.h to qemu-options.def

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Rename qemu-options.h to qemu-options.def as it is not a header file for general use and this leaves space for a proper qemu-options.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard

[Qemu-devel] [PATCH 17/17] Move set_proc_name() to OS specific files.

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move handling to change process name to POSIX specific files plus add a better error message to cover the case where the feature isn't supported. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked

[Qemu-devel] [PATCH 12/17] Move runas handling from vl.c to OS specific files.

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move code to handle runas, ie. change of user id of QEMU process to OS specific files and provide dummy stub for Win32. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r

[Qemu-devel] [PATCH 13/17] Move chroot handling to OS specific files.

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move chroot handling to OS specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r...@redhat.com --- os-posix.c | 19 +++ qemu-os-posix.h

[Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Introduce OS specific cmdline argument handling by calling os_parse_cmd_args() at the end of switch() statement. Move option enum to qemu-options.h and have it included from os-posix.c and os-win32.c in addition to vl.c. In addition move SMB argument

[Qemu-devel] [PATCH 15/17] Make os_change_process_uid and os_change_root os-posix.c local

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com os_change_process_uid() and os_change_root() are now only called from os-posix.c, so no need to keep win32 stubs for them. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Acked-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r

Re: [Qemu-devel] [Bug 586420] Re: WinXP install cd hangs at boot time if machine started with floppy

2010-06-10 Thread Jes Sorensen
On 06/10/10 12:49, tekditt wrote: Well, I forgot something to mention. Again: I can boot the install CDs of Windows XP and Windows Server 2003 if I DON'T use any floppy drive. -fda/-fdb FILE as well as -drive file=FILE,if=floppy are causing this bug, the bug not to be able to boot these

Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-09 Thread Jes Sorensen
On 06/08/10 03:56, Anthony Liguori wrote: On 06/07/2010 08:01 PM, Paul Brook wrote: diff --git a/hw/realview.c b/hw/realview.c index a36bdbe..8dcef80 100644 --- a/hw/realview.c +++ b/hw/realview.c @@ -444,9 +444,9 @@ static QEMUMachine realview_eb_mpcore_machine = { .init =

Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-09 Thread Jes Sorensen
On 06/08/10 01:52, Anthony Liguori wrote: max_cpus is a weird property today. On the one hand, it represents the maximum CPUs a board can support and is used to validate the number of vcpus requested by the user. On the other hand, max_cpus can be set by the user in which case it is taken

Re: [Qemu-devel] [PATCH 21/22] machine: convert pc machines to split core vs machine API

2010-06-09 Thread Jes Sorensen
On 06/08/10 01:52, Anthony Liguori wrote: +static QemuOptValue pc_machine_v0_11[] = { +QOPT_VALUE(name, pc-0.11), +QOPT_VALUE(desc, Standard PC, qemu 0.11), +QOPT_VALUE(acpi, on), +QOPT_VALUE(pci, on), +QOPT_VALUE(cpu, PC_DEFAULT_CPU_MODEL), +QOPT_VALUE(max_cpus,

[Qemu-devel] [Bug 586420] Re: WinXP install cd hangs at boot time if machine started with floppy

2010-06-09 Thread Jes Sorensen
If you built your own qemu it may try to look for the BIOS in /usr/local/share/qemu and not where it was originally installed on your system. Could you please try to specify it with the -L option and see. You don't mention what system you are running on, it would likely be -L /usr/share/qemu-kvm

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-09 Thread Jes Sorensen
On 06/09/10 09:07, Markus Armbruster wrote: Jes Sorensen jes.soren...@redhat.com writes: On 06/04/10 13:54, Markus Armbruster wrote: If there is strong feeling we should do it this way instead, I can change the code to do it this way instead. I am not married to the current approach, I just

[Qemu-devel] [PATCH] un-register kbd driver for USB kbd unplug

2010-06-08 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, This is a fairly simple fix for the problem where the keyboard event handler is left in place when a keyboard is unplugged, eg. USB. The long term solution would be to use Shahar Havivi's multi-keyboard support patch[1] from March, but until

[Qemu-devel] [PATCH] un-register kbd driver in case of USB kbd unplug.

2010-06-08 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com If a USB keyboard is unplugged, the keyboard eventhandler is never removed, and events will continue to be passed through to the device, causing crashes or memory corruption. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- console.h|1

[Qemu-devel] [PATCH v2] un-register kbd driver for USB kbd unplug

2010-06-08 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, Kevin pointed out the TODO comment was obsolete and also suggested turning the if lines into a switch statement. It seems cleaner, so here is a second version of the patch. This is a fairly simple fix for the problem where the keyboard event

[Qemu-devel] [PATCH] un-register kbd driver in case of USB kbd unplug.

2010-06-08 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com If a USB keyboard is unplugged, the keyboard eventhandler is never removed, and events will continue to be passed through to the device, causing crashes or memory corruption. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- console.h|1

Re: [Qemu-devel] [PATCH 08/16] Move main signal handler setup to os specificfiles.

2010-06-04 Thread Jes Sorensen
On 06/03/10 22:52, Richard Henderson wrote: On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote: --- a/qemu-os-win32.h +++ b/qemu-os-win32.h @@ -41,4 +41,7 @@ int qemu_add_wait_object(HANDLE handle, WaitObjectFunc *func, void *opaque); void qemu_del_wait_object(HANDLE handle,

Re: [Qemu-devel] [PATCH 05/16] Introduce os-posix.c and create os_setup_signal_handling()

2010-06-04 Thread Jes Sorensen
On 06/03/10 22:50, Richard Henderson wrote: On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote: --- a/sysemu.h +++ b/sysemu.h @@ -79,6 +79,9 @@ int qemu_loadvm_state(QEMUFile *f); /* SLIRP */ void do_info_slirp(Monitor *mon); +/* OS specific functions */ +void

Re: [Qemu-devel] [PATCH 12/16] Move chroot handling to OS specific files.

2010-06-04 Thread Jes Sorensen
On 06/03/10 23:02, Richard Henderson wrote: On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote: +static inline void os_change_root(void) {}; You really like the ;, don't you. ;-) LOL now I get it. Yes, ;'s are so pretty ;-) I'll clean it up and send out a new version. Still not sure

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Jes Sorensen
On 06/04/10 10:15, Markus Armbruster wrote: jes.soren...@redhat.com writes: + * Parse OS specific command line options. + * return 0 if option handled, -1 otherwise + */ +int os_parse_cmd_args(const QEMUOption *popt, const char *optarg) +{ +int ret = 0; +switch (popt-index) {

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-04 Thread Jes Sorensen
On 06/04/10 10:21, Markus Armbruster wrote: jes.soren...@redhat.com writes: I have tried to be as careful as I can to not break non Linux support, but as I only have a Linux build environment handy, I would appreciate it if people with other OSes could check that I didn't break anything for

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-04 Thread Jes Sorensen
On 06/04/10 13:54, Markus Armbruster wrote: Jes Sorensen jes.soren...@redhat.com writes: On 06/04/10 10:21, Markus Armbruster wrote: I like moving stuff out of vl.c in general. Your moves of entire functions look like a win to me. I have doubts about spreading the option switch over three

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Jes Sorensen
On 06/04/10 14:04, Markus Armbruster wrote: Jes Sorensen jes.soren...@redhat.com writes: On 06/04/10 10:15, Markus Armbruster wrote: What do you mean? The real ugh! here is that it was created as a typedef. I can change the function to pass in just the index, but I don't know if we

[Qemu-devel] [PATCH 02/17] Create qemu-os-win32.h and move WIN32 specific declarations there

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Create qemu-os-win32.h for WIN32 specific declarations. Move polling handling declaration into this file from sysemu.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-os-win32.h | 43 +++ sysemu.h

[Qemu-devel] [PATCH 07/17] Rename os_setup_signal_handling() to os_setup_early_signal_handling()

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Rename os_setup_signal_handling() to os_setup_early_signal_handling() Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |2 +- os-win32.c |2 +- qemu-os-posix.h |2 +- qemu-os-win32.h |2 +- vl.c

[Qemu-devel] [PATCH 08/17] Move main signal handler setup to os specificfiles.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move main signal handler setup to os specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 27 +++ qemu-os-posix.h |1 + qemu-os-win32.h |3 +++ vl.c| 33

[Qemu-devel] [PATCH 00/17] *** SUBJECT HERE ***

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com *** BLURB HERE *** Jes Sorensen (17): vl.c: Remove double include of netinet/in.h for Solaris Create qemu-os-win32.h and move WIN32 specific declarations there Introduce os-win32.c and move polling functions from vl.c vl.c: Move

[Qemu-devel] [PATCH 10/17] Rename qemu-options.h to qemu-options.def

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Rename qemu-options.h to qemu-options.def as it is not a header file for general use and this leaves space for a proper qemu-options.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- Makefile.objs |4 ++-- vl.c |6 +++--- 2

[Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move daemonize handling from vl.c to OS specific files. Provide dummy stubs for Win32. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 102 os-win32.c |5 +++ qemu

[Qemu-devel] [PATCH 15/17] Make os_change_process_uid and os_change_root os-posix.c local

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com os_change_process_uid() and os_change_root() are now only called from os-posix.c, so no need to keep win32 stubs for them. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |8 qemu-os-posix.h |2 -- qemu-os-win32

[Qemu-devel] [PATCH 16/17] Move line-buffering setup to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move line-buffering setup to OS specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |5 + qemu-os-posix.h |1 + qemu-os-win32.h |2 ++ vl.c|5 + 4 files changed, 9 insertions(+), 4

[Qemu-devel] [PATCH 12/17] Move runas handling from vl.c to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move code to handle runas, ie. change of user id of QEMU process to OS specific files and provide dummy stub for Win32. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 28 qemu-os-posix.h |1

[Qemu-devel] [PATCH 05/17] Introduce os-posix.c and create os_setup_signal_handling()

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Introcuce os-posix.c and move posix specific signal handling there. Add dummy stub for win32. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- Makefile.objs |1 + os-posix.c | 41 + qemu-os

[Qemu-devel] [PATCH 06/17] Move win32 early signal handling setup to os_setup_signal_handling()

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move win32 early signal handling setup to os_setup_signal_handling() Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-win32.c | 29 + vl.c | 30 -- 2 files changed, 29

[Qemu-devel] [PATCH 17/17] Move set_proc_name() to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move handling to change process name to POSIX specific files plus add a better error message to cover the case where the feature isn't supported. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 24

[Qemu-devel] [PATCH 09/17] Move find_datadir to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This moves the win32 and POSIX versions of find_datadir() to OS specific files, and removes some #ifdef clutter from vl.c Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 64 +++ os-win32.c

[Qemu-devel] [PATCH 04/17] vl.c: Move host_main_loop_wait() to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move host_main_loop_wait() to OS specific files. Create qemu-os-posix.h and provide empty inline for the POSIX case. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-win32.c | 43 +++ qemu-os

[Qemu-devel] Re: [PATCH 00/17] *** SUBJECT HERE ***

2010-06-04 Thread Jes Sorensen
On 06/04/10 15:24, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com *** BLURB HERE *** ARGH, someone needs to learn about temp files please ignore this one :(

[Qemu-devel] [PATCH 13/17] Move chroot handling to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move chroot handling to OS specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 19 +++ qemu-os-posix.h |1 + qemu-os-win32.h |1 + vl.c| 18 +- 4 files

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Jes Sorensen
On 06/04/10 16:49, Richard Henderson wrote: On 06/03/2010 11:47 PM, Jes Sorensen wrote: The problem is that it requires qemu-options.h to be included, which isn't included per default for all the files. If I put it into sysemu.h at least it's going to require making every .c file build

[Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Introduce OS specific cmdline argument handling by calling os_parse_cmd_args() at the end of switch() statement. Move option enum to qemu-options.h and have it included from os-posix.c and os-win32.c in addition to vl.c. In addition move SMB argument

[Qemu-devel] [PATCH 03/17] Introduce os-win32.c and move polling functions from vl.c

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This introduces os-win32.c. It is meant to carry win32 specific functions thata are not relevant for all of QEMU as well as win32 versions of various pieces like signal handling etc. Move win32 polling handler helper functions from vl.c to os-win32.c

[Qemu-devel] [PATCH 01/17] vl.c: Remove double include of netinet/in.h for Solaris

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com vl.c: netinet/in.h is already included once above for the Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 417554f..7c4298a 100644 --- a/vl.c +++ b

[Qemu-devel] [PATCH v3 00/17] clean up vl.c code

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, Ok third time lucky ... I hope! This fixes the missing git add on qemu-options.h as building for win32 using mingw (thanks Paolo!). The patches try to clean up the vl.c code by separating out OS specific code into OS specific files. Basically

[Qemu-devel] [PATCH 10/17] Rename qemu-options.h to qemu-options.def

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Rename qemu-options.h to qemu-options.def as it is not a header file for general use and this leaves space for a proper qemu-options.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- Makefile.objs |4 ++-- vl.c |6 +++--- 2

[Qemu-devel] [PATCH 12/17] Move runas handling from vl.c to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move code to handle runas, ie. change of user id of QEMU process to OS specific files and provide dummy stub for Win32. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 28 qemu-os-posix.h |1

[Qemu-devel] [PATCH 07/17] Rename os_setup_signal_handling() to os_setup_early_signal_handling()

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Rename os_setup_signal_handling() to os_setup_early_signal_handling() Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |2 +- os-win32.c |2 +- sysemu.h |2 +- vl.c |2 +- 4 files changed, 4 insertions(+), 4

[Qemu-devel] [PATCH 13/17] Move chroot handling to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move chroot handling to OS specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 19 +++ qemu-os-posix.h |1 + qemu-os-win32.h |1 + vl.c| 18 +- 4 files

[Qemu-devel] [PATCH 09/17] Move find_datadir to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This moves the win32 and POSIX versions of find_datadir() to OS specific files, and removes some #ifdef clutter from vl.c Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 64 +++ os-win32.c

<    3   4   5   6   7   8   9   >