[Qemu-devel] [PATCH 03/17] Introduce os-win32.c and move polling functions from vl.c

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This introduces os-win32.c. It is meant to carry win32 specific functions thata are not relevant for all of QEMU as well as win32 versions of various pieces like signal handling etc. Move win32 polling handler helper functions from vl.c to os-win32.c

[Qemu-devel] [PATCH 16/17] Move line-buffering setup to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move line-buffering setup to OS specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |5 + qemu-os-posix.h |1 + qemu-os-win32.h |2 ++ vl.c|5 + 4 files changed, 9 insertions(+), 4

[Qemu-devel] [PATCH 17/17] Move set_proc_name() to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move handling to change process name to POSIX specific files plus add a better error message to cover the case where the feature isn't supported. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 24

[Qemu-devel] [PATCH 08/17] Move main signal handler setup to os specificfiles.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move main signal handler setup to os specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 27 +++ qemu-os-posix.h |2 ++ qemu-os-win32.h |3 +++ vl.c| 33

[Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move daemonize handling from vl.c to OS specific files. Provide dummy stubs for Win32. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 102 os-win32.c |5 +++ qemu

[Qemu-devel] [PATCH 01/17] vl.c: Remove double include of netinet/in.h for Solaris

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com vl.c: netinet/in.h is already included once above for in the generic POSIX section. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 417554f..7c4298a

[Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Introduce OS specific cmdline argument handling by calling os_parse_cmd_args() at the end of switch() statement. Move option enum to qemu-options.h and have it included from os-posix.c and os-win32.c in addition to vl.c. In addition move SMB argument

[Qemu-devel] [PATCH 02/17] Create qemu-os-win32.h and move WIN32 specific declarations there

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Create qemu-os-win32.h for WIN32 specific declarations. Move polling handling declaration into this file from sysemu.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-os-win32.h | 43 +++ sysemu.h

[Qemu-devel] [PATCH 06/17] Move win32 early signal handling setup to os_setup_signal_handling()

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move win32 early signal handling setup to os_setup_signal_handling() Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-win32.c | 29 + qemu-os-posix.h |2 -- sysemu.h|2 ++ vl.c

[Qemu-devel] [PATCH 15/17] Make os_change_process_uid and os_change_root os-posix.c local

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com os_change_process_uid() and os_change_root() are now only called from os-posix.c, so no need to keep win32 stubs for them. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |8 qemu-os-posix.h |2 -- qemu-os-win32

[Qemu-devel] [PATCH 04/17] vl.c: Move host_main_loop_wait() to OS specific files.

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move host_main_loop_wait() to OS specific files. Create qemu-os-posix.h and provide empty inline for the POSIX case. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-win32.c | 43 +++ qemu-os

[Qemu-devel] [PATCH 01/16] vl.c: Remove double include of netinet/in.h for Solaris

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com vl.c: netinet/in.h is already included once above for the generic non win32 code. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 417554f..7c4298a

[Qemu-devel] [PATCH 03/16] Introduce os-win32.c and move polling functions from vl.c

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This introduces os-win32.c. It is meant to carry win32 specific functions thata are not relevant for all of QEMU as well as win32 versions of various pieces like signal handling etc. Move win32 polling handler helper functions from vl.c to os-win32.c

[Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, I have been working on a set of patches to clean up the vl.c code, by separating out OS specific code into OS specific files. Basically it introduces two header files: qemu-os-win32.h and qemu-os-posix.h as well as os-win32.c and os-posix.c. I have

[Qemu-devel] [PATCH 16/16] Move set_proc_name() to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move handling to change process name to POSIX specific files plus add a better error message to cover the case where the feature isn't supported. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 24

[Qemu-devel] [PATCH 02/16] Create qemu-os-win32.h and move WIN32 specific declarations there

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Create qemu-os-win32.h for WIN32 specific declarations. Move polling handling declaration into this file from sysemu.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-os-win32.h | 43 +++ sysemu.h

[Qemu-devel] [PATCH 05/16] Introduce os-posix.c and create os_setup_signal_handling()

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Introcuce os-posix.c and move posix specific signal handling there. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- Makefile.objs |1 + os-posix.c| 41 + sysemu.h |3 +++ vl.c

[Qemu-devel] [PATCH 04/16] vl.c: Move host_main_loop_wait() to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move host_main_loop_wait() to OS specific files. Create qemu-os-posix.h and provide empty inline for the POSIX case. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-win32.c | 43 +++ qemu-os

[Qemu-devel] [PATCH 06/16] Move win32 early signal handling setup to os_setup_signal_handling()

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move win32 early signal handling setup to os_setup_signal_handling() Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-win32.c | 29 + vl.c | 30 -- 2 files changed, 29

[Qemu-devel] [PATCH 07/16] Rename os_setup_signal_handling() to os_setup_early_signal_handling()

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Rename os_setup_signal_handling() to os_setup_early_signal_handling() Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |2 +- os-win32.c |2 +- sysemu.h |2 +- vl.c |2 +- 4 files changed, 4 insertions(+), 4

[Qemu-devel] [PATCH 09/16] Move find_datadir to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This moves the win32 and POSIX versions of find_datadir() to OS specific files, and removes some #ifdef clutter from vl.c Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 64 +++ os-win32.c

[Qemu-devel] [PATCH 14/16] Make os_change_process_uid and os_change_root os-posix.c local

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com os_change_process_uid() and os_change_root() are now only called from os-posix.c, so no need to keep win32 stubs for them. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |8 qemu-os-posix.h |2 -- qemu-os-win32

[Qemu-devel] [PATCH 11/16] Move runas handling from vl.c to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move code to handle runas, ie. change of user id of QEMU process to OS specific files and provide dummy stub for Win32. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 28 qemu-os-posix.h |1

[Qemu-devel] [PATCH 12/16] Move chroot handling to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move chroot handling to OS specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 19 +++ qemu-os-posix.h |1 + qemu-os-win32.h |1 + vl.c| 18 +- 4 files

[Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Introduce OS specific cmdline argument handling by calling os_parse_cmd_args() at the end of switch() statement. In addition move SMB argument to os-posix.c Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 34

[Qemu-devel] [PATCH 13/16] Move daemonize handling to OS specific files

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move daemonize handling from vl.c to OS specific files. Provide dummy stubs for Win32. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 102 os-win32.c |5 +++ qemu

[Qemu-devel] [PATCH 15/16] Move line-buffering setup to OS specific files.

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Move line-buffering setup to OS specific files. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c |5 + qemu-os-posix.h |1 + qemu-os-win32.h |2 ++ vl.c|5 + 4 files changed, 9 insertions(+), 4

[Qemu-devel] Re: [SeaBIOS] SMBIOS strings

2010-06-02 Thread Jes Sorensen
On 06/01/10 22:26, Sebastian Herbszt wrote: Jes Sorensen wrote: Handle 0x0401, DMI type 4, 32 bytes Processor Information - Socket Designation: CPU 1 + Socket Designation: CPU01 smbios.c got snprintf((char*)start, 6, CPU%2x, cpu_number); It should print CPU 1 instead

Re: [Qemu-devel] Re: [PATCHv2-RFC 0/2] virtio: put last seen used index into ring itself

2010-06-02 Thread Jes Sorensen
On 05/31/10 09:46, Rusty Russell wrote: On Thu, 27 May 2010 05:20:35 am Michael S. Tsirkin wrote: Here's a rewrite of the original patch with a new layout. I haven't tested it yet so no idea how this performs, but I think this addresses the cache bounce issue raised by Avi. Posting for early

Re: [Qemu-devel] Re: [SeaBIOS] SMBIOS strings

2010-06-01 Thread Jes Sorensen
On 06/01/10 07:34, Markus Armbruster wrote: Sebastian Herbszt herb...@gmx.de writes: Gleb Natapov wrote: I don't care much as long as we will not have CPU :. It looks like something that can change after BIOS upgrade, so it is hard to believe Windows will stop working because of this

Re: [Qemu-devel] Re: [PATCH 00/14] Block-related fixes and cleanups

2010-06-01 Thread Jes Sorensen
On 05/31/10 11:19, Gerd Hoffmann wrote: On 05/28/10 15:38, Markus Armbruster wrote: I'm working on cleanly separating block device host and guest parts. I'd like to route all this work through Kevin's block tree. This is just preliminaries. Markus Armbruster (14): blockdev: Belatedly

[Qemu-devel] [Bug 588127] Re: qemu fails to recognize host features SSE4.1, SSE4.2

2010-06-01 Thread Jes Sorensen
Tried this on with two versions of QEMU (0.12.50 out of CVS) and qemu- kvm 0.12.1: QEMU emulator version 0.12.50, Copyright (c) 2003-2008 Fabrice Bellard QEMU PC emulator version 0.12.1 (qemu-kvm-devel), Copyright (c) 2003-2008 Fabrice Bellard model name : Intel(R) Xeon(R) CPU

[Qemu-devel] Re: [SeaBIOS] SMBIOS strings

2010-05-31 Thread Jes Sorensen
On 05/28/10 17:44, Gleb Natapov wrote: On Fri, May 28, 2010 at 05:24:47PM +0200, Jes Sorensen wrote: I guess the Socket Designation in particular might have been done for a reason? It was part of commit cf2affa6de. And was a result of moving to snprintf() instead of direct string

[Qemu-devel] Re: [SeaBIOS] SMBIOS strings

2010-05-31 Thread Jes Sorensen
On 05/29/10 14:49, Sebastian Herbszt wrote: Jes Sorensen wrote: We were looking at the dmidecode output from qemu-kvm pre-seabios and current qemu-kvm and noticed some of the strings have changed. The main problem with this is that certain OSes are quite sensitive to system changes

[Qemu-devel] Re: [PATCHv2-RFC 0/2] virtio: put last seen used index into ring itself

2010-05-31 Thread Jes Sorensen
On 05/30/10 13:22, Michael S. Tsirkin wrote: On Fri, May 28, 2010 at 11:56:54AM +0200, Jes Sorensen wrote: It looks pretty good to me, however one thing I have been thinking of while reading through it: Rather than storing a pointer within the ring struct, pointing into a position within

[Qemu-devel] Re: [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe

2010-05-28 Thread Jes Sorensen
On 05/28/10 10:32, Paolo Bonzini wrote: On 05/27/2010 05:44 PM, Jes Sorensen wrote: Candidate for stable too? It should be safe to apply, but I didn't find any current users where the mask was applied in a way where it was causing problems. Not sure if you want the noise, or apply

[Qemu-devel] Re: [PATCHv2-RFC 0/2] virtio: put last seen used index into ring itself

2010-05-28 Thread Jes Sorensen
On 05/26/10 21:50, Michael S. Tsirkin wrote: Here's a rewrite of the original patch with a new layout. I haven't tested it yet so no idea how this performs, but I think this addresses the cache bounce issue raised by Avi. Posting for early flames/comments. Generally, the Host end of the

[Qemu-devel] [PATCH] vhost_net.c: Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2

2010-05-27 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2 The format statement expects unsigned long on x86_64, but receives unsigned long long, so gcc exits with an error. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw

[Qemu-devel] [PATCH] vhost_net.c: v2 Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2

2010-05-27 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2 The format statement expects unsigned long on x86_64, but receives unsigned long long, so gcc exits with an error. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw

[Qemu-devel] Re: [PATCH] vhost_net.c: v2 Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2

2010-05-27 Thread Jes Sorensen
On 05/27/10 12:44, Michael S. Tsirkin wrote: On Thu, May 27, 2010 at 12:22:29PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2 The format statement expects unsigned long on x86_64

[Qemu-devel] Re: [PATCH] vhost_net.c: v2 Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2

2010-05-27 Thread Jes Sorensen
On 05/27/10 12:53, Michael S. Tsirkin wrote: On Thu, May 27, 2010 at 12:55:49PM +0200, Jes Sorensen wrote: On 05/27/10 12:44, Michael S. Tsirkin wrote: I think this part of 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2 should just be reverted. We have unsigned long, it should be printed woith %ll

[Qemu-devel] Re: [PATCH] vhost_net.c: v2 Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2

2010-05-27 Thread Jes Sorensen
On 05/27/10 12:54, Michael S. Tsirkin wrote: On Thu, May 27, 2010 at 12:55:49PM +0200, Jes Sorensen wrote: On 05/27/10 12:44, Michael S. Tsirkin wrote: On Thu, May 27, 2010 at 12:22:29PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Fix build failure

[Qemu-devel] [PATCH] vhost_net.c: v2 Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2

2010-05-27 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2 The format statement expects unsigned long on x86_64, but receives unsigned long long, so gcc exits with an error. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw

[Qemu-devel] [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe

2010-05-27 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com C defaults to int, so make definition of BDRV_SECTOR_SIZE 64 bit safe as it and BDRV_SECTOR_MASK may be used against 64 bit addresses. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- block.h |2 +- 1 files changed, 1 insertions(+), 1

[Qemu-devel] [PATCH 0/4] Cleanups for block code

2010-05-27 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, Reading through some of the blk code, I noticed a lot of cases where we mix and match between hard-coded values for the block size of 512 and using BDRV_SECTOR_SIZE. Trying to clean it up a bit and change the 512 constants to BDRV_SECTOR_SIZE

[Qemu-devel] [PATCH 2/4] Cleanup: Be consistent and use BDRV_SECTOR_SIZE instead of 512

2010-05-27 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Clean up block.c and use BDRV_SECTOR_SIZE rather than hard coded numbers (512) when referring to sector size throughout the code. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- block.c | 13 +++-- 1 files changed, 7 insertions(+), 6

[Qemu-devel] [PATCH 1/4] Cleanup: bdrv_open() no need to shift total_size just to shift back.

2010-05-27 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com In bdrv_open() there is no need to shift total_size 9 just to multiply it by 512 again just a few lines later, since this is the only place the variable is used. Mask with BDRV_SECTOR_MASK to protect against case where we are passed a corrupted image

[Qemu-devel] [PATCH 4/4] Cleanup: virtio-blk.c: Be more consistent using BDRV_SECTOR_SIZE instead

2010-05-27 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Clean up virtio-blk.c to be more consistent using BDRV_SECTOR_SIZE instead of hard coded 512 values. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/virtio-blk.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 3/4] Cleanup: raw-posix.c: Be more consistent using BDRV_SECTOR_SIZE instead of 512

2010-05-27 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Clean up raw-posix.c to be more consistent using BDRV_SECTOR_SIZE instead of hard coded 512 values. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- block/raw-posix.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions

[Qemu-devel] Re: [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe

2010-05-27 Thread Jes Sorensen
On 05/27/10 17:38, Paolo Bonzini wrote: On 05/27/2010 04:27 PM, Kevin Wolf wrote: Am 27.05.2010 15:46, schrieb jes.soren...@redhat.com: From: Jes Sorensenjes.soren...@redhat.com C defaults to int, so make definition of BDRV_SECTOR_SIZE 64 bit safe as it and BDRV_SECTOR_MASK may be used

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-20 Thread Jes Sorensen
On 05/19/10 02:58, Natalia Portillo wrote: Hi, - We'll try to migrate as many confirmable bugs from the Source Forge tracker to Launchpad. I think that part of the bug day should also include retesting OSes that appear in OS Support List as having bug and confirming if the bug is still

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-20 Thread Jes Sorensen
On 05/19/10 15:34, Anthony Liguori wrote: On 05/19/2010 12:04 AM, Aurelien Jarno wrote: The idea is nice, but would it be possible to hold this on a week-end, I personally won't be able to attend such thing on a day week. Or maybe holding that on two days: friday and saturday so that people

[Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com We seem to get into the discussion of what is the correct default setting disk images in QEMU. The libvirt team is reluctant to change specified for newly created images without the default setting matching it, and everybody seems to agree

[Qemu-devel] [PATCH] QEMU: Change default disk caching to nocache

2010-05-20 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Change default disk image caching to nocache (O_DIRECT). However in case it fails (ramfs, NFS etc.). fall back and retry with write-back. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c | 25 +++-- 1 files changed, 19

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Jes Sorensen
On 05/20/10 14:30, Anthony Liguori wrote: On 05/20/2010 04:32 AM, jes.soren...@redhat.com wrote: Therefore, here is a patch that does two things: - default to nocache - in case of failure with nocache, retry with write-back This sort of change requires performance data in a variety

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Jes Sorensen
On 05/20/10 15:40, Anthony Liguori wrote: On 05/20/2010 08:36 AM, Jes Sorensen wrote: And I strongly suspect that such a blanket change would be wrong but that a more targeted change like making cache=none default for physical devices would satisfy mostly everyone. Is there any other

Re: [Qemu-devel] [PATCH] virtio-blk: Avoid zeroing every request structure

2010-05-18 Thread Jes Sorensen
benchmarks using a ramdisk passed to the guest as a virtio device and with this patch I saw improvements ranging from 5-20%. I believe the fluctuations are due to not being able to numa bind it due to limited memory. However a win all the way round! Acked-by: Jes Sorensen jes.soren...@redhat.com Jes

[Qemu-devel] Re: [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-17 Thread Jes Sorensen
On 05/14/10 15:21, Anthony Liguori wrote: On 05/13/2010 03:32 AM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com Add -version-simple argument for QEMU, printing just the version number, without any supporting text. I'm not a huge fan of the name. It was the

[Qemu-devel] [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-13 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Add -version-simple argument for QEMU, printing just the version number, without any supporting text. This makes it simpler for other apps, such as libvirt, to parse the version string from QEMU independant of how the naming string may change. Signed

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-13 Thread Jes Sorensen
On 05/12/10 22:48, Cole Robinson wrote: I agree libvirt's method is a crappy approach. Adding a proper -version argument is certainly the way forward, but doesn't help users with existing libvirt installations that want to use latest qemu. This is the type of issue that libvirt devs will be

[Qemu-devel] [PATCH] Add -version-simple argument to QEMU

2010-05-13 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, I ran into a problem with the version string in QEMU changing, confusing libvirt to not accept the output from qemu -help. Rather than trying to change QEMU or continue to adapt apps when this change, I believe it's a better solution to add

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-13 Thread Jes Sorensen
On 05/13/10 15:04, Cole Robinson wrote: On 05/13/2010 04:35 AM, Jes Sorensen wrote: On 05/12/10 22:48, Cole Robinson wrote: I think rather than 1, it would be better to add a patch to libvirt to catch both formats. I know Chris Lalancette already cooked up a patch for this. Combined

Re: [Qemu-devel] [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-13 Thread Jes Sorensen
On 05/13/10 15:33, Daniel P. Berrange wrote: This omits the KVM version string which is something we also want to see. It would also be nice to avoid having to parse the -help output to determine ARGV supported too. I wonder if it would be a good idea to just produce a well structured

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-12 Thread Jes Sorensen
On 05/12/10 22:29, Cole Robinson wrote: Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version string from: QEMU PC Emulator version x.yy.z to QEMU Emulator version x.yy.z libvirt is overly sensitive to the format of this string, and barfs when trying to parse qemu

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Jes Sorensen
On 05/11/10 15:53, Luiz Capitulino wrote: On Tue, 11 May 2010 15:50:32 +0200 Alexander Graf ag...@suse.de wrote: Luiz Capitulino wrote: On Mon, 10 May 2010 08:02:50 -0700 Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. -

[Qemu-devel] Re: [SeaBIOS] About cpu_set, CPU hotplug and related subjects

2010-04-28 Thread Jes Sorensen
On 04/22/10 03:12, Kevin O'Connor wrote: As I understand it, the hotplug support was only in the kvm copy of bochs bios. It also limited the number of cpus one could use (I think 16). The current smp support in SeaBIOS doesn't limit the number of cpus. So, there has been reluctance to

[Qemu-devel] Re: [SeaBIOS] About cpu_set, CPU hotplug and related subjects

2010-04-28 Thread Jes Sorensen
On 04/28/10 12:30, Gleb Natapov wrote: On Wed, Apr 28, 2010 at 11:31:00AM +0200, Jes Sorensen wrote: On 04/22/10 03:12, Kevin O'Connor wrote: Generating the more complex tables dynamically would be preferred, but it requires like half an AML compiler in Seabios, so it kinda stalled

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-23 Thread Jes Sorensen
On 04/22/10 20:47, Anthony Liguori wrote: On 04/12/2010 07:23 AM, Jamie Lokier wrote: Some simple but versatile hook ideas: -emulator-append-option (no space splitting, one option, appended) -emulator-append-options (space splitting multiple options) -emulator-prepend-option

[Qemu-devel] Linux Plumbers Conference 2010 - call for tracks

2010-04-23 Thread Jes Sorensen
Hi, I am organizing a Virtualization track at LPC 2010 (Linux Plumbers Conference 2010). Please see the official call for tracks below. LPC is particular well suited for work in progress and subjects that needs discussion and collaboration between communities, for example between KVM/QEMU and

Re: [Qemu-devel] Re: KVM call agenda for Mar 23

2010-03-25 Thread Jes Sorensen
On 03/25/10 10:39, Jan Kiszka wrote: Zhang, Xiantao wrote: For ia64 part, maybe we can keep the current qemu-kvm.git for the users. And it is not a must to push it into Qemu upstream. Xiantao Does it still build work? Does someone test it at least infrequently? Or are there users? There

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Jes Sorensen
On 03/22/10 22:53, Anthony Liguori wrote: On 03/22/2010 04:33 PM, Gerd Hoffmann wrote: libvirt is very unfriendly to qemu hackers. There is no easy way to add command line switches. There is no easy way to get access to the monitor. I can get it done by pointing emulator to a wrapper script and

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Jes Sorensen
On 03/23/10 11:25, Gerd Hoffmann wrote: On 03/23/10 09:54, Jes Sorensen wrote: One problem I have found, and I am not sure how to fix this in this context. Sometimes when hacking on qemu, I want to try out a new qemu binary on an existing image, without replacing the system wide one and may

Re: [Qemu-devel] Re: KVM call agenda for Mar 23

2010-03-23 Thread Jes Sorensen
On 03/23/10 13:45, Anthony Liguori wrote: I don't think we can pull in: - extboot - ia64 - in-kernel pit[1] - associated command line options - device passthrough The question is, if we dropped those things, would people actually use qemu.git instead of qemu-kvm.git. If the answer is no, what

Re: [Qemu-devel] Summer of Code 2010

2010-03-10 Thread Jes Sorensen
On 03/09/10 16:56, Alexander Graf wrote: On 09.03.2010, at 16:50, Natalia Portillo wrote: Qemu towards what xnu expects -- that's what I called Mac's memory space. Of course is not only memory, the SMU, TPM module, anything it will search for without hacking. (If you need testing comment

[Qemu-devel] [PATCH] QEMU-KVM missing bits for E820 handling.

2010-03-09 Thread Jes Sorensen
Hi, This is the last piece needed for QEMU-KVM to match the changes that went into upstream QEMU. Cheers, Jes Use qemu-cfg to provide the BIOS with an optional table of e820 entries. The missing bits for qemu-kvm.git to match what qemu does. Signed-off-by: Jes Sorensen jes.soren...@redhat.com

Re: [Qemu-devel] [PATCH] QEMU e820 reservation patch

2010-02-21 Thread Jes Sorensen
On 02/19/10 22:02, Anthony Liguori wrote: Acked-by: Anthony Liguori aligu...@us.ibm.com Would be nice to use git-send-email in the future as your attachments are often rendered poorly by mail clients. Just switching over from quilt to git, and still having issues with git-send-email. It does

[Qemu-devel] [PATCH] QEMU kill CR3_CACHE references

2010-02-18 Thread Jes Sorensen
Hi, The CR3 caching was never implemented in QEMU and is obsoleted by NPT/EPT. This patch removes the unused references to it from target-i386/kvm.c. Cheers, Jes commit 5ed16687929511d015dd3542c4359cabe170401a Author: Jes Sorensen jes.soren...@redhat.com Date: Fri Feb 19 07:39:56 2010 +0100

[Qemu-devel] [PATCH] Seabios e820 reservation portion v3

2010-02-16 Thread Jes Sorensen
On 02/16/10 01:43, Kevin O'Connor wrote: On Mon, Feb 15, 2010 at 06:33:59PM +0100, Jes Sorensen wrote: Hi, This is the Seabios part to match my e820 reservation via fw_cfg patch. This still has 'struct e820_entry' which is too similar to 'struct e820entry' in memmap.h. Otherwise, it looks

[Qemu-devel] Re: [PATCH] QEMU e820 reservation patch

2010-02-16 Thread Jes Sorensen
On 02/15/10 19:54, Stefano Stabellini wrote: On Mon, 15 Feb 2010, Jes Sorensen wrote: Kevin and I have agreed on the approach for this one now. So here is the latest version of the patch for QEMU, submitting e820 reservation entries via fw_cfg. I think the interface is fine

[Qemu-devel] [PATCH] QEMU e820 reservation patch

2010-02-15 Thread Jes Sorensen
+EPT range to by reserving it via the e820 table. This matches a corresponding patch for Seabios, however older versions of Seabios will default to the hardcoded address range and stay compatible with current QEMU. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/pc.c | 35

[Qemu-devel] [PATCH] Seabios e820 reservation portion

2010-02-15 Thread Jes Sorensen
. For now, fall back to the old hard coded values for the TSS and EPT switch page for compatibility reasons. Compatibility code could possibly be removed in the future. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- src/paravirt.c | 17 + src/paravirt.h |9

[Qemu-devel] Re: [PATCH] Seabios - read e820 table from qemu_cfg

2010-02-08 Thread Jes Sorensen
. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- src/paravirt.c | 17 + src/paravirt.h |9 + src/post.c | 13 - 3 files changed, 38 insertions(+), 1 deletion(-) Index: seabios/src/paravirt.c

Re: [Qemu-devel] The new qemu.org

2010-02-03 Thread Jes Sorensen
On 02/02/10 17:22, G 3 wrote: The new site looks nice. When is the Mac OS X section under Compilation from the sources going to be updated from the lame The Mac OS X patches are not fully merged in QEMU, so you should look at the QEMU mailing list archive to have all the necessary information..

[Qemu-devel] Re: [PATCH] Seabios - read e820 table from qemu_cfg

2010-01-29 Thread Jes Sorensen
On 01/28/10 05:39, Kevin O'Connor wrote: I think defining accessor functions for every piece of data passed through qemu-cfg interface is going to get tiring. I'd prefer to extend the existing qemu-cfg file interface for new content. For example, add a helper with something like: int

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-26 Thread Jes Sorensen
On 01/26/10 07:46, Gleb Natapov wrote: On Mon, Jan 25, 2010 at 06:13:35PM +0100, Jes Sorensen wrote: I am fine with having QEMU build the e820 tables completely if there is a consensus to take that path. QEMU can't build the e820 map completely. There are things it doesn't know. Like how much

[Qemu-devel] [PATCH] Seabios - read e820 table from qemu_cfg

2010-01-26 Thread Jes Sorensen
the location of KVM's switch area etc. rather than rely on hard coded values. For now, fall back to the old hard coded values for the TSS and EPT switch page for compatibility reasons. Compatibility code could possibly be removed in the future. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- src

[Qemu-devel] [PATCH] QEMU-KVM - provide e820 table via fw_cfg

2010-01-26 Thread Jes Sorensen
the e820 table. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw/pc.c | 35 +++ hw/pc.h |9 + qemu-kvm-x86.c|7 +++ target-i386/kvm.c |7 +++ 4 files changed, 58 insertions(+) Index: qemu-kvm/hw/pc.c

[Qemu-devel] [PATCH] Seabios - read e820 reserve from qemu_cfg

2010-01-25 Thread Jes Sorensen
qemu-cfg Read location of KVM's switch area (VMX TSS pages and EPT) from QEMU via qemu-cfg instead of relying on hard coded values. For now, fall back to the old hard coded values for compatibility reasons. Compatibility code can be removed in the future. Signed-off-by: Jes Sorensen jes.soren

[Qemu-devel] [PATCH] QEMU-KVM - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
Hi, This is the QEMU-KVM bits for providing the e820-reserve space through qemu-cfg. Cheers, Jes Use qemu-cfg to notify the BIOS of the location of the TSS range to reserve in the e820 table, to avoid relying on hard coded values. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw

[Qemu-devel] [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
Hi, This is the QEMU patch for providing the e820-reserve space through qemu-cfg. Cheers, Jes Use qemu-cfg to notify the BIOS of the location of the TSS range to reserve in the e820 table, to avoid relying on hard coded values. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hw

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
On 01/25/10 17:58, Alexander Graf wrote: Howdy. Congratulations to the new mail address - looks neat ;-). :-) Two comments: 1) I don't see how passing a single region is any help. I'd rather like to see a device tree like table structure You'd get one variable for len of the table, one

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
On 01/25/10 18:28, Alexander Graf wrote: That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way qemu generates all of the e820 tables and we can declare whatever we want. Just add a type field in the

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
On 01/25/10 21:14, Anthony Liguori wrote: On 01/25/2010 02:04 PM, Alexander Graf wrote: Yes, sounds good. Should be fairly extensible then. What about memory holes? Do we need to take care of them? It would be nice for QEMU to be able to add additional e820 regions that don't necessarily fit

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
On 01/25/10 22:08, Alexander Graf wrote: On 25.01.2010, at 22:05, Jes Sorensen wrote: Only problem is that we don't really have a way to pass back info saying 'you messed up trying to pinch an area that the BIOS wants for itself'. Eh - the BIOS shouldn't even try to use regions

<    4   5   6   7   8   9