Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> All we do with the value of RDMAContext member @error_state is test
> whether it's zero. Change to bool and rename to @errored.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> This is just to make the error value more obvious. Callers don't
> mind.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
des, leaving readers
> confused on what the function actually returns.
>
> Clean up and simplify: return -1 instead of negative errno code.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
* hook_ram_load:
>
> Negative value means error. rdma_load_hook() already returns -1 on
> error. Leave it alone.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Changed idea. Will include this and rebase mines on top.
des, leaving readers
> confused on what the function actually returns.
>
> Clean up and simplify: return -1 instead of negative errno code.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> @error_reported and @received_error are flags. The latter is even
> assigned bool true. Change them from int to bool.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
on-zero
> value as failure. Also change them to return -1 instead of the value
> received from getaddrinfo() on failure, to avoid positive error
> values.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> The QEMUFileHooks methods don't come with a written contract. Digging
> through the code calling them, we find:
>
> * save_page():
>
> Negative values RAM_SAVE_CONTROL_DELAYED and
> RAM_SAVE_CONTROL_NOT_SUPP are special. Any other negative value is
> an
en its own call of
> rdma_get_cm_event() fails. Make the error handling more obvious: set
> a specific error right after rdma_get_cm_event() fails. Delete the
> generic error.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Peter Xu
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> qemu_rdma_data_init() neglects to set an Error when it fails because
> @host_port is null. Fortunately, no caller passes null, so this is
> merely a latent bug. Drop the flawed code handling null argument.
>
> Signed-off-by: Markus Armbruster
Re
Markus Armbruster wrote:
> Hiding return statements in macros is a bad idea. Use a function
> instead, and open code the return part.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
I hated this macro, thanks.
neglects to set an Error when
> ibv_open_device() fails. If a later address fails differently, we use
> that Error instead, or else the generic one. Harmless enough, but
> needs fixing all the same.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewe
y from the definition.
>
> I elected not to investigate how callers are impacted.
>
> Expand the two bad macro uses, so we can set an error and return -1.
> The next commit will then get rid of the macro altogether.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
uman-readable errno
> information (which a number is not) can be useful, reporting an
> error code that may or may not be an errno value is useless.
>
> Drop these error codes from the error messages.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
>
Markus Armbruster wrote:
> qemu_rdma_buffer_mergeable() is semantically a predicate. It returns
> int 0 or 1. Return bool instead, and fix the function name's
> spelling.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> qemu_rdma_search_ram_block() can't fail. Return void, and drop the
> unreachable error handling.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> rdma_add_block() can't fail. Return void, and drop the unreachable
> error handling.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> When all we do with an Error we receive into a local variable is
> propagating to somewhere else, we can just as well receive it there
> right away.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijia
conform. Clean it up.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
e there, make qio_channel_rdma_readv() and
> qio_channel_rdma_writev() more consistent: change the former's @done
> to ssize_t, and delete the latter's useless initialization of @len.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
Reviewed-by: Juan Quintela
y, but needs fixing all the
> same.
>
> Fixes: 6ddd2d76ca6f (migration: convert RDMA to use QIOChannel interface)
> Signed-off-by: Markus Armbruster
Reviewed-by: Juan Quintela
gative enumeration constants.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
rkus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> rdma_delete_block() always returns 0, which its only caller ignores.
> Return void instead.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
abiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
queued
by: Markus Armbruster
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Li Zhijian
Reviewed-by: Juan Quintela
queued.
Fabiano Rosas wrote:
> Juan Quintela writes:
>
>> Fabiano Rosas wrote:
>>> Juan Quintela writes:
>>>
>>>> From: Steve Sistare
>>>>
>>>> Extend the migration URI to support file:. This can be used for
>>>> any
Fabiano Rosas wrote:
> Based-on:
> [PATCH V4 0/2] migration file URI
> https://lore.kernel.org/r/1688135108-316997-1-git-send-email-steven.sist...@oracle.com
Full series are integrated for next PULL request.
Thanks, Juan.
>
> Since v4:
>
> - Implemented a separate version of
d the 'events'
> capability. Having the capability enabled is sufficient to continue to
> receive the event.
>
> Reviewed-by: Peter Xu
> Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
r, similarly to migrate_qmp.
>
> Also make sure migration events are enabled and wait for the incoming
> migration to start before returning. This avoid a race when querying
> the migration status too soon after issuing the command.
>
> Reviewed-by: Peter Xu
> Signed-off-by: Fabiano R
54981c-e8ae-c676-3b04-eeb030e11...@tls.msk.ru/
> [4]
> https://lore.kernel.org/qemu-devel/20230301142926.18686-1-yuval.shaia...@gmail.com/
> [5] https://lore.kernel.org/qemu-devel/8734z9f086@pond.sub.org/
>
> Signed-off-by: Thomas Huth
Acked-by: Juan Quintela
Peter Xu wrote:
> Add a test for StrOrNull parameters (tls-*).
>
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
queued
;migration: add support for a "tls-authz" migration
> parameter")
> Reviewed-by: Daniel P. Berrangé
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
queued.
Fabiano Rosas wrote:
> Juan Quintela writes:
>
>> From: Steve Sistare
>>
>> Extend the migration URI to support file:. This can be used for
>> any migration scenario that does not require a reverse path. It can be
>> used as an alternative to 'exec
Juan Quintela wrote:
> Tejus GK wrote:
>> On 04/10/23 1:53 pm, Juan Quintela wrote:
>>> Tejus GK wrote:
>>>> On 03/10/23 6:14 pm, Juan Quintela wrote:
> Ouch, that again.
>
> I think that I know how to fix that.
>
> Will take a look.
>
> L
Helper to say if we are doing a migration over rdma.
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
migration/migration.h | 2 ++
migration/options.h | 1 +
migration/migration.c | 1 +
migration/options.c | 7 +++
migration/rdma.c | 4 +++-
5 files changed, 14 insertions
Instead of going trhough ram_control_load_hook(), call
qemu_rdma_registration_handle() directly.
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 1 -
migration/rdma.h | 3 +++
migration/ram.c | 5 -
migration/rdma.c | 12 +++-
4
Functions are long enough even without this.
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
migration/rdma.h | 12 ++--
migration/ram.c| 14 +++---
migration/rdma.c | 40 +++-
migration/trace-events | 28
files.
Please, review.
Thanks, Juan.
Juan Quintela (10):
migration: Create migrate_rdma()
migration/rdma: Unfold ram_control_before_iterate()
migration/rdma: Unfold ram_control_after_iterate()
migration/rdma: Remove all uses of RAM_CONTROL_HOOK
migration/rdma: Unfold hook_ram_load
Once there:
- Remove unused data parameter
- unfold it in its callers.
- change all callers to call qemu_rdma_registration_start()
- We need to call QIO_CHANNEL_RDMA() after we check for migrate_rdma()
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
--
initilazize rioc after checknig
The only user was rdma, and its use is gone.
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 4
migration/qemu-file.c | 6 --
migration/rdma.c | 9 -
3 files changed, 19 deletions(-)
diff --git a/migration/qemu-file.h b/migration/qemu
Once there:
- Remove unused data parameter
- unfold it in its callers
- change all callers to call qemu_rdma_registration_stop()
- We need to call QIO_CHANNEL_RDMA() after we check for migrate_rdma()
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
This function has goto's. So I don't
There is only one flag called with: RAM_CONTROL_BLOCK_REG.
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 11 ---
migration/rdma.h | 3 +++
migration/qemu-file.c | 10 --
migration/ram.c | 6 --
migration/rdma.c | 34
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
migration/rdma.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index c73e610416..62293ab1d6 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -3253,10 +3253,6 @@ static
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 17 -
migration/rdma.h | 16
migration/ram.c | 2 +-
3 files changed, 17 insertions(+), 18 deletions(-)
diff --git a/migration/qemu-file.h b/migration/qemu-file.h
index
The only user of ram_control_save_page() and save_page() hook was
rdma. Just move the function to rdma.c, rename it to
rdma_control_save_page().
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 12
migration/rdma.h | 10 ++
migration/qemu
Tejus GK wrote:
> On 04/10/23 1:53 pm, Juan Quintela wrote:
>> Tejus GK wrote:
>>> On 03/10/23 6:14 pm, Juan Quintela wrote:
>>>> Tejus GK wrote:
>>>>> A few code paths exist in the source code,where a migration is
>>>>> marked as
From: Daniil Tatianin
So that we have less magic numbers to deal with. This also allows us to
reuse these in the following commits.
Reviewed-by: Peter Xu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Juan Quintela
Signed-off-by: Daniil Tatianin
Signed-off-by: Juan Quintela
Message
still has
the bandwidth.
Cc: Daniel P. Berrangé
Cc: Juan Quintela
Cc: Markus Armbruster
Cc: Zhijian Li (Fujitsu)
Cc: Fabiano Rosas
Acked-by: Li Zhijian
Reviewed-by: Juan Quintela
Signed-off-by: Peter Xu
Signed-off-by: Juan Quintela
Message-ID: <20230925133441.265455-1-pet...@redhat.
The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0:
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging
(2023-10-03 07:43:44 -0400)
are available in the Git repository at:
https://gitlab.com/juan.quintela/qemu.git
nspecified, it defaults
to 0.
This is needed by libvirt to store its own data at the head of the file.
Suggested-by: Daniel P. Berrange
Reviewed-by: Peter Xu
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Signed-off-by: Steve Sistare
Signed-off-by: Juan Quintela
Message-ID: <169
/qemu/-/issues/932
Reviewed-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Peter Xu
Signed-off-by: Juan Quintela
Message-ID: <20230906204722.514474-1-pet...@redhat.com>
---
migration/vmstate.c| 34 ++
migration/trace-events | 1 +
2
eviewed-by: Peter Xu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20230919102346.2117963-3-d-tatia...@yandex-team.ru>
---
tests/migration/i386/a-b-bootblock.h | 16
tests/migration/i386/a-b-bootblock.S | 9
-x86_64: Unknown control message QEMU FILE
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
Signed-off-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20230926100103.201564-2-lizhij...@fujitsu.com>
---
migration/rdma.c | 2 +-
1 file changed, 1 ins
axy
Reviewed-by: Michael Galaxy
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <1694182931-61390-2-git-send-email-steven.sist...@oracle.com>
---
migration/file.h | 14 +
description, and hence
clients like libvirt never know the actual reason for the failure.
This patch covers such cases outside of migration.c and updates the
error description at the appropriate places.
Acked-by: Peter Xu
Reviewed-by: Juan Quintela
Signed-off-by: Tejus GK
Signed-off-by: Juan Quintela
ation: Enable the migration test on s390x, too")
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
Signed-off-by: Daniil Tatianin
Signed-off-by: Juan Quintela
Message-ID: <20230919102346.2117963-4-d-tatia...@yandex-team.ru>
---
tests/mig
due
to some dependencies for unit tests. Hence, this patch introduces a new
function vmstate_save_state_with_err, which will eventually propagate
the error message to savevm.c where a migrate_set_error call can be
eventually done.
Acked-by: Peter Xu
Reviewed-by: Juan Quintela
Signed-off-by: Tejus
From: Peter Xu
Per the qemu upstream call a few hours ago, proposing Fabiano and myself as
the co-maintainer for migration subsystem to help Juan.
Cc: Fabiano Rosas
Cc: Juan Quintela
Acked-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Peter
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
queued.
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
debugging things like:
>
> https://gitlab.com/qemu-project/qemu/-/issues/932
>
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
queued.
ile starting at offset. If unspecified, it defaults
> to 0.
>
> This is needed by libvirt to store its own data at the head of the file.
>
> Suggested-by: Daniel P. Berrange
> Signed-off-by: Steve Sistare
> Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
queued.
h series.
>
> Signed-off-by: Steve Sistare
> Tested-by: Michael Galaxy
> Reviewed-by: Michael Galaxy
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
queued.
Fabiano Rosas wrote:
> Daniel P. Berrangé writes:
>
>> On Tue, Oct 03, 2023 at 05:24:50PM +0200, Philippe Mathieu-Daudé wrote:
[...]
>> $ cat myqemu.dkr
>> FROM fedora:38
>>
>> RUN dnf -y install qemu-kvm
>>
>> $ podman build -f myqemu.dkr --tag myqemu .
>>
>> $ cat > myqemu <> #!/bin/sh
>>
5571dc824b ("tests/migration: Enable the migration test on s390x, too")
> Signed-off-by: Daniil Tatianin
Reviewed-by: Juan Quintela
queued.
zeroing the first byte of each page in the range so
> that we get consistent results no matter the initial contents.
>
> Fixes: ea0c6d62391 ("test: Postcopy")
> Signed-off-by: Daniil Tatianin
> Reviewed-by: Peter Xu
> ---
Reviewed-by: Juan Quintela
queued.
Daniil Tatianin wrote:
> So that we have less magic numbers to deal with. This also allows us to
> reuse these in the following commits.
>
> Signed-off-by: Daniil Tatianin
> Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
queued.
Tejus GK wrote:
> On 03/10/23 6:14 pm, Juan Quintela wrote:
>> Tejus GK wrote:
>>> A few code paths exist in the source code,where a migration is
>>> marked as failed via MIGRATION_STATUS_FAILED, but the failure happens
>>> outside of migration.c
>&g
Peter Xu wrote:
> On Tue, Sep 26, 2023 at 06:01:02PM +0800, Li Zhijian wrote:
>> Migration over RDMA failed since
>> commit: 294e5a4034 ("multifd: Only flush once each full round of memory")
>> with erors:
>> qemu-system-x86_64: rdma: Too many requests in this message
>> (3638950032).Bailing.
>>
h_section;
> }
>
> bool migrate_postcopy(void)
But I think this is ugly.
migrate_multifd_flush_after_each_section()
returnls true
with multifd not enabled?
And we are creating a "function" that just reads a property now does
something else.
What about this?
I know that the
ch, error will become:
> qemu-system-x86_64: Unknown control message QEMU FILE
>
> Reviewed-by: Fabiano Rosas
> Reviewed-by: Peter Xu
> Signed-off-by: Li Zhijian
Reviewed-by: Juan Quintela
queued.
Peter Xu wrote:
> Per the qemu upstream call a few hours ago, proposing Fabiano and myself as
> the co-maintainer for migration subsystem to help Juan.
>
> Cc: Fabiano Rosas
> Cc: Juan Quintela
> Signed-off-by: Peter Xu
> ---
>
> Fabiano, would you please ack her
hich
>> > already covers the rdma files) to be clear on that, meanwhile add Zhijian
>> > as Reviewer, so Zhijian can see the patches and review when he still has
>> > the bandwidth.
>> >
>> > Cc: Daniel P. Berrangé
>> > Cc: Juan Quintela
>> &g
Peter Xu
> Signed-off-by: Tejus GK
Reviewed-by: Juan Quintela
Queued.
But I wonder.
> index 1f65294bf4..60eec7c31f 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -979,6 +979,8 @@ static void save_section_footer(QEMUFile *f,
> SaveStateEntry *se)
> static int
Acked-by: Peter Xu
> Signed-off-by: Tejus GK
Reviewed-by: Juan Quintela
Hi This week we have agenda: * Where are we with the “Single Binary” work.
- still outstanding questions on the whole “startup” subject (related, but
not the same) * the plugin-API to cover ‘icount’ use cases - that seems to
be nudging open a pandora’s box * Migration issues - community
So no need to assert we are in x86_64.
Once there, refactor the function to remove useless variables.
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-11-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 5 +
1 file changed, 1 insertion
Just create a variable for it, the same way that multifd does. This
way it is safe to use for other thread, etc, etc.
Reviewed-by: Leonardo Bras
Signed-off-by: Juan Quintela
Message-Id: <20230515195709.63843-11-quint...@redhat.com>
---
migration/migration-stats.h | 4
mig
We only care about the amount of bytes transferred. Flushing is done
by the system somewhere else.
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20230530183941.7223-4-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
migration/block.c | 4 ++--
1 file chan
, but this needs to be done some other way.
Reviewed-by: Leonardo Bras
Signed-off-by: Juan Quintela
Message-Id: <20230515195709.63843-16-quint...@redhat.com>
---
migration/qemu-file.h | 14 ++
migration/qemu-file.c | 12 ++--
migration/ram.c | 10 +++---
mig
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-4-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 3346
:
- Refactor repeated call of yank_unregister_instance (tejus)
- More migraton-test changes
Please, apply.
Juan Quintela (12):
migration-test: Create kvm_opts
migration-test: bootpath is the same for all tests and for all archs
migration
Remove the one in control_save_page().
Reviewed-by: Leonardo Bras
Signed-off-by: Juan Quintela
Message-Id: <20230515195709.63843-12-quint...@redhat.com>
---
migration/ram.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 9040d66e61..f2c5
Signed-off-by: Juan Quintela
Message-Id: <20230515195709.63843-14-quint...@redhat.com>
---
migration/qemu-file.c | 5 +
migration/ram.c | 1 -
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 19c33c9985..e
The bootsector code is read only from the guest (otherwise we are
going to have problems with it being read from both source and
destination).
Create a single copy for all the tests.
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-10-quint...@redhat.com>
Signed-off-by: Juan Qu
From: Tejus GK
In the function qmp_migrate(), yank_unregister_instance() gets called
twice which isn't required. Hence, refactoring it so that it gets called
during the local_error cleanup.
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Acked-by: Peter Xu
Signed-off-by: Tejus GK
Reviewed-by: Leonardo Bras
Signed-off-by: Juan Quintela
Message-Id: <20230515195709.63843-13-quint...@redhat.com>
---
migration/rdma.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 2a3c784328..9007
So just make it a global variable.
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-9-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/tests/qtest/migration-
After this change, nothing abuses QEMUFile to account for data
transferrefd during migration.
Reviewed-by: Leonardo Bras
Signed-off-by: Juan Quintela
Message-Id: <20230515195709.63843-15-quint...@redhat.com>
---
migration/qemu-file.h | 8
migration/qemu-file.c | 5 -
2
So arch_dirty_ring option becomes one option like the others.
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-8-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tests
Elena Ufimtseva wrote:
> Hello Juan,
>
> Not sure if this is worth its own topic, would be it possible to hear
> the community thoughts on the live migration series review/pull
> progress (atomics, zero page multifd etc.. )? Seems like there are few
> outstanding relevant patches.
Hi
If
Mark Burton wrote:
> Seems like we’ve had a bit of a ’slower’ time in recent weeks -
> presumably “summer time” - If I understand correctly, Linaro are not
> going toe preset this week?
> Maybe we should re-group in the next meeting,
>
> So I’m happy to have the meeting tomorrow if Linaro can
Juan Quintela wrote:
> Hi
>
> If you have any topics, please add to this email.
You can also update here if you preffer:
https://wiki.qemu.org/QEMUCall#Call_for_agenda_for_2023-09-19
Later, Juan.
> Thanks, Juan.
Hi
If you have any topics, please add to this email.
Thanks, Juan.
Mark Burton wrote:
> Are too many people away right now?
Hi
Some of us are still working O:-)
But I think that the easiest way to cancel it is if nobody puts an
agenda.
Later, Juan.
Hi Do you have any topics for next week QEMU call? You can answer this
email or use the wiki: https://wiki.qemu.org/QEMUCall Thanks, Juan.
QEMU developers fortnightly conference call
Tuesday 2023-08-08 ⋅ 15:00 – 16:00
Central European Time - Madrid
Location
https://meet.jit.si/kvmcallmeeting
701 - 800 of 10827 matches
Mail list logo
