On 03/10/2014 10:52 PM, Paolo Bonzini wrote:
Il 10/03/2014 15:37, Mark Wu ha scritto:
Before spapr_vga_init will returned false if the vga is specified by
the command '-device VGA' because vga_interface_type was evaluated to
VGA_NONE. With the change in previous patch of t
On 03/07/2014 05:43 PM, Paolo Bonzini wrote:
Il 07/03/2014 10:37, Mark Wu ha scritto:
Before spapr_vga_init will returned false if the vga is specified by
the command '-device VGA' because vga_interface_type was evaluated to
VGA_NONE. With the change in previous patch of t
eanups:
1. skip initialization for VGA_NONE
2. remove the useless 'break'
Signed-off-by: Mark Wu
---
hw/ppc/spapr.c | 4 +++-
vl.c | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index bf46c38..5c9a154 100644
--- a/hw/ppc/sp
tch adds a new vga device type to indicate
that it has a vga device, which will be initliazed in qom devices
initialization.
Signed-off-by: Mark Wu
---
Changes:
v2 -> v3:
Change the var name from 'no_defaults' to 'has_defaults' to avoid
initializing statics to 0.
incl
tch adds a new vga device type to indicate
that it has a vga device, which will be initliazed in qom devices
initialization.
Signed-off-by: Mark Wu
---
include/sysemu/sysemu.h | 2 +-
vl.c| 42 ++
2 files changed, 23 insertions(+), 21
in flow of the generic devices initialization.
This patch also makes two cleanups:
1. skip initialization for VGA_NONE
2. remove the useless 'break'
Signed-off-by: Mark Wu
---
hw/ppc/spapr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/
On 03/07/2014 12:09 AM, Paolo Bonzini wrote:
Il 06/03/2014 15:39, Andreas Färber ha scritto:
Am 06.03.2014 15:33, schrieb Paolo Bonzini:
Il 06/03/2014 14:37, Mark Wu ha scritto:
Thanks for your reply! I need confirm I am understanding your comments
correctly. I think you're suggesti
On 02/28/2014 09:03 PM, Paolo Bonzini wrote:
Il 28/02/2014 13:45, Mark Wu ha scritto:
Some machine (like ppc) initialization code determines if it has vga
configured according to vga_interface_type. In the original code,
vga_interface_type is evaluated to VGA_NONE even if a vga is added
by
This patch adds a new vga device type to indicate
that it has a vga device, but the machine code doesn't need to care
about its initialization.
Signed-off-by: Mark Wu
---
include/sysemu/sysemu.h | 2 +-
vl.c| 8 +++-
2 files changed, 8 insertions(+), 2 deletions(-
in flow of the generic devices initialization.
This patch also makes two cleanups:
1. skip initialization for VGA_NONE
2. remove the useless 'break'
Signed-off-by: Mark Wu
---
hw/ppc/spapr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/
n Wed 09 Oct 2013 10:58:04 AM CST, Eric Blake wrote:
On 10/08/2013 08:39 PM, Mark Wu wrote:
In the original code, qmp_get_command_list is used to construct
a list of all commands' name. To get the information of all qga
commands, it traverses the name list and search the command info
with its
ce to traverse the qmp command list by
QmpCommand to replace qmp_get_command_list. It can decrease the
complexity from O(n^2) to O(n).
Signed-off-by: Mark Wu
---
v4:
Add the missing change from cmd->namd to qmp_command_name(cmd)
v3:
Add an accessor for cmd->name to avoid exposing i
On Wed 09 Oct 2013 10:36:21 AM CST, Mark Wu wrote:
In the original code, qmp_get_command_list is used to construct
a list of all commands' name. To get the information of all qga
commands, it traverses the name list and search the command info
with its name. So it can cause O(n^2) in the n
ce to traverse the qmp command list by
QmpCommand to replace qmp_get_command_list. It can decrease the
complexity from O(n^2) to O(n).
Signed-off-by: Mark Wu
---
v3:
Add an accessor for cmd->name to avoid exposing internals of QmpCommand
v2:
1. Keep the signature of qmp_command_is_enab
lexibly.
Signed-off-by: Mark Wu
---
v5:
Fix a tab indent and rebase
v4:
Add signature of qmp_has_success_response per Michael.
v3:
1. treat cmd->options as a bitmask instead of single option (per Eric)
2. rebase on the patch " Add interface to traverse
ce to traverse the qmp command list by
QmpCommand to replace qmp_get_command_list. It can decrease the
complexity from O(n^2) to O(n).
Signed-off-by: Mark Wu
---
v3:
Add an accessor for cmd->name to avoid exposing internals of QmpCommand
v2:
1. Keep the signature of qmp_command_is_enab
lexibly.
Signed-off-by: Mark Wu
---
Changes:
v4:
Add signature of qmp_has_success_response per Michael.
v3:
1. treat cmd->options as a bitmask instead of single option (per Eric)
2. rebase on the patch " Add interface to traverse the qmp command list
by Q
ce to traverse the qmp command list by
QmpCommand to replace qmp_get_command_list. It can decrease the
complexity from O(n^2) to O(n).
Signed-off-by: Mark Wu
---
Changes:
v2:
1. Keep the signature of qmp_command_is_enabled (per Eric and Michael)
2. Remove the unnecessary pointer castings (per
It's verified by the following tests:
1. run ./qemu-ga -b help,
it print a list of qga command names as expected
2. run ./guest-sync -b guest-ping, guest-sync
command 'guest-info' show that guest-ping and guest-sync are disabled
On Thu 26 Sep 2013 09:56:39 AM CST, Mar
lexibly.
Signed-off-by: Mark Wu
---
Changes:
v3:
1. treat cmd->options as a bitmask instead of single option (per Eric)
2. rebase on the patch " Add interface to traverse the qmp command list
by QmpCommand" to avoid the O(n2) problem (per Eric and Michael)
v2:
ce to traverse the qmp command list by
QmpCommand to replace qmp_get_command_list. It can decrease the
complexity from O(n) to O(n^2)
Signed-off-by: Mark Wu
---
include/qapi/qmp/dispatch.h | 3 +-
qapi/qmp-registry.c | 28 ++-
qga/commands.c
Hi guys,
Thanks a lot for all your insightful comments. I will post a patch to
resolve the O(n2) problem according to Michael's comments soon and
rebase the 'success-response' on it.
Mark.
On 09/25/2013 08:34 AM, Luiz Capitulino wrote:
On Tue, 24 Sep 2013 16:07:29 -0500
Michael Roth wrote
e flexibly.
Changes:
v2: add the notation 'since 1.7' to the option 'success-response'
(per Eric Blake's comments)
Signed-off-by: Mark Wu
---
include/qapi/qmp/dispatch.h | 1 +
qapi/qmp-registry.c | 13 +
qga/commands.c
lexibly.
Signed-off-by: Mark Wu
---
include/qapi/qmp/dispatch.h | 1 +
qapi/qmp-registry.c | 13 +
qga/commands.c | 2 ++
qga/qapi-schema.json| 4 +++-
4 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/include/qapi/qmp/dispatch.h b/include
On 03/09/2012 05:00 PM, zwu.ker...@gmail.com wrote:
From: Stefan Hajnoczi
There is no longer a distinction between vlan clients and non-vlan
clients in the net core. The net core only knows about point-to-point
clients which are connected to a peer. It's time to rename the global
list of net c
On 03/08/2012 02:11 PM, Zhi Hui Li wrote:
when I use the command :
1: mkdir /my_directory
2: qemu linux.img -fda fat:floppy:/my_directory
when I write to the floppy(just "mkdir test.dir" in the floppy), the
error occur:
"FLOPPY ERROR: fdctrl_transfer_handler: writing sector 1"
and nothi
On 03/06/2012 04:14 PM, Paolo Bonzini wrote:
Il 06/03/2012 08:16, Mark Wu ha scritto:
It seems we need a name for the union to reference its member.
What version is your compiler?
So I
modified the scripts as the following patch. I also updated blockdev.c
accordingly. After that I can
On 03/06/2012 04:31 PM, Paolo Bonzini wrote:
Il 06/03/2012 09:19, Mark Wu ha scritto:
gcc -v
Using built-in specs.
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info
--with-bugurl=http://bugzilla.redhat.com/bugzilla --enable
On 03/06/2012 01:33 AM, Paolo Bonzini wrote:
Reviewed-by: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
qapi-schema-test.json | 10 ++
scripts/qapi-types.py |5 +
scripts/qapi-visit.py | 31 ++-
test-qmp-input-visitor.c | 18 +
I tried to optimize the zero detecting code with SSE instruction. The
idea comes from Paolo's patch "migration: vectorize is_dup_page". It's
expected to give us an noticeable improvement. But I didn't find any
improvement in the qemu-io test even though I increased the image size
to 5GB. Th
On 12/02/2011 11:34 AM, Li Zhi Hui wrote:
Signed-off-by: Li Zhi Hui
---
qemu-nbd.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 291cba2..ab7fa6c 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -500,8 +500,10 @@ int main(int argc, char **
On 12/02/2011 11:23 AM, Li Zhi Hui wrote:
Signed-off-by: Li Zhi Hui
---
hw/smbus_eeprom.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/smbus_eeprom.c b/hw/smbus_eeprom.c
index 5d080ab..d66fbbc 100644
--- a/hw/smbus_eeprom.c
+++ b/hw/smbus_eeprom.c
@@ -142,4 +142,
On 11/29/2011 12:18 AM, Stefan Hajnoczi wrote:
Callers of bdrv_is_allocated() may go beyond the end of the image. For
general robustness we should limit to the end of the image so that
callers don't end up using out-of-range sector counts and receive -EIO.
It seems the same problem exists in qco
Total physical memory on Windows will always be the same,
because we don't hot-plug/unplug physical memory.
Balloon driver works with non-paged pool memory instead.
So, every time you inflate or deflate balloon in your system,
you should see "Available memory" is changing, while physical
will al
Ahh, I got it!
Thanks.
2011/11/25 Paolo Bonzini
> On 11/25/2011 08:26 AM, Mark Wu wrote:
>
>> 1. This patch aims to add 4k logical support for qemu running on a host
>> with 4k logical block size, right?
>>
>
> No, it adds support for 512b logical block sizes runni
I don't understand this series very well. So could you help me answer the
following questions?
1. This patch aims to add 4k logical support for qemu running on a host
with 4k logical block size, right? For guest, we can use
logical_block_size=4096 to achieve that even on a host with the
logical_bl
On 11/22/2011 02:00 AM, Paolo Bonzini wrote:
Hours in 12-hour mode are in the 1-12 range, not 0-11.
Interesting. I would like to know how you could find this problem. It
seems linux driver never changes the format and 24-hour is default in
rtc emulation code. So how did it expose and how to te
On 11/11/2011 08:11 AM, Anthony Liguori wrote:
I did a brain dump of my understanding of the various storage
requirements for live migration. I think it's accurate but I may have
misunderstand some details so I would appreciate review.
I think given sections (1) and (2), the only viable thing
d-off-by: Mark Wu
Acked-by: Luiz Capitulino
---
QMP/qmp | 126 +++
1 files changed, 126 insertions(+), 0 deletions(-)
create mode 100755 QMP/qmp
diff --git a/QMP/qmp b/QMP/qmp
new file mode 100755
index 000..1db3c7f
--- /dev/null
When I run this tool, I got two python exceptions. It turned out that
both of them were caused by wrong usage. Do you think we need add
validation for input to handle these cases?
Thanks.
1. Not using '=' for path:
$ ./QMP/qmp --path monitor-address
Traceback (most recent call last):
File
On 11/07/2011 05:52 AM, Hervé Poussineau wrote:
Signed-off-by: Hervé Poussineau
---
net/dump.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/net/dump.c b/net/dump.c
index 8132411..4b48d48 100644
--- a/net/dump.c
+++ b/net/dump.c
@@ -30,6 +30,7 @@
typedef str
On 11/01/2011 02:36 AM, Corey Bryant wrote:
The default bridge that we attach to is br0. The thinking is that a distro
could preconfigure such an interface to allow out-of-the-box bridged networking.
Alternatively, if a user wants to use a different bridge, they can say:
qemu linux.img -net
On 11/02/2011 01:13 AM, Corey Bryant wrote:
static int net_tap_init(QemuOpts *opts, int *vnet_hdr)
{
int fd, vnet_hdr_required;
@@ -433,8 +570,11 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char
*name, VLANState *vlan
if (qemu_opt_get(opts, "ifname") ||
On 10/31/2011 10:05 PM, Stefan Hajnoczi wrote:
>net/queue.c |1 +
Oops!
Thanks. Very sorry for that! I will be more cautious.
ned-off-by: Mark Wu
---
docs/tracing.txt |9 -
net/queue.c |1 +
trace/simple.c | 19 +--
trace/stderr.c | 17 -
4 files changed, 42 insertions(+), 4 deletions(-)
diff --git a/docs/tracing.txt b/docs/tracing.txt
index 95ca16c..ea29f2c 10
On 10/28/2011 05:13 PM, Stefan Hajnoczi wrote:
On Thu, Oct 27, 2011 at 10:02 AM, Mark Wu wrote:
Now queue flushing and sent callback could be invoked even on delivery
failure. We add a checking of receiver's return value to avoid this
case.
Signed-off-by: Mark Wu
---
net/queue.c |
Now queue flushing and sent callback could be invoked even on delivery
failure. We add a checking of receiver's return value to avoid this
case.
Signed-off-by: Mark Wu
---
net/queue.c | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/net/queue.c b/net/qu
Now queue flushing and sent callback could be invoked even on delivery
failure. We add a checking of receiver's return value to avoid this
case.
Signed-off-by: Mark Wu
---
net/queue.c | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/net/queue.c b/net/qu
ned-off-by: Mark Wu
---
docs/tracing.txt |9 -
trace/simple.c | 19 +--
trace/stderr.c | 17 -
3 files changed, 41 insertions(+), 4 deletions(-)
diff --git a/docs/tracing.txt b/docs/tracing.txt
index 95ca16c..ea29f2c 100644
--- a/docs/tracing.txt
Signed-off-by: Mark Wu
---
docs/tracing.txt | 29 ++---
1 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/docs/tracing.txt b/docs/tracing.txt
index 95ca16c..139a331 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -16,6 +16,7 @@ for debugging
Each trace events group starts with a line containing the string
"group_start:group-name" and end with a line containing the string
"group_end". The range of a trace events group is determined by
the "tracetool" script when it processes the "trace-ev
On 10/20/2011 02:41 PM, Mark Wu wrote:
This series add support for trace events grouping. The state of a given group
of trace events can be queried or changed in bulk by the following monitor
commands:
* info trace-groups
View available trace event groups and their state. State 1 means
Signed-off-by: Mark Wu
---
trace/simple.c | 30 ++
trace/simple.h |7 +++
2 files changed, 37 insertions(+), 0 deletions(-)
diff --git a/trace/simple.c b/trace/simple.c
index b639dda..05acee0 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -321,6
Add monitor commands 'trace-group NAME on|off' and 'info trace-groups'
to set and query the state of a given group of trace events.
Signed-off-by: Mark Wu
---
hmp-commands.hx | 14 ++
monitor.c | 22 ++
trace/control.h |9 ++
Signed-off-by: Mark Wu
---
trace/stderr.c | 32
trace/stderr.h |7 +++
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/trace/stderr.c b/trace/stderr.c
index 7107c4a..c55bed4 100644
--- a/trace/stderr.c
+++ b/trace/stderr.c
@@ -12,6
A group of trace events can be enabled in early running stage through
adding its group name prefixed with "group:" to trace events list file
which is passed to "-trace events".
Signed-off-by: Mark Wu
---
trace/control.c | 17 +
1 files changed, 17 insert
le problems
* rebase against latest master
Mark Wu (6):
trace: Make "tracetool" generate a group list
trace: Add HMP monitor commands for trace events group
trace: Add trace events group implementation in the backend "simple"
trace: Add trace events group implementation
Hi Jason,
Could you please elaborate what problem you try to resolve by this
patch? And do you think we need notify I/O thread re-polling tap fd
when receive descriptor becomes available? Otherwise, tap read polling
will be disabled until the I/O handlers are updated by other reasons. Am
I ri
On 10/13/2011 01:14 AM, Mark Wu wrote:
This series add support for trace events grouping. The state of a given group
of trace events can be queried or changed in bulk by the following monitor
commands:
* info trace-groups
View available trace event groups and their state. State 1 means
Signed-off-by: Mark Wu
---
trace/stderr.c | 32
trace/stderr.h |7 +++
2 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/trace/stderr.c b/trace/stderr.c
index 7107c4a..c409840 100644
--- a/trace/stderr.c
+++ b/trace/stderr.c
@@ -12,6
Signed-off-by: Mark Wu
---
docs/tracing.txt | 29 ++---
1 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/docs/tracing.txt b/docs/tracing.txt
index 95ca16c..2bd4824 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -16,6 +16,7 @@ for debugging
A group of trace events can be enabled in early running stage through
adding its group name prefixed with "group:" to trace events list file
which is passed to "-trace events".
Signed-off-by: Mark Wu
---
trace/control.c | 17 +
1 files changed, 17 insert
Signed-off-by: Mark Wu
---
trace/simple.c | 30 ++
trace/simple.h |7 +++
2 files changed, 37 insertions(+), 0 deletions(-)
diff --git a/trace/simple.c b/trace/simple.c
index b639dda..7aa4c0b 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -321,6
Each trace events group starts with a line containing "group_start:
GroupName" and end with a line containing "group_end". The range of
a trace events group is determined by the "tracetool" script when it
processes the "trace-events" file.
Signed-off-by
Add monitor commands 'trace-group NAME on|off' and 'info trace-groups'
to set and query the state of a given group of trace events.
Signed-off-by: Mark Wu
---
hmp-commands.hx | 14 ++
monitor.c | 22 ++
trace/control.h |9 ++
-group NAME on|off
Enable/disable a given trace event group.
A group of trace events can also be enabled in early running stage through
adding its group name prefixed with "group:" to trace events list file
which is passed to "-trace events".
Mark Wu (6):
trace: Make "tr
This patch excludes I/O requests ending with error from the
accounting of operations, bytes and time, and adds accounting
for errors separately.It could make the statistics more accurate
and record the number of I/O failure.
Signed-off-by: Mark Wu
---
block.c | 30
. By using
the info block command it's possible to determine that the 'ide0-hd1' device
caused the error, which turns out to be due to no space.
I test it with the options enospc and stop on virtio and scsi models. It
works fine.
Tested-by: Mark Wu
I tested this patch with the following command:
x86_64-softmmu/qemu-system-x86_64 --enable-kvm rhel54_1.img -m 1024 -net
tap,ifname=tap0,script=no -net nic,model=virtio -sdl -drive
file=iscsi://127.0.0.1/iqn.2011-09.com.example:server.target1/
And I found that the whole qemu process would get fr
69 matches
Mail list logo
