[PATCH V12 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

2024-05-29 Thread Salil Mehta via
GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta Reviewed

[PATCH V12 7/8] gdbstub: Add helper function to unregister GDB register space

2024-05-29 Thread Salil Mehta via
://lore.kernel.org/qemu-devel/20230926103654.34424-1-salil.me...@huawei.com/ Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang Reviewed-by: Vishnu Pajjuri Tested-by: Zhao Liu --- gdbstub/gdbstub.c

[PATCH V12 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-05-29 Thread Salil Mehta via
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested

[PATCH V12 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2024-05-29 Thread Salil Mehta via
Zhu Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang Tested-by: Zhao Liu --- hw/acpi/cpu.c | 23 --- hw/i386/acpi-build.c | 3

[PATCH V12 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2024-05-29 Thread Salil Mehta via
later on for clean-up) Reference: [1] https://lore.kernel.org/qemu-devel/1463496205-251412-24-git-send-email-imamm...@redhat.com/ Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri

[PATCH V12 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-05-29 Thread Salil Mehta via
)plug events. ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed

[PATCH V12 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2024-05-29 Thread Salil Mehta via
CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V12 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-29 Thread Salil Mehta via
is intended here. Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang Reviewed-by: Vishnu Pajjuri Reviewed-by: Nicholas Piggin Tested-by: Zhao Liu Reviewed-by: Zhao

[PATCH V12 0/8] Add architecture agnostic code to support vCPU Hotplug

2024-05-29 Thread Salil Mehta via
[Patch 4,5] 4. Helper functions to support unrealization of CPU objects [Patch 6,7] 5. Docs [Patch 8] Repository: [*] https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v3.arch.agnostic.v12 NOTE: This series is meant to work in conjunction with Architecture specific patch-set. For ARM

RE: [PATCH V11 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-05-23 Thread Salil Mehta via
> From: Harsh Prateek Bora > Sent: Thursday, May 23, 2024 8:05 AM > > Hi Salil, > > On 5/23/24 02:41, Salil Mehta wrote: > > +void kvm_park_vcpu(CPUState *cpu); > > + > > +/** > > + * kvm_unpark_vcpu - unpark QEMU KVM vCPU context > &g

[PATCH V11 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

2024-05-22 Thread Salil Mehta via
GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta Reviewed

[PATCH V11 7/8] gdbstub: Add helper function to unregister GDB register space

2024-05-22 Thread Salil Mehta via
://lore.kernel.org/qemu-devel/20230926103654.34424-1-salil.me...@huawei.com/ Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang Reviewed-by: Vishnu Pajjuri --- gdbstub/gdbstub.c | 13

[PATCH V11 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-05-22 Thread Salil Mehta via
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested

[PATCH V11 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2024-05-22 Thread Salil Mehta via
later on for clean-up) Reference: [1] https://lore.kernel.org/qemu-devel/1463496205-251412-24-git-send-email-imamm...@redhat.com/ Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri

[PATCH V11 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2024-05-22 Thread Salil Mehta via
Zhu Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang --- hw/acpi/cpu.c | 23 --- hw/i386/acpi-build.c | 3 ++- include/hw/acpi

[PATCH V11 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-05-22 Thread Salil Mehta via
)plug events. ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed

[PATCH V11 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-22 Thread Salil Mehta via
is intended here. Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang Reviewed-by: Vishnu Pajjuri Reviewed-by: Nicholas Piggin --- accel/kvm/kvm-all.c| 95

[PATCH V11 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2024-05-22 Thread Salil Mehta via
CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V11 0/8] Add architecture agnostic code to support vCPU Hotplug

2024-05-22 Thread Salil Mehta via
[Patch 4,5] 4. Helper functions to support unrealization of CPU objects [Patch 6,7] 5. Docs [Patch 8] Repository: [*] https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v3.arch.agnostic.v10 NOTE: This series is meant to work in conjunction with Architecture specific patch-set. For ARM

RE: [PATCH V10 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-05-22 Thread Salil Mehta via
> From: Nicholas Piggin > Sent: Wednesday, May 22, 2024 2:25 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > > On Tue May 21, 2024 at 9:32 AM AEST, Salil Mehta wrote: > > KVM vCPU creation is done once during the vCPU realization when Qemu >

RE: [PATCH V10 7/8] gdbstub: Add helper function to unregister GDB register space

2024-05-21 Thread Salil Mehta via
> From: Alex Bennée > Sent: Tuesday, May 21, 2024 4:23 PM > To: Salil Mehta > > Salil Mehta writes: > > > Hi Alex, > > > >> From: Alex Bennée > >> Sent: Tuesday, May 21, 2024 1:45 PM > >> To: Salil Mehta > >&

RE: [PATCH V10 7/8] gdbstub: Add helper function to unregister GDB register space

2024-05-21 Thread Salil Mehta via
Hi Alex, > From: Alex Bennée > Sent: Tuesday, May 21, 2024 1:45 PM > To: Salil Mehta > > Salil Mehta writes: > > > Add common function to help unregister the GDB register space. This > > shall be done in context to the CPU unrealization. >

[PATCH V10 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

2024-05-20 Thread Salil Mehta via
GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta Reviewed

[PATCH V10 7/8] gdbstub: Add helper function to unregister GDB register space

2024-05-20 Thread Salil Mehta via
Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang Reviewed-by: Vishnu

[PATCH V10 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-05-20 Thread Salil Mehta via
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested

[PATCH V10 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2024-05-20 Thread Salil Mehta via
Zhu Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang --- hw/acpi/cpu.c | 23 --- hw/i386/acpi-build.c | 3 ++- include/hw/acpi

[PATCH V10 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2024-05-20 Thread Salil Mehta via
later on for clean-up) Reference: [1] https://lore.kernel.org/qemu-devel/1463496205-251412-24-git-send-email-imamm...@redhat.com/ Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri

[PATCH V10 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2024-05-20 Thread Salil Mehta via
CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V10 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-05-20 Thread Salil Mehta via
)plug events. ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed

[PATCH V10 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-20 Thread Salil Mehta via
is intended here. Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang Reviewed-by: Vishnu Pajjuri --- accel/kvm/kvm-all.c| 97

[PATCH V10 0/8] Add architecture agnostic code to support vCPU Hotplug

2024-05-20 Thread Salil Mehta via
[Patch 4,5] 4. Helper functions to support unrealization of CPU objects [Patch 6,7] 5. Docs [Patch 8] Repository: [*] https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v3.arch.agnostic.v10 NOTE: For ARM, above will work in combination of the architecture specific part based on RFC V2

RE: [PATCH V9 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-05-20 Thread Salil Mehta via
> From: Nicholas Piggin > Sent: Monday, May 20, 2024 9:04 AM > > On Mon May 20, 2024 at 7:06 AM AEST, Salil Mehta wrote: > > KVM vCPU creation is done once during the vCPU realization when Qemu > > vCPU thread is spawned. This is common to all the architectures

RE: [PATCH V9 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-05-20 Thread Salil Mehta via
> From: Nicholas Piggin > Sent: Monday, May 20, 2024 9:19 AM > > On Mon May 20, 2024 at 7:06 AM AEST, Salil Mehta wrote: > > Virtual CPU Hot-unplug leads to unrealization of a CPU object. This > > also involves destruction of the CPU AddressSpace. Add common funct

RE: [PATCH V9 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-05-20 Thread Salil Mehta via
Hi Nick, > From: Nicholas Piggin > Sent: Monday, May 20, 2024 9:04 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > > On Mon May 20, 2024 at 7:06 AM AEST, Salil Mehta wrote: > > KVM vCPU creation is done once during the vCPU realization wh

[PATCH V9 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

2024-05-19 Thread Salil Mehta via
GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta Reviewed

[PATCH V9 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2024-05-19 Thread Salil Mehta via
later on for clean-up) Reference: [1] https://lore.kernel.org/qemu-devel/1463496205-251412-24-git-send-email-imamm...@redhat.com/ Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri

[PATCH V9 7/8] gdbstub: Add helper function to unregister GDB register space

2024-05-19 Thread Salil Mehta via
Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang Reviewed-by: Vishnu

[PATCH V9 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-05-19 Thread Salil Mehta via
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested

[PATCH V9 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2024-05-19 Thread Salil Mehta via
Zhu Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang --- hw/acpi/cpu.c | 23 --- hw/i386/acpi-build.c | 3 ++- include/hw/acpi

[PATCH V9 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-05-19 Thread Salil Mehta via
)plug events. ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed

[PATCH V9 0/8] Add architecture agnostic code to support vCPU Hotplug

2024-05-19 Thread Salil Mehta via
[Patch 4,5] 4. Helper functions to support unrealization of CPU objects [Patch 6,7] 5. Docs [Patch 8] Repository: [*] https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v3.arch.agnostic.v9 NOTE: For ARM, above will work in combination of the architecture specific part based on RFC V2 [1

[PATCH V9 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2024-05-19 Thread Salil Mehta via
CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V9 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-19 Thread Salil Mehta via
. No functional change is intended here. Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang Reviewed-by: Vishnu Pajjuri --- accel/kvm/kvm-all.c| 64

RE: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-17 Thread Salil Mehta via
Hi Nick, > From: Nicholas Piggin > Sent: Friday, May 17, 2024 4:44 AM > > On Thu May 16, 2024 at 11:35 PM AEST, Salil Mehta wrote: > > > > > From: Harsh Prateek Bora > > > Sent: Thursday, May 16, 2024 2:07 PM > > > > > > Hi Sal

[PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-16 Thread Salil Mehta
[+] Adding this email address to the conversation. (sorry for the noise) > From: Salil Mehta > Sent: Thursday, May 16, 2024 2:36 PM > > > From: Harsh Prateek Bora > > Sent: Thursday, May 16, 2024 2:07 PM > > > > Hi Salil, > > > > On 5/16/

RE: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-16 Thread Salil Mehta via
> From: Harsh Prateek Bora > Sent: Thursday, May 16, 2024 2:07 PM > > Hi Salil, > > On 5/16/24 17:42, Salil Mehta wrote: > > Hi Harsh, > > > >> From: Harsh Prateek Bora > >> Sent: Thursday, May 16, 2024 11:15 AM > >&

RE: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-16 Thread Salil Mehta via
ur work and let's be hopeful it gets merged soon. > > regards, > Harsh > > On 5/16/24 14:00, Salil Mehta wrote: > > Hi Harsh, > > > > Thanks for your interest in the patch-set but taking away patches like > > this from other series without any discussio

RE: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-16 Thread Salil Mehta via
can rebase your patch-set from there. I'm hopeful that it will get accepted in this cycle. Many thanks Salil. > From: Harsh Prateek Bora > Sent: Thursday, May 16, 2024 6:32 AM > > From: Salil Mehta > > KVM vCPU creation is done once during the vCPU realization when Q

RE: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-05-08 Thread Salil Mehta via
Hi Phillipe, Sorry, I missed this mail earlier. > From: Philippe Mathieu-Daudé > Sent: Friday, May 3, 2024 7:23 PM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > > On 3/5/24 17:57, Salil Mehta wrote: > > Hi Philippe, > > >

Re: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-05-07 Thread Salil Mehta
HI Vishnu, On Tue, May 7, 2024 at 12:39 PM Vishnu Pajjuri < vis...@amperemail.onmicrosoft.com> wrote: > Hi Salil, > On 03-05-2024 21:53, Salil Mehta wrote: > > [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please > be mindful of safe email han

RE: [PATCH V8 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-05-07 Thread Salil Mehta via
Hi Peter, > From: Peter Maydell > Sent: Tuesday, May 7, 2024 10:03 AM > > On Tue, 7 May 2024 at 01:11, Salil Mehta wrote: > > > > > From: Peter Maydell > > > Sent: Monday, May 6, 2024 10:29 AM > > > To: Salil Mehta > >

RE: [PATCH V8 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-05-06 Thread Salil Mehta via
> From: Peter Maydell > Sent: Monday, May 6, 2024 10:29 AM > To: Salil Mehta > > On Mon, 6 May 2024 at 10:06, Salil Mehta > wrote: > > > > Hi Peter, > > > > Thanks for the review. > > > > > From: Peter Maydell When do we

RE: [PATCH V8 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-05-06 Thread Salil Mehta via
> From: Zhao Liu > Sent: Monday, May 6, 2024 10:06 AM > > Hi Salil, > > On Fri, May 03, 2024 at 07:59:32PM +, Salil Mehta wrote: > > Date: Fri, 3 May 2024 19:59:32 +0000 > > From: Salil Mehta > > Subject: RE: [PATCH V8 3/8] hw/acpi: Updat

RE: [PATCH V8 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-05-06 Thread Salil Mehta via
Hi Peter, Thanks for the review. > From: Peter Maydell > Sent: Saturday, May 4, 2024 2:41 PM > > On Tue, 12 Mar 2024 at 02:02, Salil Mehta > wrote: > > > > Virtual CPU Hot-unplug leads to unrealization of a CPU object. This > > also involves destruc

Re: [PATCH V8 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-05-03 Thread Salil Mehta
Hi Zhukeqian, On Fri, Mar 15, 2024 at 1:17 AM zhukeqian wrote: > Hi Salil, > > [...] > > +void cpu_address_space_destroy(CPUState *cpu, int asidx) { > +CPUAddressSpace *cpuas; > + > +assert(cpu->cpu_ases); > +assert(asidx >= 0 && asidx < cpu->num_ases); > +/* KVM cannot

RE: [PATCH V8 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-05-03 Thread Salil Mehta via
Hi Vishnu, > From: Vishnu Pajjuri > Sent: Thursday, April 4, 2024 3:01 PM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > > Hi Salil, >> On 12-03-2024 07:29, Salil Mehta wrote: >> ACPI GED (as described in the ACPI 6.4 spec) uses an in

RE: [PATCH V8 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-05-03 Thread Salil Mehta via
Hello, Sorry, I missed this earlier. > From: Zhao Liu > Sent: Wednesday, March 13, 2024 6:14 AM > To: Salil Mehta > > Hi Salil, > > It seems my comment [1] in v7 was missed, but I still hit the same issue. Pls > let me paste the previous comment here

RE: [PATCH V8 7/8] gdbstub: Add helper function to unregister GDB register space

2024-05-03 Thread Salil Mehta via
Hi Vishnu, Sorry for the delay in reply. Still catching up. > From: Vishnu Pajjuri > Sent: Thursday, April 4, 2024 3:02 PM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > > Hi Salil, > On 12-03-2024 07:29, Salil Mehta wrote: >> Add common

RE: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-03 Thread Salil Mehta via
inux.ibm.com/T/#u > > On 3/22/24 13:45, Harsh Prateek Bora wrote: > > + Vaibhav, Shiva > > > > Hi Salil, > > > > I came across your patch while trying to solve a related problem on > > spapr. One query below .. > > > > On 3/12/24 07:29

RE: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-03 Thread Salil Mehta via
> I came across your patch while trying to solve a related problem on spapr. > One query below .. > > On 3/12/24 07:29, Salil Mehta via wrote: > > KVM vCPU creation is done once during the vCPU realization when Qemu > > vCPU thread is spawned. This is common to all the

RE: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-05-03 Thread Salil Mehta via
Hi Vishnu, > From: Vishnu Pajjuri > Sent: Thursday, April 4, 2024 3:00 PM > Subject: Re: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU > {creation,parking} code > > Hi Salil, >> On 12-03-2024 07:29, Salil Mehta wrote: >> KVM vCPU creation is done on

RE: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-05-03 Thread Salil Mehta via
Hi Philippe, > From: Philippe Mathieu-Daudé > Sent: Friday, May 3, 2024 10:40 AM > Subject: Re: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU > {creation,parking} code > > Hi Salil, > > On 12/3/24 02:59, Salil Mehta wrote: > > KVM vCPU creatio

[PATCH V8 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-03-11 Thread Salil Mehta via
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested

[PATCH V8 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

2024-03-11 Thread Salil Mehta via
GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta Reviewed

[PATCH V8 7/8] gdbstub: Add helper function to unregister GDB register space

2024-03-11 Thread Salil Mehta via
Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang --- gdbstub/gdbstub.c

[PATCH V8 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2024-03-11 Thread Salil Mehta via
later on for clean-up) Reference: [1] https://lore.kernel.org/qemu-devel/1463496205-251412-24-git-send-email-imamm...@redhat.com/ Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri

[PATCH V8 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2024-03-11 Thread Salil Mehta via
Zhu Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang --- hw/acpi/cpu.c | 23 --- hw/i386/acpi-build.c | 3 ++- include/hw/acpi

[PATCH V8 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-03-11 Thread Salil Mehta via
)plug events. ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed

[PATCH V8 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2024-03-11 Thread Salil Mehta via
CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-03-11 Thread Salil Mehta via
. No functional change is intended here. Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang --- accel/kvm/kvm-all.c| 64

[PATCH V8 0/8] Add architecture agnostic code to support vCPU Hotplug

2024-03-11 Thread Salil Mehta via
[Patch 4,5] 4. Helper functions to support unrealization of CPU objects [Patch 6,7] 5. Docs [Patch 8] Repository: [*] https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v2.common.v8 Revision History: Patch-set V7 -> V8 1. Rebased and Fixed the conflicts Patch-set V6 ->

[PATCH V7 7/8] gdbstub: Add helper function to unregister GDB register space

2023-11-13 Thread Salil Mehta via
Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang --- gdbstub/gdbstub.c

[PATCH V7 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

2023-11-13 Thread Salil Mehta via
GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta --- docs

[PATCH V7 6/8] physmem: Add helper function to destroy CPU AddressSpace

2023-11-13 Thread Salil Mehta via
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested

[PATCH V7 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2023-11-13 Thread Salil Mehta via
Zhu Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang --- hw/acpi/cpu.c | 23 --- hw/i386/acpi-build.c | 3 ++- include/hw/acpi

[PATCH V7 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2023-11-13 Thread Salil Mehta via
later on for clean-up) Reference: [1] https://lore.kernel.org/qemu-devel/1463496205-251412-24-git-send-email-imamm...@redhat.com/ Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri

[PATCH V7 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2023-11-13 Thread Salil Mehta via
)plug events. ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed

[PATCH V7 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2023-11-13 Thread Salil Mehta via
CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V7 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

2023-11-13 Thread Salil Mehta via
. No functional change is intended here. Signed-off-by: Salil Mehta Reviewed-by: Gavin Shan Tested-by: Vishnu Pajjuri Reviewed-by: Jonathan Cameron Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang --- accel/kvm/kvm-all.c| 64

[PATCH V7 0/8] Add architecture agnostic code to support vCPU Hotplug

2023-11-13 Thread Salil Mehta via
[Patch 4,5] 4. Helper functions to support unrealization of CPU objects [Patch 6,7] 5. Docs [Patch 8] Repository: [*] https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v2.common.v7 Revision History: Patch-set V6 -> V7 1. Addressed Alex Bennée's comments - Updated the doc

RE: [PATCH V6 5/9] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2023-11-13 Thread Salil Mehta via
Hi Igor, Sorry, I missed this as well. > From: Igor Mammedov > Sent: Friday, October 27, 2023 2:47 PM > To: Salil Mehta ; m...@redhat.com > > On Fri, 13 Oct 2023 11:51:25 +0100 > Salil Mehta wrote: > > > CPUs Control device(\\_SB.PCI0) register interface for

RE: [PATCH V6 4/9] hw/acpi: Init GED framework with CPU hotplug events

2023-11-13 Thread Salil Mehta via
Hi Igor, Sorry, I realized I missed to reply this review comment. > From: Igor Mammedov > Sent: Friday, October 27, 2023 3:08 PM > To: Salil Mehta > > On Fri, 13 Oct 2023 11:51:24 +0100 > Salil Mehta wrote: > > > ACPI GED(as described in the ACPI 6.2 spec) c

RE: [PATCH V6 7/9] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2023-11-08 Thread Salil Mehta via
Hi Igor, > From: Igor Mammedov > Sent: Friday, October 27, 2023 2:18 PM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- > phili...@linaro.org; Jonathan Cameron ; > lpieral...@kernel.org; peter.mayd...@linaro.org; > richard

RE: [PATCH V6 3/9] hw/acpi: Add ACPI CPU hotplug init stub

2023-11-06 Thread Salil Mehta via
Hi Igor, > From: Igor Mammedov > Sent: Friday, October 27, 2023 2:06 PM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- > phili...@linaro.org; Jonathan Cameron ; > lpieral...@kernel.org; peter.mayd...@linaro.org; > richard

RE: [PATCH V6 1/9] accel/kvm: Extract common KVM vCPU {creation,parking} code

2023-11-06 Thread Salil Mehta via
Hi Igor, Thanks for the review comments. I was bit on and off so could not address the comments. Please find my replies inline. > From: Igor Mammedov > Sent: Friday, October 27, 2023 1:57 PM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; j

RE: [PATCH V6 0/9] Add architecture agnostic code to support vCPU Hotplug

2023-10-27 Thread Salil Mehta via
Hi Igor, > From: Igor Mammedov > Sent: Thursday, October 26, 2023 1:41 PM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- > phili...@linaro.org; Jonathan Cameron ; > lpieral...@kernel.org; peter.mayd...@linaro.org; > richard

RE: [Question] x86/microvm: why has_hotpluggable_cpus = false but hot(ub)plug APIs exist?

2023-10-27 Thread Salil Mehta via
> From: Igor Mammedov > Sent: Thursday, October 26, 2023 1:09 PM > To: Salil Mehta > > On Wed, 25 Oct 2023 09:54:07 +0000 > Salil Mehta wrote: > > > > From: David Hildenbrand > > > Sent: Wednesday, October 25, 2023 10:32 AM > > > To:

RE: [Question] x86/microvm: why has_hotpluggable_cpus = false but hot(ub)plug APIs exist?

2023-10-25 Thread Salil Mehta via
> From: David Hildenbrand > Sent: Wednesday, October 25, 2023 10:32 AM > To: Salil Mehta ; Igor Mammedov > ; Salil Mehta > > On 25.10.23 11:16, Salil Mehta wrote: > > Hi Igor, > > > >> From: Igor Mammedov > >> Sent: Tuesday, October 24, 2023 9:

RE: [Question] x86/microvm: why has_hotpluggable_cpus = false but hot(ub)plug APIs exist?

2023-10-25 Thread Salil Mehta via
Hi Igor, > From: Igor Mammedov > Sent: Tuesday, October 24, 2023 9:06 AM > To: Salil Mehta > > On Wed, 18 Oct 2023 17:48:36 +0100 > Salil Mehta wrote: > > > Hi Alex, > > > > On 18/10/2023 16:41, Alex Bennée wrote: > > > > > > Salil Meh

Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-20 Thread Salil Mehta
Hi Bernhard, On 19/10/2023 11:33, Bernhard Beschow wrote: Am 18. Oktober 2023 17:38:33 UTC schrieb Salil Mehta : Hello, Hi Salil, Can we assume that every machine type will have all the features which a GED Device can multiplex present together? like will Memory and CPU Hotplug makes

RE: [PATCH V6 4/9] hw/acpi: Init GED framework with CPU hotplug events

2023-10-19 Thread Salil Mehta via
Hi Alex, > From: Alex Bennée > Sent: Thursday, October 19, 2023 11:16 AM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- > phili...@linaro.org; Jonathan Cameron ; > lpieral...@kernel.org; peter.mayd...@linaro.org; > richard.hender

RE: [PATCH V6 0/9] Add architecture agnostic code to support vCPU Hotplug

2023-10-19 Thread Salil Mehta via
Hi Shaoqin, > From: Shaoqin Huang > Sent: Thursday, October 19, 2023 10:05 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard

Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-18 Thread Salil Mehta
Hello, Can we assume that every machine type will have all the features which a GED Device can multiplex present together? like will Memory and CPU Hotplug makes sense for all the type of machines? If answer is no, then shouldn't every machine type override the base GED type and define it

Re: [Question] x86/microvm: why has_hotpluggable_cpus = false but hot(ub)plug APIs exist?

2023-10-18 Thread Salil Mehta
Hi Alex, On 18/10/2023 16:41, Alex Bennée wrote: Salil Mehta writes: Hello, Came across below code excerpt in x86/microvm code and wanted to know why 'has_hotpluggable_cpus' flag has been set to 'false' while various hot(un)plug APIs have been defined? static void microvm_class_init

[Question] x86/microvm: why has_hotpluggable_cpus = false but hot(ub)plug APIs exist?

2023-10-18 Thread Salil Mehta
Hello, Came across below code excerpt in x86/microvm code and wanted to know why 'has_hotpluggable_cpus' flag has been set to 'false' while various hot(un)plug APIs have been defined? static void microvm_class_init(ObjectClass *oc, void *data) { X86MachineClass *x86mc =

RE: [PATCH RFC V2 35/37] hw/arm: Support hotplug capability check using _OSC method

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 5:23 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender..

RE: [PATCH RFC V2 34/37] target/arm/kvm,tcg: Register/Handle SMCCC hypercall exits to VMM/Qemu

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 5:15 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender..

RE: [PATCH RFC V2 29/37] arm/virt: Update the guest(via GED) about CPU hot-(un)plug events

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 1:31 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender..

RE: [PATCH RFC V2 25/37] arm/virt: Add/update basic hot-(un)plug framework

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 1:21 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender..

RE: [PATCH RFC V2 23/37] arm/virt: Release objects for *disabled* possible vCPUs after init

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 12:58 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard

  1   2   3   4   >