[PATCH V13 7/8] gdbstub: Add helper function to unregister GDB register space

Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Note: These are common functions exported to arch specific code. For example, for ARM this code is being referred in associated arch specific patch-set: Link:

[PATCH V13 6/8] physmem: Add helper function to destroy CPU AddressSpace

Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by:

[PATCH V13 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta

[PATCH V13 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO port based and existing CPUs AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control device(\\_SB.PRES) register interface is memory-mapped hence _CRS

[PATCH V13 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually results in start of the CPU scan. Scan figures out the CPU and the kind of event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT method with the call to \\_SB.CPUS.CSCN Also, macro

[PATCH V13 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the _CRS object of GED to intimate OSPM about an event. Later then demultiplexes the notified event by evaluating ACPI _EVT method to know the type of event. Use ACPI GED to also notify the guest kernel about any CPU

[PATCH V13 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

KVM vCPU creation is done once during the vCPU realization when Qemu vCPU thread is spawned. This is common to all the architectures as of now. Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the corresponding KVM vCPU object in the Host KVM is not destroyed as KVM doesn't

[PATCH V13 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V13 0/8] Add architecture agnostic code to support vCPU Hotplug

Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 2,3] 3. ACPI CPUs AML code change

[PATCH V12 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta

[PATCH V12 7/8] gdbstub: Add helper function to unregister GDB register space

Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Note: These are common functions exported to arch specific code. For example, for ARM this code is being referred in associated arch specific patch-set: Link:

[PATCH V12 6/8] physmem: Add helper function to destroy CPU AddressSpace

Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by:

[PATCH V12 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO port based and existing CPUs AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control device(\\_SB.PRES) register interface is memory-mapped hence _CRS

[PATCH V12 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually results in start of the CPU scan. Scan figures out the CPU and the kind of event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT method with the call to \\_SB.CPUS.CSCN Also, macro

[PATCH V12 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the _CRS object of GED to intimate OSPM about an event. Later then demultiplexes the notified event by evaluating ACPI _EVT method to know the type of event. Use ACPI GED to also notify the guest kernel about any CPU

[PATCH V12 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V12 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

KVM vCPU creation is done once during the vCPU realization when Qemu vCPU thread is spawned. This is common to all the architectures as of now. Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the corresponding KVM vCPU object in the Host KVM is not destroyed as KVM doesn't

[PATCH V12 0/8] Add architecture agnostic code to support vCPU Hotplug

Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 2,3] 3. ACPI CPUs AML code change

RE: [PATCH V11 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

> From: Harsh Prateek Bora > Sent: Thursday, May 23, 2024 8:05 AM > > Hi Salil, > > On 5/23/24 02:41, Salil Mehta wrote: > > +void kvm_park_vcpu(CPUState *cpu); > > + > > +/** > > + * kvm_unpark_vcpu - unpark QEMU KVM vCPU context > > + * @s: KVM State > > + * @cpu: Architecture

[PATCH V11 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta

[PATCH V11 7/8] gdbstub: Add helper function to unregister GDB register space

Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Note: These are common functions exported to arch specific code. For example, for ARM this code is being referred in associated arch specific patch-set: Link:

[PATCH V11 6/8] physmem: Add helper function to destroy CPU AddressSpace

Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by:

[PATCH V11 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually results in start of the CPU scan. Scan figures out the CPU and the kind of event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT method with the call to \\_SB.CPUS.CSCN Also, macro

[PATCH V11 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO port based and existing CPUs AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control device(\\_SB.PRES) register interface is memory-mapped hence _CRS

[PATCH V11 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the _CRS object of GED to intimate OSPM about an event. Later then demultiplexes the notified event by evaluating ACPI _EVT method to know the type of event. Use ACPI GED to also notify the guest kernel about any CPU

[PATCH V11 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

KVM vCPU creation is done once during the vCPU realization when Qemu vCPU thread is spawned. This is common to all the architectures as of now. Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the corresponding KVM vCPU object in the Host KVM is not destroyed as KVM doesn't

[PATCH V11 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V11 0/8] Add architecture agnostic code to support vCPU Hotplug

Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 2,3] 3. ACPI CPUs AML code change

RE: [PATCH V10 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

> From: Nicholas Piggin > Sent: Wednesday, May 22, 2024 2:25 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > > On Tue May 21, 2024 at 9:32 AM AEST, Salil Mehta wrote: > > KVM vCPU creation is done once during the vCPU realization when Qemu > > vCPU thread is

RE: [PATCH V10 7/8] gdbstub: Add helper function to unregister GDB register space

> From: Alex Bennée > Sent: Tuesday, May 21, 2024 4:23 PM > To: Salil Mehta > > Salil Mehta writes: > > > Hi Alex, > > > >> From: Alex Bennée > >> Sent: Tuesday, May 21, 2024 1:45 PM > >> To: Salil Mehta > >> > >> Salil Mehta writes: > >> > >> > Add common function to

RE: [PATCH V10 7/8] gdbstub: Add helper function to unregister GDB register space

Hi Alex, > From: Alex Bennée > Sent: Tuesday, May 21, 2024 1:45 PM > To: Salil Mehta > > Salil Mehta writes: > > > Add common function to help unregister the GDB register space. This > > shall be done in context to the CPU unrealization. > > > > Signed-off-by: Salil Mehta > >

[PATCH V10 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta

[PATCH V10 7/8] gdbstub: Add helper function to unregister GDB register space

Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang Reviewed-by: Vishnu

[PATCH V10 6/8] physmem: Add helper function to destroy CPU AddressSpace

Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by:

[PATCH V10 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO port based and existing CPUs AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control device(\\_SB.PRES) register interface is memory-mapped hence _CRS

[PATCH V10 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually results in start of the CPU scan. Scan figures out the CPU and the kind of event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT method with the call to \\_SB.CPUS.CSCN Also, macro

[PATCH V10 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V10 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the _CRS object of GED to intimate OSPM about an event. Later then demultiplexes the notified event by evaluating ACPI _EVT method to know the type of event. Use ACPI GED to also notify the guest kernel about any CPU

[PATCH V10 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

KVM vCPU creation is done once during the vCPU realization when Qemu vCPU thread is spawned. This is common to all the architectures as of now. Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the corresponding KVM vCPU object in the Host KVM is not destroyed as KVM doesn't

[PATCH V10 0/8] Add architecture agnostic code to support vCPU Hotplug

Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 2,3] 3. ACPI CPUs AML code change

RE: [PATCH V9 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

> From: Nicholas Piggin > Sent: Monday, May 20, 2024 9:04 AM > > On Mon May 20, 2024 at 7:06 AM AEST, Salil Mehta wrote: > > KVM vCPU creation is done once during the vCPU realization when Qemu > > vCPU thread is spawned. This is common to all the architectures as of now. > > > >

RE: [PATCH V9 6/8] physmem: Add helper function to destroy CPU AddressSpace

> From: Nicholas Piggin > Sent: Monday, May 20, 2024 9:19 AM > > On Mon May 20, 2024 at 7:06 AM AEST, Salil Mehta wrote: > > Virtual CPU Hot-unplug leads to unrealization of a CPU object. This > > also involves destruction of the CPU AddressSpace. Add common function > > to help destroy

RE: [PATCH V9 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

Hi Nick, > From: Nicholas Piggin > Sent: Monday, May 20, 2024 9:04 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > > On Mon May 20, 2024 at 7:06 AM AEST, Salil Mehta wrote: > > KVM vCPU creation is done once during the vCPU realization when Qemu > > vCPU thread is

[PATCH V9 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta

[PATCH V9 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually results in start of the CPU scan. Scan figures out the CPU and the kind of event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT method with the call to \\_SB.CPUS.CSCN Also, macro

[PATCH V9 7/8] gdbstub: Add helper function to unregister GDB register space

Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang Reviewed-by: Vishnu

[PATCH V9 6/8] physmem: Add helper function to destroy CPU AddressSpace

Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by:

[PATCH V9 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO port based and existing CPUs AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control device(\\_SB.PRES) register interface is memory-mapped hence _CRS

[PATCH V9 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the _CRS object of GED to intimate OSPM about an event. Later then demultiplexes the notified event by evaluating ACPI _EVT method to know the type of event. Use ACPI GED to also notify the guest kernel about any CPU

[PATCH V9 0/8] Add architecture agnostic code to support vCPU Hotplug

Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 2,3] 3. ACPI CPUs AML code change

[PATCH V9 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V9 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

KVM vCPU creation is done once during the vCPU realization when Qemu vCPU thread is spawned. This is common to all the architectures as of now. Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the corresponding KVM vCPU object in the Host KVM is not destroyed as KVM doesn't

RE: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

Hi Nick, > From: Nicholas Piggin > Sent: Friday, May 17, 2024 4:44 AM > > On Thu May 16, 2024 at 11:35 PM AEST, Salil Mehta wrote: > > > > > From: Harsh Prateek Bora > > > Sent: Thursday, May 16, 2024 2:07 PM > > > > > > Hi Salil, > > > > > > On 5/16/24 17:42, Salil Mehta wrote:

RE: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

> From: Harsh Prateek Bora > Sent: Thursday, May 16, 2024 2:07 PM > > Hi Salil, > > On 5/16/24 17:42, Salil Mehta wrote: > > Hi Harsh, > > > >> From: Harsh Prateek Bora > >> Sent: Thursday, May 16, 2024 11:15 AM > >> > >> Hi Salil, > >> > >> Thanks for your email. > >>

RE: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

Hi Harsh, > From: Harsh Prateek Bora > Sent: Thursday, May 16, 2024 11:15 AM > > Hi Salil, > > Thanks for your email. > Your patch 1/8 is included here based on review comments on my previous > patch from one of the maintainers in the community and therefore I had > kept you in CC to

RE: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

Hi Harsh, Thanks for your interest in the patch-set but taking away patches like this from other series without any discussion can disrupt others work and its acceptance on time. This is because we will have to put lot of effort in rebasing bigger series and then testing overhead comes along with

RE: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

Hi Phillipe, Sorry, I missed this mail earlier. > From: Philippe Mathieu-Daudé > Sent: Friday, May 3, 2024 7:23 PM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > > On 3/5/24 17:57, Salil Mehta wrote: > > Hi Philippe, > > > >> From: Philippe Mathieu-Daudé > >>

RE: [PATCH V8 6/8] physmem: Add helper function to destroy CPU AddressSpace

Hi Peter, > From: Peter Maydell > Sent: Tuesday, May 7, 2024 10:03 AM > > On Tue, 7 May 2024 at 01:11, Salil Mehta wrote: > > > > > From: Peter Maydell > > > Sent: Monday, May 6, 2024 10:29 AM > > > To: Salil Mehta > > > > > > On Mon, 6 May 2024 at 10:06, Salil Mehta > > >

RE: [PATCH V8 6/8] physmem: Add helper function to destroy CPU AddressSpace

> From: Peter Maydell > Sent: Monday, May 6, 2024 10:29 AM > To: Salil Mehta > > On Mon, 6 May 2024 at 10:06, Salil Mehta > wrote: > > > > Hi Peter, > > > > Thanks for the review. > > > > > From: Peter Maydell When do we need to > > > destroy a single address space in this way

RE: [PATCH V8 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

> From: Zhao Liu > Sent: Monday, May 6, 2024 10:06 AM > > Hi Salil, > > On Fri, May 03, 2024 at 07:59:32PM +, Salil Mehta wrote: > > Date: Fri, 3 May 2024 19:59:32 + > > From: Salil Mehta > > Subject: RE: [PATCH V8 3/8] hw/acpi: Update ACPI GED framework to > > support

RE: [PATCH V8 6/8] physmem: Add helper function to destroy CPU AddressSpace

Hi Peter, Thanks for the review. > From: Peter Maydell > Sent: Saturday, May 4, 2024 2:41 PM > > On Tue, 12 Mar 2024 at 02:02, Salil Mehta > wrote: > > > > Virtual CPU Hot-unplug leads to unrealization of a CPU object. This > > also involves destruction of the CPU AddressSpace. Add

RE: [PATCH V8 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

Hi Vishnu, > From: Vishnu Pajjuri > Sent: Thursday, April 4, 2024 3:01 PM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > > Hi Salil, >> On 12-03-2024 07:29, Salil Mehta wrote: >> ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the >> _CRS

RE: [PATCH V8 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

Hello, Sorry, I missed this earlier. > From: Zhao Liu > Sent: Wednesday, March 13, 2024 6:14 AM > To: Salil Mehta > > Hi Salil, > > It seems my comment [1] in v7 was missed, but I still hit the same issue. Pls > let me paste the previous comment here again. > > [1]:

RE: [PATCH V8 7/8] gdbstub: Add helper function to unregister GDB register space

Hi Vishnu, Sorry for the delay in reply. Still catching up. > From: Vishnu Pajjuri > Sent: Thursday, April 4, 2024 3:02 PM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > > Hi Salil, > On 12-03-2024 07:29, Salil Mehta wrote: >> Add common function to help unregister

RE: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

inux.ibm.com/T/#u > > On 3/22/24 13:45, Harsh Prateek Bora wrote: > > + Vaibhav, Shiva > > > > Hi Salil, > > > > I came across your patch while trying to solve a related problem on > > spapr. One query below .. > > > > On 3/12/24 07:29

RE: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

> I came across your patch while trying to solve a related problem on spapr. > One query below .. > > On 3/12/24 07:29, Salil Mehta via wrote: > > KVM vCPU creation is done once during the vCPU realization when Qemu > > vCPU thread is spawned. This is common to all the

RE: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

Hi Vishnu, > From: Vishnu Pajjuri > Sent: Thursday, April 4, 2024 3:00 PM > Subject: Re: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU > {creation,parking} code > > Hi Salil, >> On 12-03-2024 07:29, Salil Mehta wrote: >> KVM vCPU creation is done once during the vCPU realization

RE: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

Hi Philippe, > From: Philippe Mathieu-Daudé > Sent: Friday, May 3, 2024 10:40 AM > Subject: Re: [PATCH V8 1/8] accel/kvm: Extract common KVM vCPU > {creation,parking} code > > Hi Salil, > > On 12/3/24 02:59, Salil Mehta wrote: > > KVM vCPU creation is done once during the vCPU

[PATCH V8 6/8] physmem: Add helper function to destroy CPU AddressSpace

Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by:

[PATCH V8 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta

[PATCH V8 7/8] gdbstub: Add helper function to unregister GDB register space

Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang --- gdbstub/gdbstub.c

[PATCH V8 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually results in start of the CPU scan. Scan figures out the CPU and the kind of event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT method with the call to \\_SB.CPUS.CSCN Also, macro

[PATCH V8 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO port based and existing CPUs AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control device(\\_SB.PRES) register interface is memory-mapped hence _CRS

[PATCH V8 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the _CRS object of GED to intimate OSPM about an event. Later then demultiplexes the notified event by evaluating ACPI _EVT method to know the type of event. Use ACPI GED to also notify the guest kernel about any CPU

[PATCH V8 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V8 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

KVM vCPU creation is done once during the vCPU realization when Qemu vCPU thread is spawned. This is common to all the architectures as of now. Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the corresponding KVM vCPU object in the Host KVM is not destroyed as KVM doesn't

[PATCH V8 0/8] Add architecture agnostic code to support vCPU Hotplug

Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 2,3] 3. ACPI CPUs AML code change

[PATCH V7 7/8] gdbstub: Add helper function to unregister GDB register space

Add common function to help unregister the GDB register space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by: Miguel Luis Reviewed-by: Shaoqin Huang --- gdbstub/gdbstub.c

[PATCH V7 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

GED interface is used by many hotplug events like memory hotplug, NVDIMM hotplug and non-hotplug events like system power down event. Each of these can be selected using a bit in the 32 bit GED IO interface. A bit has been reserved for the CPU hotplug event. Signed-off-by: Salil Mehta ---

[PATCH V7 6/8] physmem: Add helper function to destroy CPU AddressSpace

Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta Tested-by: Vishnu Pajjuri Reviewed-by: Gavin Shan Tested-by: Xianglai Li Tested-by:

[PATCH V7 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO port based and existing CPUs AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control device(\\_SB.PRES) register interface is memory-mapped hence _CRS

[PATCH V7 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually results in start of the CPU scan. Scan figures out the CPU and the kind of event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT method with the call to \\_SB.CPUS.CSCN Also, macro

[PATCH V7 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the _CRS object of GED to intimate OSPM about an event. Later then demultiplexes the notified event by evaluating ACPI _EVT method to know the type of event. Use ACPI GED to also notify the guest kernel about any CPU

[PATCH V7 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan

[PATCH V7 1/8] accel/kvm: Extract common KVM vCPU {creation, parking} code

KVM vCPU creation is done once during the vCPU realization when Qemu vCPU thread is spawned. This is common to all the architectures as of now. Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the corresponding KVM vCPU object in the Host KVM is not destroyed as KVM doesn't

[PATCH V7 0/8] Add architecture agnostic code to support vCPU Hotplug

Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 2,3] 3. ACPI CPUs AML code change

RE: [PATCH V6 5/9] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

Hi Igor, Sorry, I missed this as well. > From: Igor Mammedov > Sent: Friday, October 27, 2023 2:47 PM > To: Salil Mehta ; m...@redhat.com > > On Fri, 13 Oct 2023 11:51:25 +0100 > Salil Mehta wrote: > > > CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is > > based on > >

RE: [PATCH V6 4/9] hw/acpi: Init GED framework with CPU hotplug events

Hi Igor, Sorry, I realized I missed to reply this review comment. > From: Igor Mammedov > Sent: Friday, October 27, 2023 3:08 PM > To: Salil Mehta > > On Fri, 13 Oct 2023 11:51:24 +0100 > Salil Mehta wrote: > > > ACPI GED(as described in the ACPI 6.2 spec) can be used to generate ACPI > >

RE: [PATCH V6 7/9] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

Hi Igor, > From: Igor Mammedov > Sent: Friday, October 27, 2023 2:18 PM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- > phili...@linaro.org; Jonathan Cameron ; > lpieral...@kernel.org; peter.mayd...@linaro.org; > richard.hender...@linaro.org;

RE: [PATCH V6 3/9] hw/acpi: Add ACPI CPU hotplug init stub

Hi Igor, > From: Igor Mammedov > Sent: Friday, October 27, 2023 2:06 PM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- > phili...@linaro.org; Jonathan Cameron ; > lpieral...@kernel.org; peter.mayd...@linaro.org; > richard.hender...@linaro.org;

RE: [PATCH V6 1/9] accel/kvm: Extract common KVM vCPU {creation,parking} code

Hi Igor, Thanks for the review comments. I was bit on and off so could not address the comments. Please find my replies inline. > From: Igor Mammedov > Sent: Friday, October 27, 2023 1:57 PM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- >

RE: [PATCH V6 0/9] Add architecture agnostic code to support vCPU Hotplug

Hi Igor, > From: Igor Mammedov > Sent: Thursday, October 26, 2023 1:41 PM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- > phili...@linaro.org; Jonathan Cameron ; > lpieral...@kernel.org; peter.mayd...@linaro.org; > richard.hender...@linaro.org;

RE: [Question] x86/microvm: why has_hotpluggable_cpus = false but hot(ub)plug APIs exist?

> From: Igor Mammedov > Sent: Thursday, October 26, 2023 1:09 PM > To: Salil Mehta > > On Wed, 25 Oct 2023 09:54:07 + > Salil Mehta wrote: > > > > From: David Hildenbrand > > > Sent: Wednesday, October 25, 2023 10:32 AM > > > To: Salil Mehta ; Igor Mammedov > > > ; Salil Mehta > > > >

RE: [Question] x86/microvm: why has_hotpluggable_cpus = false but hot(ub)plug APIs exist?

> From: David Hildenbrand > Sent: Wednesday, October 25, 2023 10:32 AM > To: Salil Mehta ; Igor Mammedov > ; Salil Mehta > > On 25.10.23 11:16, Salil Mehta wrote: > > Hi Igor, > > > >> From: Igor Mammedov > >> Sent: Tuesday, October 24, 2023 9:06 AM > >> To: Salil Mehta > >> > >> On Wed, 18

RE: [Question] x86/microvm: why has_hotpluggable_cpus = false but hot(ub)plug APIs exist?

Hi Igor, > From: Igor Mammedov > Sent: Tuesday, October 24, 2023 9:06 AM > To: Salil Mehta > > On Wed, 18 Oct 2023 17:48:36 +0100 > Salil Mehta wrote: > > > Hi Alex, > > > > On 18/10/2023 16:41, Alex Bennée wrote: > > > > > > Salil Mehta writes: > > > > > >> Hello, > > >> > > >> Came across

RE: [PATCH V6 4/9] hw/acpi: Init GED framework with CPU hotplug events

Hi Alex, > From: Alex Bennée > Sent: Thursday, October 19, 2023 11:16 AM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- > phili...@linaro.org; Jonathan Cameron ; > lpieral...@kernel.org; peter.mayd...@linaro.org; > richard.hender...@linaro.org;

RE: [PATCH V6 0/9] Add architecture agnostic code to support vCPU Hotplug

ang...@loongson.cn; Linuxarm > Subject: Re: [PATCH V6 0/9] Add architecture agnostic code to support vCPU > Hotplug > > > > On 10/13/23 18:51, Salil Mehta via wrote: > > Virtual CPU hotplug support is being added across various > architectures[1][3]. > > This ser

RE: [PATCH RFC V2 35/37] hw/arm: Support hotplug capability check using _OSC method

Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 5:23 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 34/37] target/arm/kvm,tcg: Register/Handle SMCCC hypercall exits to VMM/Qemu

Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 5:15 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 29/37] arm/virt: Update the guest(via GED) about CPU hot-(un)plug events

Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 1:31 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

  1   2   3   4   >