On 23.04.23 04:54, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Friday, April 21, 2023 4:36 PM
To: Zhang, Chen;qemu-devel@nongnu.org
Cc:qemu-bl...@nongnu.org;michael.r...@amd.com;arm...@redhat.com;
ebl...@redhat.com;jasow...@redhat.com;quint
On 27.04.23 15:41, Vladimir Sementsov-Ogievskiy wrote:
On 27.04.23 12:53, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 53
1 file changed, 53 insertions(+)
diff --git a/docs/devel/qapi-code-gen.rst b/docs
On 27.04.23 12:53, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 53
1 file changed, 53 insertions(+)
diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index d81aac7a19..14983b074c
On 26.04.23 07:43, Michael S. Tsirkin wrote:
On Tue, Apr 25, 2023 at 07:14:34PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On incoming migration we have the following sequence to load option
ROM:
1. On device realize we do normal load ROM from the file
2. Than, on incoming migration we
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Notice that we changed the test of ->has_block_bitmap_mapping
for the test that block_bitmap_mapping is not NULL.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
migration/block-dirty-bitmap.c |
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
[same recommendations]
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
Still same recommendations: "const char *" and "s" becomes unused in
migration_tls_channel_process_incoming()
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
migration/options.c | 7 +++
migration/options.h | 1 +
migration/tls.c | 9 -
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/migration
On 24.04.23 21:32, Juan Quintela wrote:
This makes the function more regular with everything else.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
migration/migration.c | 4 ++--
migration/options.c | 4 +++-
migration/options.h | 2 +-
3 files changed
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 26.04.23 21:45, Vladimir Sementsov-Ogievskiy wrote:
On 24.04.23 21:32, Juan Quintela wrote:
Once there, make it more regular and remove th eneed for
some type here
haha, and my typo here
MigrationState parameter.
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards
On 24.04.23 21:32, Juan Quintela wrote:
Once there, make it more regular and remove th eneed for
some type here
MigrationState parameter.
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
uot;running", "singlestep": false, "running": true}}
The response of the QMP command contains the start & end time of
the QMP command processing.
Also, "start" & "end" timestaps are added to qemu guest agent responses as
qemu-ga shares the same code for
bdrv_drain_all_end()
in test_complete_in_standby().
Fixes: b6903cbe3a2 "tests/unit/test-blockjob: Disable
complete_in_standby test"
Suggested-by: Hanna Czenczek
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 25.04.23 19:48, Hanna Czenczek wrote:
On 24.04.23 20:32, Vladimir Sementsov-Ogievskiy wrote:
On 24.04.23 16:36, Emanuele Giuseppe Esposito wrote:
Am 21/04/2023 um 12:13 schrieb Vladimir Sementsov-Ogievskiy:
On 17.03.23 15:35, Thomas Huth wrote:
On 17/03/2023 11.17, Peter Maydell wrote
On 25.04.23 19:14, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
v2: simply ignore romfile on incoming migration when romsize is
specified.
Here I suggest a way to solve a problem, when we have existing
running QEMU with old option ROM of small size and want to migrate to
new environment where
Fix over-80 lines and missing curly brackets for if-operators, which
are required by QEMU coding style.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/pci/pci.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/pci/pci.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 4a61c8d24a..a442f8fce1 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -2292,7 +2292,7 @@ static void pci_add_option_rom
03; 01-02 are simple code style
improvements.
Vladimir Sementsov-Ogievskiy (3):
pci: pci_add_option_rom(): improve style
pci: pci_add_option_rom(): refactor: use g_autofree for path variable
pci: ROM preallocation for incoming migration
hw/pci/pci.c | 101
et-pci.rom[0]",
"property": "size" } }
Suggested-by: Michael S. Tsirkin
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/pci/pci.c | 77 ++--
1 file changed, 45 insertions(+), 32 deletions(-)
diff --git a/hw/pci/pci.
On 25.04.23 17:55, Igor Mammedov wrote:
On Tue, 25 Apr 2023 09:32:54 -0400
"Michael S. Tsirkin" wrote:
On Tue, Apr 25, 2023 at 04:19:12PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On 25.04.23 16:07, Vladimir Sementsov-Ogievskiy wrote:
On 25.04.23 15:43, Michael S. Tsirkin wrot
On 25.04.23 15:10, Gerd Hoffmann wrote:
On Tue, Apr 25, 2023 at 03:26:50AM -0400, Michael S. Tsirkin wrote:
On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On migration, on target we load local ROM file. But actual ROM content
migrates through migration channel
On 25.04.23 15:43, Michael S. Tsirkin wrote:
On Tue, Apr 25, 2023 at 01:56:03PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On incoming migration we have the following sequence to load option
ROM:
1. On device realize we do normal load ROM from the file
2. Than, on incoming migration we
On 25.04.23 16:07, Vladimir Sementsov-Ogievskiy wrote:
On 25.04.23 15:43, Michael S. Tsirkin wrote:
On Tue, Apr 25, 2023 at 01:56:03PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On incoming migration we have the following sequence to load option
ROM:
1. On device realize we do normal load ROM
ption on source)
2. On device realize we just preallocate ROM, and not load any file
3. On incoming migration ROM is filled from the migration stream
As a bonus we avoid extra reading from ROM file on target.
Signed-off-by: Vladimir Sementsov-Ogi
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/pci/pci.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 4a61c8d24a..a442f8fce1 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -2292,7 +2292,7 @@ static void pci_add_option_rom
Fix over-80 lines and missing curly brackets for if-operators, which
are required by QEMU coding style.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/pci/pci.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index
to
new environment where we don't have this ROM file.
All the details are in patch 03; 01-02 are simple code style
improvements.
Vladimir Sementsov-Ogievskiy (3):
pci: pci_add_option_rom(): improve style
pci: pci_add_option_rom(): refactor: use g_autofree for path variable
pci: ROM preallo
On 24.04.23 23:36, Vladimir Sementsov-Ogievskiy wrote:
On migration, on target we load local ROM file. But actual ROM content
migrates through migration channel. Original ROM content from local
file doesn't matter. But when size mismatch - we have an error like
Size mismatch: :00:03.0
On 25.04.23 10:43, Michael S. Tsirkin wrote:
On Tue, Apr 25, 2023 at 03:26:54AM -0400, Michael S. Tsirkin wrote:
On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On migration, on target we load local ROM file. But actual ROM content
migrates through migration
On 25.04.23 00:06, Michael S. Tsirkin wrote:
On Tue, Apr 25, 2023 at 12:02:49AM +0300, Vladimir Sementsov-Ogievskiy wrote:
On 24.04.23 23:45, Michael S. Tsirkin wrote:
On Mon, Apr 24, 2023 at 04:42:00PM -0400, Michael S. Tsirkin wrote:
On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir
On 24.04.23 23:45, Michael S. Tsirkin wrote:
On Mon, Apr 24, 2023 at 04:42:00PM -0400, Michael S. Tsirkin wrote:
On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On migration, on target we load local ROM file. But actual ROM content
migrates through migration
On 24.04.23 23:41, Michael S. Tsirkin wrote:
@@ -2366,7 +2368,8 @@ static void pci_add_option_rom(PCIDevice *pdev, bool
is_default_rom,
snprintf(name, sizeof(name), "%s.rom",
object_get_typename(OBJECT(pdev)));
}
pdev->has_rom = true;
-memory_region_init_rom(>rom,
On 24.04.23 21:32, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 24.04.23 21:32, Juan Quintela wrote:
Once there, rename it to migrate_tls() and make it return bool for
consistency.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
Let's just allow resizing of ROM memory. This way migration is not
relate on local ROM file on target node which is loaded by default but
is not actually needed.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/pci/pci.c | 7 +--
include/exec/memory.h | 26
On 24.04.23 16:36, Emanuele Giuseppe Esposito wrote:
Am 21/04/2023 um 12:13 schrieb Vladimir Sementsov-Ogievskiy:
On 17.03.23 15:35, Thomas Huth wrote:
On 17/03/2023 11.17, Peter Maydell wrote:
On Mon, 6 Mar 2023 at 11:16, Peter Maydell
wrote:
On Fri, 3 Mar 2023 at 18:36, Peter Maydell
On 24.04.23 12:07, Alex Bennée wrote:
Vladimir Sementsov-Ogievskiy writes:
On 20.04.23 18:57, Alex Bennée wrote:
There use makes our code safer so we should mention them.
Signed-off-by: Alex Bennée
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
docs/devel/style.rst | 36
On 15.02.23 16:25, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
Let's get rid of pattern
result = self.vm.qmp(...)
self.assert_qmp(result, 'return', {})
And switch to just
self.vm.cmd(...)
v5:
- include fixups by John
- fix 'make check-dev'
- split first patch into several
Only backup supports GROUPED mode. Make this logic more clear. And
avoid passing extra thing to each action.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 92 +++---
1 file changed, 19 insertions(+), 73 deletions(-)
diff --git
let's just transform what we have into new-style transaction
actions.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 317 +++--
1 file changed, 186 insertions(+), 131 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index d7b5c18f0a
t, we have to rename global map of actions, to not conflict with new
name for function argument.
Rename also dev_entry loop variable accordingly to new name of the
list.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 30 +++---
1 file changed, 15 insertions(+), 15
Hi all!
v8: resend, fix my emails
That's a portion of old good
"[PATCH v5 00/45] Transactional block-graph modifying API".
Let's refactor QMP transactions implementation into new (relatively)
transaction API.
Vladimir Sementsov-Ogievskiy (5):
blockdev: refactor transaction to use T
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 2174ab2694..89c573a094 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2375,7 +2375,7 @@ void qmp_transaction(TransactionActionList
-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 278 +
1 file changed, 89 insertions(+), 189 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index edaf7c6601..2bfa77e564 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1178,54 +1178,8
Add a command that can replace bs in following BdrvChild structures:
- qdev blk root child
- block-export blk root child
- any child of BlockDriverState selected by child-name
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 56
Currently for block exports we report empty blk names. That's not good.
Let's try to find corresponding block export and report its id.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 4
block/export/export.c | 13 +
include/block/export.h
Add an alternative method to check block graph, to be used in further
commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 17 +
1 file changed, 17 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index
Demonstrate new blockdev-replace API for filter insertion and removal.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/tests/filter-insertion | 257 ++
tests/qemu-iotests/tests/filter-insertion.out | 5 +
2 files changed, 262 insertions(+)
create mode
We need it for further blockdev-replace functionality.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/export/export.c | 18 ++
include/sysemu/block-backend-global-state.h | 1 +
2 files changed, 19 insertions(+)
diff --git a/block/export/export.c b
de by node-name and child name
To simplify things, let's postpone transaction support and start from
blockdev-replace single command. That still allows to insert filters
here and there!)
v7: rebase and change QAPI versions to 8.1
Vladimir Sementsov-Ogievskiy (7):
block-backend: blk_root():
We'll need get non-const child pointer for graph modifications in
further commits.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-backend.c | 2 +-
include/sysemu/block-backend-global-state.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
To be reused soon for blockdev-replace functionality.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 13 +
blockdev.c | 14 --
include/block/block_int-io.h | 1 +
3 files changed, 14 insertions(+), 14 deletions(-)
diff
DEVICE_DELETED and DEVICE_UNPLUG_GUEST_ERROR has equal data, let's
refactor it to one structure. That also helps to add new events
consistently.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/qdev.json | 39 +++
1 file changed, 27 insertions(+), 12
.
- force DEVICE_ON event to be triggered only once per device
- flatten query-hotplug output and add device-on status (corresponding
to DEVICE_ON event)
Vladimir Sementsov-Ogievskiy (4):
qapi/qdev.json: unite DEVICE_* event data into single structure
qapi: add DEVICE_ON and query-hotplug
For PCIe and SHPC hotplug it's important to track led indicators and
"device-on" status.
At this step, implement the prepared infrastructure in SHPC.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/pci-bridge/pci_bridge_dev.c | 14 ++
hw/pci-bridge/pcie_pci_bridge.c | 1
For PCIe and SHPC hotplug it's important to track led indicators and
"device-on" status.
At this step implement the prepared infrastructure in PCIe.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/pci/pcie.c | 83 +++
hw/pci/p
ntroller. That may
help to get additional information for further debugging when DEVICE_ON
/ DEVICE_DELETED not come in time as expected.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/core/hotplug.c | 13
include/hw/hotplug.h | 12
include/hw/qdev-core.h | 1 +
includ
On 17.03.23 15:35, Thomas Huth wrote:
On 17/03/2023 11.17, Peter Maydell wrote:
On Mon, 6 Mar 2023 at 11:16, Peter Maydell wrote:
On Fri, 3 Mar 2023 at 18:36, Peter Maydell wrote:
I've noticed that test-blockjob seems to fail intermittently
on the msys2-64bit job:
this could in
principle happen.
Fix it by checking hostlen.
Reported by Coverity.
Signed-off-by: Paolo Bonzini
I've already sent a similar patch, yes, but let's finally merge any:)
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
Let's add --enable / --disable configure options for these formats,
so that those who don't need them may not build them.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
v2: just a resend instead of ping, bonus: fix mistake in commit message.
block/meson.build | 18
On 20.04.23 18:57, Alex Bennée wrote:
There use makes our code safer so we should mention them.
Signed-off-by: Alex Bennée
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
docs/devel/style.rst | 36
1 file changed, 36 insertions(+)
diff --git a/docs
On 21.04.23 05:22, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Thursday, April 20, 2023 7:26 PM
To: Zhang, Chen ; qemu-devel@nongnu.org
Cc: qemu-bl...@nongnu.org; michael.r...@amd.com; arm...@redhat.com;
ebl...@redhat.com; jasow...@redhat.com; quint
On 21.04.23 06:02, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Thursday, April 20, 2023 6:53 AM
To: qemu-devel@nongnu.org
Cc: qemu-bl...@nongnu.org; michael.r...@amd.com; arm...@redhat.com;
ebl...@redhat.com; jasow...@redhat.com; quint...@redhat.com
On 16.03.23 00:22, Paolo Bonzini wrote:
On 3/15/23 15:28, Vladimir Sementsov-Ogievskiy wrote:
On 22.02.23 18:57, Peter Maydell wrote:
On Wed, 22 Feb 2023 at 14:19, Stefan Hajnoczi wrote:
On Wed, 15 Feb 2023 at 15:22, Vladimir Sementsov-Ogievskiy
wrote:
ping
[add Stefan]
I'm
On 20.04.23 16:39, Juan Quintela wrote:
To be consistent with every other parameter, rename to
migrate_block_incremental().
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 16:39, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 17:43, Eric Blake wrote:
On Thu, Apr 20, 2023 at 01:52:30AM +0300, Vladimir Sementsov-Ogievskiy wrote:
To be used in the next commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/qapi/types.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/qapi
On 02.03.23 19:33, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_return_path()
to be consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_block()
to be consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_xbzrle()
to be consistent with all other capabilities.
We change the type to return bool also for consistency.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best
-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_events()
to be consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_multifd()
to be consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_compress()
to be consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
migration/migration.h | 1 -
migration/options.h | 1
On 02.03.23 19:33, Juan Quintela wrote:
Once that we are there, we rename the function to migrate_colo() to be
consistent with all other capabilities.
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 20.04.23 13:03, Juan Quintela wrote:
Vladimir Sementsov-Ogievskiy wrote:
We don't allow to use x-colo capability when replication is not
configured. So, no reason to build COLO when replication is disabled,
it's unusable in this case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
+bool
On 20.04.23 12:09, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Thursday, April 20, 2023 6:53 AM
To: qemu-devel@nongnu.org
Cc: qemu-bl...@nongnu.org; michael.r...@amd.com; arm...@redhat.com;
ebl...@redhat.com; jasow...@redhat.com; quint...@redhat.com
On 20.04.23 11:33, Lukas Straub wrote:
On Thu, 20 Apr 2023 01:52:28 +0300
Vladimir Sementsov-Ogievskiy wrote:
Hi all!
COLO substem seems to be useless when CONFIG_REPLICATION is unset, as we
simply don't allow to set x-colo capability in this case. So, let's not
compile in unreachable code
To be used in the next commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/qapi/types.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/qapi/types.py b/scripts/qapi/types.py
index c39d054d2c..18f8734047 100644
--- a/scripts/qapi/types.py
+++ b/scripts/qapi/types.py
We don't allow to use x-colo capability when replication is not
configured. So, no reason to build COLO when replication is disabled,
it's unusable in this case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hmp-commands.hx| 2 ++
migration/colo.c | 6
Add option to not build COLO Proxy subsystem if it is not needed.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
meson.build | 1 +
meson_options.txt | 2 ++
net/meson.build | 11 ---
scripts/meson-buildoptions.sh | 3 +++
4 files changed
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/meson.build b/block/meson.build
index 382bec0e7d..b9a72e219b 100644
--- a/block/meson.build
+++ b/block/meson.build
@@ -84,7 +84,7 @@ block_ss.add(when
Proxy subsystem.
v1 was
[PATCH] replication: compile out some staff when replication is not configured
Supersedes: <20230411145112.497785-1-vsement...@yandex-team.ru>
Vladimir Sementsov-Ogievskiy (4):
block/meson.build: prefer positive condition for replication
scripts/qapi: allow op
On 11.04.23 17:51, Vladimir Sementsov-Ogievskiy wrote:
Don't compile-in replication-related files when replication is disabled
in config.
Signed-off-by: Vladimir Sementsov-Ogievskiy
v2 will be called "[PATCH v2 0/4] COLO: improve build options"
--
Best regards,
Vladimir
On 17.04.23 20:19, Vladimir Sementsov-Ogievskiy wrote:
On 16.04.23 21:44, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Friday, April 14, 2023 5:51 PM
To: Zhang, Chen ; qemu-devel@nongnu.org
Cc: qemu-bl...@nongnu.org; pbonz...@redhat.com; arm
On 16.04.23 21:44, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Friday, April 14, 2023 5:51 PM
To: Zhang, Chen ; qemu-devel@nongnu.org
Cc: qemu-bl...@nongnu.org; pbonz...@redhat.com; arm...@redhat.com;
ebl...@redhat.com; jasow...@redhat.com; dgilb
On 21.03.23 23:13, Vladimir Sementsov-Ogievskiy wrote:
Currently block_resize qmp command is simply ignored by vhost-user-blk
export. So, the block-node is successfully resized, but virtio config
is unchanged and guest doesn't see that disk is resized.
Let's handle the resize by modifying
On 14.04.23 04:24, Zhang, Chen wrote:
So, if I want to have an option to disable all COLO modules, do you mean it
should be additional --disable-colo option? Or better keep one option --
disable-replication (and, maybe just rename to to --disable-colo)?
I think keep the option
On 13.04.23 12:52, Zhang, Chen wrote:
-Original Message-
From: Vladimir Sementsov-Ogievskiy
Sent: Tuesday, April 11, 2023 10:51 PM
To: qemu-devel@nongnu.org
Cc: qemu-bl...@nongnu.org; pbonz...@redhat.com; arm...@redhat.com;
ebl...@redhat.com; jasow...@redhat.com; dgilb...@redhat.com
501 - 600 of 10944 matches
Mail list logo
