Re: [PATCH] Allow UNIX socket for VNC websocket

2023-07-24 Thread Daniel P . Berrangé
On Mon, Jul 24, 2023 at 12:03:56AM +0300, Sergii Zasenko wrote: > Signed-off-by: Sergii Zasenko > --- > ui/vnc.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/ui/vnc.c b/ui/vnc.c > index 92964dc..dea1414 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -3715,11 +3715,6 @@ static int

Re: [PATCH] Allow UNIX socket for VNC websocket

2023-07-24 Thread Daniel P . Berrangé
On Mon, Jul 24, 2023 at 12:08:26PM +0400, Marc-André Lureau wrote: > Hi > > Daniel, in commit 275e0d616b ("ui: refactor code for populating > SocketAddress from vnc_display_open"), you said "This refactoring also > removes the restriction that prevents enabling websockets when the plain > VNC

Re: [PATCH] Allow UNIX socket for VNC websocket

2023-07-24 Thread Marc-André Lureau
Hi Daniel, in commit 275e0d616b ("ui: refactor code for populating SocketAddress from vnc_display_open"), you said "This refactoring also removes the restriction that prevents enabling websockets when the plain VNC server is listening on a UNIX socket.". But you didn't remove the condition. I

[PATCH] Allow UNIX socket for VNC websocket

2023-07-23 Thread Sergii Zasenko
Signed-off-by: Sergii Zasenko --- ui/vnc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 92964dc..dea1414 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3715,11 +3715,6 @@ static int vnc_display_get_address(const char *addrstr, addr->type =