On Wed, 31 May 2023 at 16:47, Kambalin, Sergey
wrote:
>
> Hello!
>
> Thank you guys for clarifications!
>
>
> > Are the VC4 properties supposed to be present on
> > all our existing raspi models? (i.e. is this a bug
> > fix for our existing models rather than stuff we only
> > want on the new
ll the tests?
От: Philippe Mathieu-Daudé
Отправлено: 30 мая 2023 г. 17:02:00
Кому: Kambalin, Sergey; Peter Maydell; Sergey Kambalin
Копия: qemu-...@nongnu.org; qemu-devel@nongnu.org
Тема: Re: [PATCH] Prepare bcm properties for videocore 4
On 30/5/23 15:00, Kambalin, Sergey
On 30/5/23 15:00, Kambalin, Sergey wrote:
Got it! Thanks!
I'll split this one to three patches:
1) replace magic numbers with named constants (refactoring)
2) add new properties for VC 4
3) Add some unit tests to check the newly added properties via mailbox
Is it OK?
This looks good. Try
On Tue, 30 May 2023 at 14:00, Kambalin, Sergey
wrote:
>
> Got it! Thanks!
>
> I'll split this one to three patches:
> 1) replace magic numbers with named constants (refactoring)
>
> 2) add new properties for VC 4
>
> 3) Add some unit tests to check the newly added properties via mailbox
Are the
- this is my first
experience with OSS)
От: Peter Maydell
Отправлено: 30 мая 2023 г. 15:12:24
Кому: Sergey Kambalin
Копия: qemu-...@nongnu.org; qemu-devel@nongnu.org; Kambalin, Sergey
Тема: Re: [PATCH] Prepare bcm properties for videocore 4
On Wed, 24 May 2023 at 20:15
On Wed, 24 May 2023 at 20:15, Sergey Kambalin wrote:
>
> Hello!
> Sorry for a quite a big patch, but most of the changes are the same type.
> Most of the patch is about a definition of new constants/structs and replacing
> magic numbers with those constants.
>
>
> Signed-off-by: Sergey Kambalin
Hello!
Sorry for a quite a big patch, but most of the changes are the same type.
Most of the patch is about a definition of new constants/structs and replacing
magic numbers with those constants.
Signed-off-by: Sergey Kambalin
---
hw/misc/bcm2835_property.c| 314
