Re: [PATCH] mv64361: Remove extra break from a switch case

2021-07-12 Thread David Gibson
On Mon, Jul 12, 2021 at 03:11:01PM +0200, BALATON Zoltan wrote: > The switch case of writing PCI 1 IO base address had an extra break > statement that made part of the code unreachable. This did not cause a > problem as guests ususally leave this register at its default value. > > Reported-by:

Re: [PATCH] mv64361: Remove extra break from a switch case

2021-07-12 Thread BALATON Zoltan
On Mon, 12 Jul 2021, Philippe Mathieu-Daudé wrote: On 7/12/21 3:11 PM, BALATON Zoltan wrote: The switch case of writing PCI 1 IO base address had an extra break statement that made part of the code unreachable. This did not cause a problem as guests ususally leave this register at its default

Re: [PATCH] mv64361: Remove extra break from a switch case

2021-07-12 Thread Philippe Mathieu-Daudé
On 7/12/21 3:11 PM, BALATON Zoltan wrote: > The switch case of writing PCI 1 IO base address had an extra break > statement that made part of the code unreachable. This did not cause a > problem as guests ususally leave this register at its default value. > > Reported-by: Coverity (CID 1458135)

[PATCH] mv64361: Remove extra break from a switch case

2021-07-12 Thread BALATON Zoltan
The switch case of writing PCI 1 IO base address had an extra break statement that made part of the code unreachable. This did not cause a problem as guests ususally leave this register at its default value. Reported-by: Coverity (CID 1458135) Signed-off-by: BALATON Zoltan ---