Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-10 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Mar 10, 2022 at 03:11:08PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Thu, Mar 10, 2022 at 2:56 PM Daniel P. Berrangé > > wrote: > > > > > On Mon, Mar 07, 2022 at 11:09:37AM +0100, Thomas Huth wrote: > > > > On 07/03/2022 11.06,

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-10 Thread Marc-André Lureau
Hi On Thu, Mar 10, 2022 at 3:35 PM Daniel P. Berrangé wrote: > On Thu, Mar 10, 2022 at 03:11:08PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Thu, Mar 10, 2022 at 2:56 PM Daniel P. Berrangé > > wrote: > > > > > On Mon, Mar 07, 2022 at 11:09:37AM +0100, Thomas Huth wrote: > > > > On 07/03/

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-10 Thread Daniel P . Berrangé
On Thu, Mar 10, 2022 at 03:50:58PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Mar 10, 2022 at 3:35 PM Daniel P. Berrangé > wrote: > > > On Thu, Mar 10, 2022 at 03:11:08PM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On Thu, Mar 10, 2022 at 2:56 PM Daniel P. Berrangé > > > wrote: >

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-10 Thread Marc-André Lureau
Hi On Thu, Mar 10, 2022 at 3:35 PM Daniel P. Berrangé wrote: > > Removing either 'assert' or g_assert would be a massive amount of code > churn, for no real functional benefit. > > Well, a few thousands of lines that are trivially regexp. And we can make use of git blame ignore-rev (https://mich

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-10 Thread Thomas Huth
On 10/03/2022 12.35, Daniel P. Berrangé wrote: On Thu, Mar 10, 2022 at 03:11:08PM +0400, Marc-André Lureau wrote: Hi On Thu, Mar 10, 2022 at 2:56 PM Daniel P. Berrangé wrote: On Mon, Mar 07, 2022 at 11:09:37AM +0100, Thomas Huth wrote: On 07/03/2022 11.06, Daniel P. Berrangé wrote: On Mon,

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-10 Thread Daniel P . Berrangé
On Thu, Mar 10, 2022 at 03:11:08PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Mar 10, 2022 at 2:56 PM Daniel P. Berrangé > wrote: > > > On Mon, Mar 07, 2022 at 11:09:37AM +0100, Thomas Huth wrote: > > > On 07/03/2022 11.06, Daniel P. Berrangé wrote: > > > > On Mon, Mar 07, 2022 at 02:51:23

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-10 Thread Marc-André Lureau
Hi On Thu, Mar 10, 2022 at 2:56 PM Daniel P. Berrangé wrote: > On Mon, Mar 07, 2022 at 11:09:37AM +0100, Thomas Huth wrote: > > On 07/03/2022 11.06, Daniel P. Berrangé wrote: > > > On Mon, Mar 07, 2022 at 02:51:23PM +0800, Peter Xu wrote: > > > > On Wed, Mar 02, 2022 at 05:49:18PM +, Daniel

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-10 Thread Daniel P . Berrangé
On Mon, Mar 07, 2022 at 11:09:37AM +0100, Thomas Huth wrote: > On 07/03/2022 11.06, Daniel P. Berrangé wrote: > > On Mon, Mar 07, 2022 at 02:51:23PM +0800, Peter Xu wrote: > > > On Wed, Mar 02, 2022 at 05:49:18PM +, Daniel P. Berrangé wrote: > > > > The QMP commands have a trailing newline, but

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-07 Thread Peter Xu
On Mon, Mar 07, 2022 at 11:09:37AM +0100, Thomas Huth wrote: > On 07/03/2022 11.06, Daniel P. Berrangé wrote: > > On Mon, Mar 07, 2022 at 02:51:23PM +0800, Peter Xu wrote: > > > On Wed, Mar 02, 2022 at 05:49:18PM +, Daniel P. Berrangé wrote: > > > > The QMP commands have a trailing newline, but

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-07 Thread Daniel P . Berrangé
On Mon, Mar 07, 2022 at 02:51:23PM +0800, Peter Xu wrote: > On Wed, Mar 02, 2022 at 05:49:18PM +, Daniel P. Berrangé wrote: > > The QMP commands have a trailing newline, but the response does not. > > This makes the qtest logs hard to follow as the next QMP command > > appears in the same line

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-07 Thread Thomas Huth
On 07/03/2022 11.06, Daniel P. Berrangé wrote: On Mon, Mar 07, 2022 at 02:51:23PM +0800, Peter Xu wrote: On Wed, Mar 02, 2022 at 05:49:18PM +, Daniel P. Berrangé wrote: The QMP commands have a trailing newline, but the response does not. This makes the qtest logs hard to follow as the next

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-06 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:18PM +, Daniel P. Berrangé wrote: > The QMP commands have a trailing newline, but the response does not. > This makes the qtest logs hard to follow as the next QMP command > appears in the same line as the previous QMP response. > > Signed-off-by: Daniel P. Berran

[PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-02 Thread Daniel P . Berrangé
The QMP commands have a trailing newline, but the response does not. This makes the qtest logs hard to follow as the next QMP command appears in the same line as the previous QMP response. Signed-off-by: Daniel P. Berrangé --- tests/qtest/libqtest.c | 3 +++ 1 file changed, 3 insertions(+) diff