Re: [PATCH 2/7] block/nvme: drop tautologous assertion

2020-05-26 Thread Philippe Mathieu-Daudé
On 5/19/20 7:11 PM, Stefan Hajnoczi wrote: > nvme_process_completion() explicitly checks cid so the assertion that > follows is always true: > > if (cid == 0 || cid > NVME_QUEUE_SIZE) { > ... > continue; > } > assert(cid <= NVME_QUEUE_SIZE); > > Signed-off-by: Stefan Hajnoczi >

Re: [PATCH 2/7] block/nvme: drop tautologous assertion

2020-05-25 Thread Sergio Lopez
On Tue, May 19, 2020 at 06:11:33PM +0100, Stefan Hajnoczi wrote: > nvme_process_completion() explicitly checks cid so the assertion that > follows is always true: > > if (cid == 0 || cid > NVME_QUEUE_SIZE) { > ... > continue; > } > assert(cid <= NVME_QUEUE_SIZE); > > Signed-off-

[PATCH 2/7] block/nvme: drop tautologous assertion

2020-05-19 Thread Stefan Hajnoczi
nvme_process_completion() explicitly checks cid so the assertion that follows is always true: if (cid == 0 || cid > NVME_QUEUE_SIZE) { ... continue; } assert(cid <= NVME_QUEUE_SIZE); Signed-off-by: Stefan Hajnoczi --- block/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --g