Re: [PATCH 4/5] hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple()

2020-06-30 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > We use "create_simple" names for functions that allocate, initialize, > configure and realize device objects: pci_create_simple(), > isa_create_simple(), usb_create_simple(). For consistency, rename > i2c_create_slave() as i2c_slave_create_simple(). Since we have

Re: [PATCH 4/5] hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple()

2020-06-29 Thread Corey Minyard
On Mon, Jun 29, 2020 at 07:38:20PM +0200, Philippe Mathieu-Daudé wrote: > We use "create_simple" names for functions that allocate, initialize, > configure and realize device objects: pci_create_simple(), > isa_create_simple(), usb_create_simple(). For consistency, rename > i2c_create_slave() as

[PATCH 4/5] hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple()

2020-06-29 Thread Philippe Mathieu-Daudé
We use "create_simple" names for functions that allocate, initialize, configure and realize device objects: pci_create_simple(), isa_create_simple(), usb_create_simple(). For consistency, rename i2c_create_slave() as i2c_slave_create_simple(). Since we have to update all the callers, also let it