Re: [PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

2020-01-27 Thread Robert Foley
On Mon, 27 Jan 2020 at 15:07, Alex Bennée wrote: > Robert Foley writes: > > > Hi Drew, > > > > On Mon, 27 Jan 2020 at 12:27, Andrew Jones wrote: > > > >> > > >> > I suppose we could check the version of QEMU and use the above > >> > defaults only for earlier versions of QEMU. > >> > This is

Re: [PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

2020-01-27 Thread Alex Bennée
Robert Foley writes: > Hi Drew, > > On Mon, 27 Jan 2020 at 12:27, Andrew Jones wrote: > >> > >> > I suppose we could check the version of QEMU and use the above >> > defaults only for earlier versions of QEMU. >> > This is something we will probably move to aarch64vm.py since it is common. >>

Re: [PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

2020-01-27 Thread Robert Foley
Hi Drew, On Mon, 27 Jan 2020 at 12:27, Andrew Jones wrote: > > > > I suppose we could check the version of QEMU and use the above > > defaults only for earlier versions of QEMU. > > This is something we will probably move to aarch64vm.py since it is common. > > What versions of QEMU do these

Re: [PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

2020-01-27 Thread Andrew Jones
On Mon, Jan 27, 2020 at 11:47:35AM -0500, Robert Foley wrote: > On Mon, 27 Jan 2020 at 10:01, Alex Bennée wrote: > > > vm-boot-ssh-%: $(IMAGES_DIR)/%.img > > > $(call quiet-command, \ > > > - $(SRC_PATH)/tests/vm/$* \ > > > + $(PYTHON) $(SRC_PATH)/tests/vm/$* \ > >

Re: [PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

2020-01-27 Thread Robert Foley
On Mon, 27 Jan 2020 at 10:01, Alex Bennée wrote: > > vm-boot-ssh-%: $(IMAGES_DIR)/%.img > > $(call quiet-command, \ > > - $(SRC_PATH)/tests/vm/$* \ > > + $(PYTHON) $(SRC_PATH)/tests/vm/$* \ > > This seems like it should be in a different patch. Good point, will

Re: [PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

2020-01-27 Thread Alex Bennée
Robert Foley writes: > ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. > Another new file is also added aarch64vm.py, which is a module with > common methods used by aarch64 VMs, such as how to create the > flash images. > > Signed-off-by: Robert Foley > Reviewed-by: Peter

[PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

2020-01-24 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include |