Re: [PATCH v1 1/1] chardev: enable guest socket status/crontrol via DTR and DCD

2022-01-12 Thread Darrin M. Gorski
Unfortunately I ran out of cycles at the time. Adding test cases seems like it was the roadblock - I don't think I ever figured out how to implement the needed build tests for this additional feature in chardev. I'm not that strong of a C developer, unfortunately. I haven't looked at picking

Re: [PATCH v1 1/1] chardev: enable guest socket status/crontrol via DTR and DCD

2022-01-12 Thread Aaro Koskinen
Hi, On Wed, Dec 16, 2020 at 05:06:51PM -0500, Darrin M. Gorski wrote: > This patch adds a 'modemctl' option to "-chardev socket" to enable control > of the socket via the guest serial port. > The default state of the option is disabled. > > 1. disconnect a connected socket when DTR transitions

Re: [PATCH v1 1/1] chardev: enable guest socket status/crontrol via DTR and DCD

2020-12-23 Thread Eric Blake
On 12/16/20 4:06 PM, Darrin M. Gorski wrote: > This patch adds a 'modemctl' option to "-chardev socket" to enable control > of the socket via the guest serial port. > The default state of the option is disabled. > > 1. disconnect a connected socket when DTR transitions to low, also reject > new

Re: [PATCH v1 1/1] chardev: enable guest socket status/crontrol via DTR and DCD

2020-12-18 Thread Darrin M. Gorski
>> Yes, but they can override the default behaviour, or just reuse some code. >> If it doesn't fit, don't worry about it, we can just start with socket. Whew. I spent several hours yesterday trying to figure out how to alter the base class to support this - DCD could be reasonably simple, but

Re: [PATCH v1 1/1] chardev: enable guest socket status/crontrol via DTR and DCD

2020-12-18 Thread Marc-André Lureau
Hi On Thu, Dec 17, 2020 at 9:54 PM Darrin M. Gorski wrote: > > > That sounds like a good idea to me, but others may have different > opinions. > > My original idea was simply to allow DCD to track socket state, because > this is what I need. The DTR idea came from the referenced bug. The >

Re: [PATCH v1 1/1] chardev: enable guest socket status/crontrol via DTR and DCD

2020-12-17 Thread Darrin M. Gorski
> That sounds like a good idea to me, but others may have different opinions. My original idea was simply to allow DCD to track socket state, because this is what I need. The DTR idea came from the referenced bug. The feature defaults to disabled like many of the other edge cases (like telnet

Re: [PATCH v1 1/1] chardev: enable guest socket status/crontrol via DTR and DCD

2020-12-17 Thread Marc-André Lureau
Hi On Thu, Dec 17, 2020 at 2:54 AM Darrin M. Gorski wrote: > > This patch adds a 'modemctl' option to "-chardev socket" to enable control > of the socket via the guest serial port. > The default state of the option is disabled. > > 1. disconnect a connected socket when DTR transitions to low,

[PATCH v1 1/1] chardev: enable guest socket status/crontrol via DTR and DCD

2020-12-16 Thread Darrin M. Gorski
This patch adds a 'modemctl' option to "-chardev socket" to enable control of the socket via the guest serial port. The default state of the option is disabled. 1. disconnect a connected socket when DTR transitions to low, also reject new connections while DTR is low. 2. provide socket connection