Re: [PATCH v2 06/25] util: Add CRC16 (CCITT) calculation routines

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/24/21 10:41 PM, Richard Henderson wrote: > On 1/24/21 10:24 AM, Philippe Mathieu-Daudé wrote: >> On 1/24/21 9:07 PM, Richard Henderson wrote: >>> Doesn't this get put in libutil, where it is only pulled from the archive >>> when >>> needed? Also, libutil is built once, not per-target. >> >>

Re: [PATCH v2 06/25] util: Add CRC16 (CCITT) calculation routines

2021-01-24 Thread Richard Henderson
On 1/24/21 10:24 AM, Philippe Mathieu-Daudé wrote: > On 1/24/21 9:07 PM, Richard Henderson wrote: >> Doesn't this get put in libutil, where it is only pulled from the archive >> when >> needed? Also, libutil is built once, not per-target. > > Hmm I just sent a pull request with this change

Re: [PATCH v2 06/25] util: Add CRC16 (CCITT) calculation routines

2021-01-24 Thread Philippe Mathieu-Daudé
On 1/24/21 9:07 PM, Richard Henderson wrote: > On 1/24/21 8:59 AM, Philippe Mathieu-Daudé wrote: >> On 1/23/21 11:39 AM, Bin Meng wrote: >>> From: Bin Meng >>> >>> Import CRC16 calculation routines from Linux kernel v5.10: >>> >>> include/linux/crc-ccitt.h >>> lib/crc-ccitt.c >>> >>> to QEMU:

Re: [PATCH v2 06/25] util: Add CRC16 (CCITT) calculation routines

2021-01-24 Thread Richard Henderson
On 1/24/21 8:59 AM, Philippe Mathieu-Daudé wrote: > On 1/23/21 11:39 AM, Bin Meng wrote: >> From: Bin Meng >> >> Import CRC16 calculation routines from Linux kernel v5.10: >> >> include/linux/crc-ccitt.h >> lib/crc-ccitt.c >> >> to QEMU: >> >> include/qemu/crc-ccitt.h >> util/crc-ccitt.c

Re: [PATCH v2 06/25] util: Add CRC16 (CCITT) calculation routines

2021-01-24 Thread Philippe Mathieu-Daudé
On 1/23/21 11:39 AM, Bin Meng wrote: > From: Bin Meng > > Import CRC16 calculation routines from Linux kernel v5.10: > > include/linux/crc-ccitt.h > lib/crc-ccitt.c > > to QEMU: > > include/qemu/crc-ccitt.h > util/crc-ccitt.c > > Signed-off-by: Bin Meng > Acked-by: Alistair Francis

[PATCH v2 06/25] util: Add CRC16 (CCITT) calculation routines

2021-01-23 Thread Bin Meng
From: Bin Meng Import CRC16 calculation routines from Linux kernel v5.10: include/linux/crc-ccitt.h lib/crc-ccitt.c to QEMU: include/qemu/crc-ccitt.h util/crc-ccitt.c Signed-off-by: Bin Meng Acked-by: Alistair Francis --- (no changes since v1) include/qemu/crc-ccitt.h | 33