Re: [PATCH v2 13/15] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h'

2023-09-26 Thread Markus Armbruster
Paolo Bonzini writes: > On 9/25/23 13:03, Markus Armbruster wrote: >> +David >> Markus Armbruster writes: >> >>> Philippe Mathieu-Daudé writes: >>> DEFINE_PROP_DMAADDR() is only used once. Since it doesn't add much value, simply remove it, along with the header defining it.

Re: [PATCH v2 13/15] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h'

2023-09-25 Thread Paolo Bonzini
On 9/25/23 13:03, Markus Armbruster wrote: +David Markus Armbruster writes: Philippe Mathieu-Daudé writes: DEFINE_PROP_DMAADDR() is only used once. Since it doesn't add much value, simply remove it, along with the header defining it. Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v2 13/15] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h'

2023-09-25 Thread Markus Armbruster
+David Markus Armbruster writes: > Philippe Mathieu-Daudé writes: > >> DEFINE_PROP_DMAADDR() is only used once. Since it doesn't >> add much value, simply remove it, along with the header >> defining it. >> >> Signed-off-by: Philippe Mathieu-Daudé > > DEFINE_PROP_DMAADDR() lets you wrap a

Re: [PATCH v2 13/15] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h'

2023-09-25 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > DEFINE_PROP_DMAADDR() is only used once. Since it doesn't > add much value, simply remove it, along with the header > defining it. > > Signed-off-by: Philippe Mathieu-Daudé DEFINE_PROP_DMAADDR() lets you wrap a property around a dma_addr_t member without

[PATCH v2 13/15] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h'

2023-02-03 Thread Philippe Mathieu-Daudé
DEFINE_PROP_DMAADDR() is only used once. Since it doesn't add much value, simply remove it, along with the header defining it. Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/hcd-ohci-pci.c | 1 - hw/usb/hcd-ohci.c | 3 +-- include/hw/qdev-dma.h | 16 3 files changed, 1