Re: [PATCH v2 2/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-17 Thread Ani Sinha
On Mon, Feb 14, 2022 at 6:21 PM Igor Mammedov wrote: > > On Mon, 7 Feb 2022 17:01:28 +0530 > Ani Sinha wrote: > > > With the current smbios table assignment code, we can have only 512 DIMM > > slots > it's a bit confusing, since it's not DIMM slots in QEMU sense (we do not > expose > DIMM

Re: [PATCH v2 2/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-14 Thread Igor Mammedov
On Mon, 7 Feb 2022 17:01:28 +0530 Ani Sinha wrote: > With the current smbios table assignment code, we can have only 512 DIMM slots it's a bit confusing, since it's not DIMM slots in QEMU sense (we do not expose DIMM devices via SMBIOS/E820). So maybe clarify here that initial RAM is split into

[PATCH v2 2/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-07 Thread Ani Sinha
With the current smbios table assignment code, we can have only 512 DIMM slots (each DIMM of 16 GiB in size) before tables 17 and 19 conflict with their addresses. A guest with more than 8 TiB of memory will hit this limitation and would fail with the following assertion in isa-debugcon: