Re: [PATCH v2 26/28] target/ppc/mmu_common.c: Move BookE MMU functions together

2024-05-08 Thread Nicholas Piggin
On Thu May 9, 2024 at 9:33 AM AEST, BALATON Zoltan wrote: > On Wed, 8 May 2024, Nicholas Piggin wrote: > > On Tue May 7, 2024 at 10:31 PM AEST, BALATON Zoltan wrote: > >> On Tue, 7 May 2024, Nicholas Piggin wrote: > >>> What do you think about adding mmu-book3e.c instead? > >> > >> I have

Re: [PATCH v2 26/28] target/ppc/mmu_common.c: Move BookE MMU functions together

2024-05-08 Thread BALATON Zoltan
On Wed, 8 May 2024, Nicholas Piggin wrote: On Tue May 7, 2024 at 10:31 PM AEST, BALATON Zoltan wrote: On Tue, 7 May 2024, Nicholas Piggin wrote: What do you think about adding mmu-book3e.c instead? I have considered that but found that some functions have to be in the same file and declared

Re: [PATCH v2 26/28] target/ppc/mmu_common.c: Move BookE MMU functions together

2024-05-08 Thread Nicholas Piggin
On Tue May 7, 2024 at 10:31 PM AEST, BALATON Zoltan wrote: > On Tue, 7 May 2024, Nicholas Piggin wrote: > > What do you think about adding mmu-book3e.c instead? > > I have considered that but found that some functions have to be in the > same file and declared static for the compiler to inline

Re: [PATCH v2 26/28] target/ppc/mmu_common.c: Move BookE MMU functions together

2024-05-07 Thread BALATON Zoltan
On Tue, 7 May 2024, Nicholas Piggin wrote: What do you think about adding mmu-book3e.c instead? Now I remember that besides possible performance loss because of loss of automatic inline if not all functions are static the other reason was that these functions use mmu_ctx_t that I don't want

Re: [PATCH v2 26/28] target/ppc/mmu_common.c: Move BookE MMU functions together

2024-05-07 Thread BALATON Zoltan
On Tue, 7 May 2024, Nicholas Piggin wrote: What do you think about adding mmu-book3e.c instead? I have considered that but found that some functions have to be in the same file and declared static for the compiler to inline them otherwise I get worse performance. Maybe after these

Re: [PATCH v2 26/28] target/ppc/mmu_common.c: Move BookE MMU functions together

2024-05-07 Thread Nicholas Piggin
What do you think about adding mmu-book3e.c instead? Thanks, Nick On Thu May 2, 2024 at 9:43 AM AEST, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > target/ppc/mmu_common.c | 300 > 1 file changed, 150 insertions(+), 150 deletions(-) > >

[PATCH v2 26/28] target/ppc/mmu_common.c: Move BookE MMU functions together

2024-05-01 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 300 1 file changed, 150 insertions(+), 150 deletions(-) diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c index b76611da80..204b8af455 100644 --- a/target/ppc/mmu_common.c +++