Re: [PATCH v3 02/20] exec: Split out variable page size support to exec-vary.c

2019-09-23 Thread Richard Henderson
On 9/23/19 1:26 AM, David Hildenbrand wrote: >> +void finalize_target_page_bits(void) >> +{ >> +#ifdef TARGET_PAGE_BITS_VARY >> +if (target_page_bits == 0) { >> +target_page_bits = TARGET_PAGE_BITS_MIN; >> +} >> +target_page_bits_decided = true; >> +#endif >> +} > I wonder if

Re: [PATCH v3 02/20] exec: Split out variable page size support to exec-vary.c

2019-09-23 Thread David Hildenbrand
On 22.09.19 05:54, Richard Henderson wrote: > The next patch will play a trick with "const" that will > confuse the compiler about the uses of target_page_bits > within exec.c. Moving everything to a new file prevents > this confusion. > > No functional change so far. > > Reviewed-by: Philippe

[PATCH v3 02/20] exec: Split out variable page size support to exec-vary.c

2019-09-21 Thread Richard Henderson
The next patch will play a trick with "const" that will confuse the compiler about the uses of target_page_bits within exec.c. Moving everything to a new file prevents this confusion. No functional change so far. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Paolo Bonzini Signed-off-by: