Re: [PATCH v4 01/15] hw/pci: Add a pci_setup_iommu_ops() helper

2023-10-09 Thread Cédric Le Goater
On 10/6/23 19:59, Joao Martins wrote: On 06/10/2023 18:09, Cédric Le Goater wrote: Getting acks from everyone will be difficultsince some PHBs are orphans. [...] This is what gets me a bit hesitant orphans shouldn't be an issue, nor the PPC emulated machines. We will see what other

Re: [PATCH v4 01/15] hw/pci: Add a pci_setup_iommu_ops() helper

2023-10-06 Thread Joao Martins
On 06/10/2023 18:09, Cédric Le Goater wrote: >>> Getting acks from everyone will be difficultsince some PHBs are orphans. >> >> [...] This is what gets me a bit hesitant > > orphans shouldn't be an issue, nor the PPC emulated machines. We will see > what other maintainers have to say. How about

Re: [PATCH v4 01/15] hw/pci: Add a pci_setup_iommu_ops() helper

2023-10-06 Thread Cédric Le Goater
Hello Joao, I think you should first convert all PHBs to PCIIOMMUOps to avoid all the tests as below and adapt pci_setup_iommu_ops() with the new parameter. OK, that's Yi's original patch: https://lore.kernel.org/all/20210302203827.437645-5-yi.l@intel.com/ I went with this one is that

Re: [PATCH v4 01/15] hw/pci: Add a pci_setup_iommu_ops() helper

2023-10-06 Thread Joao Martins
On 06/10/2023 09:50, Cédric Le Goater wrote: > On 10/6/23 10:38, Joao Martins wrote: >> On 02/10/2023 16:12, Cédric Le Goater wrote: >>> Hello Joao, >>> >>> On 6/22/23 23:48, Joao Martins wrote: From: Yi Liu Add a pci_setup_iommu_ops() that uses a newly added structure

Re: [PATCH v4 01/15] hw/pci: Add a pci_setup_iommu_ops() helper

2023-10-06 Thread Joao Martins
On 06/10/2023 09:45, Eric Auger wrote: > Hi Joao, > > On 6/22/23 23:48, Joao Martins wrote: >> From: Yi Liu >> >> Add a pci_setup_iommu_ops() that uses a newly added structure >> (PCIIOMMUOps) instead of using PCIIOMMUFunc. The old pci_setup_iommu() >> that uses PCIIOMMUFunc is still kept for

Re: [PATCH v4 01/15] hw/pci: Add a pci_setup_iommu_ops() helper

2023-10-06 Thread Cédric Le Goater
On 10/6/23 10:38, Joao Martins wrote: On 02/10/2023 16:12, Cédric Le Goater wrote: Hello Joao, On 6/22/23 23:48, Joao Martins wrote: From: Yi Liu Add a pci_setup_iommu_ops() that uses a newly added structure (PCIIOMMUOps) instead of using PCIIOMMUFunc. The old pci_setup_iommu() that uses

Re: [PATCH v4 01/15] hw/pci: Add a pci_setup_iommu_ops() helper

2023-10-06 Thread Eric Auger
Hi Joao, On 6/22/23 23:48, Joao Martins wrote: > From: Yi Liu > > Add a pci_setup_iommu_ops() that uses a newly added structure > (PCIIOMMUOps) instead of using PCIIOMMUFunc. The old pci_setup_iommu() > that uses PCIIOMMUFunc is still kept for other IOMMUs to get an > an address space for a PCI

Re: [PATCH v4 01/15] hw/pci: Add a pci_setup_iommu_ops() helper

2023-10-06 Thread Joao Martins
On 02/10/2023 16:12, Cédric Le Goater wrote: > Hello Joao, > > On 6/22/23 23:48, Joao Martins wrote: >> From: Yi Liu >> >> Add a pci_setup_iommu_ops() that uses a newly added structure >> (PCIIOMMUOps) instead of using PCIIOMMUFunc. The old pci_setup_iommu() >> that uses PCIIOMMUFunc is still

Re: [PATCH v4 01/15] hw/pci: Add a pci_setup_iommu_ops() helper

2023-10-02 Thread Cédric Le Goater
Hello Joao, On 6/22/23 23:48, Joao Martins wrote: From: Yi Liu Add a pci_setup_iommu_ops() that uses a newly added structure (PCIIOMMUOps) instead of using PCIIOMMUFunc. The old pci_setup_iommu() that uses PCIIOMMUFunc is still kept for other IOMMUs to get an an address space for a PCI device

[PATCH v4 01/15] hw/pci: Add a pci_setup_iommu_ops() helper

2023-06-22 Thread Joao Martins
From: Yi Liu Add a pci_setup_iommu_ops() that uses a newly added structure (PCIIOMMUOps) instead of using PCIIOMMUFunc. The old pci_setup_iommu() that uses PCIIOMMUFunc is still kept for other IOMMUs to get an an address space for a PCI device in vendor specific way. In preparation to expand to