Re: [PATCH v5 1/6] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC

2021-05-20 Thread Thomas Huth
On 19/05/2021 13.05, Philippe Mathieu-Daudé wrote: On 5/19/21 10:23 AM, Thomas Huth wrote: On 18/05/2021 21.32, Philippe Mathieu-Daudé wrote: isa_superio_realize() calls isa_fdc_init_drives(), which is defined in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol. If I get that

Re: [PATCH v5 1/6] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC

2021-05-19 Thread Philippe Mathieu-Daudé
On 5/19/21 10:23 AM, Thomas Huth wrote: > On 18/05/2021 21.32, Philippe Mathieu-Daudé wrote: >> isa_superio_realize() calls isa_fdc_init_drives(), which is defined >> in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol. > > If I get that right, not all superio chipsets provide a

Re: [PATCH v5 1/6] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC

2021-05-19 Thread Thomas Huth
On 18/05/2021 21.32, Philippe Mathieu-Daudé wrote: isa_superio_realize() calls isa_fdc_init_drives(), which is defined in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol. If I get that right, not all superio chipsets provide a floppy drive (there's this "k->floppy.is_enabled"

[PATCH v5 1/6] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC

2021-05-18 Thread Philippe Mathieu-Daudé
isa_superio_realize() calls isa_fdc_init_drives(), which is defined in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol. Reported-by: John Snow Fixes: c0ff3795143 ("Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.c") Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/Kconfig |