Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Vladimir Sementsov-Ogievskiy
On 6/28/22 20:28, Emanuele Giuseppe Esposito wrote: Am 28/06/2022 um 17:26 schrieb Vladimir Sementsov-Ogievskiy: On 6/28/22 18:22, Vladimir Sementsov-Ogievskiy wrote: On 6/28/22 16:04, Emanuele Giuseppe Esposito wrote: Ok so far I did the following: - duplicated each public function as stat

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Emanuele Giuseppe Esposito
Am 28/06/2022 um 17:26 schrieb Vladimir Sementsov-Ogievskiy: > On 6/28/22 18:22, Vladimir Sementsov-Ogievskiy wrote: >> On 6/28/22 16:04, Emanuele Giuseppe Esposito wrote: > Ok so far I did the following: > > - duplicated each public function as static {function}_locked() They s

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Vladimir Sementsov-Ogievskiy
On 6/28/22 18:22, Vladimir Sementsov-Ogievskiy wrote: On 6/28/22 16:04, Emanuele Giuseppe Esposito wrote: Ok so far I did the following: - duplicated each public function as static {function}_locked() They shouldn't be duplicates: function without _locked suffix should take the mutex. By "dup

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Vladimir Sementsov-Ogievskiy
On 6/28/22 16:04, Emanuele Giuseppe Esposito wrote: Ok so far I did the following: - duplicated each public function as static {function}_locked() They shouldn't be duplicates: function without _locked suffix should take the mutex. By "duplicate" I mean same function name, with just _locked su

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Emanuele Giuseppe Esposito
Am 28/06/2022 um 12:47 schrieb Vladimir Sementsov-Ogievskiy: > On 6/28/22 10:40, Emanuele Giuseppe Esposito wrote: >> >> >> Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: >>> On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: Am 21/06/2022 um 19:26 schrieb Vladimir

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Vladimir Sementsov-Ogievskiy
On 6/28/22 10:40, Emanuele Giuseppe Esposito wrote: Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: Am 21/06/2022 um 19:26 schrieb Vladimir Sementsov-Ogievskiy: On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: With the*no

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Emanuele Giuseppe Esposito
Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: > On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: >> >> >> Am 21/06/2022 um 19:26 schrieb Vladimir Sementsov-Ogievskiy: >>> On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: With the*nop*  job_lock/unlock placed, rename the

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-24 Thread Emanuele Giuseppe Esposito
Am 24/06/2022 um 17:28 schrieb Paolo Bonzini: > On 6/24/22 16:29, Kevin Wolf wrote: >> Yes, I think Vladimir is having the same difficulties with reading the >> series as I had. And I believe his suggestion would make the >> intermediate states less impossible to review. The question is how much

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-24 Thread Paolo Bonzini
On 6/24/22 16:29, Kevin Wolf wrote: Yes, I think Vladimir is having the same difficulties with reading the series as I had. And I believe his suggestion would make the intermediate states less impossible to review. The question is how much work it would be and whether you're willing to do this. A

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-24 Thread Kevin Wolf
Am 23.06.2022 um 13:19 hat Emanuele Giuseppe Esposito geschrieben: > > > Am 23/06/2022 um 13:10 schrieb Vladimir Sementsov-Ogievskiy: > > On 6/23/22 12:08, Emanuele Giuseppe Esposito wrote: > >> > >> > >> Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: > >>> On 6/22/22 17:26, Emanuel

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-23 Thread Vladimir Sementsov-Ogievskiy
On 6/23/22 14:19, Emanuele Giuseppe Esposito wrote: Am 23/06/2022 um 13:10 schrieb Vladimir Sementsov-Ogievskiy: On 6/23/22 12:08, Emanuele Giuseppe Esposito wrote: Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: Am 21/06/202

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-23 Thread Emanuele Giuseppe Esposito
Am 23/06/2022 um 13:10 schrieb Vladimir Sementsov-Ogievskiy: > On 6/23/22 12:08, Emanuele Giuseppe Esposito wrote: >> >> >> Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: >>> On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: Am 21/06/2022 um 19:26 schrieb Vladimir

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-23 Thread Vladimir Sementsov-Ogievskiy
On 6/23/22 12:08, Emanuele Giuseppe Esposito wrote: Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: Am 21/06/2022 um 19:26 schrieb Vladimir Sementsov-Ogievskiy: On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: With the*no

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-23 Thread Emanuele Giuseppe Esposito
Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: > On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: >> >> >> Am 21/06/2022 um 19:26 schrieb Vladimir Sementsov-Ogievskiy: >>> On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: With the*nop*  job_lock/unlock placed, rename the

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-22 Thread Vladimir Sementsov-Ogievskiy
On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: Am 21/06/2022 um 19:26 schrieb Vladimir Sementsov-Ogievskiy: On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: With the*nop*  job_lock/unlock placed, rename the static functions that are always under job_mutex, adding "_locked" suffix. Li

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-22 Thread Emanuele Giuseppe Esposito
Am 21/06/2022 um 19:26 schrieb Vladimir Sementsov-Ogievskiy: > On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: >> With the*nop*  job_lock/unlock placed, rename the static >> functions that are always under job_mutex, adding "_locked" suffix. >> >> List of functions that get this suffix: >> j

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-21 Thread Vladimir Sementsov-Ogievskiy
On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: With the*nop* job_lock/unlock placed, rename the static functions that are always under job_mutex, adding "_locked" suffix. List of functions that get this suffix: job_txn_refjob_txn_del_job job_txn_apply job_state

[PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-16 Thread Emanuele Giuseppe Esposito
With the *nop* job_lock/unlock placed, rename the static functions that are always under job_mutex, adding "_locked" suffix. List of functions that get this suffix: job_txn_refjob_txn_del_job job_txn_apply job_state_transition job_should_pause job_event_cance