Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-03-27 Thread Kevin Wolf
Am 27.03.2012 17:17, schrieb Andreas Färber: > Am 27.03.2012 16:43, schrieb Kevin Wolf: >> Am 27.03.2012 16:30, schrieb Andreas Färber: >>> Am 27.03.2012 04:42, schrieb David Gibson: Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to determine the direction of DMA it is emulati

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-03-27 Thread Andreas Färber
Am 27.03.2012 16:43, schrieb Kevin Wolf: > Am 27.03.2012 16:30, schrieb Andreas Färber: >> Am 27.03.2012 04:42, schrieb David Gibson: >>> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to >>> determine the direction of DMA it is emulating. We already have a >>> DMADirection enum design

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-03-27 Thread Kevin Wolf
Am 27.03.2012 16:30, schrieb Andreas Färber: > Am 27.03.2012 04:42, schrieb David Gibson: >> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to >> determine the direction of DMA it is emulating. We already have a >> DMADirection enum designed specifically to encode DMA directions. >> Th

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-03-27 Thread Andreas Färber
Am 27.03.2012 04:42, schrieb David Gibson: > Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > determine the direction of DMA it is emulating. We already have a > DMADirection enum designed specifically to encode DMA directions. > This patch uses it for dma_bdrv_io() as well. This i

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-03-27 Thread Stefan Hajnoczi
On Tue, Mar 27, 2012 at 01:42:23PM +1100, David Gibson wrote: > Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > determine the direction of DMA it is emulating. We already have a > DMADirection enum designed specifically to encode DMA directions. > This patch uses it for dma_bdrv_io

[Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-03-26 Thread David Gibson
Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to determine the direction of DMA it is emulating. We already have a DMADirection enum designed specifically to encode DMA directions. This patch uses it for dma_bdrv_io() as well. This involves removing the DMADirection definition from t

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-22 Thread Hannes Reinecke
On 02/22/2012 10:54 AM, Andreas Färber wrote: > Am 22.02.2012 02:11, schrieb David Gibson: >> On Tue, Feb 21, 2012 at 10:09:01AM +0100, Kevin Wolf wrote: >>> Am 21.02.2012 09:35, schrieb Paolo Bonzini: On 02/20/2012 11:50 AM, Alexander Graf wrote: >>> DMAAIOCB *dbs = qemu_aio_get(&dma_

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-22 Thread Andreas Färber
Am 22.02.2012 02:11, schrieb David Gibson: > On Tue, Feb 21, 2012 at 10:09:01AM +0100, Kevin Wolf wrote: >> Am 21.02.2012 09:35, schrieb Paolo Bonzini: >>> On 02/20/2012 11:50 AM, Alexander Graf wrote: >> DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); >> >> -trace_

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-21 Thread David Gibson
On Tue, Feb 21, 2012 at 10:09:01AM +0100, Kevin Wolf wrote: > Am 21.02.2012 09:35, schrieb Paolo Bonzini: > > On 02/20/2012 11:50 AM, Alexander Graf wrote: > DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); > > -trace_dma_bdrv_io(dbs, bs, sector_num, to_dev); > >>

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-21 Thread Kevin Wolf
Am 21.02.2012 09:35, schrieb Paolo Bonzini: > On 02/20/2012 11:50 AM, Alexander Graf wrote: DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); -trace_dma_bdrv_io(dbs, bs, sector_num, to_dev); +trace_dma_bdrv_io(dbs, bs, sector_num, dir); >> Was the trace wr

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-21 Thread Paolo Bonzini
On 02/20/2012 11:50 AM, Alexander Graf wrote: >> > DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); >> > >> > -trace_dma_bdrv_io(dbs, bs, sector_num, to_dev); >> > +trace_dma_bdrv_io(dbs, bs, sector_num, dir); > Was the trace wrong before or is it now? I don't see its defin

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-20 Thread David Gibson
On Mon, Feb 20, 2012 at 11:50:40AM +0100, Alexander Graf wrote: > > On 20.02.2012, at 04:01, David Gibson wrote: > > > Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > > determine the direction of DMA it is emulating. We already have a > > DMADirection enum designed specifically t

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-20 Thread Alexander Graf
On 20.02.2012, at 04:01, David Gibson wrote: > Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > determine the direction of DMA it is emulating. We already have a > DMADirection enum designed specifically to encode DMA directions. > This patch uses it for dma_bdrv_io() as well. >

[Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-19 Thread David Gibson
Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to determine the direction of DMA it is emulating. We already have a DMADirection enum designed specifically to encode DMA directions. This patch uses it for dma_bdrv_io() as well. Signed-off-by: David Gibson --- dma-helpers.c | 20 +