Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-18 Thread Blue Swirl
On Fri, Feb 17, 2012 at 14:31, Anthony Liguori aligu...@us.ibm.com wrote: On 02/11/2012 03:44 AM, Blue Swirl wrote: On Fri, Feb 10, 2012 at 17:47, Anthony Liguorialigu...@us.ibm.com  wrote: On 02/09/2012 10:02 PM, malc wrote: On Fri, 10 Feb 2012, Evgeny Voevodin wrote: On 02/09/2012

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-18 Thread Blue Swirl
On Fri, Feb 17, 2012 at 15:26, Anthony Liguori aligu...@us.ibm.com wrote: On 02/17/2012 08:55 AM, Markus Armbruster wrote: Anthony Liguorialigu...@us.ibm.com  writes: I really hate having these discussions.  I would almost rather we just pay the one-time cost of re-indenting so we can stop

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-18 Thread Stefan Weil
Am 18.02.2012 10:13, schrieb Blue Swirl: On Fri, Feb 17, 2012 at 15:26, Anthony Liguori aligu...@us.ibm.com wrote: Well this was what I was getting at in my previous comments. If we just need to reindent 10 files with a few random changes here and there, then maybe that isn't so bad. But

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-18 Thread Anthony Liguori
On 02/18/2012 04:56 AM, Stefan Weil wrote: Am 18.02.2012 10:13, schrieb Blue Swirl: On Fri, Feb 17, 2012 at 15:26, Anthony Liguori aligu...@us.ibm.com wrote: Well this was what I was getting at in my previous comments. If we just need to reindent 10 files with a few random changes here and

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-18 Thread Blue Swirl
On Sat, Feb 18, 2012 at 14:18, Anthony Liguori anth...@codemonkey.ws wrote: On 02/18/2012 04:56 AM, Stefan Weil wrote: Am 18.02.2012 10:13, schrieb Blue Swirl: On Fri, Feb 17, 2012 at 15:26, Anthony Liguori aligu...@us.ibm.com wrote: Well this was what I was getting at in my previous

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-18 Thread Andreas Färber
Am 18.02.2012 10:13, schrieb Blue Swirl: One way to handle this is gradual reformatting, every time when code is touched, only changes towards common CODING_STYLE are allowed. That's what we've been doing wrt braces and I appreciate us not cluttering the history with reformatting commits.

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-18 Thread Eric Blake
On 02/18/2012 08:53 AM, Andreas Färber wrote: I think only 'git blame' output would be affected and that is not 100% reliable anyway, considering for example code movement. I use repo.or.cz's blame function quite often to find out who to cc or what commit to mention, and (valid) typo fixes

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-17 Thread Anthony Liguori
On 02/11/2012 03:44 AM, Blue Swirl wrote: On Fri, Feb 10, 2012 at 17:47, Anthony Liguorialigu...@us.ibm.com wrote: On 02/09/2012 10:02 PM, malc wrote: On Fri, 10 Feb 2012, Evgeny Voevodin wrote: On 02/09/2012 06:59 PM, Andreas F?rber wrote: Disable warnings for spaces before opening

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-17 Thread Markus Armbruster
Anthony Liguori aligu...@us.ibm.com writes: I really hate having these discussions. I would almost rather we just pay the one-time cost of re-indenting so we can stop debating about this. For folks that feel strongly about this, please submit the following: An indent command that takes

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-17 Thread Anthony Liguori
On 02/17/2012 08:55 AM, Markus Armbruster wrote: Anthony Liguorialigu...@us.ibm.com writes: I really hate having these discussions. I would almost rather we just pay the one-time cost of re-indenting so we can stop debating about this. For folks that feel strongly about this, please submit

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-11 Thread Blue Swirl
On Thu, Feb 9, 2012 at 14:59, Andreas Färber afaer...@suse.de wrote: Disable warnings for spaces before opening parenthesis in hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Blue Swirl blauwir...@gmail.com Cc: malc av1...@comtv.ru ---  

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-11 Thread Blue Swirl
On Fri, Feb 10, 2012 at 17:47, Anthony Liguori aligu...@us.ibm.com wrote: On 02/09/2012 10:02 PM, malc wrote: On Fri, 10 Feb 2012, Evgeny Voevodin wrote: On 02/09/2012 06:59 PM, Andreas F?rber wrote: Disable warnings for spaces before opening parenthesis in

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-10 Thread Anthony Liguori
On 02/09/2012 10:02 PM, malc wrote: On Fri, 10 Feb 2012, Evgeny Voevodin wrote: On 02/09/2012 06:59 PM, Andreas F?rber wrote: Disable warnings for spaces before opening parenthesis in hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. Why audio files are such a special thing? Because they are

[Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-09 Thread Andreas Färber
Disable warnings for spaces before opening parenthesis in hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Blue Swirl blauwir...@gmail.com Cc: malc av1...@comtv.ru --- scripts/checkpatch.pl |5 + 1 files changed, 5 insertions(+), 0

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-09 Thread Andreas Färber
Am 09.02.2012 15:59, schrieb Andreas Färber: Disable warnings for spaces before opening parenthesis in hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Blue Swirl blauwir...@gmail.com Cc: malc av1...@comtv.ru --- For testing I used the

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-09 Thread malc
On Thu, 9 Feb 2012, Andreas F?rber wrote: Disable warnings for spaces before opening parenthesis in hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. Signed-off-by: Andreas F?rber afaer...@suse.de Cc: Blue Swirl blauwir...@gmail.com Cc: malc av1...@comtv.ru Thanks. --- scripts/checkpatch.pl

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-09 Thread Evgeny Voevodin
On 02/09/2012 06:59 PM, Andreas Färber wrote: Disable warnings for spaces before opening parenthesis in hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. Why audio files are such a special thing? Isn't it be better to revert a patch that introduced checkpatch.pl errors? -- Kind regards, Evgeny

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-09 Thread malc
On Fri, 10 Feb 2012, Evgeny Voevodin wrote: On 02/09/2012 06:59 PM, Andreas F?rber wrote: Disable warnings for spaces before opening parenthesis in hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. Why audio files are such a special thing? Because they are consistently formatted the way they