Re: [Qemu-devel] [PATCH] io: Always remove an old channel watch before adding a new one.

2017-09-08 Thread Daniel P. Berrange
On Fri, Sep 08, 2017 at 09:18:04AM -0700, Brandon Carpenter wrote: > I haven't seen this patch hit master yet and am about to submit a patch set > that is dependent on this one because it triggers the bug fixed by this > patch, causing a segmentation fault. Is it preferred that I include this > pat

Re: [Qemu-devel] [PATCH] io: Always remove an old channel watch before adding a new one.

2017-09-08 Thread Brandon Carpenter
I haven't seen this patch hit master yet and am about to submit a patch set that is dependent on this one because it triggers the bug fixed by this patch, causing a segmentation fault. Is it preferred that I include this patch in that series with the Reviewed-by: tags or to just reference this

Re: [Qemu-devel] [PATCH] io: Always remove an old channel watch before adding a new one.

2017-07-25 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 11:15:44AM -0700, Brandon Carpenter wrote: > Also set saved handle to zero when removing without adding a new watch. > > Signed-off-by: Brandon Carpenter > --- > ui/vnc-auth-vencrypt.c | 3 +++ > ui/vnc-ws.c| 6 ++ > ui/vnc.c | 4 > 3 fi

Re: [Qemu-devel] [PATCH] io: Always remove an old channel watch before adding a new one.

2017-07-24 Thread Paolo Bonzini
On 24/07/2017 20:15, Brandon Carpenter wrote: > Also set saved handle to zero when removing without adding a new watch. > > Signed-off-by: Brandon Carpenter > --- > ui/vnc-auth-vencrypt.c | 3 +++ > ui/vnc-ws.c| 6 ++ > ui/vnc.c | 4 > 3 files changed, 13 inser

[Qemu-devel] [PATCH] io: Always remove an old channel watch before adding a new one.

2017-07-24 Thread Brandon Carpenter
Also set saved handle to zero when removing without adding a new watch. Signed-off-by: Brandon Carpenter --- ui/vnc-auth-vencrypt.c | 3 +++ ui/vnc-ws.c| 6 ++ ui/vnc.c | 4 3 files changed, 13 insertions(+) diff --git a/ui/vnc-auth-vencrypt.c b/ui/vnc-auth-ve