Re: [Qemu-devel] [PATCH] memory region: check the old.mmio.read status

2018-09-12 Thread Peter Maydell
On 13 September 2018 at 05:31, Mark Cave-Ayland wrote: > This sounds familiar to me. I remember whilst working on the Mac > uninorth patches I couldn't quite figure out why a simple change to the > PCI bridge IO address space started to cause some accesses to fail: it > was because the guest was

Re: [Qemu-devel] [PATCH] memory region: check the old.mmio.read status

2018-09-12 Thread Mark Cave-Ayland
On 13/09/18 01:31, Peter Maydell wrote: > On 12 September 2018 at 18:43, Laszlo Ersek wrote: >> On 09/12/18 14:54, Peter Maydell wrote: >>> There's patches on-list which drop the old_mmio field from the MemoryRegion >>> struct entirely, so I think this patch as it stands is obsolete. >>> >>>

Re: [Qemu-devel] [PATCH] memory region: check the old.mmio.read status

2018-09-12 Thread Li Qiang
Peter Maydell 于2018年9月13日周四 上午8:31写道: > On 12 September 2018 at 18:43, Laszlo Ersek wrote: > > On 09/12/18 14:54, Peter Maydell wrote: > >> There's patches on-list which drop the old_mmio field from the > MemoryRegion > >> struct entirely, so I think this patch as it stands is obsolete. > >> >

Re: [Qemu-devel] [PATCH] memory region: check the old.mmio.read status

2018-09-12 Thread Peter Maydell
On 12 September 2018 at 18:43, Laszlo Ersek wrote: > On 09/12/18 14:54, Peter Maydell wrote: >> There's patches on-list which drop the old_mmio field from the MemoryRegion >> struct entirely, so I think this patch as it stands is obsolete. >> >> Currently our semantics are "you must provide both

Re: [Qemu-devel] [PATCH] memory region: check the old.mmio.read status

2018-09-12 Thread Laszlo Ersek
On 09/12/18 16:28, Li Qiang wrote: > Peter Maydell 于2018年9月12日周三 下午8:55写道: > >> On 12 September 2018 at 13:32, Li Qiang wrote: >>> To avoid NULL-deref for the devices without read callbacks >>> >>> Signed-off-by: Li Qiang >>> --- >>> memory.c | 4 >>> 1 file changed, 4 insertions(+) >>>

Re: [Qemu-devel] [PATCH] memory region: check the old.mmio.read status

2018-09-12 Thread Laszlo Ersek
On 09/12/18 14:54, Peter Maydell wrote: > On 12 September 2018 at 13:32, Li Qiang wrote: >> To avoid NULL-deref for the devices without read callbacks >> >> Signed-off-by: Li Qiang >> --- >> memory.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/memory.c b/memory.c >> index

Re: [Qemu-devel] [PATCH] memory region: check the old.mmio.read status

2018-09-12 Thread Li Qiang
Peter Maydell 于2018年9月12日周三 下午8:55写道: > On 12 September 2018 at 13:32, Li Qiang wrote: > > To avoid NULL-deref for the devices without read callbacks > > > > Signed-off-by: Li Qiang > > --- > > memory.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/memory.c b/memory.c > >

Re: [Qemu-devel] [PATCH] memory region: check the old.mmio.read status

2018-09-12 Thread Peter Maydell
On 12 September 2018 at 13:32, Li Qiang wrote: > To avoid NULL-deref for the devices without read callbacks > > Signed-off-by: Li Qiang > --- > memory.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/memory.c b/memory.c > index 9b73892768..48d025426b 100644 > --- a/memory.c > +++

[Qemu-devel] [PATCH] memory region: check the old.mmio.read status

2018-09-12 Thread Li Qiang
To avoid NULL-deref for the devices without read callbacks Signed-off-by: Li Qiang --- memory.c | 4 1 file changed, 4 insertions(+) diff --git a/memory.c b/memory.c index 9b73892768..48d025426b 100644 --- a/memory.c +++ b/memory.c @@ -406,6 +406,10 @@ static MemTxResult