Re: [Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses

2017-08-14 Thread Paolo Bonzini
On 14/08/2017 21:03, Matt Parker wrote: >>> static const MemoryRegionOps rtl8139_mmio_ops = { >> I think you don't even need to declare a separate MemoryRegionOps, and >> can just recycle rtl8139_io_ops? > Looking at the memory region, it's only 0x100 bytes in size, > so addr & 0xFF would not be n

Re: [Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses

2017-08-14 Thread Matt Parker
On Mon, Aug 14, 2017 at 10:40:27AM +0200, Paolo Bonzini wrote: > On 12/08/2017 23:33, Matt Parker wrote: > > This updates the current MemoryRegionOps for the bar 1 memory region > > from using the old_mmio accessors to the .read and .write accessors. > > > > Signed-off-by: Matt Parker > > --- > >

Re: [Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses

2017-08-14 Thread Paolo Bonzini
On 12/08/2017 23:33, Matt Parker wrote: > This updates the current MemoryRegionOps for the bar 1 memory region > from using the old_mmio accessors to the .read and .write accessors. > > Signed-off-by: Matt Parker > --- > hw/net/rtl8139.c | 60 > +++---

Re: [Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses

2017-08-13 Thread Jason Wang
On 2017年08月13日 05:34, Matt Parker wrote: This updates the current MemoryRegionOps for the bar 1 memory region from using the old_mmio accessors to the .read and .write accessors. Signed-off-by: Matt Parker --- hw/net/rtl8139.c | 60 +++-

[Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses

2017-08-12 Thread Matt Parker
This updates the current MemoryRegionOps for the bar 1 memory region from using the old_mmio accessors to the .read and .write accessors. Signed-off-by: Matt Parker --- hw/net/rtl8139.c | 60 +++- 1 file changed, 16 insertions(+), 44 deletions(

[Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses

2017-08-12 Thread Matt Parker
This updates the current MemoryRegionOps for the bar 1 memory region from using the old_mmio accessors to the .read and .write accessors. Signed-off-by: Matt Parker --- hw/net/rtl8139.c | 60 +++- 1 file changed, 16 insertions(+), 44 deletions(