Re: [Qemu-devel] [PATCH] qmp: add support for mixed typed input visitor

2016-07-20 Thread Markus Armbruster
Copying Kevin and Max to alert them to possibly related issues due to the block layer's use of QemuOpts and QDict instead of QAPI. A bit of context: QMP netdev_add and device_add interpret their arguments in highly unorthodox ways. This is an artifact of their (non-QAPI) implementation,

Re: [Qemu-devel] [PATCH] qmp: add support for mixed typed input visitor

2016-07-15 Thread Markus Armbruster
Eric Blake writes: > On 07/14/2016 08:39 AM, Daniel P. Berrange wrote: >> On Thu, Jul 14, 2016 at 08:23:18AM -0600, Eric Blake wrote: >>> On 07/14/2016 08:16 AM, Daniel P. Berrange wrote: Add a qmp_mixed_input_visitor_new() method which returns a QMP input visitor

Re: [Qemu-devel] [PATCH] qmp: add support for mixed typed input visitor

2016-07-14 Thread Eric Blake
On 07/14/2016 08:39 AM, Daniel P. Berrange wrote: > On Thu, Jul 14, 2016 at 08:23:18AM -0600, Eric Blake wrote: >> On 07/14/2016 08:16 AM, Daniel P. Berrange wrote: >>> Add a qmp_mixed_input_visitor_new() method which returns >>> a QMP input visitor that accepts either strings or the >>> native

[Qemu-devel] [PATCH] qmp: add support for mixed typed input visitor

2016-07-14 Thread Daniel P. Berrange
Add a qmp_mixed_input_visitor_new() method which returns a QMP input visitor that accepts either strings or the native data types. Signed-off-by: Daniel P. Berrange --- NB, just a demo - this should have tests added before submitting for real.

Re: [Qemu-devel] [PATCH] qmp: add support for mixed typed input visitor

2016-07-14 Thread Daniel P. Berrange
On Thu, Jul 14, 2016 at 08:23:18AM -0600, Eric Blake wrote: > On 07/14/2016 08:16 AM, Daniel P. Berrange wrote: > > Add a qmp_mixed_input_visitor_new() method which returns > > a QMP input visitor that accepts either strings or the > > native data types. > > > > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH] qmp: add support for mixed typed input visitor

2016-07-14 Thread Eric Blake
On 07/14/2016 08:16 AM, Daniel P. Berrange wrote: > Add a qmp_mixed_input_visitor_new() method which returns > a QMP input visitor that accepts either strings or the > native data types. > > Signed-off-by: Daniel P. Berrange > --- > > NB, just a demo - this should have