Re: [Qemu-devel] [PATCH] s390x/sclpconsole: Remove dead code - make _error functions void

2018-03-05 Thread Cornelia Huck
On Mon, 5 Mar 2018 09:07:17 +0100 Christian Borntraeger wrote: > On 03/04/2018 02:45 PM, Nia Alarie wrote: > > These functions always return 0. By changing their return type to > > void, some dead code can be removed. > > the event facility part looks ok, but I am asking myself if we should >

Re: [Qemu-devel] [PATCH] s390x/sclpconsole: Remove dead code - make _error functions void

2018-03-05 Thread Christian Borntraeger
On 03/04/2018 02:45 PM, Nia Alarie wrote: > These functions always return 0. By changing their return type to > void, some dead code can be removed. the event facility part looks ok, but I am asking myself if we should go a step further. Do we need the exit callback at all? We can certainly keep i

[Qemu-devel] [PATCH] s390x/sclpconsole: Remove dead code - make _error functions void

2018-03-04 Thread Nia Alarie
These functions always return 0. By changing their return type to void, some dead code can be removed. Signed-off-by: Nia Alarie --- hw/char/sclpconsole-lm.c | 3 +-- hw/char/sclpconsole.c | 3 +-- hw/s390x/event-facility.c | 6 +- hw/s390x/virtio-ccw.c