Re: [Qemu-devel] [PATCH] vvfat mbr fixes

2007-09-24 Thread Ivan Kalvachev
2007/9/24, Johannes Schindelin <[EMAIL PROTECTED]>: > Hi, > On Mon, 24 Sep 2007, Ivan Kalvachev wrote: [...] > > I believe that I've answered and addressed all your comments. > > Ooops. I think I mixed up your patch with the other patch for vvfat that > floated around recently. (Probably because

Re: [Qemu-devel] [PATCH] vvfat mbr fixes

2007-09-24 Thread Johannes Schindelin
Hi, On Mon, 24 Sep 2007, Ivan Kalvachev wrote: > 2007/9/24, Johannes Schindelin <[EMAIL PROTECTED]>: > > > On Mon, 24 Sep 2007, Ivan Kalvachev wrote: > > > > > I had a discussion with Johannes Schindelin over my patch, that I > > > thought is on the maillist, but apparently it wasn't. I'm > > >

Re: [Qemu-devel] [PATCH] vvfat mbr fixes

2007-09-24 Thread Ivan Kalvachev
urself, as I do now. I just hope I haven't missed some. If you have more questions just ask them. -- Forwarded message ------ From: Ivan Kalvachev <[EMAIL PROTECTED]> Date: 23.09.2007 03:27 Subject: Re: [Qemu-devel] [PATCH] vvfat mbr fixes To: Johannes Schindelin <[EMAIL PROTEC

Re: [Qemu-devel] [PATCH] vvfat mbr fixes

2007-09-24 Thread Johannes Schindelin
Hi, On Mon, 24 Sep 2007, Ivan Kalvachev wrote: > I had a discussion with Johannes Schindelin over my patch, that I > thought is on the maillist, but apparently it wasn't. I'm subscribed, so > please don't send me mails directly, gmail web interface could be quite > misleading. > > So here is

Re: [Qemu-devel] [PATCH] vvfat mbr fixes

2007-09-24 Thread Ivan Kalvachev
I had a discussion with Johannes Schindelin over my patch, that I thought is on the maillist, but apparently it wasn't. I'm subscribed, so please don't send me mails directly, gmail web interface could be quite misleading. So here is the third revision of my patch. Changes include: using more stru

Re: [Qemu-devel] [PATCH] vvfat mbr fixes

2007-09-22 Thread Johannes Schindelin
Hi, On Sun, 23 Sep 2007, Ivan Kalvachev wrote: > I've been having problems using vvfat virtual block device. Even linux > fdisk was able to find problems with it. The reason turned out to be > simple, MBR have bogus parameters. Thanks for doing this; I did not find any time for that. Overall,

[Qemu-devel] [PATCH] vvfat mbr fixes

2007-09-22 Thread Ivan Kalvachev
Hello, I've been having problems using vvfat virtual block device. Even linux fdisk was able to find problems with it. The reason turned out to be simple, MBR have bogus parameters. 1. Partition size in sectors is threated as partition end, causing the partition to have the same size as the devic