Re: [Qemu-devel] [PATCH 01/13] target-arm: A64: add support for conditional select

2013-12-06 Thread Peter Maydell
On 5 December 2013 22:26, Richard Henderson r...@twiddle.net wrote: On 12/06/2013 10:51 AM, Peter Maydell wrote: +if (cond = 0x0e) { /* condition always */ +tcg_src = read_cpu_reg(s, rn, sf); +tcg_gen_mov_i64(tcg_rd, tcg_src); I wonder if it's worth adding that 0x0[ef]

Re: [Qemu-devel] [PATCH 01/13] target-arm: A64: add support for conditional select

2013-12-06 Thread Richard Henderson
On 12/07/2013 01:45 AM, Peter Maydell wrote: On 5 December 2013 22:26, Richard Henderson r...@twiddle.net wrote: On 12/06/2013 10:51 AM, Peter Maydell wrote: +if (cond = 0x0e) { /* condition always */ +tcg_src = read_cpu_reg(s, rn, sf); +tcg_gen_mov_i64(tcg_rd, tcg_src);

Re: [Qemu-devel] [PATCH 01/13] target-arm: A64: add support for conditional select

2013-12-06 Thread Peter Maydell
On 6 December 2013 16:44, Richard Henderson r...@twiddle.net wrote: On 12/07/2013 01:45 AM, Peter Maydell wrote: On 5 December 2013 22:26, Richard Henderson r...@twiddle.net wrote: On 12/06/2013 10:51 AM, Peter Maydell wrote: +if (cond = 0x0e) { /* condition always */ +tcg_src =

[Qemu-devel] [PATCH 01/13] target-arm: A64: add support for conditional select

2013-12-05 Thread Peter Maydell
From: Claudio Fontana claudio.font...@linaro.org This patch adds support for the instruction group C3.5.6 Conditional select: CSEL, CSINC, CSINV, CSNEG. Signed-off-by: Claudio Fontana claudio.font...@linaro.org Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c

Re: [Qemu-devel] [PATCH 01/13] target-arm: A64: add support for conditional select

2013-12-05 Thread Richard Henderson
On 12/06/2013 10:51 AM, Peter Maydell wrote: +if (cond = 0x0e) { /* condition always */ +tcg_src = read_cpu_reg(s, rn, sf); +tcg_gen_mov_i64(tcg_rd, tcg_src); I wonder if it's worth adding that 0x0[ef] case to the generic condition processing rather than keep replicating it

Re: [Qemu-devel] [PATCH 01/13] target-arm: A64: add support for conditional select

2013-12-05 Thread Peter Maydell
On 5 December 2013 22:26, Richard Henderson r...@twiddle.net wrote: On 12/06/2013 10:51 AM, Peter Maydell wrote: +if (cond = 0x0e) { /* condition always */ +tcg_src = read_cpu_reg(s, rn, sf); +tcg_gen_mov_i64(tcg_rd, tcg_src); I wonder if it's worth adding that 0x0[ef]

Re: [Qemu-devel] [PATCH 01/13] target-arm: A64: add support for conditional select

2013-12-05 Thread Richard Henderson
On 12/06/2013 11:31 AM, Peter Maydell wrote: On 5 December 2013 22:26, Richard Henderson r...@twiddle.net wrote: On 12/06/2013 10:51 AM, Peter Maydell wrote: +if (cond = 0x0e) { /* condition always */ +tcg_src = read_cpu_reg(s, rn, sf); +tcg_gen_mov_i64(tcg_rd, tcg_src);