Re: [Qemu-devel] [PATCH 01/19] exec: split cpu_exec_init()

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 06:02, David Gibson wrote: > On Wed, Oct 05, 2016 at 01:13:18PM -0700, Peter Maydell wrote: >> I think cpu_list_add() needs to be in init, because >> this is where we set cpu->cpu_index, and (after patch 5) >> target-arm assumes that cpu_index has

Re: [Qemu-devel] [PATCH 01/19] exec: split cpu_exec_init()

2016-10-05 Thread David Gibson
On Wed, Oct 05, 2016 at 01:13:18PM -0700, Peter Maydell wrote: > On 5 October 2016 at 12:38, Laurent Vivier wrote: > > Extract the realize part to cpu_exec_realize(), update all > > calls to cpu_exec_init() to add cpu_exec_realize() to > > have no functionnal change. > > > >

Re: [Qemu-devel] [PATCH 01/19] exec: split cpu_exec_init()

2016-10-05 Thread Laurent Vivier
On 05/10/2016 22:13, Peter Maydell wrote: > On 5 October 2016 at 12:38, Laurent Vivier wrote: >> Extract the realize part to cpu_exec_realize(), update all >> calls to cpu_exec_init() to add cpu_exec_realize() to >> have no functionnal change. >> >> Put in cpu_exec_init()

Re: [Qemu-devel] [PATCH 01/19] exec: split cpu_exec_init()

2016-10-05 Thread Eduardo Habkost
On Wed, Oct 05, 2016 at 01:13:18PM -0700, Peter Maydell wrote: > On 5 October 2016 at 12:38, Laurent Vivier wrote: > > Extract the realize part to cpu_exec_realize(), update all > > calls to cpu_exec_init() to add cpu_exec_realize() to > > have no functionnal change. > > > >

Re: [Qemu-devel] [PATCH 01/19] exec: split cpu_exec_init()

2016-10-05 Thread Peter Maydell
On 5 October 2016 at 12:38, Laurent Vivier wrote: > Extract the realize part to cpu_exec_realize(), update all > calls to cpu_exec_init() to add cpu_exec_realize() to > have no functionnal change. > > Put in cpu_exec_init() what initializes the CPU, > in cpu_exec_realize()

[Qemu-devel] [PATCH 01/19] exec: split cpu_exec_init()

2016-10-05 Thread Laurent Vivier
Extract the realize part to cpu_exec_realize(), update all calls to cpu_exec_init() to add cpu_exec_realize() to have no functionnal change. Put in cpu_exec_init() what initializes the CPU, in cpu_exec_realize() what adds it to the environment. CC: Paolo Bonzini