[Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
From: Alon Levy al...@redhat.com guest_connected should be false before guest driver initialization, and true after, both for multiport aware and non multiport aware drivers. Don't set it before the guest_features are available; instead use set_status which is called by io to VIRTIO_PCI_STATUS

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: From: Alon Levy al...@redhat.com guest_connected should be false before guest driver initialization, and true after, both for multiport aware and non multiport aware

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: From: Alon Levy al...@redhat.com guest_connected should be false before guest driver initialization, and

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: From: Alon Levy al...@redhat.com

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 04:44:10PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Andreas Färber
Am 24.04.2012 12:26, schrieb Amit Shah: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: From: Alon Levy al...@redhat.com guest_connected should be false before guest driver initialization, and true after, both for

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
On (Tue) 24 Apr 2012 [14:21:36], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 04:44:10PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Alon Levy
On Tue, Apr 24, 2012 at 01:23:53PM +0200, Andreas Färber wrote: Am 24.04.2012 12:26, schrieb Amit Shah: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: From: Alon Levy al...@redhat.com guest_connected should be false

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 05:10:23PM +0530, Amit Shah wrote: Sure. So fix it for single port now and for multiport in a separate patch. Alon's patch is a single line and it made sense, yours differs in that you have added more code to implement a bug. Disagree; it was not obvious in that

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: From: Alon Levy al...@redhat.com guest_connected should be false before guest driver initialization, and true after, both for multiport aware and non multiport aware drivers. Don't set it before the guest_features are available;