Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-11-05 Thread Gerd Hoffmann
On Mon, Nov 05, 2018 at 11:49:40AM -0200, Eduardo Habkost wrote: > On Mon, Nov 05, 2018 at 08:30:28AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > - Maintainers can deprecate stuffs > > > > - Orphan code can become Supported > > > > - Once scheduled for removal, there is no way back > > > >

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-11-05 Thread Eduardo Habkost
On Mon, Nov 05, 2018 at 08:30:28AM +0100, Gerd Hoffmann wrote: > Hi, > > > > - Maintainers can deprecate stuffs > > > - Orphan code can become Supported > > > - Once scheduled for removal, there is no way back > > > - 'Unknown' seems pretty similar to 'Orphan'. > > > > I'm still worried that

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-11-04 Thread Gerd Hoffmann
On Wed, Oct 31, 2018 at 03:06:04PM -0300, Eduardo Habkost wrote: > On Wed, Oct 31, 2018 at 12:04:16PM -0400, John Snow wrote: > > > > > > On 10/30/2018 09:32 AM, Philippe Mathieu-Daudé wrote: > > > Hi Gerd, > > > > > > On 30/10/18 12:13, Gerd Hoffmann wrote: > > >> Indicates support state for

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-11-04 Thread Gerd Hoffmann
Hi, > > - Maintainers can deprecate stuffs > > - Orphan code can become Supported > > - Once scheduled for removal, there is no way back > > - 'Unknown' seems pretty similar to 'Orphan'. > > I'm still worried that the supported/unsupported distinction may > cause unnecessary hassle for every

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-31 Thread John Snow
On 10/31/2018 02:58 PM, Eduardo Habkost wrote: > On Wed, Oct 31, 2018 at 02:37:36PM -0400, John Snow wrote: >> >> >> On 10/31/2018 02:06 PM, Eduardo Habkost wrote: >>> On Wed, Oct 31, 2018 at 12:04:16PM -0400, John Snow wrote: On 10/30/2018 09:32 AM, Philippe Mathieu-Daudé wrote:

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-31 Thread Eduardo Habkost
On Wed, Oct 31, 2018 at 02:37:36PM -0400, John Snow wrote: > > > On 10/31/2018 02:06 PM, Eduardo Habkost wrote: > > On Wed, Oct 31, 2018 at 12:04:16PM -0400, John Snow wrote: > >> > >> > >> On 10/30/2018 09:32 AM, Philippe Mathieu-Daudé wrote: > >>> Hi Gerd, > >>> > >>> On 30/10/18 12:13, Gerd

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-31 Thread John Snow
On 10/31/2018 02:06 PM, Eduardo Habkost wrote: > On Wed, Oct 31, 2018 at 12:04:16PM -0400, John Snow wrote: >> >> >> On 10/30/2018 09:32 AM, Philippe Mathieu-Daudé wrote: >>> Hi Gerd, >>> >>> On 30/10/18 12:13, Gerd Hoffmann wrote: Indicates support state for somerhing (device, backend,

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-31 Thread Eduardo Habkost
On Wed, Oct 31, 2018 at 12:04:16PM -0400, John Snow wrote: > > > On 10/30/2018 09:32 AM, Philippe Mathieu-Daudé wrote: > > Hi Gerd, > > > > On 30/10/18 12:13, Gerd Hoffmann wrote: > >> Indicates support state for somerhing (device, backend, subsystem, ...) > > > > "something" > > > >> in

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-31 Thread John Snow
On 10/30/2018 09:32 AM, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > On 30/10/18 12:13, Gerd Hoffmann wrote: >> Indicates support state for somerhing (device, backend, subsystem, ...) > > "something" > >> in qemu.  Modeled roughly after the "S:" states we have in MAINTANERS. >> >>

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-31 Thread Cornelia Huck
On Tue, 30 Oct 2018 20:15:45 -0300 Eduardo Habkost wrote: > On Tue, Oct 30, 2018 at 06:37:42PM +0100, Philippe Mathieu-Daudé wrote: > > If I understand correctly, we have this 'state machine': > > > >SupportedUnsupported Deprecated > > > > (someone to talk) (nobody

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Eduardo Habkost
On Tue, Oct 30, 2018 at 06:37:42PM +0100, Philippe Mathieu-Daudé wrote: > On 30/10/18 16:46, Cornelia Huck wrote: > > On Tue, 30 Oct 2018 15:13:45 +0100 > > Philippe Mathieu-Daudé wrote: > > > > > On 30/10/18 15:00, Gerd Hoffmann wrote: > > > > On Tue, Oct 30, 2018 at 02:32:40PM +0100, Philippe

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 16:46, Cornelia Huck wrote: On Tue, 30 Oct 2018 15:13:45 +0100 Philippe Mathieu-Daudé wrote: On 30/10/18 15:00, Gerd Hoffmann wrote: On Tue, Oct 30, 2018 at 02:32:40PM +0100, Philippe Mathieu-Daudé wrote: +## +# @SupportState: +# +# Indicate Support level of qemu devices,

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Cornelia Huck
On Tue, 30 Oct 2018 15:13:45 +0100 Philippe Mathieu-Daudé wrote: > On 30/10/18 15:00, Gerd Hoffmann wrote: > > On Tue, Oct 30, 2018 at 02:32:40PM +0100, Philippe Mathieu-Daudé wrote: > >>> +## > >>> +# @SupportState: > >>> +# > >>> +# Indicate Support level of qemu devices, backends,

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Eduardo Habkost
On Tue, Oct 30, 2018 at 12:13:45PM +0100, Gerd Hoffmann wrote: > Indicates support state for somerhing (device, backend, subsystem, ...) > in qemu. Modeled roughly after the "S:" states we have in MAINTANERS. > Personally, I would prefer to start with a very simple data model (e.g. a

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Eduardo Habkost
On Tue, Oct 30, 2018 at 12:13:45PM +0100, Gerd Hoffmann wrote: > Indicates support state for somerhing (device, backend, subsystem, ...) > in qemu. Modeled roughly after the "S:" states we have in MAINTANERS. > > Signed-off-by: Gerd Hoffmann [...] > +typedef struct QemuSupportState { > +

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 15:00, Gerd Hoffmann wrote: On Tue, Oct 30, 2018 at 02:32:40PM +0100, Philippe Mathieu-Daudé wrote: Hi Gerd, On 30/10/18 12:13, Gerd Hoffmann wrote: Indicates support state for somerhing (device, backend, subsystem, ...) "something" Oops, I'll fix. +## +# @SupportState: +#

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Gerd Hoffmann
On Tue, Oct 30, 2018 at 02:32:40PM +0100, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > On 30/10/18 12:13, Gerd Hoffmann wrote: > > Indicates support state for somerhing (device, backend, subsystem, ...) > > "something" Oops, I'll fix. > > +## > > +# @SupportState: > > +# > > +# Indicate

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Philippe Mathieu-Daudé
Hi Gerd, On 30/10/18 12:13, Gerd Hoffmann wrote: Indicates support state for somerhing (device, backend, subsystem, ...) "something" in qemu. Modeled roughly after the "S:" states we have in MAINTANERS. Signed-off-by: Gerd Hoffmann --- include/qemu/support-state.h | 17

[Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Gerd Hoffmann
Indicates support state for somerhing (device, backend, subsystem, ...) in qemu. Modeled roughly after the "S:" states we have in MAINTANERS. Signed-off-by: Gerd Hoffmann --- include/qemu/support-state.h | 17 + util/support-state.c | 23 +++