Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-27 Thread Stefan Hajnoczi
On Wed, Jul 18, 2018 at 11:13:18PM +0200, Emanuele wrote: > > > On 07/18/2018 09:28 PM, Paolo Bonzini wrote: > > On 18/07/2018 16:23, Stefan Hajnoczi wrote: > > > > > > +struct QOSGraphObject { > > > > > > +/* for produces, returns void * */ > > > > > > +QOSGetDriver get_driver; > > > >

Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-18 Thread Emanuele
On 07/18/2018 09:28 PM, Paolo Bonzini wrote: On 18/07/2018 16:23, Stefan Hajnoczi wrote: +struct QOSGraphObject { +/* for produces, returns void * */ +QOSGetDriver get_driver; Unused? +/* for contains, returns a QOSGraphObject * */ +QOSGetDevice get_device; Unused? What

Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-18 Thread Paolo Bonzini
On 18/07/2018 16:23, Stefan Hajnoczi wrote: +struct QOSGraphObject { +/* for produces, returns void * */ +QOSGetDriver get_driver; >>> Unused? >>> +/* for contains, returns a QOSGraphObject * */ +QOSGetDevice get_device; >>> Unused? >> What is unused? >

Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-18 Thread Emanuele
On 07/18/2018 04:23 PM, Stefan Hajnoczi wrote: On Wed, Jul 11, 2018 at 04:58:41PM +0200, Paolo Bonzini wrote: On 11/07/2018 16:28, Stefan Hajnoczi wrote: + * + * QOSGraphObject also provides a destructor, used to deallocate the + * after the test has been executed. + */ +struct

Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-18 Thread Stefan Hajnoczi
On Wed, Jul 11, 2018 at 04:58:41PM +0200, Paolo Bonzini wrote: > On 11/07/2018 16:28, Stefan Hajnoczi wrote: > >> + * > >> + * QOSGraphObject also provides a destructor, used to deallocate the > >> + * after the test has been executed. > >> + */ > >> +struct QOSGraphObject { > >> +/* for

Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 16:28, Stefan Hajnoczi wrote: >> + * build_driver_cmd_line(): builds the command line for the driver >> + * @node. The node name must be a valid qemu identifier, since it >> + * will be used to build the command line. >> + * >> + * It is also possible to pass an optional @args that

Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:30AM +0200, Emanuele Giuseppe Esposito wrote: > +/* Graph Edge.*/ > +struct QOSGraphEdge { > +QOSEdgeType type; > +char *dest; > +char *arg; /* just for CONTAIS and CONSUMED_BY */ CONTAINS? > +/** > + * remove_node(): removes a node @val from the nodes

[Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

2018-07-09 Thread Emanuele Giuseppe Esposito
Add qgraph API that allows to add/remove nodes and edges from the graph, implementation of Depth First Search to discover the paths and basic unit test to check correctness of the API. graph.h provides the public API to manage the graph nodes/edges graph_extra.h provides a more private API used