Re: [Qemu-devel] [PATCH 1/9] tests: cris: force inlining

2016-09-08 Thread Eric Blake
On 09/08/2016 01:06 PM, Peter Maydell wrote: >> +++ b/tests/tcg/cris/sys.h >> @@ -3,6 +3,8 @@ >> #define STRINGIFY(x) #x >> #define TOSTRING(x) STRINGIFY(x) >> >> +#define inline inline __attribute__((always_inline)) >> + > > I think redefining C keywords is generally a bad idea. > Can you

Re: [Qemu-devel] [PATCH 1/9] tests: cris: force inlining

2016-09-08 Thread Peter Maydell
On 5 September 2016 at 12:54, Rabin Vincent wrote: > From: Rabin Vincent > > The CRIS tests expect that functions marked inline are always inline. > With newer versions of GCC, building them results warnings like the > following and spurious failures when

Re: [Qemu-devel] [PATCH 1/9] tests: cris: force inlining

2016-09-08 Thread Rabin Vincent
On Tue, Sep 06, 2016 at 11:53:46PM +0200, Edgar E. Iglesias wrote: > On Mon, Sep 05, 2016 at 01:54:04PM +0200, Rabin Vincent wrote: > > From: Rabin Vincent > > > > The CRIS tests expect that functions marked inline are always inline. > > With newer versions of GCC, building them

Re: [Qemu-devel] [PATCH 1/9] tests: cris: force inlining

2016-09-06 Thread Edgar E. Iglesias
On Mon, Sep 05, 2016 at 01:54:04PM +0200, Rabin Vincent wrote: > From: Rabin Vincent > > The CRIS tests expect that functions marked inline are always inline. > With newer versions of GCC, building them results warnings like the > following and spurious failures when they are

[Qemu-devel] [PATCH 1/9] tests: cris: force inlining

2016-09-05 Thread Rabin Vincent
From: Rabin Vincent The CRIS tests expect that functions marked inline are always inline. With newer versions of GCC, building them results warnings like the following and spurious failures when they are run. In file included from tests/tcg/cris/check_moveq.c:5:0: