Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Jes Sorensen
On 11/18/10 15:47, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS HBA. Signed-off-by: Hannes Reinecke h...@suse.de --- Makefile.objs |2 +- hw/megasas.c | 1826 + hw/mfi.h | 1197

Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Markus Armbruster
Jes Sorensen jes.soren...@redhat.com writes: On 11/18/10 15:47, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS HBA. Signed-off-by: Hannes Reinecke h...@suse.de --- Makefile.objs |2 +- hw/megasas.c | 1826

Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Hannes Reinecke
On 11/19/2010 03:06 PM, Markus Armbruster wrote: Jes Sorensen jes.soren...@redhat.com writes: On 11/18/10 15:47, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS HBA. Signed-off-by: Hannes Reinecke h...@suse.de --- Makefile.objs |2 +- hw/megasas.c |

Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Jes Sorensen
On 11/19/10 15:06, Markus Armbruster wrote: Only comment, as you are adding another SCSI driver, maybe it's time to make the driver selection configurable, rather than hard coding the build? What do you mean by that? We hardcode lsi53c895a in two places where we really mean default SCSI

Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Alexander Graf
On 19.11.2010, at 15:31, Jes Sorensen wrote: On 11/19/10 15:06, Markus Armbruster wrote: Only comment, as you are adding another SCSI driver, maybe it's time to make the driver selection configurable, rather than hard coding the build? What do you mean by that? We hardcode lsi53c895a in

Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Jes Sorensen
On 11/19/10 17:36, Alexander Graf wrote: On 19.11.2010, at 15:31, Jes Sorensen wrote: What I mean is for most other device types we allow to specify a list of wanted devices at the configure line, which is what I am suggesting we added support for for SCSI as well. Oh, you mean something