Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-16 Thread Igor Mammedov
On Wed, 16 Apr 2014 15:02:40 +0300 "Michael S. Tsirkin" wrote: > On Fri, Apr 11, 2014 at 11:14:00AM +0200, Igor Mammedov wrote: > > On Mon, 7 Apr 2014 18:14:51 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Apr 07, 2014 at 04:32:16PM +0200, Igor Mammedov wrote: > > > > On Mon, 7 Apr 20

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-16 Thread Michael S. Tsirkin
On Fri, Apr 11, 2014 at 11:14:00AM +0200, Igor Mammedov wrote: > On Mon, 7 Apr 2014 18:14:51 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Apr 07, 2014 at 04:32:16PM +0200, Igor Mammedov wrote: > > > On Mon, 7 Apr 2014 13:23:54 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Fri, A

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-14 Thread Igor Mammedov
On Mon, 14 Apr 2014 13:25:59 -0400 Paolo Bonzini wrote: > Il 11/04/2014 05:14, Igor Mammedov ha scritto: > > > > How about simply looking for a hotplug handler type device instead? > > > > We aren't likely to have many of these, are we? > >>> > > > >>> > > How about adding link to PCMa

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-14 Thread Paolo Bonzini
Il 11/04/2014 05:14, Igor Mammedov ha scritto: > > > How about simply looking for a hotplug handler type device instead? > > > We aren't likely to have many of these, are we? > > > > How about adding link to PCMachine when it's created > > and use it instead of piix4_pm_find()/ich9_lpc_find() e

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-11 Thread Igor Mammedov
On Mon, 7 Apr 2014 18:21:14 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 07, 2014 at 04:26:02PM +0200, Igor Mammedov wrote: > > On Mon, 7 Apr 2014 11:13:01 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Apr 07, 2014 at 01:07:53PM +1000, Alexey Kardashevskiy wrote: > > > > On 04/05/2014 1

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-11 Thread Igor Mammedov
On Mon, 7 Apr 2014 18:14:51 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 07, 2014 at 04:32:16PM +0200, Igor Mammedov wrote: > > On Mon, 7 Apr 2014 13:23:54 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > > > > Notify PIIX4_PM/I

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 04:26:02PM +0200, Igor Mammedov wrote: > On Mon, 7 Apr 2014 11:13:01 -0300 > Eduardo Habkost wrote: > > > On Mon, Apr 07, 2014 at 01:07:53PM +1000, Alexey Kardashevskiy wrote: > > > On 04/05/2014 12:36 AM, Igor Mammedov wrote: > > > > Notify PIIX4_PM/ICH9LPC device about h

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 04:32:16PM +0200, Igor Mammedov wrote: > On Mon, 7 Apr 2014 13:23:54 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > > so that it would send SCI to guest

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 11:13:01 -0300 Eduardo Habkost wrote: > On Mon, Apr 07, 2014 at 01:07:53PM +1000, Alexey Kardashevskiy wrote: > > On 04/05/2014 12:36 AM, Igor Mammedov wrote: > > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > > so that it would send SCI to guest notifying about > >

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 13:23:54 +0300 "Michael S. Tsirkin" wrote: > On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > so that it would send SCI to guest notifying about > > newly added memory. > > > > Signed-off-by: Igor Mammed

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Eduardo Habkost
On Mon, Apr 07, 2014 at 01:07:53PM +1000, Alexey Kardashevskiy wrote: > On 04/05/2014 12:36 AM, Igor Mammedov wrote: > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > so that it would send SCI to guest notifying about > > newly added memory. > > > > Signed-off-by: Igor Mammedov > > ---

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 13:23:54 +0300 "Michael S. Tsirkin" wrote: > On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > so that it would send SCI to guest notifying about > > newly added memory. > > > > Signed-off-by: Igor Mammed

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > Notify PIIX4_PM/ICH9LPC device about hotplug event, > so that it would send SCI to guest notifying about > newly added memory. > > Signed-off-by: Igor Mammedov > --- > hw/i386/pc.c | 13 + > 1 file changed, 13 insertion

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-06 Thread Alexey Kardashevskiy
On 04/05/2014 12:36 AM, Igor Mammedov wrote: > Notify PIIX4_PM/ICH9LPC device about hotplug event, > so that it would send SCI to guest notifying about > newly added memory. > > Signed-off-by: Igor Mammedov > --- > hw/i386/pc.c | 13 + > 1 file changed, 13 insertions(+) > > diff --g

[Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-04 Thread Igor Mammedov
Notify PIIX4_PM/ICH9LPC device about hotplug event, so that it would send SCI to guest notifying about newly added memory. Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 734c6ee..ee5cf88 100644 --

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-04 Thread Igor Mammedov
On Fri, 04 Apr 2014 16:02:32 +0200 Paolo Bonzini wrote: > Il 04/04/2014 15:36, Igor Mammedov ha scritto: > > +acpi_dev = (acpi_dev = piix4_pm_find()) ? acpi_dev : ich9_lpc_find(); > > +if (!acpi_dev) { > > +error_setg(&local_err, > > + "memory hotplug is not enab

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-04 Thread Paolo Bonzini
Il 04/04/2014 15:36, Igor Mammedov ha scritto: +acpi_dev = (acpi_dev = piix4_pm_find()) ? acpi_dev : ich9_lpc_find(); +if (!acpi_dev) { +error_setg(&local_err, + "memory hotplug is not enabled: missing acpi device"); errp, not &local_err. Paolo +retu