[Qemu-devel] [PATCH 7/8] qom: distinguish legacy property type name from QOM type name

2011-12-18 Thread Paolo Bonzini
Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev-properties.c | 12 hw/qdev.c|9 ++--- hw/qdev.h|1 + 3 files changed, 15 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH 7/8] qom: distinguish legacy property type name from QOM type name

2011-12-16 Thread Paolo Bonzini
For non-string properties, there is no reason to distinguish type names such as uint32 or hex32. Restrict those to legacy properties. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev-properties.c | 12 hw/qdev.c|9 ++--- hw/qdev.h|1

Re: [Qemu-devel] [PATCH 7/8] qom: distinguish legacy property type name from QOM type name

2011-12-16 Thread Anthony Liguori
On 12/16/2011 06:01 AM, Paolo Bonzini wrote: For non-string properties, there is no reason to distinguish type names such as uint32 or hex32. Restrict those to legacy properties. Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- hw/qdev-properties.c | 12 hw/qdev.c

Re: [Qemu-devel] [PATCH 7/8] qom: distinguish legacy property type name from QOM type name

2011-12-16 Thread Paolo Bonzini
On 12/16/2011 03:06 PM, Anthony Liguori wrote: -type = g_strdup_printf(legacy%s, prop-info-name); +type = g_strdup_printf(legacy%s, + prop-info-legacy_name ?: prop-info-name); I think this confuses the legacy type with the legacy property names. I think it

Re: [Qemu-devel] [PATCH 7/8] qom: distinguish legacy property type name from QOM type name

2011-12-16 Thread Anthony Liguori
On 12/16/2011 08:18 AM, Paolo Bonzini wrote: On 12/16/2011 03:06 PM, Anthony Liguori wrote: - type = g_strdup_printf(legacy%s, prop-info-name); + type = g_strdup_printf(legacy%s, + prop-info-legacy_name ?: prop-info-name); I think this confuses the legacy type with the legacy property names.