Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

On Wed, Jul 26, 2017 at 01:45:51PM +0100, Daniel P. Berrange wrote: > On Wed, Jul 26, 2017 at 02:33:10PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > FYI, after adding qcodes to the keycodemapdb, (but not having picked > > > your branch), > > > > I don't think this is a good idea. qkeycode

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

On Wed, Jul 26, 2017 at 02:33:10PM +0200, Gerd Hoffmann wrote: > Hi, > > > FYI, after adding qcodes to the keycodemapdb, (but not having picked > > your branch), > > I don't think this is a good idea. qkeycode numbers are a qemu-private > thing, they can (and did in the past) change. The

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

Hi, > FYI, after adding qcodes to the keycodemapdb, (but not having picked > your branch), I don't think this is a good idea. qkeycode numbers are a qemu-private thing, they can (and did in the past) change. The names are api and must not change. > I was actually just going add an entry

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

On Wed, Jul 26, 2017 at 01:44:07PM +0200, Gerd Hoffmann wrote: > Hi, > > > qcodes as currently defined cover only a subset of the AT set1 > > scancodes, > > so we need to define countless more qcodes before we consider > > converting > > UIs to use qcodes. > > > > Aside from the pause/break

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

Hi, > qcodes as currently defined cover only a subset of the AT set1 > scancodes, > so we need to define countless more qcodes before we consider > converting > UIs to use qcodes. > > Aside from the pause/break bug, the changes to ps2 driver to round > trip > via qcodes have now made it

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

On Tue, Jul 25, 2017 at 01:53:40PM +0200, Gerd Hoffmann wrote: > Hi, > > > > You're putting some specific code for spice in ps2 emulation. > > > IMO, the workaround should be moved to spice keyboard handling > > > (ui/spice-input.c), > > > which needs to generate a qcode instead of a scancode.

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

Hi, > > You're putting some specific code for spice in ps2 emulation. > > IMO, the workaround should be moved to spice keyboard handling > > (ui/spice-input.c), > > which needs to generate a qcode instead of a scancode. > > This isn't really a spice specific hack. QEMU internal code is *not* >

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

On Mon, Jul 24, 2017 at 09:55:20PM +0200, Hervé Poussineau wrote: > Le 24/07/2017 à 18:46, Daniel P. Berrange a écrit : > > The processing of the scancodes for PAUSE/BREAK has been broken since > > the conversion to qcodes in: > > > > commit 8c10e0baf0260b59a4e984744462a18016662e3e > >

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

Le 24/07/2017 à 18:46, Daniel P. Berrange a écrit : The processing of the scancodes for PAUSE/BREAK has been broken since the conversion to qcodes in: commit 8c10e0baf0260b59a4e984744462a18016662e3e Author: Hervé Poussineau Date: Thu Sep 15 22:06:26 2016 +0200

[Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

The processing of the scancodes for PAUSE/BREAK has been broken since the conversion to qcodes in: commit 8c10e0baf0260b59a4e984744462a18016662e3e Author: Hervé Poussineau Date: Thu Sep 15 22:06:26 2016 +0200 ps2: use QEMU qcodes instead of scancodes When