Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-27 Thread Yang Hongyang
On 09/28/2015 01:47 PM, Jason Wang wrote: On 09/25/2015 10:10 PM, Markus Armbruster wrote: Jason Wang writes: On 09/24/2015 07:52 PM, Markus Armbruster wrote: Yang Hongyang writes: On 09/24/2015 04:41 PM, Markus Armbruster wrote: Yang

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-27 Thread Jason Wang
On 09/25/2015 10:10 PM, Markus Armbruster wrote: > Jason Wang writes: > >> On 09/24/2015 07:52 PM, Markus Armbruster wrote: >>> Yang Hongyang writes: >>> On 09/24/2015 04:41 PM, Markus Armbruster wrote: > Yang Hongyang

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-25 Thread Markus Armbruster
Jason Wang writes: > On 09/24/2015 07:52 PM, Markus Armbruster wrote: >> Yang Hongyang writes: >> >>> On 09/24/2015 04:41 PM, Markus Armbruster wrote: Yang Hongyang writes: [...] > diff --git a/qapi-schema.json

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-25 Thread Jason Wang
On 09/24/2015 07:52 PM, Markus Armbruster wrote: > Yang Hongyang writes: > >> On 09/24/2015 04:41 PM, Markus Armbruster wrote: >>> Yang Hongyang writes: >>> Add a netfilter object based on QOM. A netfilter is attached to a netdev,

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-24 Thread Markus Armbruster
Yang Hongyang writes: > On 09/24/2015 04:41 PM, Markus Armbruster wrote: >> Yang Hongyang writes: >> >>> Add a netfilter object based on QOM. >>> >>> A netfilter is attached to a netdev, captures all network packets >>> that pass through the netdev.

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-24 Thread Yang Hongyang
On 09/24/2015 04:41 PM, Markus Armbruster wrote: Yang Hongyang writes: Add a netfilter object based on QOM. A netfilter is attached to a netdev, captures all network packets that pass through the netdev. When we delete the netdev, we also delete the netfilter object

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-24 Thread Markus Armbruster
Yang Hongyang writes: > Add a netfilter object based on QOM. > > A netfilter is attached to a netdev, captures all network packets > that pass through the netdev. When we delete the netdev, we also > delete the netfilter object attached to it, because if the netdev is >

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-24 Thread Yang Hongyang
On 09/24/2015 04:41 PM, Markus Armbruster wrote: Yang Hongyang writes: Add a netfilter object based on QOM. A netfilter is attached to a netdev, captures all network packets that pass through the netdev. When we delete the netdev, we also delete the netfilter object

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-24 Thread Markus Armbruster
Yang Hongyang writes: > On 09/24/2015 04:41 PM, Markus Armbruster wrote: >> Yang Hongyang writes: >> >>> Add a netfilter object based on QOM. >>> >>> A netfilter is attached to a netdev, captures all network packets >>> that pass through the netdev.

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-24 Thread Yang Hongyang
On 09/24/2015 07:40 PM, Markus Armbruster wrote: Yang Hongyang writes: On 09/24/2015 04:41 PM, Markus Armbruster wrote: Yang Hongyang writes: Add a netfilter object based on QOM. A netfilter is attached to a netdev, captures all network

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-17 Thread Eric Blake
On 09/16/2015 07:23 PM, Yang Hongyang wrote: >>> +{ 'enum': 'NetFilterChain', >>> + 'data': [ 'all', 'in', 'out' ] } >> >> I don't see any other QMP usage of this enum anywhere in the series. Are >> you planning on supporting QMP? If so, let's get that design discussion >> started. If not, why

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-17 Thread Yang Hongyang
On 09/18/2015 12:09 AM, Eric Blake wrote: On 09/16/2015 07:23 PM, Yang Hongyang wrote: +{ 'enum': 'NetFilterChain', + 'data': [ 'all', 'in', 'out' ] } I don't see any other QMP usage of this enum anywhere in the series. Are you planning on supporting QMP? If so, let's get that design

[Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-16 Thread Yang Hongyang
Add a netfilter object based on QOM. A netfilter is attached to a netdev, captures all network packets that pass through the netdev. When we delete the netdev, we also delete the netfilter object attached to it, because if the netdev is removed, the filter which attached to it is useless.

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-16 Thread Eric Blake
On 09/16/2015 06:15 AM, Yang Hongyang wrote: > Add a netfilter object based on QOM. > > A netfilter is attached to a netdev, captures all network packets > that pass through the netdev. When we delete the netdev, we also > delete the netfilter object attached to it, because if the netdev is >

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-16 Thread Yang Hongyang
Hi Eric, On 09/17/2015 05:09 AM, Eric Blake wrote: On 09/16/2015 06:15 AM, Yang Hongyang wrote: Add a netfilter object based on QOM. A netfilter is attached to a netdev, captures all network packets that pass through the netdev. When we delete the netdev, we also delete the netfilter object